New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 9 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

CJK text font are unable to display on Chrome menu and bookmark in localized CJK windows OS

Project Member Reported by hongchic...@chromium.org, Mar 16 2015 Back to list

Issue description

Version: <41.0.2272.89, 41.0.2272.76>
OS: <Win 7, Win 8.1>

What steps will reproduce the problem?
1. Update to Chrome 41.0.2272.89 or 41.0.2272.89
2. Font in menu, bookmark, and tab title become squares (please see attached images)
3.

What is the expected output? What do you see instead?
Font in menu, bookmark, and tab title should show properly.
They displayed as squares.

Note:
(1) We've started seeing this issue when 41.0.2272.76 release. Issue persists when 40.0.2272.89 is released
(2) 95% reports on Win NT 6.1; 3.8% reports on Win NT 6.3
(3) No.1 Issue on CJK user feedback on M41 (33%)


 
Korean Menu.jpeg
87.7 KB View Download
JA Menu.jpg
106 KB View Download
ZH Menu.jpeg
72.0 KB View Download
Some users found workaround of "--disable-directwrite-for-ui".
Cc: ananta@chromium.org scottmg@chromium.org asvitk...@chromium.org cpu@chromium.org ckocagil@chromium.org vivianz@chromium.org pbomm...@chromium.org
ccing some people that were on  issue 422142 .

We reverted HarfBuzz for 38/39. Is it possible this is the same issue recurring?

Vivian: ISTR We had a plan to test mixing UI and OS languages after that bug, do you know if that was done for M41?

I think HarfBuzz wen on for 40, right?

A set of repro steps are the first thing we need.
Cc: msw@chromium.org pkasting@chromium.org
Labels: -Pri-2 Pri-1
Owner: ananta@chromium.org
Status: Assigned
This sounds like at least P1, if not P0, if it's breaking CJK users an masse.

If "--disable-directwrite-for-ui" fixes it, it sounds like we should disable directwrite for UI and merge this back to M41 while working on whatever more involved fix is needed for TOT before re-enabling directwrite for UI.

+pennymac, M41 TPM. Over to ananta@ per comment 1.
Cc: penny...@chromium.org
Affecting Armenian and Greek per misplaced reports in https://code.google.com/p/chromium/issues/detail?id=464784

https://productforums.google.com/forum/#!mydiscussions/chrome-ru/GqizuU2wqjI

I thought DW was on for UI in M40? But if disabling it avoids the problem then that seems like a reasonable hack.

Comment 6 by pennymac@google.com, Mar 18 2015

Cc: amineer@chromium.org
Labels: M-42
I'm ready and willing to consider taking a patch fix into M41 for this.  Just waiting to see a proposed CL for beta/stable.

+amineer for M42 (I'm assuming this issue is effecting beta and ToT as well?

Comment 7 by cpu@chromium.org, Mar 18 2015

We have what we think is a possible way for this to happen but it requires the following

1. OS localized in CJK (for example Chinese windows)
2. Chrome using a different language than the OS (for example Korean)
3. The default system font sent to a 'less than optimal' font

I don't know how many people affected, but I would not expect millions.  Specially because step 3 requires some specific 'bad' fonts.

ananta@ has a fix for the setup above and it fixes the issue in the QA case.

Labels: ReleaseBlock-Stable
Marking as an RB-S for M42.
@#7: would "adjust the system font" be a workaround that we can advise users? Thank you.
#9, yes if that's what's causing it for them, changing the font would fix it.

Win7: http://www.wikihow.com/Change-the-Default-Font-on-Windows-7 are the steps, but the font that would need to be changed is "Message Box". Another way is resetting to a default unmodified Windows theme like regular Windows Aero, which could be one explanation for how people have their fonts changed. It would be helpful to know if that does or does not fix the problem for any users.

ananta has posted a CL, but hasn't landed yet, and we'd want at least some time on Canary before merging. 
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ceae8dcde9e2f60577681fe747bbbb7ce017d3d

commit 4ceae8dcde9e2f60577681fe747bbbb7ce017d3d
Author: ananta <ananta@chromium.org>
Date: Wed Mar 18 04:52:54 2015

Add Segoe UI and its set of linked fonts to the font back list on Windows.

This is to attempt to fallback to a font which could help render text on Windows installations where the
default font is a raster font like System, etc.

Segoe UI provides fallbacks for Korean, Japanese, Chinese, Armenian, etc.

While this would not cover all cases, it is a reasonable addition.

BUG= 467459 
TEST=Install Windows 7 Korean edition. Change the system font to system. Run Chrome without this fix. Navigate to some korean websites. Observe that the tab title shows up empty. With this fix the title should render correctly.

Review URL: https://codereview.chromium.org/1009533003

Cr-Commit-Position: refs/heads/master@{#321077}

[modify] http://crrev.com/4ceae8dcde9e2f60577681fe747bbbb7ce017d3d/ui/gfx/render_text_harfbuzz.cc

hongchichang: A potential fix is landed in Canary now (comment #11). If possible, it would be great if you could get any of the affected users to try Canary to see if it helps.
Verified the fix on Latest Chrome Canary i.e., 43.0.2337.2 on Windows 7(Korean/Japanese)


Steps Followed :
1. Install and launch chrome 
2. Open couple of CJK websites like "Google.co.jp","yahoo.co.jp","naver.com", "sina.com.cn", "http://www.jagran.com/" , "Baidu.com"..etc., and book mark them(make sure the CJK text shows up on Bookmarks)
3. Exit Chrome canary
4. From Windows color and Appreance select "Item : Message Box" and "Font : System" 
5. Launch Chrome Canary.

Verification:
1. Verified that all CJK fonts are rendered properly and there were no box's were seen. 
2. Verify by Changing Chrome display language to Traditional Chinese, Japanese(on Korean machine and vise versa), Korean.
3. Check with and without Directwrite enabled i.e, launch Chrome using "--disable-directwrite-for-ui"(to disable) where it's enabled by default.
4. Changed fonts under Windows color and Appreance select "Item : Message Box" and "Font : System" and "MS UI Gothic" 




Project Member

Comment 14 by bugdroid1@chromium.org, Mar 20 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83de07b1894c61e53469c830c9f7c8986d9ae42c

commit 83de07b1894c61e53469c830c9f7c8986d9ae42c
Author: ananta <ananta@chromium.org>
Date: Fri Mar 20 02:15:48 2015

Remove duplicate fonts from the font fallback list.

We use std::unique to remove duplicate entries from the fallback list.

BUG= 467459 

Review URL: https://codereview.chromium.org/1019743004

Cr-Commit-Position: refs/heads/master@{#321497}

[modify] http://crrev.com/83de07b1894c61e53469c830c9f7c8986d9ae42c/ui/gfx/render_text_harfbuzz.cc

Labels: Merge-Requested

Comment 16 by amin...@google.com, Mar 21 2015

Labels: -Merge-Requested Merge-Review Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M41), manual review required.

Comment 17 by amin...@google.com, Mar 21 2015

Labels: Merge-Approved Hotlist-Merge-Approved
Approved for M42 (branch: 2311)
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 21 2015

Labels: -Merge-Approved merge-merged-2311
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b677007209a0e2e1a21599a6c316327488a112

commit 82b677007209a0e2e1a21599a6c316327488a112
Author: Anantanarayanan Iyengar <ananta@chromium.org>
Date: Sat Mar 21 01:37:10 2015

Merging to M42
Add Segoe UI and its set of linked fonts to the font back list on Windows.

This is to attempt to fallback to a font which could help render text on Windows installations where the
default font is a raster font like System, etc.

Segoe UI provides fallbacks for Korean, Japanese, Chinese, Armenian, etc.

While this would not cover all cases, it is a reasonable addition.

BUG= 467459 
TEST=Install Windows 7 Korean edition. Change the system font to system. Run Chrome without this fix. Navigate to some korean websites. Observe that the tab title shows up empty. With this fix the title should render correctly.

Review URL: https://codereview.chromium.org/1009533003

TBR=msw

Cr-Commit-Position: refs/heads/master@{#321077}
(cherry picked from commit 4ceae8dcde9e2f60577681fe747bbbb7ce017d3d)

Review URL: https://codereview.chromium.org/1025103002

Cr-Commit-Position: refs/branch-heads/2311@{#297}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}

[modify] http://crrev.com/82b677007209a0e2e1a21599a6c316327488a112/ui/gfx/render_text_harfbuzz.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e842dcd121e5dc4a787b612b4bce0610f5b9bf9

commit 1e842dcd121e5dc4a787b612b4bce0610f5b9bf9
Author: Anantanarayanan Iyengar <ananta@chromium.org>
Date: Sat Mar 21 01:44:26 2015

Merging to M42

Remove duplicate fonts from the font fallback list.

We use std::unique to remove duplicate entries from the fallback list.

BUG= 467459 
TBR=msw

Review URL: https://codereview.chromium.org/1019743004

Cr-Commit-Position: refs/heads/master@{#321497}
(cherry picked from commit 83de07b1894c61e53469c830c9f7c8986d9ae42c)

Review URL: https://codereview.chromium.org/1021353003

Cr-Commit-Position: refs/branch-heads/2311@{#298}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}

[modify] http://crrev.com/1e842dcd121e5dc4a787b612b4bce0610f5b9bf9/ui/gfx/render_text_harfbuzz.cc

Cc: ranjitkan@chromium.org
Labels: TE-Verified-M42 TE-Verified-42.0.2311.59
Rechecked the issue on chrome version 42.0.2311.59 on Windows 7 as per the steps provided in comment #13. fix is working as intended, no boxes displayed on web pages. Adding TE-verified-labels
Labels: -Merge-Review -Hotlist-Merge-Review Merge-Approved
Merge approved for M41 branch 2272.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 26 2015

Labels: -Merge-Approved merge-merged-2272
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3692cd10bbb714e7ead5e62ad2b7a4c18470e1

commit 9a3692cd10bbb714e7ead5e62ad2b7a4c18470e1
Author: Penny MacNeil <pennymac@chromium.org>
Date: Thu Mar 26 18:47:17 2015

Merging to M41 (2272):

Remove duplicate fonts from the font fallback list.

We use std::unique to remove duplicate entries from the fallback list.

BUG= 467459 
TBR=msw

Review URL: https://codereview.chromium.org/1019743004

Cr-Commit-Position: refs/heads/master@{#321497}
(cherry picked from commit 83de07b1894c61e53469c830c9f7c8986d9ae42c)

Review URL: https://codereview.chromium.org/1021353003

Cr-Commit-Position: refs/branch-heads/2311@{#298}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
(cherry picked from commit 1e842dcd121e5dc4a787b612b4bce0610f5b9bf9)

Review URL: https://codereview.chromium.org/1038023002

Cr-Commit-Position: refs/branch-heads/2272@{#454}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}

[modify] http://crrev.com/9a3692cd10bbb714e7ead5e62ad2b7a4c18470e1/ui/gfx/render_text_harfbuzz.cc

Whoa, wait. That one is buggy and is being fixed on 42+trunk. We don't want that in 41.
We want to merge  https://codereview.chromium.org/1009533003 this to M41 first.
As scottmg mentions we need to merge a followup fix to M41 to address the bugs he is talking about.

Labels: -Hotlist-Merge-Approved -merge-merged-2272 Merge-Approved
Reverted my too-fast commit!

https://codereview.chromium.org/1038073002/

Leaving this ticket alone with Merge-Approved, but you've only got about 24 hours to make it into the last M41 stable patch.  Otherwise, fixes will go out with M42.

Thanks for letting me know.
#12 scottmg@: I finally heard back from users. 4 out of 5 Korean users still see this issue on Canary. Their Chrome and Windows are both set in Korean. Would you please let me know what other information I should get from those users? Thank you.   
Hongchichang

It would be great if we could get details on the default system font on these SystemS. The font used for rendering message box tex. Also are these windows 7 users?
There was a fix in the latest canary which addressed issues due to incorrect font being used to display Cyrillic text causing it to render incorrectly. Would be great if they can try the latest canary.
Cc: yukawa@chromium.org
Labels: -M-41
Labels: Needs-Feedback
Prudhvi, could you please look into this issue since we does not have any OS localized in CJK/Korean. 


Comment 32 Deleted

Comment 33 Deleted

Labels: -Merge-Approved
Removing merge approval for M41 given that we missed the deadline for the latest stable patch.  Please re-apply the Merge-Requested label if you feel strongly this needs to be merged to M41, otherwise fixes will go out with M42.
Labels: -ReleaseBlock-Stable
It sounds like there might be some follow-up required here, but given c#20 that the issue is fixed for M42, I am going to remove the release block label.  Please re-apply if further work is required for M42 that will need to be merged.  Note that if further changes are required, they need to land on trunk by Fri, Apr 3.

Comment 36 by Deleted ...@, Apr 1 2015

Version 41.0.2272.101 m

OS: <Win 8.1>

Font in menu, bookmark, and tab title is different to previous versions.
issue.png
172 KB View Download

Comment 37 Deleted

Verified the fix on Latest Chrome Canary i.e., 43.0.2352.0 & 42.0.2311.68 on Windows 7(Taiwan) as steps mentioned in comments #13. 

Square boxes are not displayed in tab titles and CJK bookmarks are displayed properly. (Verified with chrome display language same as Localized window language and other than localized window language (Korean) cases)
Labels: Hotlist-ConOps

Comment 40 by cpu@chromium.org, Jun 5 2015

Cc: -cpu@chromium.org
FYI,  Issue 505162  seems duplication of this issue, but it was reported from 43.0.2357.130.

Status: Verified
hongchichang@, marking it as 'Verified' per c#38 and please feel free to change the status if you think something still needs to be done.

Thank you!

Sign in to add a comment