New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 465638



Sign in to add a comment

Offer User Timing in Workers

Project Member Reported by kenjibaheux@chromium.org, Mar 10 2015

Issue description

End goal:
 To allow developers to instrument and measure script execution (via User Timing) timing data within the ServiceWorker.

Relevancy:
 Provides performance insights and helps driving toward midnight train goals.

Spec: http://w3c.github.io/user-timing/
 
Cc: igrigo...@chromium.org

Comment 2 by falken@chromium.org, Apr 21 2015

Owner: ksakamoto@chromium.org
Status: Assigned
Blockedon: chromium:465638
Labels: Cr-Blink-Performance-APIs
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=196724

------------------------------------------------------------------
r196724 | ksakamoto@chromium.org | 2015-06-09T02:59:29.052588Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/workers/worker-performance-timeline.html?r1=196724&r2=196723&pathrev=196724
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/PerformanceBase.cpp?r1=196724&r2=196723&pathrev=196724
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/workers/shared-worker-performance-timeline.html?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/performance/WorkerGlobalScopePerformance.cpp?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/Performance.cpp?r1=196724&r2=196723&pathrev=196724
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/PerformanceBase.h?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/performance/WorkerGlobalScopePerformance.h?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/Performance.h?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/PerformanceUserTiming.cpp?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/performance/WorkerPerformance.idl?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/timing/PerformanceUserTiming.h?r1=196724&r2=196723&pathrev=196724
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/workers/resources/performance-timeline-worker.js?r1=196724&r2=196723&pathrev=196724
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/performance-timeline.html?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/performance/WorkerPerformance.cpp?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=196724&r2=196723&pathrev=196724
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/performance/WorkerPerformance.h?r1=196724&r2=196723&pathrev=196724

Offer User Timing in workers

This patch makes User Timing available in Dedicated / Shared / Service
Workers behind the experimental flag. The getEntries* methods [1] and
User Timing extension [2] of the Performance interface are added to
WrokerPerformance.

In order to make the new methods available from workers, PerformanceBase
class is introduced as a common base class of Performance and
WorkerPerformance.

[1] https://w3c.github.io/performance-timeline/#the-performance-interface
[2] https://w3c.github.io/user-timing/#extensions-performance-interface

BUG= 465638 , 465643 
TEST=http/tests/workers,http/tests/serviceworker

Review URL: https://codereview.chromium.org/1100813004
-----------------------------------------------------------------
Labels: M-45
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 24 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197722

------------------------------------------------------------------
r197722 | ksakamoto@chromium.org | 2015-06-24T09:34:43.800560Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=197722&r2=197721&pathrev=197722

Enable ServiceWorkerPerformanceTimeline flag for stable

This ships User Timing and Resource Timing in Workers, and workerStart
attribute of Resource Timing.

I think it's safe to enable it now; User Timing and workerStart have
landed over 2 weeks ago. Resource Timing part is new, but I only added
main thread to worker plumbing on the existing stable implementation.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA

BUG= 465640 , 465641 , 465643 

Review URL: https://codereview.chromium.org/1203953002
-----------------------------------------------------------------
Status: Fixed

Comment 8 by falken@chromium.org, Jul 13 2015

Labels: Cr-Blink-Workers
B

Comment 9 by falken@chromium.org, Jul 13 2015

Summary: Offer User Timing in Workers (was: Offer User Timing in Service Worker )
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=199493

------------------------------------------------------------------
r199493 | ksakamoto@chromium.org | 2015-07-27T07:19:49.145929Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=199493&r2=199492&pathrev=199493
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt?r1=199493&r2=199492&pathrev=199493

Revert of Enable ServiceWorkerPerformanceTimeline flag for stable (patchset #1 id:1 of https://codereview.chromium.org/1203953002/)

Reason for revert:
This shipped new prefixed APIs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/htsW078UcFA/2cel1auAH60J

Original issue's description:
> Enable ServiceWorkerPerformanceTimeline flag for stable
>
> This ships User Timing and Resource Timing in Workers, and workerStart
> attribute of Resource Timing.
>
> I think it's safe to enable it now; User Timing and workerStart have
> landed over 2 weeks ago. Resource Timing part is new, but I only added
> main thread to worker plumbing on the existing stable implementation.
>
> Intent to Implement and Ship:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA
>
> BUG= 465640 ,  465641 ,  465643 
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197722

BUG= 465640 ,  465641 ,  465643 

Review URL: https://codereview.chromium.org/1254803002
-----------------------------------------------------------------
Labels: -M-45 M-46
Re-opening for M46.
Status: Assigned
Labels: -Cr-Blink-Performance-APIs Cr-Blink-PermissionsAPI
Manually move Cr-Blink-Performance-APIs to Cr-Blink-PermissionsAPI
Labels: -Cr-Blink-PermissionsAPI Cr-Blink-PerformanceAPIs
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 14 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=200524

------------------------------------------------------------------
r200524 | ksakamoto@chromium.org | 2015-08-14T07:04:11.782909Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=200524&r2=200523&pathrev=200524
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt?r1=200524&r2=200523&pathrev=200524

Reland: Enable ServiceWorkerPerformanceTimeline flag for stable

This ships User Timing and Resource Timing in Workers, and workerStart
attribute of Resource Timing.

This is a reland of r197722, which is reverted in r199493 to avoid
shipping prefixed Resource Timing APIs. That has been addressed in
r200301; now only unprefixed version of the APIs are available in worker
contexts.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA

BUG= 465640 , 465641 , 465643 

Review URL: https://codereview.chromium.org/1289803002
-----------------------------------------------------------------
Status: Fixed
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 23 2015

Labels: merge-merged-2490
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9377665348aee84522828a7086ac4b8bac12972

commit d9377665348aee84522828a7086ac4b8bac12972
Author: ksakamoto@chromium.org <ksakamoto@chromium.org>
Date: Fri Aug 14 07:04:11 2015

Reland: Enable ServiceWorkerPerformanceTimeline flag for stable

This ships User Timing and Resource Timing in Workers, and workerStart
attribute of Resource Timing.

This is a reland of r197722, which is reverted in r199493 to avoid
shipping prefixed Resource Timing APIs. That has been addressed in
r200301; now only unprefixed version of the APIs are available in worker
contexts.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA

BUG= 465640 , 465641 , 465643 

Review URL: https://codereview.chromium.org/1289803002

git-svn-id: svn://svn.chromium.org/blink/trunk@200524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[modify] http://crrev.com/d9377665348aee84522828a7086ac4b8bac12972/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/d9377665348aee84522828a7086ac4b8bac12972/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Sign in to add a comment