New issue
Advanced search Search tips

Issue 464910 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Track the performance of slimming paint

Project Member Reported by pdr@chromium.org, Mar 6 2015

Issue description

This is a metabug for tracking the performance of slimming paint as we get closer to releasing.

The initial goal is to add a few monitoring benchmarks to chromeperf.appspot.com with the --enable-slimming-paint flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b914bd1347b4b125f3cca75227a7a7c5b768be

commit d1b914bd1347b4b125f3cca75227a7a7c5b768be
Author: pdr <pdr@chromium.org>
Date: Wed Mar 18 15:52:19 2015

Add a slimming paint variant of the rasterize and record micro benchmark

This patch adds a new benchmark for slimming paint:
rasterize_and_record_micro.top_25_slimming_paint_smooth

I verified this test passes locally. Perf cl tryjobs:
linux - https://codereview.chromium.org/1010103002
nexus5 - https://codereview.chromium.org/1013653003
nexus4 - https://codereview.chromium.org/1012893003

BUG= 464910 

Review URL: https://codereview.chromium.org/1016503002

Cr-Commit-Position: refs/heads/master@{#321142}

[modify] http://crrev.com/d1b914bd1347b4b125f3cca75227a7a7c5b768be/tools/perf/benchmarks/rasterize_and_record_micro.py

Comment 2 by pdr@chromium.org, Mar 30 2015

Labels: Hotlist-Slimming-Paint
Blocking: chromium:471332
Cc: paint-dev@chromium.org
 Issue 470583  has been merged into this issue.
Blockedon: chromium:451219
Blockedon: chromium:471786

Comment 7 Deleted

Blockedon: chromium:472167
Blockedon: -chromium:471786
draw properties benchmark has been enabled. \o/
Blockedon: chromium:474749
This document has lots of details on the current status and graphs over time:

https://docs.google.com/document/d/1moskT1Tkg8GcHZylRNQakyrCjk3LR_O5Yys9fDriVcY/edit

Blockedon: chromium:476073
Blockedon: -chromium:470558
Blockedon: -chromium:470554
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da8b63007bd79a03f9d5429d75511db8b723a2ea

commit da8b63007bd79a03f9d5429d75511db8b723a2ea
Author: pdr <pdr@chromium.org>
Date: Mon Apr 27 22:48:27 2015

Add a slimming paint version of the r&r key silk case benchmark

This patch adds a version of rasterize and record on key silk cases with
--enable-slimming-paint.

BUG= 464910 

Review URL: https://codereview.chromium.org/1106823003

Cr-Commit-Position: refs/heads/master@{#327162}

[modify] http://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea/tools/perf/benchmarks/rasterize_and_record_micro.py

Blockedon: chromium:482055
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73d581341c40a225475a60f35a695f7b076c70d2

commit 73d581341c40a225475a60f35a695f7b076c70d2
Author: pdr <pdr@chromium.org>
Date: Tue Apr 28 17:52:14 2015

Revert of Add a slimming paint version of the r&r key silk case benchmark (patchset #1 id:1 of https://codereview.chromium.org/1106823003/)

Reason for revert:
Turns out, we really only care about the smoothness version of this benchmark. I'm going to revert this change and put up a new patch to enable the key silk cases smoothness benchmark with slimming paint enabled.

Original issue's description:
> Add a slimming paint version of the r&r key silk case benchmark
>
> This patch adds a version of rasterize and record on key silk cases with
> --enable-slimming-paint.
>
> BUG= 464910 
>
> Committed: https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea
> Cr-Commit-Position: refs/heads/master@{#327162}

TBR=chrishtr@chromium.org,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 464910 

Review URL: https://codereview.chromium.org/1110203002

Cr-Commit-Position: refs/heads/master@{#327318}

[modify] http://crrev.com/73d581341c40a225475a60f35a695f7b076c70d2/tools/perf/benchmarks/rasterize_and_record_micro.py

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c29dadf0e944111278ff9c96b1dd7af2ade06d9b

commit c29dadf0e944111278ff9c96b1dd7af2ade06d9b
Author: pdr <pdr@chromium.org>
Date: Wed Apr 29 15:32:18 2015

Add a smoothness benchmark with slimming paint enabled

This patch adds a smoothness benchmark with slimming paint.

BUG= 464910 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;

Review URL: https://codereview.chromium.org/1114713002

Cr-Commit-Position: refs/heads/master@{#327493}

[modify] http://crrev.com/c29dadf0e944111278ff9c96b1dd7af2ade06d9b/tools/perf/benchmarks/smoothness.py

Blockedon: chromium:484943
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f519613998a4e3886673d2ead30636049bd422e4

commit f519613998a4e3886673d2ead30636049bd422e4
Author: pdr <pdr@chromium.org>
Date: Mon Jul 06 22:18:49 2015

Turn down SmoothnessKeyMobileSitesWithSlimmingPaint

Slimming paint seems to be sticking so I'm turning down the sp-specific
benchmarks.
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

BUG= 464910 

Review URL: https://codereview.chromium.org/1217083012

Cr-Commit-Position: refs/heads/master@{#337496}

[modify] http://crrev.com/f519613998a4e3886673d2ead30636049bd422e4/tools/perf/benchmarks/smoothness.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e085bffbc79f85284a4c9c0c5145f80d94726c3b

commit e085bffbc79f85284a4c9c0c5145f80d94726c3b
Author: pdr <pdr@chromium.org>
Date: Mon Jul 06 23:22:51 2015

Turn down MemoryTop7StressWithSlimmingPaint

Slimming paint seems to be sticking so I'm turnng down the sp-specific
benchmarks.
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

BUG= 464910 

Review URL: https://codereview.chromium.org/1214433005

Cr-Commit-Position: refs/heads/master@{#337514}

[modify] http://crrev.com/e085bffbc79f85284a4c9c0c5145f80d94726c3b/tools/perf/benchmarks/memory.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d13647aa0463a12c0100b280103db80733cad2b

commit 7d13647aa0463a12c0100b280103db80733cad2b
Author: pdr <pdr@chromium.org>
Date: Tue Jul 07 00:36:03 2015

Turn down RasterizeAndRecordMicroTop25WithSlimmingPaint

Slimming paint seems to be sticking so I'm turning down the sp-specific
benchmarks.
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

BUG= 464910 

Review URL: https://codereview.chromium.org/1224443002

Cr-Commit-Position: refs/heads/master@{#337534}

[modify] http://crrev.com/7d13647aa0463a12c0100b280103db80733cad2b/tools/perf/benchmarks/rasterize_and_record_micro.py

Status: Fixed

Sign in to add a comment