New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 458983 link

Starred by 21 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2015
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----


Sign in to add a comment

Add native support for Client Hints' Width, Viewport-Width, and DPR

Project Member Reported by y...@yoav.ws, Feb 16 2015

Issue description

(See http://www.chromium.org/blink#launch-process for an overview)

Change description:
Add Client Hints request headers (CH-DPR and CH-RW) as well the Content-DPR response header in order to enable content-negotiation based responsive images.

Changes to API surface:
* CH-DPR request header
* CH-RW response header
* Opt-in mechanism (TBD)
* Content-DPR response header

Links:
Public standards discussion: http://igrigorik.github.io/http-client-hints/

Support in other browsers:
Internet Explorer: Not supported. Under consideration.
Firefox: Not supported. Both positive and negative signals regarding the feature's support.
Safari: Not supported.


 

Comment 1 by y...@yoav.ws, Feb 16 2015

Summary: Add native support for Client Hints' RW and DPR (was: Add native support for Client Hints' (RW and DPR))

Comment 2 by y...@yoav.ws, Feb 16 2015

Cc: igrigo...@chromium.org abarth@chromium.org rbyers@chromium.org
 Issue 170388  has been merged into this issue.
Small nitpick: latest draft dropped the CH- prefixes, so the headers should be: DPR, RW, and Content-DPR. For background, see: https://github.com/igrigorik/http-client-hints/issues/24.

Comment 4 by y...@yoav.ws, Feb 17 2015

My bad. I was referring to the `DPR` and `RW` request headers, obviously.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e20e7611b94ccaeab582fbb829ac2dd83052e4f

commit 7e20e7611b94ccaeab582fbb829ac2dd83052e4f
Author: yoav <yoav@yoav.ws>
Date: Mon Feb 23 20:22:22 2015

Removed partial Client Hints implementation from the Chrome side.

The first step in adding full Client-Hints support on the Blink side is to delete the partial implementation from the Chrome side. This CL does that.

BUG= 458983 

Review URL: https://codereview.chromium.org/948843003

Cr-Commit-Position: refs/heads/master@{#317639}

[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/browser/io_thread.cc
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/browser/net/chrome_network_delegate.cc
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/browser/net/chrome_network_delegate.h
[delete] http://crrev.com/0d59aeae3e815c53b10fb0ffc1199be524c62f86/chrome/browser/net/client_hints.cc
[delete] http://crrev.com/0d59aeae3e815c53b10fb0ffc1199be524c62f86/chrome/browser/net/client_hints.h
[delete] http://crrev.com/0d59aeae3e815c53b10fb0ffc1199be524c62f86/chrome/browser/net/client_hints_unittest.cc
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/browser/profiles/profile_io_data.cc
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/chrome_browser.gypi
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/chrome_tests_unit.gypi
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/common/chrome_switches.cc
[modify] http://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f/chrome/common/chrome_switches.h

Comment 6 by y...@yoav.ws, Feb 25 2015

Blockedon: chromium:461741
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 25 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=190831

------------------------------------------------------------------
r190831 | yoav@yoav.ws | 2015-02-25T14:29:05.825905Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ImageResource.cpp?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/FrameView.h?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/LocalFrame.h?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ResourceFetcher.h?r1=190831&r2=190830&pathrev=190831
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept.php?r1=190831&r2=190830&pathrev=190831
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-dpr.php?r1=190831&r2=190830&pathrev=190831
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-rw.php?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=190831&r2=190830&pathrev=190831
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-no-accept.html?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/FrameView.cpp?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/LocalFrame.cpp?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/Resource.cpp?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ResourceFetcher.cpp?r1=190831&r2=190830&pathrev=190831
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ResourceFetcherTest.cpp?r1=190831&r2=190830&pathrev=190831

Added basic client hints support.

This CL adds basic client hints support for the DPR and RW hints.
It also includes an "Accept-CH" based opt-in mechanism.
It does not include:
* A decent Accept-CH parser
* Actual Resource width being sent as the RW header

BUG= 458983 

Review URL: https://codereview.chromium.org/951303003
-----------------------------------------------------------------
@yoav: that looks great! 

QQ: are you also planning to enable meta opt-in?  E.g. <meta http-equiv="accept-ch" content="dpr, rw">

Comment 9 by y...@yoav.ws, Feb 25 2015

Thanks Ilya!

Adding <meta> opt-in definitely should be in the plans :)
I'll open a bug and block this one on it.

Comment 10 by y...@yoav.ws, Feb 25 2015

Blockedon: chromium:461941
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 9 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193479

------------------------------------------------------------------
r193479 | yoav@yoav.ws | 2015-04-09T21:07:44.760387Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLResourcePreloader.cpp?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/FetchRequest.cpp?r1=193479&r2=193478&pathrev=193479
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-rw.php?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLResourcePreloader.h?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContext.cpp?r1=193479&r2=193478&pathrev=193479
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/FetchRequest.h?r1=193479&r2=193478&pathrev=193479

Added preloader support for sizes based RW values

This CL adds support for RW hints that are based on the element's sizes attribute.
It currently adds this only to the PreloadScanner.
The same would be added later to the regular parser.

BUG= 458983 

Review URL: https://codereview.chromium.org/1078633003
-----------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 10 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193521

------------------------------------------------------------------
r193521 | yoav@yoav.ws | 2015-04-10T07:52:42.188055Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ImageLoader.cpp?r1=193521&r2=193520&pathrev=193521
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=193521&r2=193520&pathrev=193521
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-dynamic-rw-sizes.html?r1=193521&r2=193520&pathrev=193521
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=193521&r2=193520&pathrev=193521

Add ImageLoader support for sizes based Client-Hints RW values

This CL adds support for RW hints that are based on the element's sizes attribute to ImageLoader, to cover dynamically added images.

BUG= 458983 

Review URL: https://codereview.chromium.org/1060483003
-----------------------------------------------------------------

Comment 14 by y...@yoav.ws, Apr 10 2015

Blockedon: -chromium:46194 chromium:461941

Comment 15 by y...@yoav.ws, Apr 30 2015

Blockedon: chromium:482840

Comment 16 by y...@yoav.ws, Apr 30 2015

Blockedon: chromium:471249

Comment 17 by y...@yoav.ws, Apr 30 2015

Blockedon: chromium:482849

Comment 18 by y...@yoav.ws, Apr 30 2015

Blockedon: chromium:482851

Comment 19 by y...@yoav.ws, May 4 2015

Blockedon: chromium:484110

Comment 20 by y...@yoav.ws, Jun 16 2015

Blockedon: -chromium:484110 chromium:434477

Comment 21 by y...@yoav.ws, Jun 16 2015

Blockedon: -chromium:471249 chromium:484110
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 16 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197164

------------------------------------------------------------------
r197164 | yoav@yoav.ws | 2015-06-16T09:12:01.051859Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContextTest.cpp?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ImageLoader.cpp?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContext.cpp?r1=197164&r2=197163&pathrev=197164
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-width.php?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScannerTest.cpp?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept.php?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept-meta.html?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=197164&r2=197163&pathrev=197164
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-rw.php?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferences.cpp?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferencesTest.cpp?r1=197164&r2=197163&pathrev=197164
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/resources/image-checks-for-viewport-width.php?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept-meta-preloader.html?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferences.h?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-dynamic-rw-sizes.html?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-preload-rw-sizes.html?r1=197164&r2=197163&pathrev=197164
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-no-accept.html?r1=197164&r2=197163&pathrev=197164

Split RW hint into Width and Viewport-Width

This CL aligns the implementation with the spec, by splitting up the RW hint into the "Width" and "Viewport-Width" hints: https://github.com/igrigorik/http-client-hints/pull/48

BUG= 458983 

Review URL: https://codereview.chromium.org/1183233002
-----------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 16 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197208

------------------------------------------------------------------
r197208 | yoav@yoav.ws | 2015-06-16T23:55:03.966498Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/FetchContext.h?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferences.cpp?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferencesTest.cpp?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContext.cpp?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ClientHintsPreferences.h?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContext.h?r1=197208&r2=197207&pathrev=197208
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=197208&r2=197207&pathrev=197208

Add use-counters for Client-Hints features

In order to be aware of usage, this CL adds use-counters for the various
Client-Hints features.
Due to ClientHintsPreferences living in fetch/ (Owned by FetchRequest)
and the will to avoid creating dependencies between fetch/ and
the rest of core/, counted features are re-defined in FetchContext
and counting is done through loader/FrameFetchContext.

BUG= 458983 

Review URL: https://codereview.chromium.org/1189523015
-----------------------------------------------------------------
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 18 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197374

------------------------------------------------------------------
r197374 | yoav@yoav.ws | 2015-06-18T17:10:09.382789Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-rw-width.html?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ImageLoader.cpp?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept-meta-preloader.html?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=197374&r2=197373&pathrev=197374
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElementTest.cpp?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScannerTest.cpp?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept.php?r1=197374&r2=197373&pathrev=197374
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/misc/client-hints-accept-meta.html?r1=197374&r2=197373&pathrev=197374

Add support for `width` based Width Client Hint

In order to increase the cases in which we can send an accurate `Width`
hint, this CL sends them when `sizes` is absent, but `width` is present
(when `width`'s value is not '%' based)

BUG= 458983 

Review URL: https://codereview.chromium.org/1186333004
-----------------------------------------------------------------
Summary: Add native support for Client Hints' Width, Viewport-Width, and DPR (was: Add native support for Client Hints' RW and DPR)
Labels: -M-43
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 23 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197640

------------------------------------------------------------------
r197640 | yoav@yoav.ws | 2015-06-23T10:26:25.034601Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=197640&r2=197639&pathrev=197640
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScannerTest.cpp?r1=197640&r2=197639&pathrev=197640

HTMLPreloadScanner should also add width to non-`w` based image resources

The HTMLPreloadScanner was not adding sizes based Width values to
requests issued by <img> tags where only `src` was present or the picked
`srcset` candidate was based on an `x` descriptor.
This CL fixes that issue and adds tests to make sure it won't regress.

BUG= 458983 

Review URL: https://codereview.chromium.org/1196293002
-----------------------------------------------------------------

Comment 28 Deleted

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 28 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197949

------------------------------------------------------------------
r197949 | noel@chromium.org | 2015-06-28T16:42:22.529623Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=197949&r2=197948&pathrev=197949
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScannerTest.cpp?r1=197949&r2=197948&pathrev=197949
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.h?r1=197949&r2=197948&pathrev=197949

Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #3 id:40001 of https://codereview.chromium.org/1214663004/)

Reason for revert:
Seems to have broken the Mac10.9 Tests (dbg) on the chromium waterfall, see build #7701



Original issue's description:
> Fix CH Width header when preloadScanner and <picture> are involved
> 
> When images are loaded by the preloader and <picture> is involved,
> there was a bug where the sent sizes value was related to the fallback
> <img> tag rather than the picked resource.
> This CL fixes that.
> 
> BUG= 458983 
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197948

TBR=mkwst@chromium.org,yoav@yoav.ws
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 458983 

Review URL: https://codereview.chromium.org/1217703002
-----------------------------------------------------------------
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 28 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197950

------------------------------------------------------------------
r197950 | noel@chromium.org | 2015-06-28T18:25:35.153206Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=197950&r2=197949&pathrev=197950
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScannerTest.cpp?r1=197950&r2=197949&pathrev=197950
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.h?r1=197950&r2=197949&pathrev=197950

Revert of Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #1 id:1 of https://codereview.chromium.org/1217703002/)

Reason for revert:
Wasn't the cause of build 7701 failure, was a bot flake.

Original issue's description:
> Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #3 id:40001 of https://codereview.chromium.org/1214663004/)
> 
> Reason for revert:
> Seems to have broken the Mac10.9 Tests (dbg) on the chromium waterfall, see build #7701
> 
> 
> 
> Original issue's description:
> > Fix CH Width header when preloadScanner and <picture> are involved
> > 
> > When images are loaded by the preloader and <picture> is involved,
> > there was a bug where the sent sizes value was related to the fallback
> > <img> tag rather than the picked resource.
> > This CL fixes that.
> > 
> > BUG= 458983 
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197948
> 
> TBR=mkwst@chromium.org,yoav@yoav.ws
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 458983 
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197949

TBR=mkwst@chromium.org,yoav@yoav.ws
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 458983 

Review URL: https://codereview.chromium.org/1220443004
-----------------------------------------------------------------
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 6 2015

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 12 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=200414

------------------------------------------------------------------
r200414 | yoav@yoav.ws | 2015-08-12T19:10:41.142041Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=200414&r2=200413&pathrev=200414

Turn Client-Hints' DPR, Width and Viewport-Width on by default.

Intent to ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vvX1vCQihDE/wg6JQg9utaMJ

BUG= 458983 

Review URL: https://codereview.chromium.org/1262253002
-----------------------------------------------------------------
Version 46.0.2485.0 canary:

Given an HTML document served with
Accept-CH: DPR, Width, Viewport-Width
with references to
* extenal scripts
* an img with srcset/w and sizes
* another HTML document.

The request for the image contains DPR, Viewport-Width and Width (:-)). The requests for the external scripts contain DPR and Viewport-Width (:-)). But the request for the HTML document itself or a the linked document contain no client hint request headers (:-(). Why?

I think the request for an HTML document should also contain client hint headers (DPR, Viewport-Width), so that e.g. img markup can be reduced like in the examples in https://github.com/igrigorik/http-client-hints#picture-element . There must be some indicator in the request to decide whether or not to reduce the markup.

Comment 34 by y...@yoav.ws, Aug 17 2015

Status: Fixed
Support for this feature have landed. Closing.

@walbaerjkoch: Since sending the hints without an opt-in on navigational requests may be more privacy sensitive, it is not currently enabled. Please open a separate issue requesting that. Thanks :)
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 23 2015

Labels: merge-merged-2490
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1739f72f373b76316e848608d39fafb6ced4f53a

commit 1739f72f373b76316e848608d39fafb6ced4f53a
Author: yoav@yoav.ws <yoav@yoav.ws>
Date: Wed Aug 12 19:10:41 2015

Turn Client-Hints' DPR, Width and Viewport-Width on by default.

Intent to ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vvX1vCQihDE/wg6JQg9utaMJ

BUG= 458983 

Review URL: https://codereview.chromium.org/1262253002

git-svn-id: svn://svn.chromium.org/blink/trunk@200414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[modify] http://crrev.com/1739f72f373b76316e848608d39fafb6ced4f53a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Sign in to add a comment