New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 45745 link

Starred by 23 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
M-6

Blocking:
issue 45762
issue 46394

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Remove omnibox ears.

Project Member Reported by ben@chromium.org, Jun 3 2010

Issue description

We should detach the ears from the omnibox like so:

- Reload becomes its own button again and combines with Stop. I will not stab 
anyone if this is done the way it's combined with Go now. (i.e. using logic 
so it doesn't change state if the mouse is over it).
- We kill the go button.
- The omnibox gets rounded rect edges matching the shape of adjacent buttons 
on either end.


 

Comment 1 by ben@chromium.org, Jun 3 2010

Labels: OS-Windows

Comment 2 by sh...@chromium.org, Jun 3 2010

Q: Does the popup go back to rounded-top with a gap?
A: Yes.  But we don't need to re-add the PopupPositioner since it's still only the 
width of the omnibox.

Of course, this does mean I need to hack up the info bubble code more.  Urgh.
- I agree, but you could try just removing the right ear and combine the go and stop 
into the reload button on left ear. Rounding the edges of the omnibox on right side.

- I like the way the reload is attached to the omnibox, it looks neat and it shows that 
they are connected in the literal sense.

-The navigation forward and back buttons are on the left so makes sense to have the new 
combined go, stop reload button on left anyway.
can we see some mocks for the desired implementation here? thanks...

Comment 6 by jecsh...@gmail.com, Jun 4 2010

I want to see how this goes. Especially my usability, since I'm used to WinExplorer and 
IE with their stop/reload on the right ear. And now I prefer using the Go button for 
everything:
1, Visit the typed text
2. Stop loading
3. Reload the page
Labels: Restrict-AddIssueComment-Commit
Status: Fixed
This is basically done in r49727.  I still need correct button images, but I claim that can be its own bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2013

Blocking: -chromium:45762 -chromium:46394 chromium:45762 chromium:46394
Labels: -Area-UI -Feature-Omnibox -Mstone-6 M-6 Cr-UI Cr-UI-Browser-Omnibox
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment