New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2015
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 371902

Blocking:
issue 360334



Sign in to add a comment
link

Issue 455497: WebLocalFrameImpl::firstRectForCharacterRange doesn't account for pinch viewport

Reported by bokan@chromium.org, Feb 5 2015 Project Member

Issue description

Comment 1 by shuchen@chromium.org, Feb 5 2015

Cc: shuchen@chromium.org

Comment 2 by bokan@chromium.org, Feb 24 2015

Blockedon: chromium:371902

Comment 3 by bokan@chromium.org, Feb 24 2015

Labels: -M-42 M-43

Comment 4 by bugdroid1@chromium.org, Mar 21 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192299

------------------------------------------------------------------
r192299 | bokan@chromium.org | 2015-03-21T00:31:49.962251Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PopupListBox.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/events/MouseRelatedEvent.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ValidationMessageClientImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/TouchActionTest.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebPluginContainer.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBox.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLocalFrameImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMenuList.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/TouchDisambiguation.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ContextMenuClientImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/FrameView.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebAXObject.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDevToolsAgentImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewImpl.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/PinchViewportTest.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/ColorInputType.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebInputEventConversion.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventHandler.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PopupContainer.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PopupListBox.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/SmartClip.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DragController.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/events/MouseRelatedEvent.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebViewTest.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/PinchViewport.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/TextFinder.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebFrameWidgetImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBox.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/LinkHighlight.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLocalFrameImpl.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ExternalPopupMenu.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/FrameView.h?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebPluginContainerTest.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/SmartClip.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMAgent.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/PinchViewport.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/TouchAdjustment.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/LocalFrame.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp?r1=192299&r2=192298&pathrev=192299
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebFrame.h?r1=192299&r2=192298&pathrev=192299

Removed FrameView's windowToContents and contentsToWindow methods.

This CL adds methods to FrameView for converting between the FrameView's
content space and Blink's viewport space and then replaces |window| in
all uses of contentsToWindow and windowToContents with either rootFrame
or Viewport. |Window| is equivalent to |RootFrame| so it has no behavioral
change. Changing |Window| to |Viewport| will change behavior under page
scale.

See http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for details.

BUG= 371902 , 455497 , 455328 

Review URL: https://codereview.chromium.org/967213004
-----------------------------------------------------------------

Comment 5 by bokan@chromium.org, Mar 23 2015

Status: Fixed
This should be fixed in ToT/Canary, let me know if that's not the case.

Comment 6 by patricia@chromium.org, Apr 8 2015

Labels: VerifyIn-43

Comment 7 by patricia@chromium.org, Apr 8 2015

Labels: -VerifyIn-43

Comment 8 by krisr@chromium.org, Apr 14 2015

Status: Verified

Comment 9 by yukawa@chromium.org, Apr 22 2015

Blocking: chromium:360334

Sign in to add a comment