New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 45546 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
ooo sick
Closed: Jun 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M-6

Blocking:
issue 45547

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Content Settings dialog should have a list of categories on the left instead of tabs at the top

Project Member Reported by thakis@chromium.org, Jun 1 2010

Issue description

Content Settings dialog should have a list of categories on the left instead of tabs at the top
 
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=48956 

------------------------------------------------------------------------
r48956 | thakis@chromium.org | 2010-06-04 11:35:35 -0700 (Fri, 04 Jun 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentSettings.xib?r1=48956&r2=48955
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm?r1=48956&r2=48955
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=48956&r2=48955
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=48956&r2=48955

Mac: Change content settings from showing tabs on top to showing a list on the side.

xib changes:
* Set NSTabView's style to "Tabless" (but kept panes in an NSTabView, since it's a convenient method to handle multiple overlapping views in IB)
* Put NSTabView into a split view, put a table view in the other split pane of the split view, gave it class TabViewSwitcherTable
* changed autosize flags of all child views of the tab view items
* Made the NSTabView the tabView_ of the table view

BUG= 45546 
TEST=Content settings window should still work. If it's opened through an omnibox bubble, the right section should still be autoselected.

Review URL: http://codereview.chromium.org/2534001
------------------------------------------------------------------------

Comment 4 by bugdro...@gmail.com, Jun 11 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=49467 

------------------------------------------------------------------------
r49467 | thakis@chromium.org | 2010-06-10 15:57:22 -0700 (Thu, 10 Jun 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc?r1=49467&r2=49466

Gtk: Side tabs for content settings window.

UI leads-approved.

BUG= 45546 
TEST=Open content settings window. Tabs are now on the left.

Review URL: http://codereview.chromium.org/2717007
------------------------------------------------------------------------

Comment 5 by thakis@chromium.org, Jun 30 2010

Status: Fixed
If r51205 sticks, this is done on all 3 platforms.  Issue 46965  is a followup on Linux, and the mac side needs better spacing, but this bug can be closed.

Comment 7 by bugdro...@gmail.com, Jun 30 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=51205 

------------------------------------------------------------------------
r51205 | thakis@chromium.org | 2010-06-29 18:03:53 -0700 (Tue, 29 Jun 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/content_filter_page_view.cc?r1=51205&r2=51204
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/content_settings_window_view.cc?r1=51205&r2=51204
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/content_settings_window_view.h?r1=51205&r2=51204
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/label.h?r1=51205&r2=51204

Windows: Replace tabs in content settings with a listbox.

Depends on http://codereview.chromium.org/2815034

BUG= 45546 
TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before.

Review URL: http://codereview.chromium.org/2799042
------------------------------------------------------------------------

Comment 8 by bugdro...@gmail.com, Jul 13 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52199 

------------------------------------------------------------------------
r52199 | thakis@chromium.org | 2010-07-13 11:56:32 -0700 (Tue, 13 Jul 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/cocoa_protocols_mac.h?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentSettings.xib?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table.h?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table.mm?r1=52199&r2=52198
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view_picker_table_unittest.mm?r1=52199&r2=52198

Mac: Tweak content settings window.

Add "Features" label to source list.
xib change: Add some vertical space at the top of each tab, change outline view cell size to "small", hook up new outlet.

http://i.imgur.com/KGES6.png

BUG= 45546 
TEST=Content settings window still works: Current pane is still remembered, and opening the window from a bubble selects the right pane.

Review URL: http://codereview.chromium.org/2932009
------------------------------------------------------------------------

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12 2012

Blocking: -chromium:45547 chromium:45547
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Privacy -Mstone-6 Cr-Privacy M-6 Cr-UI
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 12 by laforge@google.com, Jul 24 2013

Cc: -jeffreyc@chromium.org

Sign in to add a comment