Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 45147 Update available notification (Mac)
Starred by 10 users Project Member Reported by mark@chromium.org, May 26 2010 Back to list
Status: Verified
Owner:
Closed: Jul 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature
M-6

Blocked on:
issue 37925

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
From bug 27941.

I’m interested in the backend work here, but not so much in the UI.
 
Comment 1 by mark@chromium.org, May 26 2010
Comment 2 by tha...@chromium.org, May 26 2010
Labels: Mstone-6
Comment 3 by krisr@chromium.org, Jun 2 2010
Labels: -Pri-2 Pri-1 Area-Internals Internals-Install
Status: Assigned
Brian - we need to know what we are going to have UI wise.
krisr: Page and Tools menu will be unified and then default to on on OS X as well since it's only one button. That 
button will show a yellow light, like on windows.
Comment 5 by brian@chromium.org, Jun 2 2010
The plan described by thakis the plan as I know it.
Blockedon: 37925
Hmm... I don't understand why this is blocked on 37925...? The same would have applied 
to Windows and the Windows version is checked in already.
'cause mac doesn't show wrench/tools buttons by default, but windows does.
I see. I guess I should say that the development of the feature is not gated on that 
since you can turn it on while developing and then once we make it on by default it 
just works... (maybe that's the plan already?)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52524 

------------------------------------------------------------------------
r52524 | mark@chromium.org | 2010-07-15 13:46:36 -0700 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/keystone_glue.h?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/keystone_glue.mm?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/upgrade_detector.cc?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer_util.gypi?r1=52524&r2=52523

Make UpgradeDetector work on the Mac.

This is the backend work only. There's no UI yet.

BUG= 45147 
TEST=manual
Review URL: http://codereview.chromium.org/3032001
------------------------------------------------------------------------

Comment 11 by mark@chromium.org, Jul 15 2010
Backend done. Over to Rob for uiuiui.
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52911 

------------------------------------------------------------------------
r52911 | rsesek@chromium.org | 2010-07-19 09:14:47 -0700 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/restart_browser.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/wrench_menu_model.cc?r1=52911&r2=52910

[Mac] Implement the update available notification in the wrench menu.

The changes to restart_browser.mm also affect the sheet displayed in the About
window. Note that the badge on the wrench menu looks bad.

BUG= 45147 
TEST=difficult

Review URL: http://codereview.chromium.org/2856042
------------------------------------------------------------------------

Status: Fixed
Labels: Verifier-Srikanth
Verifier Updated by AutoAllocator, contact AmolK or KrisR for questions
The Change not visible on Mac Google Chrome	6.0.472.18 (Official Build 54489) dev
Testing steps :
1. Point chrome ticket to update(+1) , verify from about menu update available .
check for the notification on wrench menu.

The notification is on a timer. I believe it's currently set to 24 hours before it gets shown.
Labels: -Verifier-Srikanth Verifier-Srikanthk
Status: Verified
Platform:
  Hostname: testings-mac-mini-3.local
  Mac OS X Version 10.6.4 (Build 10F569)
  Processor: 4 Intel 2.66 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 6.0.484.0 r54715  <<<Release/Debug>>>
  QuickTime Player: 7.6.6
  QuickTime PlayerX: 114

Issue 45370 has been merged into this issue.
Issue 52402 has been merged into this issue.
Project Member Comment 22 by bugdroid1@chromium.org, Oct 12 2012
Blockedon: -chromium:37925 chromium:37925
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 23 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Mstone-6 -Area-Internals -Internals-Install M-6 Cr-Internals Cr-Internals-Install
Project Member Comment 24 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 25 by bugdroid1@chromium.org, Apr 5 2013
Labels: -Cr-Internals-Install Cr-Internals-Installer
Sign in to add a comment