New issue
Advanced search Search tips

Issue 44955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Security
M-5

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Need to merge WebCore::toAlphabetic() crash to 375 branch.

Project Member Reported by infe...@chromium.org, May 24 2010

Issue description

Comment 1 by bugdro...@gmail.com, May 24 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=48100 

------------------------------------------------------------------------
r48100 | inferno@chromium.org | 2010-05-24 16:26:18 -0700 (Mon, 24 May 2010) | 33 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/375/LayoutTests/ChangeLog?r1=48100&r2=48099
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/375/LayoutTests/fast/lists/alpha-boundary-values.html
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/375/LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.checksum
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/375/LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.png
   A http://src.chromium.org/viewvc/chrome/branches/WebKit/375/LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.txt
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/375/WebCore/ChangeLog?r1=48100&r2=48099
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/375/WebCore/rendering/RenderListMarker.cpp?r1=48100&r2=48099

Merge 59950 - WebCore: Fix for <rdar://problem/8009118> Crash in WebCore::toAlphabetic() 
while running MangleMe
and corresponding
https://bugs.webkit.org/show_bug.cgi?id=39508

Reviewed by Darin Adler.

The math was slightly off here, and we wound up trying to access an 
array at index 1 in some cases. We need to decrement numberShadow 
rather than subtracting one from the result of the modulo 
operation.

* rendering/RenderListMarker.cpp:
(WebCore::toAlphabeticOrNumeric):

LayoutTests: Test for <rdar://problem/8009118> Crash in WebCore::toAlphabetic() 
while running MangleMe
and corresponding
https://bugs.webkit.org/show_bug.cgi?id=39508

Reviewed by Darin Adler.

* fast/lists/alphaboundaryvalues.html: Added.
* platform/mac/fast/lists/alphaboundaryvaluesexpected.checksum: Added.
* platform/mac/fast/lists/alphaboundaryvaluesexpected.png: Added.
* platform/mac/fast/lists/alphaboundaryvaluesexpected.txt: Added.



TBR=bdakin@apple.com
BUG= 44955 

Review URL: http://codereview.chromium.org/2158002
------------------------------------------------------------------------

Labels: -Area-Undefined Area-WebKit Mstone-5
Status: FixUnreleased
Labels: -Restrict-View-SecurityTeam
Status: Fixed
Fixed in 5.0.375.70

Comment 4 by jsc...@chromium.org, Dec 16 2010

Labels: -Pri-0 Pri-1 SecSeverity-High

Comment 5 by jsc...@chromium.org, Mar 21 2011

Labels: Type-Security
Labels: SecImpacts-Stable
Batch update.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
Owner: ----
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -Mstone-5 -SecSeverity-High -Type-Security -SecImpacts-Stable Cr-Content M-5 Security-Impact-Stable Type-Bug-Security Security-Severity-High
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2013

Labels: -Security-Severity-High Security_Severity-High
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 21 2013

Labels: -Security-Impact-Stable Security_Impact-Stable
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 1 2016

Labels: Restrict-View-SecurityNotify
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 2 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment