Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users
Status: Fixed
Owner:
Closed: Feb 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
Add support for 8 Indic locales
Reported by mal.chro...@gmail.com, Nov 16 2008 Back to list
We have (almost complete) translations for 8 new locales:

bn,gu,kn,ml,mr,or,ta,te

Tony has already checked in partial support for building the DLLs, and I 
have code for review that will complete it to the point where we build and 
ship the DLLs.

However, building these and running with --lang=bn does not work. 

I don't know what else is required to get these locales enabled in the UI 
(changes to ICU?).

Assigning to tony to let me know what else needs to be done or to reassign 
to someone else (jshin?).

I'd like to get this in for 1.0 if possible, and certainly enabled on the 
trunk soon so that the translation team can do LQA.

 
Comment 1 by tony@chromium.org, Nov 16 2008
Hmm, I bet we need to add these languages to ICU.  Specifically, 
chrome/common/l10n_util.cc:IsLocaleAvailable is probably failing because the call to 
SetICUDefaultLocale failing.  I will verify on Monday and assign to Jungshik if that's the case.
Labels: -Mstone-1.0 Mstone-1.1
Comment 3 by js...@chromium.org, Nov 20 2008
Ok. I'll add those locales to the ICU data. Taking the bug.

 As for additional 8 Indian language support in 1.0, I have some reservation (see
 issue 1097 ). Also, there's a font issue in both renderer and places like omnibox. 
I'd rather not add them for 1.0. 

Comment 4 by js...@chromium.org, Nov 24 2008
For some of 8 languages, CLDR entries are rather scantly populated. For instance, 
gu (Gujarati) has only 3 language names translated ( http://demo.icu-project.org/icu-
bin/locexp?d_=en&_=gu ). Kannada has more names translated but still a lot of entries 
are missing ( http://demo.icu-project.org/icu-bin/locexp?
_=kn&SHOWLanguages=1#Languages )

Bengali, Malayalam and Tamil have much better data. 

We have to fill them with the help of native speakers. I'll talk to Reggie about 
that. Populating them would be easy for native speakers. 



Labels: Mstone-2.0
Comment 6 by js...@chromium.org, Feb 5 2009
Status: Fixed
8 Indian locales are now enabled:

http://src.chromium.org/viewvc/chrome?view=rev&revision=9156
http://src.chromium.org/viewvc/chrome?view=rev&revision=9158

Two follow-up bugs were filed : bug 7319 and  bug 7325 

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=9156 

------------------------------------------------------------------------
r9156 | jungshik@google.com | 2009-02-04 11:16:33 -0800 (Wed, 04 Feb 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/README.google?r1=9156&r2=9155
   A http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/gbk.patch
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/icudt38.dll?r1=9156&r2=9155
   A http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/indian8_locales.txt
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/in/icudt38l.dat?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/bn.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/gu.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/kn.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/ml.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/mr.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/or.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/reslocal.mk?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/ta.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/locales/te.txt?r1=9156&r2=9155
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu38/source/data/mappings/windows-936-2000.ucm?r1=9156&r2=9155

Add the locale data (datetime format, region,language,script names) for 8 Indian languages 
to our copy of ICU. After checking in this patch, another change needs to be
made in chrome/app to enable 8 Indian languages.

Add fallback mappings for 4 Unicode code points for GBK converter to match
what's done by webkit in TextCodecICU.cpp. Chrome uses the ICU converter outside
webkit and it'd better be made to behave identically in and outside webkit.

BUG= 4473 , 7314 

Review URL: http://codereview.chromium.org/19545
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=9158 

------------------------------------------------------------------------
r9158 | jungshik@google.com | 2009-02-04 11:22:48 -0800 (Wed, 04 Feb 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/google_chrome_strings.grd?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_bn.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_gu.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_kn.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ml.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_mr.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_or.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ta.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_te.rc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/l10n_string_util.cc?r1=9158&r2=9157
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkit_strings.grd?r1=9158&r2=9157

Add support for 8 Indian languages. 
  * Add entries for 8 Indian languages to grd files (<translations> section)
  * Change the default spellcheck language for new languages to en-US for now. They'll be switched back to
    the UI language when we have spell check dictionaries for them
  * Add entries for 8 languages to installer's string offset table.

This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated.

BUG= 4473 

Review URL: http://codereview.chromium.org/19761
------------------------------------------------------------------------

Labels: -I18N bulkmove Feature-I18N
We have (almost complete) translations for 8 new locales:

bn,gu,kn,ml,mr,or,ta,te

Tony has already checked in partial support for building the DLLs, and I 
have code for review that will complete it to the point where we build and 
ship the DLLs.

However, building these and running with --lang=bn does not work. 

I don't know what else is required to get these locales enabled in the UI 
(changes to ICU?).

Assigning to tony to let me know what else needs to be done or to reassign 
to someone else (jshin?).

I'd like to get this in for 1.0 if possible, and certainly enabled on the 
trunk soon so that the translation team can do LQA.
Project Member Comment 10 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 11 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Feature-I18N Cr-UI-I18N
Project Member Comment 12 by bugdroid1@chromium.org, Mar 20 2013
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment