Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 44654 Add orientation event to Chromium
Starred by 15 users Reported by jorlow@chromium.org, May 20 2010 Back to list
Status: Verified
Owner:
Closed: Sep 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Device orientation events are being landed upstream (https://bugs.webkit.org/show_bug.cgi?
id=39210).  We should implement them in Chromium some time.
 
Comment 1 by h...@chromium.org, Jun 1 2010
Labels: -Mstone-6 Mstone-7
Comment 2 by h...@chromium.org, Jul 5 2010
Status: Started
WebKit bug for the plumbing: https://bugs.webkit.org/show_bug.cgi?id=41616
Comment 3 by bugdro...@gmail.com, Jul 22 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53317 

------------------------------------------------------------------------
r53317 | hans@chromium.org | 2010-07-22 02:55:33 -0700 (Thu, 22 Jul 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=53317&r2=53316
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/enable_switch_browsertest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=53317&r2=53316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=53317&r2=53316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=53317&r2=53316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=53317&r2=53316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=53317&r2=53316
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/device_orientation
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/device_orientation/enable_switch_test.html

Add --enable-device-orientation switch and set ENABLE_DEVICE_ORIENTATION=1

Flip the compile-time enable switch for device orientation to on,
and add a command-line switch to put the functionality behind.

The command-line flag will be used both on the Chromium side,
and in WebKit via WebRuntimeFeatures.

BUG= 44654 
TEST=browser_tests --gtest_filter=DeviceOrientationEnableSwitchTest.*

Review URL: http://codereview.chromium.org/3042009
------------------------------------------------------------------------

Comment 4 by bugdro...@gmail.com, Aug 12 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55724 

------------------------------------------------------------------------
r55724 | hans@chromium.org | 2010-08-11 07:42:53 -0700 (Wed, 11 Aug 2010) | 12 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/device_orientation_browsertest.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/dispatcher_host.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/dispatcher_host.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/orientation.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.h?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_renderer.gypi?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=55724&r2=55723
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/device_orientation_dispatcher.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/device_orientation_dispatcher.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=55724&r2=55723
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=55724&r2=55723
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/device_orientation/device_orientation_test.html

Chromium plumbing for Device Orientation.

Add the plumbing needed for communicating with the Device Orientation code in WebKit.

RenderView provides an implementation of WebKit::WebDeviceOrientationClient: DeviceOrientationDispatcher. This communicates with the browser-side class device_orientation::DispatcherHost.

device_orientation::Provider, responsible for providing the orientation data, is just an empty shell for now.

BUG= 44654 
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest

Review URL: http://codereview.chromium.org/2858049
------------------------------------------------------------------------

Comment 5 by bugdro...@gmail.com, Aug 23 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57036 

------------------------------------------------------------------------
r57036 | hans@chromium.org | 2010-08-23 00:39:28 -0700 (Mon, 23 Aug 2010) | 9 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/data_fetcher.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/orientation.h?r1=57036&r2=57035
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.cc?r1=57036&r2=57035
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.h?r1=57036&r2=57035
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider_impl.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider_impl.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57036&r2=57035
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=57036&r2=57035

Implement device_orientation::Provider.

Provider provides its registered observers with device orientation data
by finding and polling a DataFetcher on a background thread.

BUG= 44654 
TEST=unit_tests --gtest_filter="DeviceOrientationProviderTest.*"

Review URL: http://codereview.chromium.org/3136008
------------------------------------------------------------------------

Comment 6 by bugdro...@gmail.com, Aug 24 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57176 

------------------------------------------------------------------------
r57176 | hans@chromium.org | 2010-08-24 05:54:51 -0700 (Tue, 24 Aug 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/dispatcher_host.cc?r1=57176&r2=57175
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/dispatcher_host.h?r1=57176&r2=57175
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.h?r1=57176&r2=57175

device_orientation::DispatcherHost: one Provider observer per render_view_id.

Refactor device_orientation::DispatcherHost to create a 1-to-1 relationship
between a RenderView and an observer of the Provider. The intention is
to remove the need for logic from DispatcherHost, and in effect have the
RenderView observe the Provider.

BUG= 44654 
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest

Review URL: http://codereview.chromium.org/3152043
------------------------------------------------------------------------

Comment 7 by bugdro...@gmail.com, Aug 26 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57521 

------------------------------------------------------------------------
r57521 | hans@chromium.org | 2010-08-26 07:34:41 -0700 (Thu, 26 Aug 2010) | 11 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/accelerometer_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/accelerometer_mac.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/provider.cc?r1=57521&r2=57520
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57521&r2=57520

Adding MacBook Pro accelerometer support.

A class for handling Sudden Motion Sensors. It's only compiled under Mac OS.

Landing for Leandro Gracia Gil <leandrogracia@google.com>.
Original code review: http://codereview.chromium.org/3169040/show

BUG= 44654 
TEST=none

Review URL: http://codereview.chromium.org/3187025
------------------------------------------------------------------------

Comment 8 by bugdro...@gmail.com, Aug 27 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57650 

------------------------------------------------------------------------
r57650 | hans@chromium.org | 2010-08-27 01:06:31 -0700 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/device_orientation_dispatcher.cc?r1=57650&r2=57649
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/device_orientation_dispatcher.h?r1=57650&r2=57649

DeviceOrientationDispatcher: no orientation updates equal to lastOrientation().

The DeviceOrientationDispatcher, which implements WebDeviceOrientationClient,
must not send orientation updates that are equal to its lastOrientation().
This can happen when the client is stopped and then started again.

BUG= 44654 
TEST=Manual

Review URL: http://codereview.chromium.org/3104038
------------------------------------------------------------------------

Comment 9 by bugdro...@gmail.com, Aug 27 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57684 

------------------------------------------------------------------------
r57684 | hans@chromium.org | 2010-08-27 08:47:37 -0700 (Fri, 27 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/device_orientation_browsertest.cc?r1=57684&r2=57683
   D /trunk/src/chrome/browser/device_orientation/enable_switch_browsertest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=57684&r2=57683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=57684&r2=57683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=57684&r2=57683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=57684&r2=57683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=57684&r2=57683
   D /trunk/src/chrome/test/data/device_orientation/enable_switch_test.html

Enable device orientation by default.

Enable device orientation by default. Replace the --enable-device-orientation
command-line flag with a --disable-device-orientation flag.

BUG= 44654 
TEST=browser_tests --gtest_filter="DeviceOrientationBrowserTest.*"

Review URL: http://codereview.chromium.org/3136038
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57721 

------------------------------------------------------------------------
r57721 | hans@chromium.org | 2010-08-27 12:52:36 -0700 (Fri, 27 Aug 2010) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/accelerometer_mac.cc?r1=57721&r2=57720
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/device_orientation/accelerometer_mac.h?r1=57721&r2=57720

Added tested and corrected accelerometer support for the following MacBook / MacBook Pro models:

- MacBookPro2,2
- MacBookPro3,1
- MacBookPro4,1
- MacBookPro5,1
- MacBookPro6,2
- MacBookPro7,1

This patch fixes the axis inversion problems on these.

Landing for Leandro Gracia Gil <leandrogracia@google.com>.
Original code review: http://codereview.chromium.org/3177035/show

BUG= 44654 
TEST=None

Review URL: http://codereview.chromium.org/3275002
------------------------------------------------------------------------

Comment 11 by h...@chromium.org, Sep 1 2010
Labels: OS-Mac
Status: Fixed
Marking this fixed. Attaching instructions for manual test.
test.html
2.7 KB View Download
Labels: Verifier-Rohitbm
Verified label updated by AutoAllocator, contact AmolK or KrisR for details
Status: Verified
7.0.517.0 (Official Build 58656) dev

I liked this! :)
Is there any latest feature related with device orientation?

Project Member Comment 15 by bugdroid1@chromium.org, Mar 29 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129588

------------------------------------------------------------------------
r129588 | hans@chromium.org | Thu Mar 29 01:08:22 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=129588&r2=129587&pathrev=129588
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/device_orientation/accelerometer_mac.h?r1=129588&r2=129587&pathrev=129588
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.h?r1=129588&r2=129587&pathrev=129588 (from /trunk/src/content/browser/device_orientation/accelerometer_mac.h revision 129584)
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor?r1=129588&r2=129587&pathrev=129588
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc?r1=129588&r2=129587&pathrev=129588 (from /trunk/src/content/browser/device_orientation/accelerometer_mac.cc revision 129584)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/device_orientation/accelerometer_mac.cc?r1=129588&r2=129587&pathrev=129588
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor/LICENSE?r1=129588&r2=129587&pathrev=129588
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor/sudden_motion_sensor.gyp?r1=129588&r2=129587&pathrev=129588
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/device_orientation/DEPS?r1=129588&r2=129587&pathrev=129588
 A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sudden_motion_sensor/README.chromium?r1=129588&r2=129587&pathrev=129588

Move the Sudden Motion Sensor library into third_party.

BUG= 118913 
TEST=manual (see instructions at http://code.google.com/p/chromium/issues/detail?id=44654#c11)

Review URL: https://chromiumcodereview.appspot.com/9844020
------------------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 17 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-WebKit -Mstone-7 Cr-Content M-7
Project Member Comment 18 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 19 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content Cr-Blink
Sign in to add a comment