New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 442131
issue 442132

Blocking:
issue 442145



Sign in to add a comment
link

Issue 442133: Web Notifications: Support the renotify preference flag

Reported by peter@chromium.org, Dec 14 2014 Project Member

Issue description

Web Notifications recently have been given a "renotify" member on the NotificationObjects object, which indicates behavior when a notification is being replaced.

In short, when set to TRUE, the sound and vibration associated with the notification have to be triggered again.

For the Message Center implementation, we can also tie this to re-showing the notification when it's been updated, which we currently enforce for none but Web Notifications.

For Android, this pretty much comes down to using the setOnlyAlertOnce() flag.
 

Comment 1 by peter@chromium.org, Dec 14 2014

Blocking: chromium:442145

Comment 2 by harkness@chromium.org, Jan 26 2016

Owner: harkness@chromium.org
Status: Assigned

Comment 3 by mvanouwe...@chromium.org, Feb 2 2016

Status: Started

Comment 4 by bugdroid1@chromium.org, Feb 11 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2

commit 39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2
Author: harkness <harkness@chromium.org>
Date: Wed Feb 10 20:15:27 2016

Implementation of renotify flag for Notifications.

Implement and plumb the renotify flag. This flag controls whether alert sound, lights,
and vibration are played again when a notification replaces a previous notification.

Changes for this issue are covered by Intent to Implement and Ship: Notification Renotify.

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k5n129-lM1A

BUG= 442133 

Review URL: https://codereview.chromium.org/1656243002

Cr-Commit-Position: refs/heads/master@{#374709}

[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/browser/notifications/notification_ui_manager_android.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/browser/notifications/platform_notification_service_browsertest.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/chrome/test/data/notifications/platform_notification_service.html
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/browser/notifications/notification_database_data.proto
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/browser/notifications/notification_database_data_conversions.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/browser/notifications/notification_database_data_unittest.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/child/notifications/notification_data_conversions.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/child/notifications/notification_data_conversions_unittest.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/common/platform_notification_messages.h
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/content/public/common/platform_notification_data.h
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/Notification.idl
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/NotificationData.cpp
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/ui/message_center/notification.cc
[modify] http://crrev.com/39c49fe6e8dfe2f2ae3c7db261cb8e845692dfd2/ui/message_center/notification.h

Comment 5 by harkness@chromium.org, Feb 11 2016

Status: Fixed

Comment 6 by jmedley@chromium.org, Feb 17 2016

Labels: M-50

Sign in to add a comment