New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 439389 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner:
vacation (back 11/27)
Closed: May 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 466371
issue 474233
issue 474236
issue 474238
issue 474239

Blocking:
issue 452745
issue 455282



Sign in to add a comment

Expose the Cache Storage API to window (and workers)

Project Member Reported by jakearchibald@chromium.org, Dec 5 2014

Issue description

Cc: igrigo...@chromium.org
Labels: Needs-Feedback
Looking for use cases to inform the priority. 

Comment 3 Deleted

Cc: jsb...@chromium.org gavinp@chromium.org
Labels: -Needs-Feedback M-43
Owner: jsb...@chromium.org
Status: Available
Discussed with Cache team members, I believe we could try M43. 
Leaving as P2 to keep enough headroom for critical work.

I'll open an OWP-launch bug and work on the prerequisite reviews as well as the intent to ship draft.
Blocking: chromium:455282
Blocking: chromium:452745
Status: Started

Comment 9 by mtragut@google.com, Mar 20 2015

Is this bug still on time for 43? 

Having cacheStorage available in the window would make it much easier for us to write good tests (they can only run in window right now).
Yes, still working on it. First CL is at https://codereview.chromium.org/992353003/
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abadb9bf3f02e61f3543ea62ade29a009b18e654

commit abadb9bf3f02e61f3543ea62ade29a009b18e654
Author: jsbell <jsbell@chromium.org>
Date: Mon Mar 23 21:03:44 2015

Decouple Cache Storage messaging from Service Worker/Embedded Worker

We plan to expose the Cache Storage API independent of Service Worker.
Tease the IPC message routing off of Service Worker and Embedded
Worker, mirroring the other context-independent storage APIs. With
this CL the browser side is independent but the renderer side entry
point is still only available to the SW's context. Files have been
left in the content/*/service_worker/ directories for now; follow-ups
will shorten the names and move them to dedicated directories.

BUG= 439389 

Review URL: https://codereview.chromium.org/992353003

Cr-Commit-Position: refs/heads/master@{#321847}

[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/renderer_host/render_process_host_impl.cc
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/cache_storage_context_impl.cc
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/cache_storage_context_impl.h
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/cache_storage_dispatcher_host.cc
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/cache_storage_dispatcher_host.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_cache_listener.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_cache_listener.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_context_core.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_context_core.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_context_wrapper.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_version.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_version.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/service_worker/service_worker_version_unittest.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/storage_partition_impl.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/storage_partition_impl.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/browser/storage_partition_impl_map.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/common/content_message_generator.h
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/common/service_worker/cache_storage_messages.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/common/service_worker/service_worker_messages.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/content_browser.gypi
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/content_common.gypi
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/content_renderer.gypi
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/render_thread_impl.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/render_thread_impl.h
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/cache_storage_message_filter.cc
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/cache_storage_message_filter.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/embedded_worker_context_client.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/service_worker_cache_storage_dispatcher.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/service_worker_script_context.cc
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/service_worker_script_context.h
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/webserviceworkercachestorage_impl.cc
[add] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/content/renderer/service_worker/webserviceworkercachestorage_impl.h
[modify] http://crrev.com/abadb9bf3f02e61f3543ea62ade29a009b18e654/ipc/ipc_message_start.h

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82f0728287f968b27d9fc9e54153df145a9fe1c

commit e82f0728287f968b27d9fc9e54153df145a9fe1c
Author: jsbell <jsbell@chromium.org>
Date: Tue Mar 24 20:01:37 2015

Use "database identifier" rather than raw origin as directory hash input

When we allow non-Service Workers to have access to the Cache Storage
API we will want to match other storage systems and use a database
identifier generated from a Blink SecurityOrigin object, rather than
just the origin URL, as the key for per-origin storage.

This change changes the computation of the directory name on disk (a
hash) from using the origin to a database identifier, in anticipation
of an identifier being passed in after some future CLs.

Existing data is preserved by preceding the uses of the directory name
(open, delete, or enumeration) with a directory rename from the
"legacy" name computed from the origin to the "new" name computed from
the directory identifier. The rename is done by posting a task to the
cache task runner just before the actual task. After a few releases we
remove the migration code.

R=michaeln,jkarlin
BUG= 439389 

Review URL: https://codereview.chromium.org/1020413002

Cr-Commit-Position: refs/heads/master@{#322055}

[modify] http://crrev.com/e82f0728287f968b27d9fc9e54153df145a9fe1c/content/browser/service_worker/service_worker_cache_storage_manager.cc
[modify] http://crrev.com/e82f0728287f968b27d9fc9e54153df145a9fe1c/content/browser/service_worker/service_worker_cache_storage_manager.h
[modify] http://crrev.com/e82f0728287f968b27d9fc9e54153df145a9fe1c/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/555f534f8262449d2bff2abdd635a6ada4cd9f9e

commit 555f534f8262449d2bff2abdd635a6ada4cd9f9e
Author: jsbell <jsbell@chromium.org>
Date: Thu Mar 26 00:39:15 2015

Cache Storage: Implement Blink Platform API

The API will be defined in a follow-up Blink CL. Unlike the existing,
Service Worker-specific API, this one passes ownership of the new
object to the caller. The origin is specified by a database identifier
derived from the SecurityOrigin on the Blink side.

BUG= 439389 

Review URL: https://codereview.chromium.org/1031063002

Cr-Commit-Position: refs/heads/master@{#322278}

[modify] http://crrev.com/555f534f8262449d2bff2abdd635a6ada4cd9f9e/content/renderer/renderer_blink_platform_impl.cc
[modify] http://crrev.com/555f534f8262449d2bff2abdd635a6ada4cd9f9e/content/renderer/renderer_blink_platform_impl.h
[modify] http://crrev.com/555f534f8262449d2bff2abdd635a6ada4cd9f9e/content/renderer/service_worker/embedded_worker_context_client.h

Blocking: chromium:457157
Summary: Expose the Cache Storage API to window (and workers) (was: Expose caches API to window (and workers))
hiroshige@: this is ready (I'm sending an intent to ship). Consider  issue 457157  unblocked.
Blocking: -chromium:457157
Blockedon: chromium:466371
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 31 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279efb4de2d891d4575329c853e1c9858c057d2a

commit 279efb4de2d891d4575329c853e1c9858c057d2a
Author: jsbell <jsbell@chromium.org>
Date: Tue Mar 31 17:02:46 2015

Cache Storage: Move files to content/*/cache_storage, rename classes

* Introduce content/*/cache_storage
* Move Cache Storage files from content/*/service_worker
* Update gypi/gn files
* Rename classes, ipc messages, protobuf messages

The renames are basically mechanical:
* ServiceWorkerCacheStorageFoo -> CacheStorageFoo
* ServiceWorkerCacheFoo -> CacheStorageFoo
* ServiceWorkerCache -> CacheStorageCache (not just 'Cache')

Also, made jkarlin@ and jsbell@ (that's me!) OWNERS in the new
directories in addition to the */service_worker/OWNERS.

BUG= 439389 

Review URL: https://codereview.chromium.org/1039763002

Cr-Commit-Position: refs/heads/master@{#323060}

[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/BUILD.gn
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/background_sync/background_sync_manager.h
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/BUILD.gn
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/OWNERS
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/PRESUBMIT.py
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage.h
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage.proto
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_cache.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_cache.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_cache_unittest.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_context_impl.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_context_impl.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_dispatcher_host.h
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_listener.cc
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_listener.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_manager.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_manager.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_manager_unittest.cc
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_proto.gyp
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_quota_client.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_quota_client.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_scheduler.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_scheduler.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/cache_storage/cache_storage_scheduler_unittest.cc
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/renderer_host/render_process_host_impl.cc
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/service_worker/BUILD.gn
[delete] http://crrev.com/f00ca402211beed68dd9215558adce3f9cb85171/content/browser/service_worker/service_worker_cache.proto
[delete] http://crrev.com/f00ca402211beed68dd9215558adce3f9cb85171/content/browser/service_worker/service_worker_cache_listener.cc
[delete] http://crrev.com/f00ca402211beed68dd9215558adce3f9cb85171/content/browser/service_worker/service_worker_cache_listener.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/service_worker/service_worker_proto.gyp
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/browser/storage_partition_impl.h
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/cache_storage/OWNERS
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/cache_storage/cache_storage_messages.h
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/cache_storage/cache_storage_types.cc
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/cache_storage/cache_storage_types.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/content_message_generator.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/service_worker/service_worker_types.cc
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/common/service_worker/service_worker_types.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/content_browser.gypi
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/content_common.gypi
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/content_renderer.gypi
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/content_tests.gypi
[add] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/OWNERS
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/cache_storage_dispatcher.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/cache_storage_dispatcher.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/cache_storage_message_filter.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/cache_storage_message_filter.h
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
[rename] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/cache_storage/webserviceworkercachestorage_impl.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/render_thread_impl.cc
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/render_thread_impl.h
[modify] http://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a/content/renderer/renderer_blink_platform_impl.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 31 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192588

------------------------------------------------------------------
r192588 | jsbell@chromium.org | 2015-03-26T07:56:20.606023Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.h?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeClientImpl.h?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/public/platform/Platform.h?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebServiceWorkerContextClient.h?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.cpp?r1=192588&r2=192587&pathrev=192588
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h?r1=192588&r2=192587&pathrev=192588

Cache Storage: Add Platform API to retrieve CacheStorage for origin

Define a public API to allow any execution context, not just a Service
Worker, to access the Cache Storage system. Switch Service Workers
(and SW devtools) over to using it, and drop the old public API. No
other contexts are given access to it, so there is no change in
functionality exposed to script.

BUG= 439389 

Review URL: https://codereview.chromium.org/1029423004
-----------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 31 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192778

------------------------------------------------------------------
r192778 | jsbell@chromium.org | 2015-03-30T22:10:06.662340Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-match-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-put.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-delete-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-delete-expected.txt?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-match.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-storage-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-add-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-match.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-delete-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-delete.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-add-expected.txt?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-delete.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-put-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-storage.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/common-worker.js?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Cache.idl?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-add.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-put.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-storage-keys.html?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-storage-keys.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/common.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-put-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-delete.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WindowCacheStorage.idl?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-add.html?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/weborigin/SecurityOrigin.h?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WorkerCacheStorage.idl?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-put.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.cpp?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-storage-match.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/fetch-status.php?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-expected.txt?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-put.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-storage.js?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-storage-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/blank.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-match.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.h?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/cache-storage.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-add-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/resources/testharness-helpers.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/iframe.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/simple.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-delete.js?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-match.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-keys.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-put-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/resources/test-helpers.js?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-match-expected.txt?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-add.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/window/sandboxed-iframes.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/worker/cache-storage-match.html?r1=192778&r2=192777&pathrev=192778
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.idl?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/serviceworker/cache-storage-keys.html?r1=192778&r2=192777&pathrev=192778
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js?r1=192778&r2=192777&pathrev=192778

Expose Cache Storage API in global window/worker scope

Exposes self.caches which accesses the origin's CacheStorage instance.
Requires the --enable-experimental-web-platform-features flag, otherwise
the API is only available in Service Workers.

https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache

BUG= 439389 

Review URL: https://codereview.chromium.org/1032623008
-----------------------------------------------------------------
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 1 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192898

------------------------------------------------------------------
r192898 | jsbell@chromium.org | 2015-04-01T03:02:38.210974Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-storage-match-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-add.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-delete-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-match.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-storage-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-storage-match.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-delete.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-add-expected.txt?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-storage.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-storage-keys-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-match-expected.txt?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-put.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-delete-expected.txt?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-storage-keys.html?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-storage-expected.txt?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-add-worker.js?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/cache-put-expected.txt?r1=192898&r2=192897&pathrev=192898
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js?r1=192898&r2=192897&pathrev=192898

Remove redundant serviceworker/cache-* tests

The tests were moved to cachestorage/ and made generic to cover
window, worker, and serviceworker cases, so coverage is identical.

BUG= 439389 
R=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/1043213003
-----------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 3 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193068

------------------------------------------------------------------
r193068 | jsbell@chromium.org | 2015-04-03T03:48:50.399049Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WorkerCacheStorage.idl?r1=193068&r2=193067&pathrev=193068
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.cpp?r1=193068&r2=193067&pathrev=193068
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.h?r1=193068&r2=193067&pathrev=193068
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WindowCacheStorage.idl?r1=193068&r2=193067&pathrev=193068

Drop ScriptState argument from global Cache Storage accessor.

We only need an ExecutionContext and that can be obtained from the
global scope that is implicitly passed in. Simplifies the IDL.

R=dmurph@chromium.org
BUG= 439389 

Review URL: https://codereview.chromium.org/1051363004
-----------------------------------------------------------------
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 4 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193152

------------------------------------------------------------------
r193152 | jsbell@chromium.org | 2015-04-04T00:32:34.115779Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheTest.cpp?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Cache.cpp?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/Cache.idl?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheQueryOptions.idl?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/OWNERS?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheStorage.h?r1=193152&r2=193151&pathrev=193152
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/DEPS?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/Cache.cpp?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheTest.cpp?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.h?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.h?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/WindowCacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/WorkerCacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/GlobalCacheStorage.cpp?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.h?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.h?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheStorage.cpp?r1=193152&r2=193151&pathrev=193152
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WindowCacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Cache.h?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/WorkerCacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/GlobalCacheStorage.cpp?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.idl?r1=193152&r2=193151&pathrev=193152
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/Cache.h?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/DEPS?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.cpp?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Cache.idl?r1=193152&r2=193151&pathrev=193152
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/GlobalCacheStorage.h?r1=193152&r2=193151&pathrev=193152
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheQueryOptions.idl?r1=193152&r2=193151&pathrev=193152

Move Cache Storage API implementation to modules/cachestorage

Since it's no longer limited to Service Worker context, give it a
module of its very own.

Add jkarlin to OWNERS

BUG= 439389 

Review URL: https://codereview.chromium.org/1055543004
-----------------------------------------------------------------
Blockedon: chromium:474233
Blockedon: chromium:474238
Blockedon: chromium:474236
Blockedon: chromium:474239
Labels: -M-43 M-44 MovedFrom-43
[AUTO] Moving all non essential bugs to the next Milestone.  (This decision is based on the labels attached to your ticket.)


Ref: https://sites.google.com/a/chromium.org/dev/developers/ticket-milestone-punting-1
Project Member

Comment 31 by bugdroid1@chromium.org, Apr 21 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=194060

------------------------------------------------------------------
r194060 | dmurph@chromium.org | 2015-04-21T00:04:38.916637Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/resources/ResourcesPanel.js?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDevToolsAgentImpl.cpp?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/sdk/ServiceWorkerManager.js?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/sdk/Target.js?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-deletion.html?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-names.html?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/protocol.json?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-data.html?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-deletion-expected.txt?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-names-expected.txt?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/event_idl_files_list.tmp?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/sdk/WorkerManager.js?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp?r1=194060&r2=194059&pathrev=194060
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/cache-storage/cache-data-expected.txt?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.h?r1=194060&r2=194059&pathrev=194060
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/inspector/inspector-test.js?r1=194060&r2=194059&pathrev=194060

[Storage] Cache storage inspection on all the frames!
 * Simplified the ServiceWorkerCacheModel & added securityOrigin support
 * Renamed protocol to "CacheStorage"
 * Hooked up cache using new piping from Josh
 * Add agent in the same spot as the IndexedDB agent.

BUG= 439389 

Review URL: https://codereview.chromium.org/1044203004
-----------------------------------------------------------------
Labels: Cr-Blink-ServiceWorker-Cache Release-Notes-M43 Release-Notes-M44
Labels: -M-44 MovedFrom-44
[AUTO] This issue has already been moved once and is lower than Priority 1,therefore removing mstone.
jsbell: Is this bug done?
Status: Fixed
I was holding off closing it until all the "blockers" are resolved, but they're not technically blockers since we shipped it. So... sure.

Labels: -MovedFrom-43 -MovedFrom-44 M-43 M-44
Thanks! For reference, cache storage was exposed to window/worker in M43, and inspection on all frames was added in M44.
Components: Blink>Storage>CacheStorage
Components: -Blink>ServiceWorker>Cache

Sign in to add a comment