New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 43938 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug
M-6

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

uncolored popup window custom frame

Project Member Reported by est...@chromium.org, May 11 2010

Issue description

see attachment

it's a popup window with the custom frame enabled on linux ToT. The theme is 
the default chrome theme. Should be blue, not white (?)
 
pale.png
30.4 KB View Download

Comment 1 by e...@chromium.org, May 11 2010

Status: Assigned
This is sort of by design, but may be changed/refined later. For the full story, see 
 issue 21672 .

A very quick recap: There was outcry that on Windows, the rest of the windows didn't 
match the main frame. Per Glen, popups couldn't use the main theme_frame image 
because there are a bunch of themes where any text would be totally unreadable if we 
used that image. So we use the tab images for these windows, which already are guaranteed to have a good text color/image combination for readable text. (Now, of 
course, there is an outcry that we're doing things this way.)

I intend on reverting this behaviour in the case of the default theme. This has been 
the default behaviour for mac for a while. Whether this change sticks long-
term...*shrug*.

Comment 2 by evan@chromium.org, Jun 9 2010

Labels: -Pri-1 -Regression Pri-2 Polish

Comment 3 by evan@chromium.org, Jun 9 2010

Labels: Mstone-X

Comment 4 by e...@chromium.org, Jun 9 2010

Labels: -Pri-2 -Mstone-X Pri-1 Mstone-6
Actually, I'm going to keep this P1 M6 because mirandac and I are meeting with glen about this.

Comment 5 by e...@chromium.org, Jun 10 2010

Status: Fixed

Comment 6 by bugdro...@gmail.com, Jun 11 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=49458 

------------------------------------------------------------------------
r49458 | erg@chromium.org | 2010-06-10 15:23:02 -0700 (Thu, 10 Jun 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_titlebar.cc?r1=49458&r2=49457
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=49458&r2=49457
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.h?r1=49458&r2=49457
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc?r1=49458&r2=49457
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.h?r1=49458&r2=49457

GTK: Always use default frame in popup windows.

Now that glen@ has spoken, make popup windows on linux match the XP behaviour
by never using themed resources for the window frame.

BUG= 43938 
TEST=none

Review URL: http://codereview.chromium.org/2771011
------------------------------------------------------------------------

Labels: -polish bulkmove Type-Polish
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-6 -Type-Polish M-6 Cr-UI-Polish Cr-UI Type-Bug
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment