New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 4391: Upstream new and forked layout tests

Reported by pam@chromium.org, Nov 13 2008 Project Member

Issue description

Upstream as many tests from pending/ and chrome/ as possible.
 

Comment 1 by pam@chromium.org, Nov 15 2008

Most of the tests in pending/ have been upstreamed, pulled back down in merges, and removed 
from pending/.  I'm still working on these:

* plugins/destroy-stream-twice.html: needs to be looked at more

* fast/events/special-key-events-in-input-text.html: has been edited to work on Windows 
WebKit; needs to be upstreamed in its new form

* fast/repaint/bugzilla-6473.html: https://bugs.webkit.org/show_bug.cgi?id=21536

* security/block-test.html: https://bugs.webkit.org/show_bug.cgi?id=21530

* Several tests in http/tests/security/:  We both changed the port these run under and made 
some adjustments in an attempt to clear up an intermittent failure/race.  WebKit also 
addressed the race condition, in an entirely different way.  The port change mainly supported 
a different DocumentRoot so we could get to tests outside LayoutTests. After discussion with 
deanm, who did the original forking, we're going to try re-enabling the copies in LayoutTests 
and see what happens. If they pass consistently, we'll just drop these.

* http/tests/misc/frame-default-enc-same-domain.html: newly added since I started upstreaming; 
needs to be looked at

Comment 2 by bugdro...@gmail.com, Mar 12 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11584 

------------------------------------------------------------------------
r11584 | pam@chromium.org | 2009-03-12 15:16:04 -0700 (Thu, 12 Mar 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/chrome/fast/dom/resources/wrapper-context-inner.html?r1=11584&r2=11583
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/chrome/fast/dom/wrapper-context-expected.txt?r1=11584&r2=11583
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/chrome/fast/dom/wrapper-context.html?r1=11584&r2=11583

Make wrapper-context.html faster by eliminating timeouts.

BUG= 4391 
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/42097
------------------------------------------------------------------------

Comment 3 by bugdro...@gmail.com, Mar 27 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=12696 

------------------------------------------------------------------------
r12696 | pam@chromium.org | 2009-03-27 13:23:53 -0700 (Fri, 27 Mar 2009) | 6 lines
Changed paths:
   D /trunk/src/webkit/data/layout_tests/chrome/editing
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/TestApplet.class
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/Window
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/document_write_params-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/document_write_params.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/dom-add-optionelement-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/dom-add-optionelement.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/dom-constructors-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/dom-constructors.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/function_arguments-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/function_arguments.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmlcollection-detectability-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmlcollection-detectability.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmlformelement-indexed-getter-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmlformelement-indexed-getter.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmliframeelement-document-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmliframeelement-document.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmloptionscollection-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmloptionscollection.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmloptionscollection_call_as_function-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/htmloptionscollection_call_as_function.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/java-applet-calls-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/java-applet-calls.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/navigator-cookieEnabled-no-crash-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/navigator-cookieEnabled-no-crash.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/no-init-context-in-access-check-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/no-init-context-in-access-check.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/nodelist-item-with-name-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/nodelist-item-with-name.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/object_collection-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/object_collection.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/onload-fires-twice-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/onload-fires-twice.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/onload-name-collision-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/onload-name-collision.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/resources/1.gif
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/resources/wrapper-context-inner.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/script_lineno-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/script_lineno.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/set-document-body-no-crash-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/set-document-body-no-crash.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/set-table-head-no-crash-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/set-table-head-no-crash.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/typecheck-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/typecheck.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-collection-length-no-crash-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-collection-length-no-crash.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-frames-self-referential-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-frames-self-referential.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-image-name-conflict-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-image-name-conflict.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-location-precedence-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-location-precedence.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-postmessage-null-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-postmessage-null.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/wrapper-context-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/wrapper-context.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/xmlhttprequest-gc-expected.checksum
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/xmlhttprequest-gc-expected.png
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/xmlhttprequest-gc-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/xmlhttprequest-gc.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/contextmenu-event-ordering-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/contextmenu-event-ordering.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/document-no-frame-events-no-crash-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/document-no-frame-events-no-crash.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/nested-window-event-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/events/nested-window-event.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/forms/var-name-conflict-in-form-event-handler-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/forms/var-name-conflict-in-form-event-handler.html
   D /trunk/src/webkit/data/layout_tests/chrome/fonts
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=12696&r2=12695

Remove tests that have been upstreamed. Update test_expectations list
accordingly.

BUG= 4391 
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/55025
------------------------------------------------------------------------

Comment 4 by bugdro...@gmail.com, Apr 7 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=13292 

------------------------------------------------------------------------
r13292 | pam@chromium.org | 2009-04-07 15:13:03 -0700 (Tue, 07 Apr 2009) | 8 lines
Changed paths:
   D /trunk/src/webkit/data/layout_tests/pending/security
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/regexp-overflow-expected.txt?r1=13292&r2=13291
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/regexp-overflow-expected.txt?r1=13292&r2=13291
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/security/block-test-expected.txt?r1=13292&r2=13291
   D /trunk/src/webkit/data/layout_tests/platform/chromium-win/pending/security/block-test-expected.txt
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13292&r2=13291

For two layout tests that were split into pieces to allow us to pass most of
their test cases, re-baseline the pieces we pass and WONTFIX the pieces we
won't. Also remove the corresponding pending/ test now that the change has been
upstreamed.

BUG= 4391 
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/62120
------------------------------------------------------------------------

Comment 5 by bugdro...@gmail.com, Apr 7 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=13298 

------------------------------------------------------------------------
r13298 | pam@chromium.org | 2009-04-07 15:52:09 -0700 (Tue, 07 Apr 2009) | 6 lines
Changed paths:
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/location-shadowing-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/location-shadowing.html
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/resources
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-shadowing-expected.txt
   D /trunk/src/webkit/data/layout_tests/chrome/fast/dom/window-shadowing.html

Remove some tests that have been sent upstream and brought back down in WebKit.
These were split into various fast/dom/Window/Location/ tests.

BUG= 4391 
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/63094
------------------------------------------------------------------------

Comment 6 by jon@chromium.org, Apr 9 2009

Labels: -Area-DevTools Area-Infrastructure

Comment 7 by pam@chromium.org, Apr 22 2009

Status: Available
Opening up my bugs for someone else to look at while I'm away.

Lots done, a bunch left to go.  See

http://spreadsheets.google.com/ccc?key=piGkUUMLW-PNUzuhTCzm4NQ&hl=en

for the list of remaining tests and who's signed up for what, as well as (on the 
second sheet) tips and instructions for upstreaming.

Comment 8 by dglazkov@chromium.org, Aug 20 2009

Labels: LayoutTests

Comment 9 by mal.chro...@gmail.com, Sep 30 2009

Labels: Mstone-X
Status: Started
Karen is currently working through these tests as time permits.

Comment 10 by mal.chro...@gmail.com, Dec 18 2009

Labels: -Area-Infrastructure Area-BuildTools

Comment 11 by lafo...@chromium.org, Mar 19 2011

Labels: -Area-BuildTools bulkmove Area-Build
Upstream as many tests from pending/ and chrome/ as possible.

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Type-Cleanup -Pri-2 -Tests -Area-Build Pri-3 Type-Bug Cr-Tests Build

Comment 13 by dglazkov@chromium.org, Oct 11 2013

Status: Fixed

Sign in to add a comment