New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 430238
issue 443563



Sign in to add a comment

Implement Permissions API

Project Member Reported by mlamouri@chromium.org, Dec 1 2014

Issue description

This bug is about the implementation.  bug 432570  is about shipping.
 
Blocking: chromium:432570
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=186310

------------------------------------------------------------------
r186310 | mlamouri@chromium.org | 2014-12-02T16:43:27.539295Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt?r1=186310&r2=186309&pathrev=186310
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/test-api-surface.html?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.cpp?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/test-query.html?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/helpers.js?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.h?r1=186310&r2=186309&pathrev=186310
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.idl?r1=186310&r2=186309&pathrev=186310
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/EventTargetModulesFactory.in?r1=186310&r2=186309&pathrev=186310
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-api-surface.js?r1=186310&r2=186309&pathrev=186310
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/OWNERS?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.cpp?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-query.js?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.h?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.idl?r1=186310&r2=186309&pathrev=186310
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources?r1=186310&r2=186309&pathrev=186310

Stub implementation of Permissions API module.

This is adding the Permissions interface with the query()
method and implements it by always rejecting.

This CL also introduces a test framework to be able to
test the API in different scopes easily and uses it to
test the above mentioned implementation.

Intent to implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wfszE6uUmk8/r9ucFjbfvY4J

BUG= 437770 

Review URL: https://codereview.chromium.org/760223003
-----------------------------------------------------------------
Blockedon: chromium:443563
Blockedon: chromium:430238
 Issue 461374  has been merged into this issue.
Labels: Cr-Permissions
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 11 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=191721

------------------------------------------------------------------
r191721 | mlamouri@chromium.org | 2015-03-11T17:54:56.247439Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionQueryCallback.cpp?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionController.cpp?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.cpp?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/modules/permissions/WebPermissionClient.h?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/modules/permissions/OWNERS?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/modules/permissions/WebPermissionType.h?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-query.js?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionQueryCallback.h?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/modules/permissions/WebPermissionStatus.h?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.h?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionController.h?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.idl?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebFrameClient.h?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/public/platform/Platform.h?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.cpp?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLocalFrameImpl.cpp?r1=191721&r2=191720&pathrev=191721
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/modules/permissions?r1=191721&r2=191720&pathrev=191721
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=191721&r2=191720&pathrev=191721

Implement Permissions.query() and static PermissionStatus.

This is adding a WebPermissionClient implement by WebFrameClient
and blink::Platform in order to be accessible from Workers and
Documents.

BUG= 437770 

Review URL: https://codereview.chromium.org/804553003
-----------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 11 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=191730

------------------------------------------------------------------
r191730 | sigbjornf@opera.com | 2015-03-11T19:49:31.604743Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionController.h?r1=191730&r2=191729&pathrev=191730

Oilpan: fix build after r191721 (b3a40c954).

TBR=oilpan-reviews
BUG= 437770 
NOTRY=true

Review URL: https://codereview.chromium.org/1003473003
-----------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 17 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/670a86def14a54e127fdad702be51572a81532a8

commit 670a86def14a54e127fdad702be51572a81532a8
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Mar 17 16:06:25 2015

Implement WebPermissionClient for Document and Worker contexts

It does enable Permissions.query() in Document and Worker context.

It is using the mojo pipe associated to the RenderFrameImpl or BlinkPlatformImpl
so the PermissionManager doesn't need to know in which context it lives.
However, it needs to do some thread jumping to be back in the main thread.

This is based on top of https://codereview.chromium.org/804553003

BUG= 437770 

Review URL: https://codereview.chromium.org/801613004

Cr-Commit-Position: refs/heads/master@{#320927}

[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/browser/permissions/permission_service_impl.cc
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/blink_platform_impl.cc
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/blink_platform_impl.h
[add] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/permissions/OWNERS
[add] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/permissions/permission_manager.cc
[add] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/permissions/permission_manager.h
[add] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/permissions/permission_manager_thread_proxy.cc
[add] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/child/permissions/permission_manager_thread_proxy.h
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/common/permission_service.mojom
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/content_child.gypi
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/renderer/render_frame_impl.cc
[modify] http://crrev.com/670a86def14a54e127fdad702be51572a81532a8/content/renderer/render_frame_impl.h

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 24 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192432

------------------------------------------------------------------
r192432 | mlamouri@chromium.org | 2015-03-24T13:46:19.583496Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/WorkerNavigatorPermissions.h?r1=192432&r2=192431&pathrev=192432
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/NavigatorPermissions.cpp?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-api-surface.js?r1=192432&r2=192431&pathrev=192432
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/NavigatorPermissions.h?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-query.js?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.idl?r1=192432&r2=192431&pathrev=192432
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/WorkerNavigatorPermissions.idl?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/test-api-surface.html?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.cpp?r1=192432&r2=192431&pathrev=192432
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/NavigatorPermissions.idl?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.h?r1=192432&r2=192431&pathrev=192432
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/WorkerNavigatorPermissions.cpp?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-expected.txt?r1=192432&r2=192431&pathrev=192432
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=192432&r2=192431&pathrev=192432

Make navigator.permissions an instance of Permissions interface.

This is exposing navigator.permissions instead of static methods on
Permissions. Following TAG comments and various discussions.

See spec bug: https://github.com/w3c/permissions/issues/11

BUG= 437770 

Review URL: https://codereview.chromium.org/1002633005
-----------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2a873b6f8f4251a491891c5d5d825b25150a032

commit e2a873b6f8f4251a491891c5d5d825b25150a032
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Mar 25 15:06:15 2015

Make content::PermissionType an enum class.

It allows us to forward declare it instead of including the file everywhere.

BUG= 437770 

Review URL: https://codereview.chromium.org/1020683003

Cr-Commit-Position: refs/heads/master@{#322164}

[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/android_webview/browser/aw_content_browser_client.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/chrome/browser/chrome_content_browser_client.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/chrome/browser/content_settings/permission_context_uma_util.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/browser/frame_host/render_frame_host_impl.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/browser/media/cdm/browser_cdm_manager.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/browser/permissions/permission_service_impl.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/browser/permissions/permission_service_impl.h
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/public/browser/content_browser_client.h
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/public/browser/permission_type.h
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/shell/browser/layout_test/layout_test_content_browser_client.h
[modify] http://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032/content/shell/browser/shell_content_browser_client.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5

commit c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5
Author: mlamouri <mlamouri@chromium.org>
Date: Sat Mar 28 17:48:14 2015

Rename content::PermissionManager to content::PermissionDispatcher.

https://codereview.chromium.org/1011953003 introduces a
content::PermissionManager interface which doesn't work well with the
current one.

BUG= 437770 ,  430238 

Review URL: https://codereview.chromium.org/1035223003

Cr-Commit-Position: refs/heads/master@{#322708}

[modify] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/blink_platform_impl.cc
[modify] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/blink_platform_impl.h
[rename] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/permissions/permission_dispatcher.cc
[rename] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/permissions/permission_dispatcher.h
[add] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/permissions/permission_dispatcher_thread_proxy.cc
[rename] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/child/permissions/permission_dispatcher_thread_proxy.h
[delete] http://crrev.com/a28055583609850edaa984ed1f54779ffcedacea/content/child/permissions/permission_manager_thread_proxy.cc
[modify] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/content_child.gypi
[modify] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/renderer/render_frame_impl.cc
[modify] http://crrev.com/c6d31dbb45e964becb9b4f9c9d8bc958dc93b9b5/content/renderer/render_frame_impl.h

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e37202019e367f9c40beaa499813526941cc1f6

commit 4e37202019e367f9c40beaa499813526941cc1f6
Author: mlamouri <mlamouri@chromium.org>
Date: Sun Mar 29 14:51:06 2015

Refactor Permissions related method out of ContentBrowserClient.

This is creating a content/public/browser/permission_manager.h interface
that is hooked on the BrowserContext. It has an implementation in chrome/
android_webview/, content/shell/ and one for layout tests.

BUG= 437770 ,  430238 

Review URL: https://codereview.chromium.org/1011953003

Cr-Commit-Position: refs/heads/master@{#322721}

[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/android_webview.gyp
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_browser_context.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_browser_context.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_content_browser_client.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_content_browser_client.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_permission_manager.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/android_webview/browser/aw_permission_manager.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/BUILD.gn
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/chrome_content_browser_client.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/chrome_content_browser_client.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/chrome_content_browser_client_unittest.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/OWNERS
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_context.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_context.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_manager.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_manager.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_manager_factory.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_manager_factory.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/permissions/permission_manager_unittest.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/profiles/profile_impl.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/profiles/profile_impl.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/ui/app_list/test/fake_profile.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/browser/ui/app_list/test/fake_profile.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/chrome_browser.gypi
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/chrome_tests_unit.gypi
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/test/base/testing_profile.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/chrome/test/base/testing_profile.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/browser/download/download_manager_impl_unittest.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/browser/frame_host/render_frame_host_impl.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/browser/media/cdm/browser_cdm_manager.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/browser/permissions/permission_service_impl.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/content_shell.gypi
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/browser/browser_context.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/browser/content_browser_client.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/browser/content_browser_client.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/browser/permission_manager.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/test/test_browser_context.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/public/test/test_browser_context.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/BUILD.gn
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_browser_context.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_browser_context.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_content_browser_client.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_permission_manager.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_browser_context.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_browser_context.h
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_content_browser_client.cc
[modify] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_content_browser_client.h
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_permission_manager.cc
[add] http://crrev.com/4e37202019e367f9c40beaa499813526941cc1f6/content/shell/browser/shell_permission_manager.h

Comment 14 Deleted

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 31 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=192876

------------------------------------------------------------------
r192876 | mlamouri@chromium.org | 2015-03-31T22:39:24.703538Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.cpp?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.cpp?r1=192876&r2=192875&pathrev=192876
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionDescriptor.idl?r1=192876&r2=192875&pathrev=192876
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PushPermissionDescriptor.idl?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-query.js?r1=192876&r2=192875&pathrev=192876
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/MidiPermissionDescriptor.idl?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.h?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionStatus.h?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.idl?r1=192876&r2=192875&pathrev=192876
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=192876&r2=192875&pathrev=192876

Implement PermissionDescriptor usage in Permissions API.

This is changing Permissions.query() to take an object instead of a
PermissionName. The name is then expected inside the object.

BUG= 437770 

Review URL: https://codereview.chromium.org/1045283002
-----------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 2 2015

Labels: M-43
Status: Fixed
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 3 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=193120

------------------------------------------------------------------
r193120 | mlamouri@chromium.org | 2015-04-03T14:25:25.980461Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/permissions/resources/test-query.js?r1=193120&r2=193119&pathrev=193120
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/Permissions.cpp?r1=193120&r2=193119&pathrev=193120
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionDescriptor.idl?r1=193120&r2=193119&pathrev=193120

Permissions: use newly supported required attribute on Dictionary properties.

This is removing the custom checks and rely on the bindings instead.
Also adding a couple of tests regarding bindings.

This CL doesn't change any behaviour.

BUG= 437770 

Review URL: https://codereview.chromium.org/1057283002
-----------------------------------------------------------------
Blocking: -chromium:432570
Components: Blink>PermissionsAPI
Labels: -M-43 m-43

Sign in to add a comment