New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.
Issue 43408
Starred by 3 users
Status: Fixed
Owner:
█ albertb@chromium.org
Email to this user bounced
Closed: May 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
 PasswordStoreDefault::OnWebDataServiceRequestDone (this=0x44ea2d0, handle=3, result=0x0) at chrome/browser/password_manager/password_store_default.cc:121
Reported by bugabu...@gmail.com, May 6 2010 Back to list 
Chrome Version       : 6.0.397.0 (46539)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
IE 8:

What steps will reproduce the problem?
1. open browser, behind an ISA proxy server
2. try to open a site

What is the expected result?
to be asked for the password

What happens instead?
segphault

Please provide any additional information below. Attach a screenshot if
possible.
Program received signal SIGSEGV, Segmentation fault.
PasswordStoreDefault::OnWebDataServiceRequestDone (this=0x39e5d80, 
handle=3, result=0x0) at 
chrome/browser/password_manager/password_store_default.cc:121
121	chrome/browser/password_manager/password_store_default.cc: No such 
file or directory.
	in chrome/browser/password_manager/password_store_default.cc
(gdb) bt full
gdb.log
22.0 KB View Download
Comment 1 by stuartmorgan@chromium.org, May 6 2010
Labels: -Area-Undefined Area-UI Feature-Passwords
Looks like we need a real NULL check on 'result'.
Comment 2 by pcgo...@gmail.com, May 6 2010 
Patch to fix this is here: http://codereview.chromium.org/2035003
Comment 3 by bugdro...@gmail.com, May 6 2010 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=46614 

------------------------------------------------------------------------
r46614 | evan@chromium.org | 2010-05-06 13:43:36 -0700 (Thu, 06 May 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_default.cc?r1=46614&r2=46613

Fix a possible crash introduced by r46412 by not accessing the result variable before the NULL check

BUG= 43408 
TEST=none

Patch by Benjamin Jemlich <pcgod99@gmail.com>.

Review URL: http://codereview.chromium.org/2035003
------------------------------------------------------------------------
Comment 4 by albertb@chromium.org, May 10 2010
Status: Fixed
Project Member Comment 5 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 6 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Area-UI -Feature-Passwords Cr-UI-Browser-Passwords Cr-UI
► Sign in to add a comment