New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 427587
issue 427583
issue 428383



Sign in to add a comment
link

Issue 427584: Switch from -std=gnu++14 to -std=c++14

Reported by thakis@chromium.org, Oct 27 2014 Project Member

Issue description

We currently build with -std=gnu++11, mostly because we use typeof in a handful of places. We can now use decltype, so we should use that and switch to -std=c++11.
 

Comment 1 by thakis@chromium.org, Oct 27 2014

Blockedon: chromium:427587

Comment 2 by thakis@chromium.org, Oct 27 2014

Summary: Switch from -std=gnu++11 to -std=c++11 (was: Swtich from -std=gnu++11 to -std=c++11)

Comment 3 by bugdroid1@chromium.org, Oct 28 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12bfc7484b420c42d7f5cd9c44b79fe0df9a784c

commit 12bfc7484b420c42d7f5cd9c44b79fe0df9a784c
Author: thakis <thakis@chromium.org>
Date: Tue Oct 28 04:37:49 2014

Update C++11 feature page.

Allow decltype.
Disallow long long, uniform initialization, raw string literals.

BUG= 427584 
NOTRY=true

Review URL: https://codereview.chromium.org/685663002

Cr-Commit-Position: refs/heads/master@{#301562}

[modify] https://chromium.googlesource.com/chromium/src.git/+/12bfc7484b420c42d7f5cd9c44b79fe0df9a784c/styleguide/c++/c++11.html

Comment 5 by thakis@chromium.org, Oct 29 2014

Blockedon: chromium:428383

Comment 7 by bugdroid1@chromium.org, Oct 29 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/584af40a101ba22ef6d67506eb7775f34a90fc52

commit 584af40a101ba22ef6d67506eb7775f34a90fc52
Author: thakis <thakis@chromium.org>
Date: Wed Oct 29 22:28:53 2014

Use decltype instead of typeof in generate_library_loader.py

No behavior change.

BUG= 427584 

Review URL: https://codereview.chromium.org/685203002

Cr-Commit-Position: refs/heads/master@{#301953}

[modify] https://chromium.googlesource.com/chromium/src.git/+/584af40a101ba22ef6d67506eb7775f34a90fc52/tools/generate_library_loader/generate_library_loader.py

Comment 8 by bugdroid1@chromium.org, Oct 31 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d982517408272862e5d2ef62f07f031df22187c

commit 7d982517408272862e5d2ef62f07f031df22187c
Author: thakis <thakis@chromium.org>
Date: Fri Oct 31 19:40:27 2014

mac: use -std=c++11 instead of -std=gnu++11.

Linux and Android need some more work before this can
happen there. No intended behavior change.

BUG= 427584 

Review URL: https://codereview.chromium.org/679143004

Cr-Commit-Position: refs/heads/master@{#302310}

[modify] https://chromium.googlesource.com/chromium/src.git/+/7d982517408272862e5d2ef62f07f031df22187c/build/common.gypi

Comment 9 by bugdroid1@chromium.org, Nov 4 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a90810d3df55fcf2d1e97d8b7946d0b1d444807f

commit a90810d3df55fcf2d1e97d8b7946d0b1d444807f
Author: thakis <thakis@chromium.org>
Date: Tue Nov 04 19:41:54 2014

ios: Switch from -std=gnu++0x to -std=c++11.

BUG= 427584 

Review URL: https://codereview.chromium.org/693893004

Cr-Commit-Position: refs/heads/master@{#302644}

[modify] https://chromium.googlesource.com/chromium/src.git/+/a90810d3df55fcf2d1e97d8b7946d0b1d444807f/build/common.gypi

Comment 10 by bugdroid1@chromium.org, Sep 24 2015

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f9152a906db2d2b2967a77cbcca5614068c1116

commit 1f9152a906db2d2b2967a77cbcca5614068c1116
Author: tfarina <tfarina@chromium.org>
Date: Thu Sep 24 15:36:02 2015

Build GN with c++11.

GN code does not need GNU extensions to be built like some other
Chromium code.

BUG= 427584 
TEST=./tools/gn/bootstrap/bootstrap.py, the manual part still works.
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1358243003

Cr-Commit-Position: refs/heads/master@{#350558}

[modify] http://crrev.com/1f9152a906db2d2b2967a77cbcca5614068c1116/tools/gn/bootstrap/bootstrap.py

Comment 11 by sheriffbot@chromium.org, Jul 11 2016

Project Member
Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by thakis@chromium.org, Jul 11 2016

Labels: -Hotlist-OpenBugWithCL

Comment 13 by premk@google.com, Jan 3 2017

Any possibility of supporting Linux builds with c++11? Our team can possibly help since it will benefit us and others significantly.

Comment 14 by thakis@chromium.org, Jan 3 2017

premk: Do you mean `-std=c++11`, or do you just mean "C++11 support" in general? If the latter, we've had that for a while. If the former (this bug), then you're welcome to try and replace -std=gnu++11 with -std=c++11 locally and see what fails. Last time I tried I think there was only one blocker (something in net/gssapi) and maybe it's not too hard.

Comment 15 by bozkurtus@google.com, Jan 9 2017

Working in conjunction with Prem on this. We would like to build for Arm64/Linux using clang/libc++. I replaced the remaining "typeof" invocation with "decltype." This allowed me to compile WebRTC successfully using the arm-linux-clang toolchain. It turns out that the resulting library used libstdc++ instead of libc++. I then tried to force libc++ by simply adding -stdlib=libc++ to the c/ld flags. The build crashed and indicated that -lc++ failed because libc++ could not be found. I then tried searching for libc++ in the repo but found nothing. This strikes me as odd considering that libc++ is part of the mac toolchain. I then tried adding a libc++.so from the target project to the link line but to no avail. Can you provide any clues on how to proceed? There's plenty more that I could try, but it seems that I'm shooting around in the dark at this point.

Comment 16 by thakis@chromium.org, Jan 9 2017

I'll add you to some thread about libc++, but that seems independent of this bug (-std has nothing to do with std lib, you can use libc++ or libstdc++ with both -std=c++11 and -std=gnu++11).

Comment 17 by thomasanderson@chromium.org, Aug 1 2017

Cc: thomasanderson@chromium.org thakis@chromium.org
do we still care about this?  what benefit does fixing this provide?

Comment 18 by thakis@chromium.org, Aug 2 2017

Yes, we still care about this. The benefit is that we'll rely on fewer gnu extensions, and have more similar compiler configs across platforms.

Comment 19 by dtapu...@chromium.org, Nov 10 2017

Components: Build

Comment 20 by timbrown@chromium.org, Jan 2 2018

Cc: timbrown@chromium.org

Comment 21 by thomasanderson@chromium.org, Feb 16 2018

Summary: Switch from -std=gnu++14 to -std=c++14 (was: Switch from -std=gnu++11 to -std=c++11)

Comment 22 by thomasanderson@chromium.org, Jul 24 2018

Cc: -timbrown@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
I'm interested in working on this

Comment 23 by thomasanderson@chromium.org, Jul 25 2018

Status: Started (was: Assigned)
Good news.  The only GNU extension we're using right now is typeof(), and there's only 2 instances of those which were easy to remove.  I was able to build all targets with -std=c11 and std=c++14.

Comment 24 by bugdroid1@chromium.org, Jul 25 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b560e27327c700683b273a8c0dbb5f71c956984c

commit b560e27327c700683b273a8c0dbb5f71c956984c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jul 25 20:45:02 2018

Prepare to stop using -std=gnu*

This CL is necessary for:
https://chromium-review.googlesource.com/c/chromium/src/+/1149337

Some third party changes are necessary, so code of the form
  #ifndef _GNU_SOURCE
  #define _GNU_SOURCE
  #endif
will be necessary in the meantime.

BUG= 427584 

Change-Id: I89b3640d35da5fd8666c69d21836212558140c00
Reviewed-on: https://chromium-review.googlesource.com/1149336
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578046}
[modify] https://crrev.com/b560e27327c700683b273a8c0dbb5f71c956984c/base/third_party/libevent/README.chromium
[modify] https://crrev.com/b560e27327c700683b273a8c0dbb5f71c956984c/base/third_party/libevent/buffer.c
[modify] https://crrev.com/b560e27327c700683b273a8c0dbb5f71c956984c/sandbox/linux/services/credentials_unittest.cc
[modify] https://crrev.com/b560e27327c700683b273a8c0dbb5f71c956984c/sandbox/linux/suid/process_util_linux.c
[modify] https://crrev.com/b560e27327c700683b273a8c0dbb5f71c956984c/sandbox/linux/suid/sandbox.c

Comment 25 by bugdroid1@chromium.org, Jul 26 2018

Project Member
The following revision refers to this bug:
  https://aomedia.googlesource.com/aom/+/4f1fd9640433a9ee83dfd48c83a3d281fbdfce3d

commit 4f1fd9640433a9ee83dfd48c83a3d281fbdfce3d
Author: Tom Anderson <thomasanderson@google.com>
Date: Thu Jul 26 22:40:57 2018

Fix build with CFLAGS="-std=c11 -D_GNU_SOURCE"

BUG= chromium:427584 

Change-Id: If134b2882c6b0cb97a2ee844748213524f778101

[modify] https://crrev.com/4f1fd9640433a9ee83dfd48c83a3d281fbdfce3d/aom/src/aom_encoder.c

Comment 27 by bugdroid1@chromium.org, Jul 27 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e336d0be148b758b490682cc352f58cdb2107f87

commit e336d0be148b758b490682cc352f58cdb2107f87
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jul 27 19:22:33 2018

Roll fontconfig to 1451f82

Changelist:
https://chromium.googlesource.com/external/fontconfig/+log/d1f48f11d5dffa1d954a1b0abe44ce9e4bfc3709..1451f829e750926cec27855eded71c24ac7ac7c6

BUG= 427584 
TBR=dnicoara

Change-Id: Ic23281b056fa08e8d4a75613fdf4a36aae5838e8
Reviewed-on: https://chromium-review.googlesource.com/1153436
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578745}
[modify] https://crrev.com/e336d0be148b758b490682cc352f58cdb2107f87/DEPS

Comment 28 by bugdroid1@chromium.org, Jul 27 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/184a37de4ca9088e2719bdb381332bf1247f094f

commit 184a37de4ca9088e2719bdb381332bf1247f094f
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jul 27 19:54:03 2018

Roll src/third_party/libaom/source/libaom/ ef95278f7..4f1fd9640 (11 commits)

https://aomedia.googlesource.com/aom.git/+log/ef95278f79fa..4f1fd9640433

$ git log ef95278f7..4f1fd9640 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 thomasanderson Fix build with CFLAGS="-std=c11 -D_GNU_SOURCE"
2018-07-26 yunqingwang Free frame header buffer
2018-07-17 sachin.kumargarg Add ARM Neon optimization of txfm 8x8
2018-07-25 ddvfinite Add compute_stats SSE4_1 and AVX2 code
2018-07-26 jonathan.matthews [normative]Reset quantization params when not set
2018-07-26 deepa.kg Enable sse2 intrinsics for highbd variance calculation
2018-07-25 binpengsmail Refine pingpong buffer in handle_inter_mode
2018-07-25 ranjit.tulabandu Fix issues in interpolation filter selection
2018-07-22 birkbeck Add ifdef in SSE2/AVX2 fft tests
2018-07-25 binpengsmail Speedup motion_mode_rd
2018-07-25 angiebird Fix bug of DO_RANGE_CHECK_CLAMP

Created with:
  roll-dep src/third_party/libaom/source/libaom

BUG= 427584 

Change-Id: I96aac1e87e921bdc4c019c97d06d1884e66b6165
Reviewed-on: https://chromium-review.googlesource.com/1152365
Reviewed-by: James Zern <jzern@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578758}
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/DEPS
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/README.chromium
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/libaom_srcs.gni
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/config/aom_version.h
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.c
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/linux/arm-neon/config/aom_config.c
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/linux/arm/config/aom_config.c
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/linux/arm64/config/aom_config.c
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/linux/ia32/config/aom_config.c
[modify] https://crrev.com/184a37de4ca9088e2719bdb381332bf1247f094f/third_party/libaom/source/config/win/ia32/config/aom_config.c

Comment 29 by bugdroid1@chromium.org, Aug 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87042be6b9b11f1fe4f18fb565cadfea71f256e7

commit 87042be6b9b11f1fe4f18fb565cadfea71f256e7
Author: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 07 01:21:00 2018

Roll src/native_client 64cb8d9d67fb..821833667ccc (1 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/64cb8d9d67fb..821833667ccc


git log 64cb8d9d67fb..821833667ccc --date=short --no-merges --format='%ad %ae %s'
2018-08-06 thomasanderson@chromium.org Fix arm build with -std=c11


Created with:
  gclient setdep -r src/native_client@821833667ccc

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:427584 
TBR=mseaborn@chromium.org

Change-Id: If0b1ba66262b33ab569850d988b0631c14c39e20
Reviewed-on: https://chromium-review.googlesource.com/1164285
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581084}
[modify] https://crrev.com/87042be6b9b11f1fe4f18fb565cadfea71f256e7/DEPS

Comment 31 by bugdroid1@chromium.org, Aug 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c401fad606e536b2b8e0218ed425c518b2b2bcaa

commit c401fad606e536b2b8e0218ed425c518b2b2bcaa
Author: Abhishek Arya <inferno@chromium.org>
Date: Wed Aug 08 05:34:17 2018

Revert "Stop using -std=gnu*"

This reverts commit c85c6c919698348c3aec13badd5f73e972040ff4.

Reason for revert: Broke AFL ASan builder
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Afl%20Upload%20Linux%20ASan

Original change's description:
> Stop using -std=gnu*
> 
> BUG= 427584 
> R=‚Äčthakis
> TBR=sbc
> 
> Change-Id: I4a6f67aa6ddaf8ab78719a3c925fcd732b8c28bf
> Reviewed-on: https://chromium-review.googlesource.com/1149337
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581478}

TBR=thakis@chromium.org,thomasanderson@chromium.org

Change-Id: Ie673c185580662fad3d641000edfc4ee203acf9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  427584 
Reviewed-on: https://chromium-review.googlesource.com/1166663
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581481}
[modify] https://crrev.com/c401fad606e536b2b8e0218ed425c518b2b2bcaa/build/config/compiler/BUILD.gn
[modify] https://crrev.com/c401fad606e536b2b8e0218ed425c518b2b2bcaa/native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc
[modify] https://crrev.com/c401fad606e536b2b8e0218ed425c518b2b2bcaa/native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc
[modify] https://crrev.com/c401fad606e536b2b8e0218ed425c518b2b2bcaa/third_party/libdrm/BUILD.gn
[modify] https://crrev.com/c401fad606e536b2b8e0218ed425c518b2b2bcaa/third_party/wayland/BUILD.gn

Comment 32 by bugdroid1@chromium.org, Aug 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b

commit 6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Aug 18 02:07:36 2018

[Reland] Stop using -std=gnu*

This reland includes a patch that fixes the AFL build with CFLAGS="-std=c11
-D_GNU_SOURCE".

BUG= 427584 
TBR=thakis,sbc

Change-Id: I9c3c52f4898a9ae1efc377802671ac44b79e9381
Reviewed-on: https://chromium-review.googlesource.com/1180170
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584284}
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/build/config/compiler/BUILD.gn
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/afl/README.chromium
[add] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/afl/patches/0001-fix-build-with-std-c11.patch
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/afl/src/afl-fuzz.c
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/afl/src/types.h
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/afl/update.py
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/libdrm/BUILD.gn
[modify] https://crrev.com/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b/third_party/wayland/BUILD.gn

Comment 33 by thomasanderson@chromium.org, Aug 18

Status: Fixed (was: Started)

Comment 34 by bugdroid1@chromium.org, Aug 20

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1c0cf3101d330efbee49afc8a6dba210af500d45

commit 1c0cf3101d330efbee49afc8a6dba210af500d45
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Aug 20 08:15:13 2018

Stop using typeof() GNU extension

https://chromium.googlesource.com/chromium/src/+/6009a54aabbe95c77b5f0ca3f8ec8489d2b7093b
switches away from -std=gnu++...

Bug:  chromium:427584 
Change-Id: Ib9cb76ce6fb901727f696ded3944af0e510c030a
Reviewed-on: https://webrtc-review.googlesource.com/94779
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24337}
[modify] https://crrev.com/1c0cf3101d330efbee49afc8a6dba210af500d45/modules/audio_device/linux/latebindingsymboltable_linux.h

Comment 35 by bugdroid1@chromium.org, Aug 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/118832bca939330f3e2377fb2d37efead3161936

commit 118832bca939330f3e2377fb2d37efead3161936
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 20 11:05:52 2018

Roll src/third_party/webrtc c7ca7b19c714..1c0cf3101d33 (2 commits)

https://webrtc.googlesource.com/src.git/+log/c7ca7b19c714..1c0cf3101d33


git log c7ca7b19c714..1c0cf3101d33 --date=short --no-merges --format='%ad %ae %s'
2018-08-20 oprypin@webrtc.org Stop using typeof() GNU extension
2018-08-20 titovartem@webrtc.org Introduce SimulatedNetworkReceiverInterface.


Created with:
  gclient setdep -r src/third_party/webrtc@1c0cf3101d33

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:427584 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9d8c9cb255a1b391cc583d15ebf7da1ad5ce37cd
Reviewed-on: https://chromium-review.googlesource.com/1180854
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584405}
[modify] https://crrev.com/118832bca939330f3e2377fb2d37efead3161936/DEPS

Sign in to add a comment