New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 420527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add support for color interpolation hints to CSS gradients.

Reported by ro...@adobe.com, Oct 6 2014

Issue description

CSS images level 4 defines support for gradient color interpolation hints (aka midpoints): http://dev.w3.org/csswg/css-images-4/#color-interpolation-hint

Webkit already got this feature: https://bugs.webkit.org/show_bug.cgi?id=137171
In Firefox it is work in progress: https://bugzilla.mozilla.org/show_bug.cgi?id=1074056

 

Comment 1 by ro...@adobe.com, Oct 6 2014

A CSS gradient generator with support for color interpolation hints, drawing the reference in a canvas:
http://codepen.io/adobe/full/fhnBJ.
Labels: -Type-Bug Type-Feature Cr-Blink-CSS
Status: Untriaged
Marking the same as Untriaged as this is a new feature request.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=183460

------------------------------------------------------------------
r183460 | rosca@adobe.com | 2014-10-09T13:08:08.760643Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGradientValue.cpp?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-color-hints-edge-cases-expected.html?r1=183460&r2=183459&pathrev=183460
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-gradient-parsing.html?r1=183460&r2=183459&pathrev=183460
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-color-hints-edge-cases.html?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.txt?r1=183460&r2=183459&pathrev=183460
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.cpp?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-linear-gradients-color-hints-expected.txt?r1=183460&r2=183459&pathrev=183460
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGradientValue.h?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-radial-gradients-color-hints-expected.txt?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-repeating-gradient-color-hint.html?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-linear-gradients-color-hints.html?r1=183460&r2=183459&pathrev=183460
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-gradient-parsing-expected.txt?r1=183460&r2=183459&pathrev=183460
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/gradients/unprefixed-radial-gradients-color-hints.html?r1=183460&r2=183459&pathrev=183460

Adding support for color interpolation hints to CSS gradients.

CSS images level 4 defines support for gradient color interpolation
hints (aka midpoints):
http://dev.w3.org/csswg/css-images-4/#color-interpolation-hint

Webkit: https://bugs.webkit.org/show_bug.cgi?id=137171
Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1074056

Manual test: http://codepen.io/adobe/full/fhnBJ

BUG= 420527 

Review URL: https://codereview.chromium.org/631753002
-----------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=183472

------------------------------------------------------------------
r183472 | sigbjornf@opera.com | 2014-10-09T15:34:41.219638Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGradientValue.cpp?r1=183472&r2=183471&pathrev=183472

Oilpan: fix build after r183460.

R=haraken
BUG= 420527 
NOTRY=true

Review URL: https://codereview.chromium.org/642843002
-----------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=183473

------------------------------------------------------------------
r183473 | wangxianzhu@chromium.org | 2014-10-09T15:35:02.608614Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-linear-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/gradients/unprefixed-linear-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-radial-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/gradients/unprefixed-linear-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/gradients/unprefixed-radial-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/fast/gradients?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/gradients/unprefixed-radial-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/gradients/unprefixed-linear-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/gradients/unprefixed-radial-gradients-color-hints-expected.png?r1=183473&r2=183472&pathrev=183473
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=183473&r2=183472&pathrev=183473
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-repeating-gradient-color-hint-expected.png?r1=183473&r2=183472&pathrev=183473

Auto-rebaseline for r183460

http://src.chromium.org/viewvc/blink?view=revision&revision=183460

BUG= 420527 
TBR=rosca@adobe.com

Review URL: https://codereview.chromium.org/646603002
-----------------------------------------------------------------
Cc: ro...@adobe.com fmalita@chromium.org
Status: Fixed
I assume we can close this - feel free to reopen if there's more to be done.

Sign in to add a comment