New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Failing SW registration/... should be advertised in the "blocked' tab of the "Show cookies and other site data..." panel

Project Member Reported by kenjibaheux@chromium.org, Oct 1 2014

Issue description

Version: 40.0.2174.0
OS: Windows 7

I'm checking how we are doing against the Chrome privacy team's guidance for SW (go/sw-privacy-review ; on going).


Test cases:
#1
1. From a blank state (e.g. no service worker registered for the origin used in this test)
2. Go to chrome://settings/content and select "Block sites from setting any data"
3. Go to http://jakearchibald.github.io/trained-to-thrill/ 
4. Notice the cookies blocked icon in the omnibox (triggered thanks to actual cookies being blocked but should triggered on blocked SW registration/... operation as well as Cache operations).
5. Click on the cookies blocked icon
6. Click on "Show cookies and other site data..." link
7. Click on "Blocked"
8. Notice that there is an entry for Indexed DB

Expected:
9. There should be an entry for SW

Actual:
9. no entry for SW.


10. Now, click again on the cookies blocked icon.
11. Click on Always allow...
12. Click reload
13. Click on the cookies set icon
14. Click on the "Show cookies and other data..." link
15. On Allowed tab, notice that there is an entry for Indexed DB

Expected:
16. There should be an entry for SW

Actual:
16. No entry for SW.


I'm not sure this is a P1 issue (ship blocker). Looping our privacy contact.
Will attach some pictures.
 
Attached 2 screenshots to illustrate the issue.
cookies allowed - sw missing.png
324 KB View Download
cookies data blocked - sw missing.png
87.5 KB View Download
Cc: markusheintz@chromium.org
Owner: ----
Status: Available
Fedback from Markus (summarizing):

This is P2 for M40.

 - nice to have:  change the title to "Cookies and site data" because it's more accurate
 - display allowed SW registrations and blocked SW registrations.
 - make sure that the "cookie blocked" Omnibox icon shows up when a SW registration is blocked
 - For allowed service worker registrations: display the same info as we have on chrome://settings/cookies.
 - For blocked SW registration: URL is enough.

Rationale: 
 - It is strange if they show up in one dialog and not in the other.
 - Also, this is the only way for users that block cookies and site data to discover why a page does not work as expected.


Note: the requirements for SW in M41 may change because of upcoming extra capability it will enable. I will work with the privacy team on defining these.

Comment 3 by falken@chromium.org, Nov 10 2014

Labels: -M-40 M-41
This won't make M40. Markus, is this still the UI we want?

Comment 4 by falken@chromium.org, Dec 11 2014

Question for Markus: Is the blocked cookie displayed somewhere on Chrome for Android? I don't see an omnibox icon there like on desktop.

Comment 5 by falken@chromium.org, Jan 13 2015

Labels: -M-41 M-42
Labels: -M-42 M-43 MovedFrom-42
Status: Untriaged
[AUTO] Moving all non essential bugs to the next Milestone.  (This decision is based on the labels attached to your ticket.)


Ref: https://sites.google.com/a/chromium.org/dev/developers/ticket-milestone-punting-1

Comment 7 by pennymac@google.com, Apr 14 2015

Labels: -M-43 MovedFrom-43
[AUTO] This issue has already been moved once and is lower than Priority 1,therefore removing mstone.

Comment 8 by battre@chromium.org, Apr 15 2015

Re #3: I think that we still want to get this UI eventually.

Comment 9 by falken@chromium.org, Apr 15 2015

Labels: m-44
Owner: falken@chromium.org
Status: Assigned
Labels: -Restrict-View-Google
This doesn't need to be restricted.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a22dcef5fca50876226b2128cb4ecf24a0bf12c

commit 4a22dcef5fca50876226b2128cb4ecf24a0bf12c
Author: falken <falken@chromium.org>
Date: Thu Apr 30 08:25:20 2015

Expose Service Worker accesses in "Cookies set by this page" UI

Now users can see when SWs are accepted or blocked by
the content settings policy.

BUG= 419284 

Review URL: https://codereview.chromium.org/1110323005

Cr-Commit-Position: refs/heads/master@{#327684}

[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/chrome/browser/chrome_content_browser_client.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/chrome/browser/chrome_content_browser_client.h
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/chrome/browser/content_settings/tab_specific_content_settings.h
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/public/browser/content_browser_client.cc
[modify] http://crrev.com/4a22dcef5fca50876226b2128cb4ecf24a0bf12c/content/public/browser/content_browser_client.h

Status: Fixed

Sign in to add a comment