New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 418848 link

Starred by 19 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 425979
issue 448077

Blocking:
issue 419870



Sign in to add a comment

Tracking bug for removing SSLv3 fallback.

Project Member Reported by agl@chromium.org, Sep 30 2014

Issue description

This is a tracking bug for the removal of SSLv3 fallback. Additionally, error pages contain a link to this bug for people to star if they are still needing to access buggy servers that need SSLv3 fallback.

"An SSLv3 fallback was able to handshake with the server but we no longer accept SSLv3 fallbacks due to new attacks against the protocol. The server needs to be updated to support a minimum of TLS 1.0 and preferably TLS 1.2."
 

Comment 1 by agl@chromium.org, Oct 2 2014

Blocking: chromium:419870

Comment 2 by f...@chromium.org, Oct 14 2014

Cc: egm@chromium.org
Do we need a help center update for this?
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3

commit 32352ad08ee673a4d43e8593ce988b224f6482d3
Author: Adam Langley <agl@google.com>
Date: Tue Oct 14 22:31:00 2014

net: disable SSLv3 fallback.

This change adds a "minimum fallback version" (TLS 1.0). When doing fallback, versions below this minimum will still be tried but the resulting connection, if successful won't actually be used. Rather Chrome will show a different error message if SSLv3 would have worked.

SSLv3 fallback can still be enabled via a new command line flag for those who need it but it'll be interesting to see how this does on dev and beta.

BUG= 419870 , 418848 
R=davidben@chromium.org, felt@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/619463002

Cr-Commit-Position: refs/heads/master@{#299567}

[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/browser/net/ssl_config_service_manager_pref.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/browser/prefs/command_line_pref_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/common/chrome_switches.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/common/chrome_switches.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/common/pref_names.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/chrome/common/pref_names.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/base/net_error_list.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/socket/ssl_client_socket_nss.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/socket/ssl_client_socket_openssl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/ssl/ssl_config.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/ssl/ssl_config.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/net/url_request/url_request_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/32352ad08ee673a4d43e8593ce988b224f6482d3/tools/metrics/histograms/histograms.xml

Comment 4 by agl@chromium.org, Oct 14 2014

Labels: -Pri-2 -Restrict-View-Google Pri-1
Removing restrictions -- this is now public.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/701bb044ac5ad4f1572e86b83a673cc49383efb4

commit 701bb044ac5ad4f1572e86b83a673cc49383efb4
Author: Adam Langley <agl@google.com>
Date: Wed Oct 15 00:14:08 2014

net: add specific error message for disabled SSLv3 fallback.

This change adds a specific error message for the error added in r299567. This
is because adding strings makes a change harder to merge to branches thus these
parts were split into this CL.

(Was reviewed as part of r299567 -- just split for landing.)

BUG= 418848 , 419870 

Review URL: https://codereview.chromium.org/659633002

Cr-Commit-Position: refs/heads/master@{#299593}

[modify] https://chromium.googlesource.com/chromium/src.git/+/701bb044ac5ad4f1572e86b83a673cc49383efb4/chrome/app/generated_resources.grd
[modify] https://chromium.googlesource.com/chromium/src.git/+/701bb044ac5ad4f1572e86b83a673cc49383efb4/chrome/common/localized_error.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb

commit 33369a4034528613b79464015cf8a000e3f27abb
Author: agl <agl@chromium.org>
Date: Fri Oct 17 22:28:10 2014

Add Enterprise policy option to control minimum SSL fallback level.

r299567 disabled SSLv3 fallback. This change adds an enterprise policy option
to control this value so that enterprises can reenable the fallback if they
need it.

This option is in contrast to the one added in r299755. That one allows
enterprises to be more aggressive in disabling SSLv3, while this one is
intended for those who need to more slower that Chrome's default.

BUG= 418848 , 419870 

Review URL: https://codereview.chromium.org/644913008

Cr-Commit-Position: refs/heads/master@{#300178}

[modify] https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb/chrome/browser/policy/policy_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb/chrome/test/data/policy/policy_test_cases.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb/components/policy/resources/policy_templates.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/33369a4034528613b79464015cf8a000e3f27abb/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 21 2014

Labels: merge-merged-2171
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d

commit 7d993fb9f3d71e5df03d90e205d22ee80dba8e8d
Author: Adam Langley <agl@google.com>
Date: Tue Oct 21 22:09:56 2014

net: disable SSLv3 fallback.

This change adds a "minimum fallback version" (TLS 1.0). When doing fallback, versions below this minimum will still be tried but the resulting connection, if successful won't actually be used. Rather Chrome will show a different error message if SSLv3 would have worked.

SSLv3 fallback can still be enabled via a new command line flag for those who need it but it'll be interesting to see how this does on dev and beta.

BUG= 419870 , 418848 
R=davidben@chromium.org, felt@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/619463002

(cherry picked from commit 32352ad08ee673a4d43e8593ce988b224f6482d3)

Conflicts:
	net/url_request/url_request_unittest.cc

Cr-Commit-Position: refs/branch-heads/2171@{#218}
Cr-Branched-From: 267aeeb8d85c8503a7fd12bd14654b8ea78d3974-refs/heads/master@{#297060}

[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/browser/net/ssl_config_service_manager_pref.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/browser/prefs/command_line_pref_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/common/chrome_switches.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/common/chrome_switches.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/common/pref_names.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/chrome/common/pref_names.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/base/net_error_list.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/socket/ssl_client_socket_nss.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/socket/ssl_client_socket_openssl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/ssl/ssl_config.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/ssl/ssl_config.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/net/url_request/url_request_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/7d993fb9f3d71e5df03d90e205d22ee80dba8e8d/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816

commit d78e6694cfce3f406a21da9017b3e6ddc9a01816
Author: Adam Langley <agl@google.com>
Date: Tue Oct 21 22:30:17 2014

Add Enterprise policy option to control minimum SSL fallback level.

r299567 disabled SSLv3 fallback. This change adds an enterprise policy option
to control this value so that enterprises can reenable the fallback if they
need it.

This option is in contrast to the one added in r299755. That one allows
enterprises to be more aggressive in disabling SSLv3, while this one is
intended for those who need to more slower that Chrome's default.

BUG= 418848 , 419870 

Review URL: https://codereview.chromium.org/644913008

(cherry picked from commit 33369a4034528613b79464015cf8a000e3f27abb)

Conflicts:
	components/policy/resources/policy_templates.json

Cr-Commit-Position: refs/branch-heads/2171@{#222}
Cr-Branched-From: 267aeeb8d85c8503a7fd12bd14654b8ea78d3974-refs/heads/master@{#297060}

[modify] https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816/chrome/browser/policy/policy_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816/chrome/test/data/policy/policy_test_cases.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816/components/policy/resources/policy_templates.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/d78e6694cfce3f406a21da9017b3e6ddc9a01816/tools/metrics/histograms/histograms.xml

Comment 9 by Deleted ...@, Oct 22 2014

Dear all,

My Not Working Empower software solve the problem in emPower.

 
Blockedon: chromium:425979

Comment 11 by Deleted ...@, Oct 27 2014

PUTOS

Comment 12 by jossi...@gmail.com, Oct 27 2014

i don't know what i did in my settings or in my mac system preferences? but now is not letting me get in to my college web and this is the answer i got.

Comment 13 by sidv@chromium.org, Oct 27 2014

Labels: -M-40 M-39

Comment 14 by agl@chromium.org, Oct 27 2014

Dear all who are hitting this error message:

This change is the result of a security issue with SSLv3 (https://www.imperialviolet.org/2014/10/14/poodle.html) which is motivating the removal of SSLv3 support.

Chrome 39 will be removing SSLv3-fallback support and Chrome 40 should be removing SSLv3 support entirely. Firefox will be removing SSLv3 completely in version 34 at the end of Nov: https://blog.mozilla.org/security/2014/10/14/the-poodle-attack-and-the-end-of-ssl-3-0/

If you are hitting issues with Chrome 39/40 then the server in question needs to be fixed. The changes in Chrome 39 only affect buggy servers and it's hopefully easy for administrators to update. If you know the vendor then, in some cases, I can chase them up but the best course is to point the administrators to this issue so that they know that need to update their servers.

(I'll see about chasing up Empower.)

Enterprises that control Chrome via group policy have controls in Chrome 39 to tune this change. See the updated documentation for policies SSLVersionMin and SSLVersionFallbackMin.

Comment 15 by jossi...@gmail.com, Oct 28 2014

thx for the updates # 14 but how come i tried to do it from other computers, using chrome with no issues?? it let's me log in to my college without any problems
 
Screenshot 2014-10-27 01.23.21.png
106 KB View Download

Comment 16 by agl@chromium.org, Oct 28 2014

jossief3: this change is only in Chrome 39 or 40. But the current version is Chrome 38. I would guess that the affected Chrome installation is on the dev or beta channels and so is getting this change early.

(You can check which version any particular Chrome install is by going to "about:version". The first line will say something like "Google Chrome: 39.0.2171.36" -- the first number is the important one here.

Comment 17 by jossi...@gmail.com, Oct 28 2014

but is my college website look i tried to go to epcc.edu but when i go to
current student and hit the banner which is to log in for my info. it won't
let me but if i try to go to my college email it takes me right away i
don't know what to do i love chrome and wouldn't like to go to safari or
firefox.
It does appear that https://ssb.epcc.edu/ is buggy and relied on the SSLv3 fallback to work. Unfortunately Chrome (and likely other browsers too: see Mozilla's blog linked in comment #14) won't be supporting that in the future because of a security issue. Would you mind sending your college's IT department an email and pointing them at this bug? They'll probably want to update the software running on that website. Thanks!
According to https://www.ssllabs.com/ssltest/analyze.html?d=ssb.epcc.edu this server has both TLS version and extensions intolerance.

Comment 20 by f...@fj.je, Dec 11 2014

I hesitate to report this as a bug because I have a limited number of machines and configurations to test with, but I have bumped into cases where the SSLVersionMin is properly set in Chrome 39 through the Apps Admin Console, and yet SSL v. 3 continues to be available to the end-user.

In 39.0.2171.95 (64-bit), I can use the chrome://policy page to check that "SSLVersionMin" is set to tls1.1 with a status of "OK" and yet Qualys and others still report these Chrome installs as being SSL3-enabled.

Comment 21 by agl@chromium.org, Dec 12 2014

fj@fj.je: are you sure that Chrome has restarted in those cases? Are you testing with https://www.ssllabs.com/ssltest/viewMyClient.html? On the Chrome installs, does that setting appear in chrome://policy/?

Comment 22 by f...@fj.je, Dec 22 2014

#21 - Yes, I am sure that Chrome has been restarted. In fact, the whole computer has been restarted many times since applying the policy, and Chrome has even gone through updates, now.

On these Chrome install, the chrome://policy page shows "Current user, Mandatory, SSLVersionMin, tls1.1, OK" and the Qualys Client test reports that the browser is vulnerable to POODLE. 

I just tested again, but this is the exact chain of checks and tests that led me to post here in the first place.

Comment 23 by agl@chromium.org, Jan 6 2015

(Picking this up after the holiday.)

On Linux, I can set this policy to "tls1.1", "tls1.2" etc and see the effect immediately upon loading https://www.ssllabs.com/ssltest/viewMyClient.html. It works even without restarting if the Reload button on chrome://policy is used.

I can do this when building with both NSS and OpenSSL.

fj: what OS is this?

Comment 24 by f...@fj.je, Jan 6 2015

#23 — OS X v. 10.10.2 (14C81f). Still no luck making it work despite repeated attempts, I am afraid…
I seem to be having a hard time figuring out how to fiddle with policy on my Mac... possibly I'm doing it wrong, or perhaps I can't tweak policy on my work machine? I'll test again when I get home. --ssl-version-min=tls1.1 works fine though.

If you launch Chrome with --ssl-version-min=tls1.1, does it pick up?  (Quit Chrome and run /path/to/chrome.app/Contents/MacOS/Google\ Chrome --ssl-version-min=tls1.1.) Those should end up going through the same codepath, so that would distinguish between something being off with the version_min logic or somehow the policy setting not making its way there.

Comment 26 by f...@fj.je, Jan 7 2015

I can confirm that launching Chrome with the command-line flag does work: Qualys is quite satisfied when queried in this fashion. However, the Apps-applied policy seems to have no effect. Strangely enough, chrome://policy shows the exact same thing in both cases, whether Qualys reports Chrome as "fixed" or not. It seems therefore that the Policy page does not accurately reflect the state of things.

I should add that I have moved to OS X v. 10.10.2 (14C94b)
Cc: atwilson@chromium.org
Sorry, that was unclear. --ssl-version-min and policy both end up in the same place as far as the net stack is concerned, but I wouldn't expect --ssl-version-min to affect chrome://policy.

My home machine seems also unhappy. It seems the Workgroup Manager download is only for 10.9 and not 10.10? +atwilson (picked a components/policy OWNERS at random) who is probably way more qualified to debug this.

Comment 28 by f...@fj.je, Jan 9 2015

#27 — Nothing to be sorry about, I understood what you meant. All I meant is that the chrome://policy page seems sometimes not to reflect the true state of the browser's configuration: the Apps-enforced policy appears to be "loaded" and is reflected in the UI, but without being actually enforced in the net stack. (I am speaking schematically, of course.)
Blockedon: chromium:448077
I can confirm fj's problem which I've filed as the separate  bug 448077  to reduce the noise on the tracking bug.
Cc: tnagel@chromium.org
Labels: Hotlist-Recharge
This issue likely requires triage.  The current issue owner may be inactive (i.e. hasn't fixed an issue in the last 30 days or commented in this particular issue in the last 90 days).  Thanks for helping out!

-Anthony
Status: Verified

Sign in to add a comment