New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 417463 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 426330



Sign in to add a comment

Replace OVERRIDE and FINAL with their C++11 counterparts

Project Member Reported by dcheng@chromium.org, Sep 24 2014

Issue description

This bug covers several things:
1) A giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions.
2) Fixing virtual method annotations to conform to the C++ style guide, which states that 

I'm only working on part 2, if someone wants to volunteer for part 1...
 
Showing comments 404 - 503 of 503 Older
Project Member

Comment 404 by bugdroid1@chromium.org, Jan 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4220eea6d0c7ffa94d59a996819af4b3f244829a

commit 4220eea6d0c7ffa94d59a996819af4b3f244829a
Author: dcheng <dcheng@chromium.org>
Date: Wed Jan 21 00:20:30 2015

Update {virtual,override,final} to follow C++11 style chrome/browser/ui/webui/chromeos.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/854063002

Cr-Commit-Position: refs/heads/master@{#312302}

[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/cryptohome_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/network_config_message_handler.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/network_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/nfc_debug_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/power_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/provided_file_systems_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/proxy_settings_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/salsa_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/set_time_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/slow_trace_ui.h
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/slow_ui.cc
[modify] http://crrev.com/4220eea6d0c7ffa94d59a996819af4b3f244829a/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.h

Project Member

Comment 405 by bugdroid1@chromium.org, Jan 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465662ed7e306369e589acf088ff311522a79385

commit 465662ed7e306369e589acf088ff311522a79385
Author: dcheng <dcheng@chromium.org>
Date: Wed Jan 21 14:19:21 2015

Update {virtual,override,final} to follow C++11 style chrome/browser/ui.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=msw@chromium.org

Review URL: https://codereview.chromium.org/857433003

Cr-Commit-Position: refs/heads/master@{#312354}

[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/app_list/test/fake_profile.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/ime_controller_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/ime_controller_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/media_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/session_state_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/user_accounts_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/volume_controller_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_factory.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Project Member

Comment 406 by bugdroid1@chromium.org, Jan 21 2015

Labels: merge-merged-2283
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465662ed7e306369e589acf088ff311522a79385

commit 465662ed7e306369e589acf088ff311522a79385
Author: dcheng <dcheng@chromium.org>
Date: Wed Jan 21 14:19:21 2015

Update {virtual,override,final} to follow C++11 style chrome/browser/ui.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=msw@chromium.org

Review URL: https://codereview.chromium.org/857433003

Cr-Commit-Position: refs/heads/master@{#312354}

[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/app_list/test/fake_profile.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/ime_controller_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/ime_controller_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/media_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/session_state_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/user_accounts_delegate_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/ash/volume_controller_chromeos.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_factory.h
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc
[modify] http://crrev.com/465662ed7e306369e589acf088ff311522a79385/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Project Member

Comment 407 by bugdroid1@chromium.org, Jan 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae98daac90e8a97f807911858856fcb402c36860

commit ae98daac90e8a97f807911858856fcb402c36860
Author: dcheng <dcheng@chromium.org>
Date: Wed Jan 21 20:30:49 2015

Update {virtual,override,final} to follow C++11 style in chromeos.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/856563004

Cr-Commit-Position: refs/heads/master@{#312426}

[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/attestation/mock_attestation_flow.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/audio/audio_devices_pref_handler_impl.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/audio/cras_audio_handler.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/audio/cras_audio_handler_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/cert_loader.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/cryptohome/async_method_caller.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/cryptohome/homedir_methods.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/cryptohome/homedir_methods_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/cryptohome/system_salt_getter_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/disks/disk_mount_manager.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/disks/disk_mount_manager_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/geolocation/simple_geolocation_request.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/cryptohome_authenticator.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/extended_authenticator_impl.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/fake_extended_authenticator.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/login_performer.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/mock_authenticator.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/mock_url_fetchers.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/online_attempt.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/online_attempt_host.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/auth/test_attempt_state.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/login/login_state_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/process_proxy/process_output_watcher_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/process_proxy/process_proxy_unittest.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/settings/timezone_settings.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/system/fake_statistics_provider.h
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/system/statistics_provider.cc
[modify] http://crrev.com/ae98daac90e8a97f807911858856fcb402c36860/chromeos/timezone/timezone_request.h

Project Member

Comment 408 by bugdroid1@chromium.org, Jan 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7733035fb94012163f74864416d321382c0e28

commit fe7733035fb94012163f74864416d321382c0e28
Author: dcheng <dcheng@chromium.org>
Date: Thu Jan 22 19:45:52 2015

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/817063006

Cr-Commit-Position: refs/heads/master@{#312655}

[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/change_list_loader.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/change_list_processor_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/directory_loader_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/download_handler.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/download_handler.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/download_handler_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/drive_file_stream_reader.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/drive_integration_service.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/drive_notification_manager_factory_browsertest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fake_file_system.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fake_file_system_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fake_free_disk_space_getter.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_cache_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/operation_test_base.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system/truncate_operation_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_system_util_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_task_executor.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_task_executor_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/file_write_watcher_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/async_file_util.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/job_scheduler.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/job_scheduler_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/local_file_reader_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/search_metadata_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/sync/entry_revert_performer_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/sync_client_unittest.cc
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/test_util.h
[modify] http://crrev.com/fe7733035fb94012163f74864416d321382c0e28/chrome/browser/chromeos/drive/write_on_cache_file_unittest.cc

Project Member

Comment 409 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/374e914e95164d69df77dc6006a08dcd8734eed6

commit 374e914e95164d69df77dc6006a08dcd8734eed6
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 01:17:09 2015

Update {virtual,override,final} to follow C++11 style in printing, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/868883003

Cr-Commit-Position: refs/heads/master@{#312724}

[modify] http://crrev.com/374e914e95164d69df77dc6006a08dcd8734eed6/printing/backend/print_backend_chromeos.cc
[modify] http://crrev.com/374e914e95164d69df77dc6006a08dcd8734eed6/printing/printing_context_no_system_dialog.h

Project Member

Comment 410 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba5f1344c894a0a70988ddd36b26027153a6eecd

commit ba5f1344c894a0a70988ddd36b26027153a6eecd
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 01:23:40 2015

Update {virtual,override,final} to follow C++11 style in remoting, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/866153003

Cr-Commit-Position: refs/heads/master@{#312730}

[modify] http://crrev.com/ba5f1344c894a0a70988ddd36b26027153a6eecd/remoting/host/chromeos/aura_desktop_capturer.h
[modify] http://crrev.com/ba5f1344c894a0a70988ddd36b26027153a6eecd/remoting/host/chromeos/skia_bitmap_desktop_frame.h
[modify] http://crrev.com/ba5f1344c894a0a70988ddd36b26027153a6eecd/remoting/host/local_input_monitor_chromeos.cc

Project Member

Comment 411 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61

commit 6c4f4ee156220fa7b058456d536d4e6e7f9b5d61
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 01:43:37 2015

Update {virtual,override,final} to follow C++11 style in extensions, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/873473003

Cr-Commit-Position: refs/heads/master@{#312737}

[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/browser/api/audio/audio_service_chromeos.cc
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/browser/api/vpn_provider/vpn_provider_api.h
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/browser/api/vpn_provider/vpn_service.cc
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/browser/api/webcam_private/webcam_private_api.h
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/shell/browser/shell_audio_controller_chromeos.h
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc
[modify] http://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61/extensions/shell/browser/shell_network_controller_chromeos.h

Project Member

Comment 412 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3

commit 8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 01:47:56 2015

Update {virtual,override,final} to follow C++11 style in net, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/867793002

Cr-Commit-Position: refs/heads/master@{#312739}

[modify] http://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3/net/cert/nss_cert_database_chromeos.h
[modify] http://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3/net/cert/nss_cert_database_chromeos_unittest.cc
[modify] http://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3/net/cert/nss_profile_filter_chromeos_unittest.cc
[modify] http://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3/net/proxy/proxy_service.cc
[modify] http://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3/net/ssl/client_cert_store_chromeos.h

Project Member

Comment 413 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dafeb843c148804b63d5728fe3153d7b1b53a12

commit 8dafeb843c148804b63d5728fe3153d7b1b53a12
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 01:50:56 2015

Update {virtual,override,final} to follow C++11 style in chrome, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/869753002

Cr-Commit-Position: refs/heads/master@{#312740}

[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h
[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/browser/notifications/message_center_settings_controller_unittest.cc
[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/test/base/testing_browser_process_platform_part.h
[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/test/base/testing_profile.h
[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/test/base/view_event_test_platform_part_chromeos.cc
[modify] http://crrev.com/8dafeb843c148804b63d5728fe3153d7b1b53a12/chrome/test/data/webui/certificate_viewer_ui_test-inl.h

Project Member

Comment 414 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee9fd750d987501be2d167ebe602333dfa19458c

commit ee9fd750d987501be2d167ebe602333dfa19458c
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 03:09:15 2015

Update {virtual,override,final} to follow C++11 style in sandbox, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/873463004

Cr-Commit-Position: refs/heads/master@{#312745}

[modify] http://crrev.com/ee9fd750d987501be2d167ebe602333dfa19458c/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc

Project Member

Comment 415 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3e12faa0908b087303764d76bc99baa8e40183

commit 3c3e12faa0908b087303764d76bc99baa8e40183
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 08:41:50 2015

Update {virtual,override,final} to follow C++11 style in media, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/870743003

Cr-Commit-Position: refs/heads/master@{#312798}

[modify] http://crrev.com/3c3e12faa0908b087303764d76bc99baa8e40183/media/video/capture/linux/video_capture_device_chromeos.cc
[modify] http://crrev.com/3c3e12faa0908b087303764d76bc99baa8e40183/media/video/capture/linux/video_capture_device_chromeos.h

Project Member

Comment 416 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd

commit bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 16:01:38 2015

Update {virtual,override,final} to follow C++11 style in components, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/865973003

Cr-Commit-Position: refs/heads/master@{#312855}

[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/crash/app/breakpad_linux.cc
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/metrics/net/wifi_access_point_info_provider_chromeos.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/pairing/bluetooth_controller_pairing_controller.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/pairing/bluetooth_host_pairing_controller.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/pairing/fake_controller_pairing_controller.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/pairing/fake_host_pairing_controller.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/pairing/shark_connection_listener.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/policy/core/common/proxy_policy_provider.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/policy/core/common/proxy_policy_provider_unittest.cc
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/storage_monitor/storage_monitor_chromeos.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/storage_monitor/storage_monitor_chromeos_unittest.cc
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/timers/rtc_alarm.h
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/user_manager/user.cc
[modify] http://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd/components/user_manager/user_manager_base.h

Project Member

Comment 417 by bugdroid1@chromium.org, Jan 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341874814d31faf091af39f4c20c98148d79d5a7

commit 341874814d31faf091af39f4c20c98148d79d5a7
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 23 23:56:59 2015

Update {virtual,override,final} to follow C++11 style in content, round 2.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/865123003

Cr-Commit-Position: refs/heads/master@{#312970}

[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/geolocation/wifi_data_provider_chromeos.h
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/media/capture/desktop_capture_device_aura_unittest.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/net_info_browsertest.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/time_zone_monitor_chromeos.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/common/gpu/media/video_decode_accelerator_unittest.cc
[modify] http://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7/content/common/gpu/media/video_encode_accelerator_unittest.cc

Project Member

Comment 418 by bugdroid1@chromium.org, Jan 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee9dbf09814cb64c3cb3bea738bec8030dd521f

commit fee9dbf09814cb64c3cb3bea738bec8030dd521f
Author: dcheng <dcheng@chromium.org>
Date: Sat Jan 24 02:11:04 2015

Enable strict checks for {virtual,override,final} on CrOS.

BUG=417463

Review URL: https://codereview.chromium.org/873883003

Cr-Commit-Position: refs/heads/master@{#312996}

[modify] http://crrev.com/fee9dbf09814cb64c3cb3bea738bec8030dd521f/build/common.gypi

Project Member

Comment 419 by bugdroid1@chromium.org, Jan 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b56b0269b2c28613d171c1bf5007e08c217fe78

commit 1b56b0269b2c28613d171c1bf5007e08c217fe78
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jan 24 03:14:30 2015

Fix {virtual,override,final} build failures on official CrOS build.

BUG=417463
TBR=gwilson@chromium.org

Review URL: https://codereview.chromium.org/871123002

Cr-Commit-Position: refs/heads/master@{#313000}

[modify] http://crrev.com/1b56b0269b2c28613d171c1bf5007e08c217fe78/rlz/chromeos/lib/rlz_value_store_chromeos.h

Project Member

Comment 420 by bugdroid1@chromium.org, Jan 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/461c8c81f644038cffe89a801b62f4d36fcf9f1e

commit 461c8c81f644038cffe89a801b62f4d36fcf9f1e
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jan 24 03:38:08 2015

Fix more {virtual,override,final} build failures for CrOS build.

BUG=417463
TBR=yukawa@chromium.org

Review URL: https://codereview.chromium.org/872713006

Cr-Commit-Position: refs/heads/master@{#313001}

[modify] http://crrev.com/461c8c81f644038cffe89a801b62f4d36fcf9f1e/ui/base/ime/chromeos/ime_keyboard_ozone.h

Project Member

Comment 421 by bugdroid1@chromium.org, Jan 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c

commit ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jan 24 03:49:30 2015

Disable {virtual,override,final} checks for Ozone CrOS builds.

BUG=417463
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/873943002

Cr-Commit-Position: refs/heads/master@{#313006}

[modify] http://crrev.com/ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c/build/common.gypi

Project Member

Comment 422 by bugdroid1@chromium.org, Jan 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/457bc8a2cdd6cfcdb7a3ef379f72be8231ff3ee6

commit 457bc8a2cdd6cfcdb7a3ef379f72be8231ff3ee6
Author: tbarzic <tbarzic@chromium.org>
Date: Mon Jan 26 19:19:27 2015

Fix {virtual,override,final} build failure on official CrOS build

BUG=417463
TBR=gwilson@chromium.org

Review URL: https://codereview.chromium.org/878573005

Cr-Commit-Position: refs/heads/master@{#313097}

[modify] http://crrev.com/457bc8a2cdd6cfcdb7a3ef379f72be8231ff3ee6/chrome/browser/rlz/rlz_unittest.cc

Project Member

Comment 424 by bugdroid1@chromium.org, Jan 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e344b9ff33d6291a61ec00ae8f77f71ee72a1f9

commit 9e344b9ff33d6291a61ec00ae8f77f71ee72a1f9
Author: spang <spang@chromium.org>
Date: Wed Jan 28 23:27:35 2015

ozone: Turn on chromium-style warnings for ChromeOS ozone

BUG=417463
TEST=build with chromeos=1 use_ozone=1

Review URL: https://codereview.chromium.org/884233002

Cr-Commit-Position: refs/heads/master@{#313613}

[modify] http://crrev.com/9e344b9ff33d6291a61ec00ae8f77f71ee72a1f9/build/common.gypi

Project Member

Comment 425 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9f934ab10ff8bf1922ccc23e449167237d98b9

commit 9f9f934ab10ff8bf1922ccc23e449167237d98b9
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 01:50:17 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=sgurun@chromium.org

Review URL: https://codereview.chromium.org/893273003

Cr-Commit-Position: refs/heads/master@{#314467}

[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/common/aw_content_client.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/lib/aw_browser_dependency_factory_impl.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/lib/main/aw_main_delegate.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_content_renderer_client.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_message_port_client.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_permission_client.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_render_frame_ext.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_render_process_observer.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/aw_render_view_ext.h
[modify] http://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9/android_webview/renderer/print_render_frame_observer.h

Project Member

Comment 426 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6a0230ed3693f0719938113a32a7f848112a9f

commit 7f6a0230ed3693f0719938113a32a7f848112a9f
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 01:54:34 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/885283009

Cr-Commit-Position: refs/heads/master@{#314468}

[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/browser_process_platform_part_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/chrome_browser_main_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/download/download_ui_controller.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/google/google_search_counter_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/google/google_search_counter_android_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/android_cache_database_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/android_history_provider_service_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/android_urls_database_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/bookmark_model_sql_handler.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/sqlite_cursor_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/urls_sql_handler_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/history/android/visit_sql_handler_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/metrics/android_metrics_provider.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/printing/print_view_manager_basic.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/profiles/profile_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/search/contextual_search_promo_source_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/search/search_android_unittest.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/search_engines/template_url_service_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/sessions/in_memory_tab_restore_service.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/signin/android_profile_oauth2_token_service.cc
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/signin/android_profile_oauth2_token_service.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/speech/tts_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/sync/glue/synced_tab_delegate_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/sync/glue/synced_window_delegate_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/sync/profile_sync_service_android.h
[modify] http://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f/chrome/browser/sync/profile_sync_service_android_unittest.cc

Project Member

Comment 427 by bugdroid1@chromium.org, Feb 4 2015

Project Member

Comment 428 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996c125c4031bd0b2c2ebfe181c5e5b4705930d0

commit 996c125c4031bd0b2c2ebfe181c5e5b4705930d0
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 02:25:49 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=benm@chromium.org

Review URL: https://codereview.chromium.org/867763003

Cr-Commit-Position: refs/heads/master@{#314476}

[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_browser_context.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_browser_main_parts.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_content_browser_client.cc
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_content_browser_client.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_dev_tools_manager_delegate.cc
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_dev_tools_manager_delegate.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_download_manager_delegate.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_form_database_service.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_form_database_service_unittest.cc
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_gl_surface.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_javascript_dialog_manager.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_login_delegate.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_pref_store.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_quota_permission_context.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_request_interceptor.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_resource_context.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_ssl_host_state_delegate.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/aw_web_resource_response.cc
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/browser_view_renderer.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/deferred_gpu_command_service.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/find_helper.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/hardware_renderer.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/icon_helper.h
[modify] http://crrev.com/996c125c4031bd0b2c2ebfe181c5e5b4705930d0/android_webview/browser/parent_output_surface.h

Project Member

Comment 429 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c09395ec838d73d66ff900bb4d471ce931b192bd

commit c09395ec838d73d66ff900bb4d471ce931b192bd
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 02:26:27 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=aelias@chromium.org

Review URL: https://codereview.chromium.org/897783002

Cr-Commit-Position: refs/heads/master@{#314477}

[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/compositor_impl_android.cc
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/compositor_impl_android.h
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/input/motion_event_android.h
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/input/synthetic_gesture_target_android.h
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/render_view_host_impl.h
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/render_widget_host_impl.h
[modify] http://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd/content/browser/renderer_host/render_widget_host_view_android.h

Project Member

Comment 430 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/361fdb39bdfcf68edd7df903103a399ea7a4f204

commit 361fdb39bdfcf68edd7df903103a399ea7a4f204
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 02:56:07 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/900733003

Cr-Commit-Position: refs/heads/master@{#314486}

[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/autofill/password_generation_popup_view_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/context_menu_helper.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/confirm_infobar.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/generated_password_saved_infobar.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/infobar_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/infobar_container_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/infobars/translate_infobar.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/javascript_app_modal_dialog_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/login_prompt_android.cc
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/tab_model/tab_model_list_unittest.cc
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/toolbar/toolbar_model_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/website_settings_popup_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/website_settings_popup_legacy_android.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/android/window_android_helper.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/auto_login_infobar_delegate.cc
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/auto_login_infobar_delegate.h
[modify] http://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204/chrome/browser/ui/screen_capture_notification_ui_stub.cc

Project Member

Comment 431 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0

commit 9b4dd1aa9e96c92ec4503eefea2c9770001f95f0
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 02:56:54 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=michaelbai@chromium.org

Review URL: https://codereview.chromium.org/893343002

Cr-Commit-Position: refs/heads/master@{#314487}

[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/android_protocol_handler.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_autofill_client.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_contents.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_contents_client_bridge.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_contents_client_bridge_unittest.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_contents_io_thread_client_impl.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_contents_io_thread_client_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_dev_tools_server.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_http_auth_handler.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_media_url_interceptor.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_message_port_service_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_pdf_exporter.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_quota_manager_bridge_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_settings.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_web_contents_delegate.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_web_contents_view_delegate.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_web_preferences_populater_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/aw_web_resource_response_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/external_video_surface_container_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/input_stream_impl.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/input_stream_unittest.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/permission/media_access_permission_request.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/permission/media_access_permission_request_unittest.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/permission/permission_request_handler.h
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/permission/permission_request_handler_unittest.cc
[modify] http://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0/android_webview/native/permission/simple_permission_request.h

Project Member

Comment 432 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/991d6faaf0dd6d37105f621783e0bc3d08be39e6

commit 991d6faaf0dd6d37105f621783e0bc3d08be39e6
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 19:18:38 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=torne@chromium.org

Review URL: https://codereview.chromium.org/882883007

Cr-Commit-Position: refs/heads/master@{#314606}

[modify] http://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6/android_webview/browser/renderer_host/aw_render_view_host_ext.h
[modify] http://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] http://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] http://crrev.com/991d6faaf0dd6d37105f621783e0bc3d08be39e6/android_webview/browser/renderer_host/print_manager.h

Project Member

Comment 433 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d97c5da05500312e7262d32ffd42b3fbb1c38e

commit 48d97c5da05500312e7262d32ffd42b3fbb1c38e
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 20:03:20 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/884103004

Cr-Commit-Position: refs/heads/master@{#314610}

[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/accessibility/android_granularity_movement_browsertest.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/accessibility/android_hit_testing_browsertest.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/accessibility/browser_accessibility_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/accessibility/browser_accessibility_manager_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/device_sensors/sensor_manager_android_unittest.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/frame_host/render_widget_host_view_guest.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/gamepad/gamepad_platform_data_fetcher_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/geolocation/location_provider_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/android/browser_demuxer_android.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/android/browser_demuxer_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/android/browser_media_player_manager.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/android/media_resource_getter_impl.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/encrypted_media_browsertest.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/media/media_source_browsertest.cc
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/screen_orientation/screen_orientation_delegate_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/screen_orientation/screen_orientation_message_filter_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/speech/speech_recognizer_impl_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/time_zone_monitor_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/web_contents/web_contents_android.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/web_contents/web_contents_impl.h
[modify] http://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e/content/browser/web_contents/web_contents_view_android.h

Project Member

Comment 434 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b

commit 7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 20:11:51 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/884213005

Cr-Commit-Position: refs/heads/master@{#314618}

[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/accessibility/font_size_prefs_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/banners/app_banner_manager.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/bookmarks/bookmarks_bridge.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/chrome_web_contents_delegate_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/dev_tools_manager_delegate_android.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/dev_tools_manager_delegate_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/dom_distiller/feedback_reporter_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/foreign_session_helper.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/intercept_download_resource_throttle.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/logo_bridge.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/logo_service.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/logo_service.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/most_visited_sites.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/omnibox/answers_image_bridge.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/omnibox/autocomplete_controller_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/password_ui_view_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/preferences/website_preference_bridge.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/provider/bookmark_model_observer_task.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/provider/chrome_browser_provider.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/provider/chrome_browser_provider.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/recently_closed_tabs_bridge.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/shortcut_helper.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/signin/signin_manager_android.cc
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/signin/signin_manager_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/tab_android.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/thumbnail/thumbnail.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/thumbnail/thumbnail_store.h
[modify] http://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b/chrome/browser/android/webapps/single_tab_mode_tab_helper.h

Project Member

Comment 435 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc

commit 4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 21:48:48 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=creis@chromium.org

Review URL: https://codereview.chromium.org/893333004

Cr-Commit-Position: refs/heads/master@{#314647}

[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/app/android/child_process_service.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/gpu_memory_buffer_factory_surface_texture.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/image_transport_surface_android.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/media/android_video_decode_accelerator.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/media/android_video_decode_accelerator_unittest.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/media/android_video_encode_accelerator.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/gpu/stream_texture_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/public/browser/android/content_protocol_handler.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/public/test/nested_message_pump_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/android/address_detector.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/android/email_detector.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/android/phone_number_detector.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/android/renderer_date_time_picker.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/gpu/stream_texture_host_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/java/gin_java_bridge_dispatcher.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/java/gin_java_bridge_object.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/java/gin_java_bridge_value_converter.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/java/gin_java_bridge_value_converter_unittest.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/media_source_delegate.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/renderer_demuxer_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/renderer_media_player_manager.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/stream_texture_factory_impl.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/stream_texture_factory_impl.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/stream_texture_factory_synchronous_impl.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/stream_texture_factory_synchronous_impl.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/webmediaplayer_android.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/media/android/webmediaplayer_android.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/renderer/render_view_impl.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/shell/app/shell_crash_reporter_client.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/shell/browser/shell.h
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/shell/browser/shell_devtools_manager_delegate.cc
[modify] http://crrev.com/4d4461f988b4f0a5c84e0ae4852c23fbbc2769fc/content/test/test_render_view_host.h

Project Member

Comment 436 by bugdroid1@chromium.org, Feb 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e27b1ef23206ea3352b4623184b3533b2bac4dcb

commit e27b1ef23206ea3352b4623184b3533b2bac4dcb
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 04 23:34:11 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=caitkp@chromium.org

Review URL: https://codereview.chromium.org/893303003

Cr-Commit-Position: refs/heads/master@{#314677}

[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/crash/browser/crash_dump_manager_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/cronet/android/url_request_adapter.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/cronet/android/url_request_context_adapter.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/cronet/android/url_request_context_adapter.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/cronet/android/wrapped_channel_upload_element_reader.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/devtools_bridge/android/session_dependency_factory_android.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/devtools_bridge/android/session_dependency_factory_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/devtools_bridge/session_dependency_factory.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/devtools_bridge/socket_tunnel_server.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/dom_distiller/core/distilled_page_prefs_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/gcm_driver/gcm_driver_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/history/core/browser/android/android_urls_sql_handler.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/history/core/browser/android/favicon_sql_handler.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/history/core/browser/android/urls_sql_handler.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/history/core/browser/android/visit_sql_handler.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/invalidation/invalidation_service_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/invalidation/invalidation_service_android_unittest.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/navigation_interception/intercept_navigation_delegate.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/policy/core/common/policy_provider_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/policy/core/common/policy_provider_android_unittest.cc
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/web_contents_delegate_android/color_chooser_android.h
[modify] http://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb/components/web_contents_delegate_android/web_contents_delegate_android.h

Project Member

Comment 437 by bugdroid1@chromium.org, Feb 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/609028a4966aeddfce9f616bcdbab77838b01da2

commit 609028a4966aeddfce9f616bcdbab77838b01da2
Author: dcheng <dcheng@chromium.org>
Date: Thu Feb 05 10:08:17 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/893363002

Cr-Commit-Position: refs/heads/master@{#314786}

[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/audio/android/audio_android_unittest.cc
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/audio/android/audio_manager_android.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/audio/android/audio_record_input.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/audio/android/opensles_input.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/audio/android/opensles_output.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/audio_decoder_job.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/media_drm_bridge.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/media_player_bridge.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/media_source_player.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/media_source_player_unittest.cc
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/base/android/video_decoder_job.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/midi/usb_midi_device_android.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/midi/usb_midi_device_factory_android.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/video/capture/android/video_capture_device_android.h
[modify] http://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2/media/video/capture/android/video_capture_device_factory_android.h

Project Member

Comment 438 by bugdroid1@chromium.org, Feb 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0217ba51893ea7cc776d843d035bec759fef9a0

commit f0217ba51893ea7cc776d843d035bec759fef9a0
Author: dcheng <dcheng@chromium.org>
Date: Thu Feb 05 19:26:33 2015

Update {virtual,override,final} to follow C++11 style.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/897773002

Cr-Commit-Position: refs/heads/master@{#314853}

[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/browser_surface_texture_manager.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/composited_touch_handle_drawable.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/content_settings.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/content_view_core_impl.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/content_view_core_impl.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/content_view_render_view.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/content_view_statics.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/download_controller_android_impl.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/edge_effect.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/edge_effect_l.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_factory_impl.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_factory_impl.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_impl.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_output_surface.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_compositor_output_surface.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/in_process/synchronous_input_event_filter.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/interstitial_page_delegate_android.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/java/gin_java_bound_object_delegate.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/java/jni_helper_unittest.cc
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/overscroll_controller_android.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/popup_touch_handle_drawable.h
[modify] http://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0/content/browser/android/web_contents_observer_android.h

Project Member

Comment 439 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef52682b97c29f94ceb9a9750e29eecad58b416

commit aef52682b97c29f94ceb9a9750e29eecad58b416
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 01:55:54 2015

Update {virtual,override,final} to follow C++11 style in tools.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/898173002

Cr-Commit-Position: refs/heads/master@{#314943}

[modify] http://crrev.com/aef52682b97c29f94ceb9a9750e29eecad58b416/tools/android/forwarder2/device_forwarder_main.cc
[modify] http://crrev.com/aef52682b97c29f94ceb9a9750e29eecad58b416/tools/android/forwarder2/host_forwarder_main.cc
[modify] http://crrev.com/aef52682b97c29f94ceb9a9750e29eecad58b416/tools/android/heap_profiler/heap_profiler_unittest.cc

Project Member

Comment 440 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bf13035ab1d276bb3b9a576963012b80a3a1749

commit 4bf13035ab1d276bb3b9a576963012b80a3a1749
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 02:04:31 2015

Update {virtual,override,final} to follow C++11 style in remoting.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/905463005

Cr-Commit-Position: refs/heads/master@{#314944}

[modify] http://crrev.com/4bf13035ab1d276bb3b9a576963012b80a3a1749/remoting/client/jni/chromoting_jni_instance.h
[modify] http://crrev.com/4bf13035ab1d276bb3b9a576963012b80a3a1749/remoting/client/jni/jni_frame_consumer.h

Project Member

Comment 441 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e3e03ecaadd10689ee34e65dce9d39cef123d65

commit 8e3e03ecaadd10689ee34e65dce9d39cef123d65
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 03:32:20 2015

Update {virtual,override,final} to follow C++11 style in base.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900613004

Cr-Commit-Position: refs/heads/master@{#314951}

[modify] http://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65/base/android/scoped_java_ref_unittest.cc
[modify] http://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65/base/android/trace_event_binding.cc
[modify] http://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65/base/memory/discardable_memory_ashmem.h
[modify] http://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65/base/message_loop/message_pump_android.h
[modify] http://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65/base/test/test_support_android.cc

Project Member

Comment 442 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12590ce9e74571df716b9f2db9ee18999820d7b7

commit 12590ce9e74571df716b9f2db9ee18999820d7b7
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 03:34:00 2015

Update {virtual,override,final} to follow C++11 style in chrome.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900183004

Cr-Commit-Position: refs/heads/master@{#314953}

[modify] http://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7/chrome/android/shell/chrome_main_delegate_chrome_shell_android.h
[modify] http://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7/chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h
[modify] http://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7/chrome/app/android/chrome_main_delegate_android.h
[modify] http://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7/chrome/app/chrome_crash_reporter_client.h
[modify] http://crrev.com/12590ce9e74571df716b9f2db9ee18999820d7b7/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_factory.h

Project Member

Comment 443 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7922e556477cb556e3c858b5273a084e80d953

commit ff7922e556477cb556e3c858b5273a084e80d953
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 03:37:13 2015

Update {virtual,override,final} to follow C++11 style in printing.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900793008

Cr-Commit-Position: refs/heads/master@{#314957}

[modify] http://crrev.com/ff7922e556477cb556e3c858b5273a084e80d953/printing/backend/print_backend_dummy.cc
[modify] http://crrev.com/ff7922e556477cb556e3c858b5273a084e80d953/printing/printing_context_android.h

Project Member

Comment 444 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c6db7d6e4f367f8a5205a034e972eea3a348c9

commit e6c6db7d6e4f367f8a5205a034e972eea3a348c9
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 03:42:57 2015

Update {virtual,override,final} to follow C++11 style in net.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/897423002

Cr-Commit-Position: refs/heads/master@{#314964}

[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/android/network_change_notifier_android.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/android/network_change_notifier_android.h
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/android/network_change_notifier_android_unittest.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/android/network_change_notifier_factory_android.h
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/cert/cert_verify_proc_android.h
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/dns/dns_config_service_posix.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/proxy/proxy_config_service_android.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/proxy/proxy_config_service_android.h
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/proxy/proxy_config_service_android_unittest.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/test/spawned_test_server/remote_test_server.h
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/test/spawned_test_server/spawner_communicator.cc
[modify] http://crrev.com/e6c6db7d6e4f367f8a5205a034e972eea3a348c9/net/test/spawned_test_server/spawner_communicator.h

Project Member

Comment 445 by bugdroid1@chromium.org, Feb 6 2015

Project Member

Comment 446 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e608bf1db146501034def593a8f5880d94d1c24a

commit e608bf1db146501034def593a8f5880d94d1c24a
Author: dcheng <dcheng@chromium.org>
Date: Fri Feb 06 07:32:46 2015

Update {virtual,override,final} to follow C++11 style in gpu.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/871293003

Cr-Commit-Position: refs/heads/master@{#314998}

[modify] http://crrev.com/e608bf1db146501034def593a8f5880d94d1c24a/gpu/command_buffer/client/gl_in_process_context.cc
[modify] http://crrev.com/e608bf1db146501034def593a8f5880d94d1c24a/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc
[modify] http://crrev.com/e608bf1db146501034def593a8f5880d94d1c24a/gpu/command_buffer/tests/gl_unittests_android.cc

Project Member

Comment 447 by bugdroid1@chromium.org, Feb 6 2015

The following change refers to this bug:
https://chrome-internal-review.googlesource.com/196206
Project Member

Comment 448 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/809e023343ae13d40f21e4d03ff7b09b5ecf005a

commit 809e023343ae13d40f21e4d03ff7b09b5ecf005a
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Feb 06 19:01:54 2015

Update {virtual,override,final} to follow C++11 style in device.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/902973002

Cr-Commit-Position: refs/heads/master@{#315079}

[modify] http://crrev.com/809e023343ae13d40f21e4d03ff7b09b5ecf005a/device/vibration/vibration_manager_impl_android.h

Project Member

Comment 449 by bugdroid1@chromium.org, Feb 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c75a0a8c21c8af479b5408b59e6463d0b9acf67

commit 4c75a0a8c21c8af479b5408b59e6463d0b9acf67
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Feb 06 19:15:20 2015

Enable strict virtual specifier checks on Android.

BUG=417463
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/908613002

Cr-Commit-Position: refs/heads/master@{#315083}

[modify] http://crrev.com/4c75a0a8c21c8af479b5408b59e6463d0b9acf67/build/common.gypi

Project Member

Comment 450 by bugdroid1@chromium.org, Feb 16 2015

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/ff3e31c726f137338050e821d7cc711fb91881ce

commit ff3e31c726f137338050e821d7cc711fb91881ce
Author: dcheng <dcheng@google.com>
Date: Mon Feb 16 15:32:24 2015

Project Member

Comment 451 by bugdroid1@chromium.org, Feb 16 2015

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/8a58963eda911d803d582fc6940d565d65b49fe2

commit 8a58963eda911d803d582fc6940d565d65b49fe2
Author: sdefresne <sdefresne@google.com>
Date: Mon Feb 16 20:57:02 2015

Project Member

Comment 452 by bugdroid1@chromium.org, Feb 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e49dd268d8b846f5301fb1323e3aed15f36cf59

commit 2e49dd268d8b846f5301fb1323e3aed15f36cf59
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 18 20:40:54 2015

Remove strict-virtual-specifiers option, since it's enabled everywhere.

BUG=417463

Review URL: https://codereview.chromium.org/938773002

Cr-Commit-Position: refs/heads/master@{#316888}

[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/FindBadConstructsAction.cpp
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/Options.h
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/base_refcounted.cpp
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/base_refcounted.h
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/base_refcounted.txt
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/overridden_methods.cpp
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/overridden_methods.h
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/overridden_methods.txt
[delete] http://crrev.com/a2a0b31b0c50b91a7d9ed0e1e8f379f8aae8c5ea/tools/clang/plugins/tests/virtual_base_method_also_final.flags
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/virtual_bodies.cpp
[delete] http://crrev.com/a2a0b31b0c50b91a7d9ed0e1e8f379f8aae8c5ea/tools/clang/plugins/tests/virtual_specifiers.flags
[modify] http://crrev.com/2e49dd268d8b846f5301fb1323e3aed15f36cf59/tools/clang/plugins/tests/weak_ptr_factory.flags

Project Member

Comment 453 by bugdroid1@chromium.org, Feb 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6980a79fa23d6c40472a003a14e55a0781ef6a74

commit 6980a79fa23d6c40472a003a14e55a0781ef6a74
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 18 20:45:59 2015

Move strict-virtual-specifiers flag to be specified in plugin_flags.sh

BUG=417463

Review URL: https://codereview.chromium.org/935083003

Cr-Commit-Position: refs/heads/master@{#316889}

[modify] http://crrev.com/6980a79fa23d6c40472a003a14e55a0781ef6a74/build/common.gypi
[modify] http://crrev.com/6980a79fa23d6c40472a003a14e55a0781ef6a74/tools/clang/scripts/plugin_flags.sh

Project Member

Comment 454 by bugdroid1@chromium.org, Feb 18 2015

Project Member

Comment 456 by bugdroid1@chromium.org, Mar 31 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/675b9a2fae1b3fc36121c45dd144d572e499d36b

commit 675b9a2fae1b3fc36121c45dd144d572e499d36b
Author: cwgreene <cwgreene@amazon.com>
Date: Tue Mar 31 20:46:55 2015

Remove unnecessary 'virtual' annotation from mojo

Removes virtual keyword from overridden methods in
mojo/services/html_viewer.

BUG=417463,469785

Review URL: https://codereview.chromium.org/1037363002

Cr-Commit-Position: refs/heads/master@{#323102}

[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/AUTHORS
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/ax_provider_impl_unittest.cc
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/blink_platform_impl.cc
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/blink_platform_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/blink_url_request_type_converters.cc
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/html_document.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/mojo_blink_platform_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/test_blink_platform_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webclipboard_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webcookiejar_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/weblayertreeview_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webmimeregistry_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webscheduler_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/websockethandle_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webstoragenamespace_impl.cc
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webstoragenamespace_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webthemeengine_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/webthread_impl.h
[modify] http://crrev.com/675b9a2fae1b3fc36121c45dd144d572e499d36b/mojo/services/html_viewer/weburlloader_impl.h

Project Member

Comment 457 by bugdroid1@chromium.org, Apr 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b0cc2654f792b8865ca9615f247a881c23826b7

commit 1b0cc2654f792b8865ca9615f247a881c23826b7
Author: nick <nick@chromium.org>
Date: Wed Apr 22 23:15:06 2015

Update {virtual,override} to follow C++11 style in ash.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1088593006

Cr-Commit-Position: refs/heads/master@{#326391}

[modify] http://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7/ash/host/ash_remote_window_tree_host_win.h
[modify] http://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7/ash/host/ash_window_tree_host_win.cc
[modify] http://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7/ash/system/win/audio/tray_audio_delegate_win.h
[modify] http://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7/ash/test/test_metro_viewer_process_host.h

Project Member

Comment 458 by bugdroid1@chromium.org, Apr 22 2015

Project Member

Comment 459 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1afc9112d09515b380002645efc21ba3a87122

commit 0e1afc9112d09515b380002645efc21ba3a87122
Author: nick <nick@chromium.org>
Date: Thu Apr 23 04:41:54 2015

Update {virtual,override} to follow C++11 style in dbus.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1055053003

Cr-Commit-Position: refs/heads/master@{#326451}

[modify] http://crrev.com/0e1afc9112d09515b380002645efc21ba3a87122/dbus/mock_object_proxy.h

Project Member

Comment 460 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8787d39596aa89b0e83dc89b361e1eb80253e246

commit 8787d39596aa89b0e83dc89b361e1eb80253e246
Author: nick <nick@chromium.org>
Date: Thu Apr 23 04:42:16 2015

Update {virtual,override} to follow C++11 style in tools.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was ironically generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1051643003

Cr-Commit-Position: refs/heads/master@{#326452}

[modify] http://crrev.com/8787d39596aa89b0e83dc89b361e1eb80253e246/tools/clang/blink_gc_plugin/Edge.h

Project Member

Comment 461 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81b3346126a4f586992ed502256eba5b43f1e19

commit e81b3346126a4f586992ed502256eba5b43f1e19
Author: nick <nick@chromium.org>
Date: Thu Apr 23 04:43:15 2015

Update {virtual,override} to follow C++11 style in chromeos.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1101763002

Cr-Commit-Position: refs/heads/master@{#326453}

[modify] http://crrev.com/e81b3346126a4f586992ed502256eba5b43f1e19/chromeos/dbus/nfc_client_unittest.cc
[modify] http://crrev.com/e81b3346126a4f586992ed502256eba5b43f1e19/chromeos/dbus/shill_client_unittest_base.h

Project Member

Comment 462 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1d060ed293f8c882e1ba82c1c10c743167d0b5

commit 5c1d060ed293f8c882e1ba82c1c10c743167d0b5
Author: nick <nick@chromium.org>
Date: Thu Apr 23 04:43:32 2015

Update {virtual,override} to follow C++11 style in chrome_elf.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1106533003

Cr-Commit-Position: refs/heads/master@{#326454}

[modify] http://crrev.com/5c1d060ed293f8c882e1ba82c1c10c743167d0b5/chrome_elf/chrome_elf_util_unittest.cc
[modify] http://crrev.com/5c1d060ed293f8c882e1ba82c1c10c743167d0b5/chrome_elf/create_file/chrome_create_file_unittest.cc
[modify] http://crrev.com/5c1d060ed293f8c882e1ba82c1c10c743167d0b5/chrome_elf/ntdll_cache_unittest.cc

Project Member

Comment 463 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07903e579abf9f18d79935e1f531c7cd88503c58

commit 07903e579abf9f18d79935e1f531c7cd88503c58
Author: nick <nick@chromium.org>
Date: Thu Apr 23 04:56:43 2015

Update {virtual,override} to follow C++11 style in pdf.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1088763004

Cr-Commit-Position: refs/heads/master@{#326456}

[modify] http://crrev.com/07903e579abf9f18d79935e1f531c7cd88503c58/pdf/instance.h
[modify] http://crrev.com/07903e579abf9f18d79935e1f531c7cd88503c58/pdf/out_of_process_instance.h

Project Member

Comment 464 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f30d02fb6e676e9a46776325e21f64903c201d

commit d3f30d02fb6e676e9a46776325e21f64903c201d
Author: nick <nick@chromium.org>
Date: Thu Apr 23 10:18:37 2015

Update {virtual,override} to follow C++11 style in net.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1088903008

Cr-Commit-Position: refs/heads/master@{#326489}

[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/base/elements_upload_data_stream_unittest.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/base/network_change_notifier_win_unittest.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/cookies/cookie_monster.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/disk_cache/blockfile/backend_impl_v3.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/disk_cache/blockfile/sparse_control_v3.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/dns/dns_test_util.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/dns/mock_mdns_socket_factory.h
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/http/http_server_properties_manager_unittest.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/http/http_stream_factory_impl_unittest.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/socket/client_socket_pool_base.h
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/test/net_test_suite.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/tools/quic/quic_time_wait_list_manager_test.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/tools/quic/test_tools/quic_test_utils.h
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/url_request/url_request_http_job_unittest.cc
[modify] http://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d/net/websockets/websocket_channel_test.cc

Project Member

Comment 465 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05b81d7617e11ae4612afc15aab69b6f57293fe

commit b05b81d7617e11ae4612afc15aab69b6f57293fe
Author: nick <nick@chromium.org>
Date: Thu Apr 23 14:00:50 2015

Update {virtual,override} to follow C++11 style in ppapi.

[Sending this chunk by itself since it's slightly less rote than the others]

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100733003

Cr-Commit-Position: refs/heads/master@{#326504}

[modify] http://crrev.com/b05b81d7617e11ae4612afc15aab69b6f57293fe/ppapi/proxy/ppapi_proxy_test.h

Project Member

Comment 466 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4784434857731fd46a2ecdf0c132561ff6674a3

commit e4784434857731fd46a2ecdf0c132561ff6674a3
Author: nick <nick@chromium.org>
Date: Thu Apr 23 14:01:48 2015

Update {virtual,override} to follow C++11 style in ppapi.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1097393007

Cr-Commit-Position: refs/heads/master@{#326505}

[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/host/ppapi_host.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/host/resource_host.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/host/resource_message_filter.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/host/resource_message_filter_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/nacl_irt/manifest_service.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/nacl_irt/ppapi_dispatcher.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/audio_buffer_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/audio_input_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/broker_dispatcher.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/broker_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/browser_font_singleton_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/compositor_layer_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/compositor_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/device_enumeration_resource_helper_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/dispatcher.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/file_chooser_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/file_io_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/file_ref_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/file_system_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_clipboard_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_drm_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_file_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_font_file_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_fullscreen_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_menu_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/flash_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/gamepad_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/graphics_2d_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/host_resolver_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/host_resolver_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/isolated_file_system_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/media_stream_audio_track_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/media_stream_track_resource_base.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/media_stream_video_track_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/net_address_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/network_list_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/network_monitor_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/network_proxy_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/output_protection_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/pdf_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/platform_verification_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_array_buffer_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_globals.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_globals.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_message_filter.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_resource_callback.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_resource_tracker.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_resource_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/plugin_var_tracker.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppapi_command_buffer_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_broker_proxy.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_buffer_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_flash_message_loop_proxy.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_flash_message_loop_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_graphics_3d_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_image_data_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_message_loop_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_video_decoder_proxy.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_x509_certificate_private_proxy.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppb_x509_certificate_private_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppp_instance_private_proxy_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppp_messaging_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppp_mouse_lock_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/ppp_text_input_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/printing_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/proxy_channel.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/proxy_object_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/raw_var_data.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/resource_creation_proxy.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/resource_message_params.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/resource_message_test_sink.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/tcp_server_socket_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/tcp_socket_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/tcp_socket_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/truetype_font_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/truetype_font_singleton_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/udp_socket_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/udp_socket_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/uma_private_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/url_loader_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/url_request_info_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/url_response_info_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/video_capture_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/video_decoder_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/video_destination_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/video_frame_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/video_source_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/proxy/websocket_resource.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/array_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/dictionary_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/media_stream_buffer_manager_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_audio_config_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_device_ref_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_graphics_3d_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_input_event_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_instance_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_video_decoder_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/ppb_view_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/resource_tracker_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/resource_var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/test_globals.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/thread_aware_callback_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/var.h
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/shared_impl/var_tracker_unittest.cc
[modify] http://crrev.com/e4784434857731fd46a2ecdf0c132561ff6674a3/ppapi/tests/test_flash_fullscreen_for_browser_ui.h

Project Member

Comment 467 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a2f9766856f4cc6ac5e56f65be8a6ca6523460b

commit 9a2f9766856f4cc6ac5e56f65be8a6ca6523460b
Author: nick <nick@chromium.org>
Date: Thu Apr 23 14:49:54 2015

Update {virtual,override} to follow C++11 style in rlz.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1097393008

Cr-Commit-Position: refs/heads/master@{#326517}

[modify] http://crrev.com/9a2f9766856f4cc6ac5e56f65be8a6ca6523460b/rlz/win/lib/rlz_value_store_registry.h

Project Member

Comment 468 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c7fbb29354afcaf0d2afbd1659128f7706f86fe

commit 9c7fbb29354afcaf0d2afbd1659128f7706f86fe
Author: nick <nick@chromium.org>
Date: Thu Apr 23 15:12:01 2015

Update {virtual,override} to follow C++11 style in google_apis.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1086453003

Cr-Commit-Position: refs/heads/master@{#326521}

[modify] http://crrev.com/9c7fbb29354afcaf0d2afbd1659128f7706f86fe/google_apis/drive/drive_api_requests.h
[modify] http://crrev.com/9c7fbb29354afcaf0d2afbd1659128f7706f86fe/google_apis/gaia/gaia_oauth_client_unittest.cc

Project Member

Comment 469 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a69aba4fdece17645148f37ad2582174aa64c97

commit 7a69aba4fdece17645148f37ad2582174aa64c97
Author: nick <nick@chromium.org>
Date: Thu Apr 23 16:39:18 2015

Update {virtual,override} to follow C++11 style in sync.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1104543005

Cr-Commit-Position: refs/heads/master@{#326541}

[modify] http://crrev.com/7a69aba4fdece17645148f37ad2582174aa64c97/sync/internal_api/sync_backup_manager_unittest.cc
[modify] http://crrev.com/7a69aba4fdece17645148f37ad2582174aa64c97/sync/internal_api/sync_manager_impl_unittest.cc
[modify] http://crrev.com/7a69aba4fdece17645148f37ad2582174aa64c97/sync/internal_api/sync_rollback_manager_unittest.cc

Project Member

Comment 470 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d60f71748cc8d3fdfa30811b6896df6e4113d15a

commit d60f71748cc8d3fdfa30811b6896df6e4113d15a
Author: nick <nick@chromium.org>
Date: Thu Apr 23 16:42:48 2015

Update {virtual,override} to follow C++11 style in ipc.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1084323007

Cr-Commit-Position: refs/heads/master@{#326544}

[modify] http://crrev.com/d60f71748cc8d3fdfa30811b6896df6e4113d15a/ipc/ipc_channel_nacl.cc
[modify] http://crrev.com/d60f71748cc8d3fdfa30811b6896df6e4113d15a/ipc/ipc_channel_nacl.h
[modify] http://crrev.com/d60f71748cc8d3fdfa30811b6896df6e4113d15a/ipc/mojo/ipc_channel_mojo_unittest.cc

Project Member

Comment 471 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641

commit 0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641
Author: nick <nick@chromium.org>
Date: Thu Apr 23 16:43:07 2015

Update {virtual,override} to follow C++11 style in extensions.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1104543004

Cr-Commit-Position: refs/heads/master@{#326545}

[modify] http://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641/extensions/browser/api/socket/socket_api.h
[modify] http://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641/extensions/browser/api/usb/usb_apitest.cc
[modify] http://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641/extensions/browser/browser_context_keyed_api_factory.h
[modify] http://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641/extensions/browser/mock_extension_system.h
[modify] http://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641/extensions/common/permissions/set_disjunction_permission.h

Project Member

Comment 472 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9530326e89f1b3572f436ffa803e20e05f4a5a39

commit 9530326e89f1b3572f436ffa803e20e05f4a5a39
Author: nick <nick@chromium.org>
Date: Thu Apr 23 17:38:09 2015

Update {virtual,override} to follow C++11 style in ui.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1081103008

Cr-Commit-Position: refs/heads/master@{#326565}

[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/aura/window_tree_host_mac.h
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/base/ime/chromeos/ime_keyboard_x11_unittest.cc
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/base/models/tree_node_model.h
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/base/resource/resource_bundle_unittest.cc
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/events/event_processor_unittest.cc
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/events/event_target_iterator.h
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/shell_dialogs/select_file_dialog_win.cc
[modify] http://crrev.com/9530326e89f1b3572f436ffa803e20e05f4a5a39/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 473 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb

commit 68fbc356f2cd540da8e65cd1896043c7b4e7d3cb
Author: nick <nick@chromium.org>
Date: Thu Apr 23 18:10:41 2015

Update {virtual,override} to follow C++11 style in win8.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1101663006

Cr-Commit-Position: refs/heads/master@{#326578}

[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/chrome_app_view_ash.cc
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/chrome_app_view_ash.h
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/file_picker.cc
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/file_picker_ash.h
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/ime/input_source.cc
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/ime/text_service.cc
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/metro_driver/metro_driver_win7.cc
[modify] http://crrev.com/68fbc356f2cd540da8e65cd1896043c7b4e7d3cb/win8/viewer/metro_viewer_process_host.h

Project Member

Comment 474 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697f429d75099ea436aee5beb9ea0c26c7dea497

commit 697f429d75099ea436aee5beb9ea0c26c7dea497
Author: nick <nick@chromium.org>
Date: Thu Apr 23 18:22:31 2015

Update {virtual,override} to follow C++11 style in remoting.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1101033002

Cr-Commit-Position: refs/heads/master@{#326582}

[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/base/breakpad_win_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/client/plugin/pepper_module.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/audio_capturer_win.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/chromeos/aura_desktop_capturer_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/clipboard_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/continue_window_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/curtain_mode_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/daemon_process_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/daemon_process_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/desktop_process_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/desktop_resizer_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/desktop_session_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/desktop_session_win.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/disconnect_window_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/gnubby_auth_handler_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/host_event_logger_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/host_mock_objects.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/input_injector_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/ipc_desktop_environment_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/pairing_registry_delegate_win.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/pairing_registry_delegate_win_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/sas_injector_win.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/setup/daemon_controller_delegate_win.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/setup/me2me_native_messaging_host.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/chromoting_module.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/host_service.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/rdp_client.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/rdp_client_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/rdp_desktop_session.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/session_desktop_environment.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/session_input_injector.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/session_input_injector.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/unprivileged_process_delegate.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/worker_process_launcher.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/worker_process_launcher_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/wts_session_process_delegate.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/host/win/wts_session_process_delegate.h
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/protocol/monitored_video_stub_unittest.cc
[modify] http://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497/remoting/signaling/mock_signal_strategy.h

Project Member

Comment 475 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a924fd8ec1041f3320c6d784d98da681719d95

commit c3a924fd8ec1041f3320c6d784d98da681719d95
Author: nick <nick@chromium.org>
Date: Thu Apr 23 18:55:54 2015

Update {virtual,override} to follow C++11 style in jingle.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1063453006

Cr-Commit-Position: refs/heads/master@{#326596}

[modify] http://crrev.com/c3a924fd8ec1041f3320c6d784d98da681719d95/jingle/notifier/listener/xmpp_push_client_unittest.cc

Project Member

Comment 476 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77137323157640d3eecae553956425c067054383

commit 77137323157640d3eecae553956425c067054383
Author: nick <nick@chromium.org>
Date: Thu Apr 23 19:40:30 2015

Update {virtual,override} to follow C++11 style in device.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1107433002

Cr-Commit-Position: refs/heads/master@{#326609}

[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/battery/battery_status_manager_win.cc
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/bluetooth/bluetooth_adapter_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/bluetooth/bluetooth_adapter_win_unittest.cc
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/bluetooth/bluetooth_device_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/bluetooth/bluetooth_socket_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/bluetooth/bluetooth_task_manager_win_unittest.cc
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/hid/hid_connection_win.cc
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/hid/hid_connection_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/hid/hid_service_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/serial/serial_device_enumerator_win.h
[modify] http://crrev.com/77137323157640d3eecae553956425c067054383/device/serial/serial_io_handler_win.h

Project Member

Comment 477 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6ac192621b71ee5ecdac74082e99346871e5024

commit d6ac192621b71ee5ecdac74082e99346871e5024
Author: nick <nick@chromium.org>
Date: Thu Apr 23 19:54:59 2015

Update {virtual,override} to follow C++11 style in sandbox.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1058123003

Cr-Commit-Position: refs/heads/master@{#326616}

[modify] http://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024/sandbox/linux/bpf_dsl/bpf_dsl.h
[modify] http://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024/sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h
[modify] http://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024/sandbox/linux/seccomp-bpf/bpf_tests.h
[modify] http://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024/sandbox/win/src/broker_services.h
[modify] http://crrev.com/d6ac192621b71ee5ecdac74082e99346871e5024/sandbox/win/src/sandbox_policy_base.h

Project Member

Comment 478 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143f36d503bb1e76be743dd19587e5d4791f94a3

commit 143f36d503bb1e76be743dd19587e5d4791f94a3
Author: nick <nick@chromium.org>
Date: Fri Apr 24 17:49:18 2015

Update {virtual,override} to follow C++11 style in courgette.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1052683004

Cr-Commit-Position: refs/heads/master@{#326831}

[modify] http://crrev.com/143f36d503bb1e76be743dd19587e5d4791f94a3/courgette/disassembler_elf_32_x86.h

Project Member

Comment 479 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be4ce8de5b489002f5868eee4ea568a4c1ea4a6a

commit be4ce8de5b489002f5868eee4ea568a4c1ea4a6a
Author: cwgreene <cwgreene@amazon.com>
Date: Fri Apr 24 18:25:09 2015

Change virtual to override in devtools generator code.

Changes Client destructor to be override instead of virtual to conform with chromium-style.

BUG=417463

Review URL: https://codereview.chromium.org/1108613002

Cr-Commit-Position: refs/heads/master@{#326842}

[modify] http://crrev.com/be4ce8de5b489002f5868eee4ea568a4c1ea4a6a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Project Member

Comment 480 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd48e5909786f81f75052d45e770c823b5935d3e

commit bd48e5909786f81f75052d45e770c823b5935d3e
Author: nick <nick@chromium.org>
Date: Fri Apr 24 18:33:42 2015

Update {virtual,override} to follow C++11 style in gpu.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

NOTRY=true
BUG=417463

Review URL: https://codereview.chromium.org/1101013002

Cr-Commit-Position: refs/heads/master@{#326845}

[modify] http://crrev.com/bd48e5909786f81f75052d45e770c823b5935d3e/gpu/command_buffer/client/client_test_helper.h

Project Member

Comment 481 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3915ed9aeda4c38a8d391f7f41f127a790a762b

commit e3915ed9aeda4c38a8d391f7f41f127a790a762b
Author: nick <nick@chromium.org>
Date: Fri Apr 24 20:13:21 2015

Update {virtual,override} to follow C++11 style in media.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1102573006

Cr-Commit-Position: refs/heads/master@{#326862}

[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/agc_audio_stream.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/alsa/alsa_output_unittest.cc
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/cras/cras_input_unittest.cc
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/cras/cras_unified_unittest.cc
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/openbsd/audio_manager_openbsd.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/base/fake_audio_render_callback.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/base/fake_text_track_stream.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/base/mock_audio_renderer_sink.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/cdm_file_io_impl.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/cdm_file_io_test.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/cdm_helpers.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/cdm_wrapper.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/external_clear_key/fake_cdm_video_decoder.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/cdm/ppapi/external_clear_key/libvpx_cdm_video_decoder.h
[modify] http://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b/media/renderers/mock_gpu_video_accelerator_factories.h

Project Member

Comment 482 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddb02ac66bad95bc04548a799eb2ce89a456b37c

commit ddb02ac66bad95bc04548a799eb2ce89a456b37c
Author: nick <nick@chromium.org>
Date: Fri Apr 24 20:45:38 2015

Update {virtual,override} to follow C++11 style in chrome.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100223002

Cr-Commit-Position: refs/heads/master@{#326870}

[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/app/chrome_crash_reporter_client.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/app/delay_load_hook_unittest_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/autocomplete/autocomplete_controller.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/autocomplete/history_url_provider.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/autofill/autofill_cc_infobar_delegate_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/browser_process_platform_part_aurawin.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chrome_browser_main_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chrome_elf_init_unittest_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chrome_select_file_dialog_factory_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/resource_loader_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/screens/mock_eula_screen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/screens/mock_network_screen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/screens/mock_wrong_hwid_screen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/crash_upload_list_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/download/download_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/download/download_target_determiner_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/display_info_provider_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/external_registry_loader_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/extensions/global_shortcut_listener_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/first_run/first_run_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/first_run/try_chrome_dialog_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/importer/in_process_importer_bridge.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/install_verification/win/module_verification_test.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/privet_device_lister_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/privet_http_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/privet_url_fetcher_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/privetv3_session_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/service_discovery_client_mdns.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/test_service_discovery_client.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/wifi/credential_getter_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/local_discovery/wifi/mock_wifi_manager.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/metrics/google_update_metrics_provider_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/password_manager/password_store_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/password_manager/password_store_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/pdf/pdf_extension_test.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/policy/cloud/device_management_service_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/policy/policy_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/predictors/resource_prefetcher_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/printing/printing_layout_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profile_resetter/jtl_interpreter.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profiles/profile_destroyer_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/profiles/profile_shortcut_manager_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/service_process/service_process_control_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/shell_integration_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/speech/tts_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/sync/profile_sync_components_factory_mock.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/translate/cld_data_harness.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/browser_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/browser_command_controller.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/metro_pin_tab_helper_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/network_profile_bubble.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/pdf/pdf_browsertest_base.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/pdf/pdf_unsupported_feature.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/startup/autolaunch_prompt_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/startup/default_browser_prompt_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/app_list/win/activation_tracker_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/app_list/win/app_list_service_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/app_list/win/app_list_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/chrome_views_delegate.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/color_chooser_dialog.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/color_chooser_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/conflicting_module_view_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/browser_frame_ashwin.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/frame/system_menu_insertion_delegate_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/menu_controller_interactive_uitest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/menu_controller_test.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/menu_item_view_interactive_uitest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/network_profile_bubble_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/panels/panel_stack_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/panels/panel_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/panels/taskbar_window_thumbnailer_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/status_icons/status_icon_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/status_icons/status_tray_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/status_icons/status_tray_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/toolbar/toolbar_button_test.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/views/uninstall_view.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/help/version_updater_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/mojo_web_ui_controller.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/options/preferences_browsertest.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/profiler_ui.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/browser/ui/webui/set_as_default_browser_ui.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/common/local_discovery/local_domain_resolver_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/common/safe_browsing/pe_image_reader_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/common/safe_browsing/pe_image_reader_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/setup/archive_patch_helper_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/setup/install_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/setup/install_worker_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/setup/setup_util_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/advanced_firewall_manager_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/callback_work_item.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chrome_binaries_operations.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chrome_browser_operations.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chrome_browser_sxs_operations.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chrome_frame_distribution.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chrome_frame_operations.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/chromium_binaries_distribution.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/delete_reg_key_work_item.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/firewall_manager_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/google_chrome_distribution.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/google_chrome_sxs_distribution.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/google_update_settings_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/install_util.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/installation_validator.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/legacy_firewall_manager_win_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/non_updating_app_registration_data.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/shell_util_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/installer/util/updating_app_registration_data.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/prerender/prerender_dispatcher.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/prerender/prerenderer_client.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/spellchecker/spellcheck_provider.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/spellchecker/spellcheck_provider_test.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/spellchecker/spellcheck_unittest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/translate/translate_helper_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/renderer/tts_dispatcher.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/service/cloud_print/print_system_win.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/service/service_utility_process_host.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/service/service_utility_process_host.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/base/test_browser_window.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/base/ui_test_utils.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/base/web_ui_browser_test_browsertest.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/data/webui/async_gen.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/data/webui/chrome_send_browsertest.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/logging/win/log_file_printer.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/logging/win/test_log_collector.cc
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/test/ppapi/ppapi_test.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/utility/font_cache_handler_win.h
[modify] http://crrev.com/ddb02ac66bad95bc04548a799eb2ce89a456b37c/chrome/utility/importer/external_process_importer_brid
Project Member

Comment 483 by bugdroid1@chromium.org, Apr 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5120892497bc7707e492c045f1afebba3199a640

commit 5120892497bc7707e492c045f1afebba3199a640
Author: nick <nick@chromium.org>
Date: Fri Apr 24 21:38:37 2015

Update {virtual,override} to follow C++11 style in content.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1091093006

Cr-Commit-Position: refs/heads/master@{#326880}

[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/accessibility/browser_accessibility_manager_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/accessibility/browser_accessibility_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/compositor/software_output_device_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/frame_host/interstitial_page_impl.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/frame_host/render_widget_host_view_guest.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/gamepad/gamepad_platform_data_fetcher_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/gamepad/raw_input_data_fetcher_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/gpu/gpu_process_host.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/indexed_db/mock_indexed_db_factory.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/plugin_process_host.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/plugin_service_impl.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/plugin_service_impl_browsertest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/power_profiler/power_data_provider_ia_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/ppapi_plugin_process_host.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/legacy_render_widget_host_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/media/video_capture_host_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/pepper/pepper_truetype_font_win.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/system_message_window_win_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/time_zone_monitor_win.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/web_contents/web_contents_impl.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/web_contents/web_contents_view_aura.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/browser/web_contents/web_contents_view_overscroll_animator_slider_mac.mm
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/blink_platform_impl_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/indexed_db/indexed_db_dispatcher_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/indexed_db/webidbcursor_impl_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/npapi/plugin_url_fetcher.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/web_url_loader_impl.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/web_url_loader_impl_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/child/websocket_bridge.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/common/dwrite_font_platform_win.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/common/font_cache_dispatcher_win.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/common/sandbox_mac_system_access_unittest.mm
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/public/renderer/platform_event_observer.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/public/test/content_test_suite_base.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/public/test/mock_download_item.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/public/test/mock_download_manager.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/public/test/mock_render_thread.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/device_sensors/device_sensor_event_pump.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/input/input_handler_proxy_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/java/gin_java_bridge_value_converter.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/media_stream_center.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/mock_media_stream_video_sink.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/mock_media_stream_video_source.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/video_capture_message_filter_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/webaudio_capturer_source.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/webrtc_audio_capturer_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/webrtc_local_audio_source_provider.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/renderer/media/webrtc_local_audio_track_unittest.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/shell/app/shell_crash_reporter_client.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/shell/browser/shell_content_browser_client.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/shell/renderer/test_runner/web_frame_test_proxy.h
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/test/content_test_suite.cc
[modify] http://crrev.com/5120892497bc7707e492c045f1afebba3199a640/content/test/ppapi/ppapi_test.h

Project Member

Comment 484 by bugdroid1@chromium.org, Apr 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af05b2a50818299ef27c8fc84fd2f65b37401329

commit af05b2a50818299ef27c8fc84fd2f65b37401329
Author: nick <nick@chromium.org>
Date: Sat Apr 25 15:40:24 2015

Update {virtual,override} to follow C++11 style in content/renderer/media.

This CL has just two files which got some extra "while I'm in there" cleanup while doing mechanical fixups across the codebase.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

BUG=417463

Review URL: https://codereview.chromium.org/1106043002

Cr-Commit-Position: refs/heads/master@{#326972}

[modify] http://crrev.com/af05b2a50818299ef27c8fc84fd2f65b37401329/content/renderer/media/mock_peer_connection_impl.h
[modify] http://crrev.com/af05b2a50818299ef27c8fc84fd2f65b37401329/content/renderer/media/rtc_data_channel_handler.h

Project Member

Comment 485 by bugdroid1@chromium.org, Apr 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b796a8539bf302d4d4aa420356d0f8c0d46063

commit 80b796a8539bf302d4d4aa420356d0f8c0d46063
Author: nick <nick@chromium.org>
Date: Mon Apr 27 22:14:53 2015

Update {virtual,override} to follow C++11 style in cloud_print.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100633004

Cr-Commit-Position: refs/heads/master@{#327154}

[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/cloud_print_request.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/cloud_print_requester.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/printer.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/gcp20/prototype/privet_http_server.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/service/win/chrome_launcher.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/service/win/cloud_print_service_config.cc
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/service/win/service_listener.h
[modify] http://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063/cloud_print/service/win/setup_listener.h

Project Member

Comment 486 by bugdroid1@chromium.org, Apr 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc76161f2f357116c647446afdc4de083712224a

commit bc76161f2f357116c647446afdc4de083712224a
Author: nick <nick@chromium.org>
Date: Mon Apr 27 23:30:46 2015

Update {virtual,override} to follow C++11 style in printing.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1101023002

Cr-Commit-Position: refs/heads/master@{#327173}

[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/backend/print_backend_win.cc
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/emf_win.h
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/emf_win_unittest.cc
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/pdf_metafile_skia.h
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/printing_context_system_dialog_win.h
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/printing_context_win.h
[modify] http://crrev.com/bc76161f2f357116c647446afdc4de083712224a/printing/printing_context_win_unittest.cc

Project Member

Comment 487 by bugdroid1@chromium.org, Apr 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ff566325268a34a0ce078dbda3ea68d21850de

commit 79ff566325268a34a0ce078dbda3ea68d21850de
Author: nick <nick@chromium.org>
Date: Tue Apr 28 17:22:22 2015

Update {virtual,override} to follow C++11 style in components.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1056633004

Cr-Commit-Position: refs/heads/master@{#327312}

[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/autofill/content/browser/wallet/mock_wallet_client.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/autofill/content/browser/wallet/wallet_client_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/autofill/core/browser/autofill_ie_toolbar_import_win.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/browser_watcher/exit_code_watcher_win_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/browser_watcher/exit_funnel_win_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/browser_watcher/watcher_metrics_provider_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/browser_watcher/watcher_metrics_provider_win_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/dom_distiller/core/dom_distiller_test_util.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/dom_distiller/core/fake_distiller.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/dom_distiller/core/fake_distiller_page.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/dom_distiller/core/viewer_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/enhanced_bookmarks/image_store_ios_unittest.mm
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/enhanced_bookmarks/image_store_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/invalidation/unacked_invalidation_set_test_util.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/leveldb_proto/proto_database_impl.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/leveldb_proto/testing/fake_db.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/nacl/broker/nacl_broker_listener.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/nacl/browser/nacl_broker_host_win.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/nacl/common/nacl_debug_exception_handler_win.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/native_viewport/platform_viewport_android.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/password_manager/core/browser/password_manager_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/pdf/browser/pdf_web_contents_helper.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/pdf/renderer/pepper_pdf_host.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/async_policy_provider_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/cloud/policy_builder.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/policy_loader_win.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/policy_loader_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/policy_loader_win_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/policy/core/common/policy_service_impl_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/proximity_auth/bluetooth_connection_finder_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/proximity_auth/bluetooth_connection_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/proximity_auth/client_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/proximity_auth/connection_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/renderer_context_menu/render_view_context_menu_observer.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/search_provider_logos/logo_tracker_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/storage_monitor_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/storage_monitor_win_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/test_portable_device_watcher_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/test_storage_monitor.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/test_storage_monitor_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/storage_monitor/test_volume_mount_watcher_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/sync_driver/shared_change_processor_unittest.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/test/run_all_unittests.cc
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/update_client/background_downloader_win.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/webdata/common/web_data_results.h
[modify] http://crrev.com/79ff566325268a34a0ce078dbda3ea68d21850de/components/wifi/wifi_service_win.cc

Project Member

Comment 488 by bugdroid1@chromium.org, Jul 7 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198370

------------------------------------------------------------------
r198370 | tkent@chromium.org | 2015-07-07T08:09:34.081152Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertLineBreakCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/CreateLinkCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/IndentOutdentCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/UnlinkCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditingStyle.cpp?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/DeleteFromTextNodeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/FrameSelection.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/FormatBlockCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/RemoveFormatCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ApplyStyleCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SplitTextNodeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ApplyBlockElementCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/TextInsertionBaseCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/RemoveCSSPropertyCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertParagraphSeparatorCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/MoveSelectionCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/BreakBlockquoteCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/AppendNodeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SpellCheckRequester.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/RemoveNodePreservingChildrenCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ReplaceSelectionCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SetNodeAttributeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SplitTextNodeContainingElementCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertNodeBeforeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ReplaceNodeWithSpanCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertListCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/RemoveNodeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SplitElementCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/DeleteSelectionCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/CompositeEditCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertIntoTextNodeCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertTextCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/MergeIdenticalElementsCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/TypingCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/WrapContentsInDummySpanCommand.h?r1=198370&r2=198369&pathrev=198370
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SimplifyMarkupCommand.h?r1=198370&r2=198369&pathrev=198370

Fix virtual/override/final usage in Source/core/editing/.

- We should specify just one of them to a function.
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1218293014
-----------------------------------------------------------------
Project Member

Comment 489 by bugdroid1@chromium.org, Jul 7 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198371

------------------------------------------------------------------
r198371 | tkent@chromium.org | 2015-07-07T08:13:29.178862Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationRecord.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptLoader.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ExecutionContextTask.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DecodedDataDocumentParser.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMDataView.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/RawDataDocumentParser.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMSettableTokenList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/custom/CustomElementUpgradeCandidateMap.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentFragment.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMURL.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Comment.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CrossThreadTask.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/InsertionPoint.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Attr.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DatasetDOMStringMap.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentMarker.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/StringCallback.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ShadowRoot.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMURLUtils.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMTypedArray.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ChildNodeList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Node.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/StyleEngine.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/TagCollection.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/StaticNodeList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EmptyNodeList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/custom/CustomElementCallbackInvocation.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CDATASection.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FirstLetterPseudoElement.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/LiveNodeList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/custom/CustomElementMicrotaskImportStep.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Fullscreen.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMArrayBufferView.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMDataView.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptableDocumentParser.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMArrayBuffer.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PseudoElement.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ProcessingInstruction.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentType.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ClassCollection.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NameNodeList.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MainThreadTaskRunnerTest.cpp?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Text.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CharacterData.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ContainerNode.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/TemplateContentDocumentFragment.h?r1=198371&r2=198370&pathrev=198371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MessagePort.h?r1=198371&r2=198370&pathrev=198371

Fix virtual/override/final usage in Source/core/dom/.

- We should specify just one of them to a function.
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1219063013
-----------------------------------------------------------------
Project Member

Comment 490 by bugdroid1@chromium.org, Jul 7 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198376

------------------------------------------------------------------
r198376 | tkent@chromium.org | 2015-07-07T08:32:39.870518Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLUListElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOutputElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSourceElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlElementWithState.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAudioElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ClassList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLProgressElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLIElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLResourcePreloader.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TrackEvent.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ImageData.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaDocument.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableColElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDetailsElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkManifest.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/TextFieldInputType.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/TextDocumentParser.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLegendElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/Path2D.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLUnknownElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeFieldElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/RadioNodeList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeSymbolicFieldElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLHtmlElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/RangeInputType.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLParagraphElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLVideoElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLHRElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ImageDocument.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSelectElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableRowElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackContainer.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLKeygenElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeNumericFieldElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/ColorInputType.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOListElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSummaryElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLStyleElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeEditElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLIFrameElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTrackElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElementTypes.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLObjectElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLEmbedElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMenuItemElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameElementBase.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMetaElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/PluginDocument.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlsCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLInputElement.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFieldSetElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLParamElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextFormControlElementTest.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableRowsCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDocument.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameSetElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAreaElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLButtonElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCanvasElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTitleElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLRubyElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaController.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/PublicURLManager.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDataListElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFontElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextFormControlElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLNoEmbedElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLBaseElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableSectionElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMapElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DetailsMarkerControl.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTablePartElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LabelableElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLModElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2DState.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/SliderThumbElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLShadowElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaSource.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPreElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/AudioTrackList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControls.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLWBRElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLBodyElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionsCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeEditElement.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkDefaultPresentation.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TrackListBase.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLNoScriptElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLBRElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElements.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableCaptionElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/FormAssociatedElement.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLContentElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAnchorElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaDocument.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTemplateElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLabelElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/ClearButtonElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLNameCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeFieldElements.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAppletElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaKeyEvent.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLQuoteElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLInputElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMarqueeElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/VideoTrack.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLScriptElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameOwnerElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPictureElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptGroupElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/DateTimeLocalInputType.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ImageDocument.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MeterShadowElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/imports/HTMLImportLoader.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLViewSourceParser.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSourceElement.cpp?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/AudioTrack.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageLoader.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/imports/HTMLImportChild.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/LoadableTextTrack.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/TextControlInnerElements.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/SpinButtonElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LabelsNodeList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/ProgressShadowElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAllCollection.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/PickerIndicatorElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMeterElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextAreaElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLScriptRunner.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLViewSourceDocument.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/imports/HTMLImportTreeRoot.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDivElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/TextDocument.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLRTElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/imports/LinkImport.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableCellElement.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/forms/InputType.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/InbandTextTrack.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/VideoTrackList.h?r1=198376&r2=198375&pathrev=198376
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/PluginDocument.h?r1=198376&r2=198375&pathrev=198376

Fix virtual/override/final usage in Source/core/html/.

- We should specify just one of them to a function.
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1219013005
-----------------------------------------------------------------
Project Member

Comment 491 by bugdroid1@chromium.org, Jul 7 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198377

------------------------------------------------------------------
r198377 | tkent@chromium.org | 2015-07-07T08:33:05.818458Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/DocumentXSLT.cpp?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathPredicate.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathFunctions.cpp?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/parser/XMLDocumentParser.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathVariableReference.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathExpressionNode.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/NativeXPathNSResolver.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathStep.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XSLStyleSheet.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathPath.h?r1=198377&r2=198376&pathrev=198377
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/parser/XMLDocumentParser.cpp?r1=198377&r2=198376&pathrev=198377

Fix virtual/override/final usage in Source/core/xml/.

- We should specify just one of them to a function.
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1224823006
-----------------------------------------------------------------
Project Member

Comment 492 by bugdroid1@chromium.org, Jul 8 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198456

------------------------------------------------------------------
r198456 | tkent@chromium.org | 2015-07-08T04:16:47.346003Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/LinkHighlight.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDOMActivityLogger.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ColorChooserPopupUIController.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/NavigatorContentUtilsClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebHelperPluginTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDevToolsAgentImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ExternalPopupMenu.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/PinchViewportTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/LocalFileSystemClient.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/DragClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/UserMediaClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/FrameLoaderClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ContextFeaturesClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebViewTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeProxy.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebSocketImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PopupMenuImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDataSourceImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PluginPlaceholderImplTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/FrameTestHelpers.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ValidationMessageClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/NotificationPermissionClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPagePopupImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WorkerGlobalScopeProxyProviderImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/DatabaseClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/SpellCheckerClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebFontImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ContextMenuClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebPluginContainerTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/StorageQuotaClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/DateTimeChooserImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/ScrollAnimatorNoneTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/EditorClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/FrameTestHelpers.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebMediaPlayerClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ExternalDateTimeChooser.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebKit.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebSettingsImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ImageDecodeBench.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/PrerenderingTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/SharedWorkerRepositoryClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PluginPlaceholderImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/InspectorOverlayImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/RemoteFrameClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/AssociatedURLLoader.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLeakDetector.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/GeolocationClientProxy.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebFileChooserCompletionImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/SharedWorkerRepositoryClientImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ExternalDateTimeChooser.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/MIDIClientProxy.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/FakeWebPlugin.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebFrameTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLocalFrameImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/StorageClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ExternalPopupMenuTest.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebRemoteFrameImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/GraphicsLayerFactoryChromium.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebTextCheckingCompletionImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/MediaKeysClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ColorChooserUIController.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/PopupMenuImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/IndexedDBClientImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/SpeechRecognitionClientProxy.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/SuspendableScriptExecutor.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/NotificationPermissionClientImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebHelperPluginImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDevToolsFrontendImpl.h?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebLocalFrameImpl.cpp?r1=198456&r2=198455&pathrev=198456
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebSocketChannelClientProxy.h?r1=198456&r2=198455&pathrev=198456

Fix virtual/override/final usage in Source/web/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1230533002
-----------------------------------------------------------------
Project Member

Comment 493 by bugdroid1@chromium.org, Jul 8 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198463

------------------------------------------------------------------
r198463 | tkent@chromium.org | 2015-07-08T04:59:25.823062Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecUTF8.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Float64Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/TypedArrayBase.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecLatin1.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Int8Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Uint32Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecUserDefined.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Uint16Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecReplacement.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Uint8ClampedArray.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecUTF16.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Int32Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Int16Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Uint8Array.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/text/TextCodecICU.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/FilePrintStream.h?r1=198463&r2=198462&pathrev=198463
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Float32Array.h?r1=198463&r2=198462&pathrev=198463

Fix virtual/override/final usage in Source/wtf/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1218293019
-----------------------------------------------------------------
Project Member

Comment 494 by bugdroid1@chromium.org, Jul 8 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198464

------------------------------------------------------------------
r198464 | tkent@chromium.org | 2015-07-08T05:06:53.403069Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDistantLightElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGNumberList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEMergeElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPointList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGCursorElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPatternElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGDescElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEColorMatrixElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedAngle.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPreserveAspectRatio.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGImageElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegListBuilder.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDropShadowElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoCubicAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFESpotLightElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMaskElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEConvolveMatrixElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGradientElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEImageElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGImageLoader.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransformListTearOff.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedColor.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoHorizontalRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGRadialGradientElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegArcRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEMorphologyElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFECompositeElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimationElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFESpecularLightingElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMetadataElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTSpanElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGeometryElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEPointLightElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGUseElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoHorizontalAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGRectElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegArcAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSVGElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStaticStringList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStyleElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathByteStreamSource.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGClipPathElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateMotionElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLength.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedIntegerOptionalInteger.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPoint.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEMergeNodeElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEComponentTransferElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathBuilder.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSVGElement.cpp?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathStringSource.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/graphics/filters/SVGFEImage.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGEllipseElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegListSource.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEBlendElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGEnumeration.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedNumber.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTitleElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMarkerElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFELightElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAngleTearOff.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedNumberOptionalNumber.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGScriptElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/graphics/SVGImage.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGDiscardElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedEnumerationBase.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathTraversalStateBuilder.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextContentElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathStringBuilder.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/animation/SVGSMILElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFilterElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLineElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathByteStreamBuilder.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGNumberOptionalNumber.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransformList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGUnknownElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGBoolean.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGIntegerOptionalInteger.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMPathElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/properties/SVGAnimatedProperty.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextContentElement.cpp?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGViewElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/properties/SVGPropertyTearOff.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGComponentTransferFunctionElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/animation/SVGSMILElement.cpp?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGForeignObjectElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/graphics/SVGImageForContainer.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGInteger.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegClosePath.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedInteger.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDiffuseLightingElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGString.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGraphicsElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEOffsetElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextPositioningElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFETileElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAngle.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGZoomEvent.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGNumber.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGDefsElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDisplacementMapElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/graphics/filters/SVGFilter.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFETurbulenceElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGRect.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimatedPath.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoVerticalRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoQuadraticRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSetElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSwitchElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransform.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSymbolElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransformTearOff.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateTransformElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEGaussianBlurElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoVerticalAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoQuadraticAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegMovetoRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEFloodElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegLinetoAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPolyElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStopElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStringList.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLinearGradientElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGCircleElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegMovetoAbs.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextPathElement.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathSegCurvetoCubicRel.h?r1=198464&r2=198463&pathrev=198464
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLengthList.h?r1=198464&r2=198463&pathrev=198464

Fix virtual/override/final usage in Source/core/svg/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1212253012
-----------------------------------------------------------------
Project Member

Comment 495 by bugdroid1@chromium.org, Jul 8 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198474

------------------------------------------------------------------
r198474 | tkent@chromium.org | 2015-07-08T06:52:48.951963Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeAura.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FilterOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/BitmapImage.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeOverlayMock.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/gpu/DrawingBuffer.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/Timer.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEComposite.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/DisplayItemListTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/CachedDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mediastream/MediaStreamCenter.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/SincResampler.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollAnimatorNone.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/geometry/FloatPolygon.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/RotateTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/AudioDSPKernelProcessor.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/BitmapPattern.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mac/ScrollAnimatorMac.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/animation/TimingFunction.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebScrollbarThemeClientImpl.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/TestingPlatformSupport.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/blob/BlobRegistry.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebScrollbarThemeGeometryNative.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/RecordingImageBufferSurface.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/DistantLightSource.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/MultiChannelResampler.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FETurbulence.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/weborigin/KURL.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/FloatClipDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebURLRequest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEDiffuseLighting.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/test/MockImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/ScaleTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/IdentityTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/FilterDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/BitmapPatternBase.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/SpotLightSource.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/PointLightSource.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/DrawingDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scheduler/CancellableTaskFactory.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FETile.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mac/ThemeMac.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FELighting.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/AudioDelayDSPKernel.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/PODArena.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/Canvas2DLayerManager.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/CrossfadeGeneratedImage.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/PerspectiveTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/UserGestureIndicator.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/StereoPanner.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/Canvas2DImageBufferSurface.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebPrerender.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mediastream/MediaStreamComponent.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/Canvas2DLayerBridge.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeMock.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEMorphology.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/LoggingCanvas.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/DecodingImageGenerator.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/LineEnding.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeMacCommon.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/DisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/Task.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEConvolveMatrix.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/DeferredImageDecoderTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/FixedPositionDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/heap/glue/MessageLoopInterruptor.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeOverlay.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEBlend.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/PODIntervalTree.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeNonMacCommon.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/PicturePattern.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/ReferenceFilter.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/GraphicsLayerDebugInfo.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/Scrollbar.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/plugins/PluginListBuilder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEMerge.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/Transform3DDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/PlatformLocale.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/ico/ICOImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEColorMatrix.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FESpecularLighting.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/heap/Heap.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/TransformDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/bmp/BMPImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/ImageFrameGenerator.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/LocaleWin.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/ContentLayerDelegate.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/UnacceleratedImageBufferSurface.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/InterpolatedTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/credentialmanager/PlatformPasswordCredential.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/FixedPositionContainerDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/TranslateTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RefCountedSupplement.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/TimerTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/gpu/DrawingBufferTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/GradientGeneratedImage.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEGaussianBlur.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/heap/GarbageCollected.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/ClipPathDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/heap/MarkingVisitor.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/heap/HeapTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/SegmentedFontData.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/mediastream/MediaStreamWebAudioSource.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/SubtreeDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEDisplacementMap.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/JSONValues.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEDropShadow.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/SimpleFontData.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/AudioDestination.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/LocaleMac.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebURLResponse.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/ClipDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/SourceAlpha.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/LocaleICU.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/SkewTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/testing/ArenaTestHelpers.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/StaticBitmapImage.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/credentialmanager/PlatformFederatedCredential.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/EqualPowerPanner.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEComponentTransfer.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/GlyphPageTreeNodeTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/ImageFrameGeneratorTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/GeneratedImage.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/png/PNGImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEOffset.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/BitmapImageTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/CompositingDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/FontCacheTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/paint/ScrollDisplayItem.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/MatrixTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/StaticBitmapPattern.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/text/DateTimeFormatTest.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/FEFlood.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/webp/WEBPImageDecoder.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/ImageDecodingStore.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/GraphicsLayer.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebScrollbarImpl.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/TracedValue.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/exported/WebMediaStreamSource.cpp?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/GlyphPageTreeNode.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/graphics/filters/SourceGraphic.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/transforms/Matrix3DTransformOperation.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/HRTFPanner.h?r1=198474&r2=198473&pathrev=198474
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/image-decoders/gif/GIFImageDecoder.h?r1=198474&r2=198473&pathrev=198474

Fix virtual/override/final usage in Source/platform/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1213003004
-----------------------------------------------------------------
Project Member

Comment 496 by bugdroid1@chromium.org, Jul 9 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198581

------------------------------------------------------------------
r198581 | tkent@chromium.org | 2015-07-09T07:29:11.965604Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/DocumentResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/MemoryCacheTest.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xmlhttprequest/XMLHttpRequest.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/WorkerThreadableLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/WorkerLoaderClientBridge.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ImageResourceClient.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/LinkLoaderTest.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/RawResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/MockImageResourceClient.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/appcache/ApplicationCacheHost.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/appcache/ApplicationCache.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/CSSStyleSheetResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/SinkDocument.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ScriptResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/TextTrackLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/FontResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ResourceLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/streams/Stream.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xmlhttprequest/XMLHttpRequest.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ImageLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameFetchContext.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/XSLStyleSheetResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ImageResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/TextResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/MemoryCache.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/RawResourceTest.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoaderClient.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameLoaderClient.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xmlhttprequest/XMLHttpRequestUpload.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/StyleSheetResourceClient.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/LinkLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/PingLoader.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/DocumentResourceReference.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/NavigationScheduler.cpp?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/LinkFetchResource.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/PrerenderHandle.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/SinkDocument.h?r1=198581&r2=198580&pathrev=198581
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h?r1=198581&r2=198580&pathrev=198581

Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.
- Also replace { } with {} for updated lines to align with Chromium style.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1229743005
-----------------------------------------------------------------
Project Member

Comment 497 by bugdroid1@chromium.org, Jul 10 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198647

------------------------------------------------------------------
r198647 | tkent@chromium.org | 2015-07-10T01:44:40.934003Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8AbstractEventListener.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8MutationCallback.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptValueSerializer.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/CallbackPromiseAdapter.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8Initializer.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8BindingForTesting.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8LazyEventListener.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8ErrorHandler.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8GCController.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptPromiseResolver.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8Binding.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8StringResource.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptPromiseTest.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ExceptionState.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/tests/results/core/V8TestCallbackInterface.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ExceptionStatePlaceholder.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptStreamerTest.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptStreamer.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptProfiler.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptWrappable.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8EventListener.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8ScriptRunnerTest.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptPromiseProperty.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/modules/v8/ScriptValueSerializerForModules.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptHeapSnapshot.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8NodeFilterCondition.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/templates/callback_interface.h?r1=198647&r2=198646&pathrev=198647
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h?r1=198647&r2=198646&pathrev=198647

Fix virtual/override/final usage in Source/bindings/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1236473002
-----------------------------------------------------------------
Project Member

Comment 498 by bugdroid1@chromium.org, Jul 10 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198662

------------------------------------------------------------------
r198662 | tkent@chromium.org | 2015-07-10T05:43:10.062099Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DirectoryReaderSync.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXInlineTextBox.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLCompressedTextureETC1.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBObjectStore.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AnalyserNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/presentation/DefaultSessionStartEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/SimpleContentDecryptionModuleResultPromise.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStream.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediasource/SourceBuffer.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/RespondWithObserver.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/credentialmanager/CredentialsContainer.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DirectoryReaderSync.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXScrollbar.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/CacheStorage.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/SyncCallbackHelper.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/SQLTransactionBackend.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/crypto/CryptoResultImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIConnectionEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/quota/StorageQuotaCallbacksImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLRenderingContextBase.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXMenuListPopup.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioDestinationNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIMessageEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/EXTsRGB.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/RTCStatsResponse.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/UserMediaRequest.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBTransactionTest.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLCompressedTexturePVRTC.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/testing/GeolocationClientMock.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXTableRow.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediasource/MediaSource.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerRegistration.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/FetchEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/FileSystemCallbacks.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/OESVertexArrayObject.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/DatabaseTracker.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStreamRegistry.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/compositorworker/CompositorWorkerMessagingProxy.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXMenuList.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/OscillatorNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIAccessor.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaDevicesRequest.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/presentation/PresentationSession.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/RTCDTMFToneChangeEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/MediaKeyMessageEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/screen_orientation/ScreenOrientationDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerThread.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/DOMWebSocket.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/RTCVoidRequestImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/EventModulesFactory.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/ChannelSplitterNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/DelayDSPKernel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLDebugRendererInfo.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DirectoryReader.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/InspectorDatabaseAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/crypto/CryptoResultImpl.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStreamTrackEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/StashedMessagePort.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/GainNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXSVGRoot.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLLoseContext.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStreamEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/background_sync/SyncEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/DOMWebSocketTest.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLRenderingContextBase.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXMockObject.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXTable.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBCursorWithValue.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/screen_orientation/LockOrientationCallback.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/crypto/KeyAlgorithm.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXMediaControls.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioNodeInput.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/OESTextureHalfFloat.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/DynamicsCompressorNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediasource/MediaSourceRegistry.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/DatabaseManager.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/FileWriterSync.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/gamepad/GamepadEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/OfflineAudioCompletionEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/FileWriter.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXSlider.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/gamepad/GamepadDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DirectoryEntrySync.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/compositorworker/CompositorWorkerThread.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXScrollView.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/DefaultAudioDestinationNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGL2RenderingContextBase.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioBufferSourceNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/DocumentWebSocketChannel.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/vr/VRController.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/MediaStreamAudioDestinationNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/quota/StorageErrorCallback.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediasource/SourceBufferList.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/MediaKeySession.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/push_messaging/PushEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXListBoxOption.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLCompressedTextureATC.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioBasicInspectorNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/permissions/PermissionQueryCallback.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLContextEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/InspectorFileSystemAgent.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStreamTrack.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/WorkerWebSocketChannel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXTableHeaderContainer.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/screen_orientation/ScreenOrientation.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/RespondWithObserver.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/DocumentWebSocketChannel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/compositorworker/CompositorWorkerGlobalScope.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXObjectCacheImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/InitModules.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/vibration/NavigatorVibration.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/storage/StorageEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/ChannelMergerNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/DocumentWebSocketChannelTest.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXLayoutObject.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/cachestorage/InspectorCacheStorageAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXNodeObject.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/presentation/PresentationAvailabilityCallback.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXListBox.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/RTCDataChannel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/SQLTransaction.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIPort.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXMenuListOption.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerContainer.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/WaveShaperDSPKernel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/AudioParam.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/MediaKeySession.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/MediaEncryptedEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/DelayProcessor.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBRequest.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DOMFileSystemSync.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLCompressedTextureS3TC.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLDepthTexture.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorker.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/MediaKeys.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webdatabase/DatabaseContext.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/BiquadDSPKernel.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXImageMapLink.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/InspectorFileSystemAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/websockets/CloseEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/accessibility/AXProgressIndicator.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/InspectorIndexedDBAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/NavigatorServiceWorker.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/FileEntry.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/fetch/Body.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIAccessInitializer.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLProgram.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/StashedPortCollection.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/presentation/PresentationSessionClientCallbacks.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/WebGLDrawBuffers.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/OESTextureFloat.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/mediastream/RTCDTMFSender.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/MediaElementAudioSourceNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/EXTTextureFilterAnisotropic.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBVersionChangeEvent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/MediaStreamAudioSourceNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/filesystem/DirectoryReader.cpp?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/gamepad/NavigatorGamepad.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBDatabase.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/StereoPannerNode.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/storage/InspectorDOMStorageAgent.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webmidi/MIDIInput.h?r1=198662&r2=198661&pathrev=198662
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webgl/O
Project Member

Comment 499 by bugdroid1@chromium.org, Jul 13 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198745

------------------------------------------------------------------
r198745 | tkent@chromium.org | 2015-07-13T02:17:33.919633Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/ConstantStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImportRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/ContentData.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/IntegerSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableDouble.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/RectSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/KeyframeStyleRuleCSSStyleDeclaration.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCrossfadeValue.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StylePendingImage.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RemoteFontFaceSource.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontFaceRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/CSSValueInterpolationType.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableClipPathOperation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableShadow.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/PathStyleMotionPath.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/DoubleStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFaceSet.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/SVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/StyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/InterpolableValueTest.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/IntegerOptionalIntegerSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableValueKeyframe.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/ImageStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFaceSetLoadEvent.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryListEvent.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/SVGStrokeDasharrayStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/KeyframeEffect.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/PrimitiveInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/VisibilityStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/CompositorAnimationsTestHelper.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/PathSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRuleList.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/LengthPairStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AnimationEffectTest.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSMediaRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/ImageSliceStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableImage.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/InertEffect.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/DeferredLegacyStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleGeneratedImage.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableFilterOperations.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryListTest.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleSheet.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/ColorStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/LengthSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/LengthStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/DefaultSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSKeyframeRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableRepeatable.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/NumberSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPageRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableTransform.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontSelector.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableColor.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCanvasValue.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRuleImport.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/NumberOptionalNumberSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSKeyframesRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/KeyframeEffectModel.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableVisibility.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/ListStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AnimationTimeline.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableSVGPaint.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLengthPoint.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSBasicShapes.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableShapeValue.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCalculationValue.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSupportsRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/PropertySetCSSStyleDeclaration.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableUnknown.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryList.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleSheet.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/BinaryDataFontFaceSource.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AngleSVGInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/LengthBoxStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleFetchedImageSet.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableDoubleAndBool.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableNeutral.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLengthSize.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSViewportRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/LocalFontFaceSource.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/StringKeyframe.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLength.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/LegacyStyleInterpolation.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLengthPoint3D.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFace.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/InterpolationEffectTest.cpp?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/css/CSSAnimations.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGroupingRule.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/animatable/AnimatableLengthBox.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/BasicShapes.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleFetchedImage.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFaceSet.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCustomFontData.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/InterpolableValue.h?r1=198745&r2=198744&pathrev=198745
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/Animation.h?r1=198745&r2=198744&pathrev=198745

Fix virtual/override/final usage in Source/core/{animation,css,style}/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1226293002
-----------------------------------------------------------------
Project Member

Comment 500 by bugdroid1@chromium.org, Jul 13 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198748

------------------------------------------------------------------
r198748 | tkent@chromium.org | 2015-07-13T04:46:27.427803Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/line/TrailingFloatsRootInlineBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMultiColumnFlowThread.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/shapes/PolygonShape.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGInline.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGForeignObject.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFlowThread.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutPagedFlowThread.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMenuList.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBoxModelObject.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGViewportContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/line/SVGRootInlineBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/line/SVGInlineTextBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/shapes/RasterShape.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFrameSet.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGModelObject.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutThemeDefault.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutView.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/FloatingObjects.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutScrollbarPart.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutRubyBase.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutInline.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutCounter.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTestHelper.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextCombine.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutImage.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTableCol.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFileUploadControl.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutSliderContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutRubyText.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTableCell.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutDetailsMarker.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutListItem.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/ImageQualityControllerTest.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutQuote.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/shapes/BoxShape.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceRadialGradient.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGImage.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGInlineText.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBR.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGTSpan.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTableCaption.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/compositing/DeprecatedPaintLayerCompositor.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutObject.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutVideo.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutScrollbarTheme.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextControlMultiLine.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextFragment.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/line/InlineFlowBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMeter.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGRect.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutListMarker.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutReplica.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutEmbeddedObject.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGGradientStop.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutScrollbar.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutDeprecatedFlexibleBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutText.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutListBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/line/EllipsisBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/line/SVGInlineFlowBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/ClipPathOperation.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/TableLayoutAlgorithmAuto.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTable.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourcePaintServer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBlock.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFrame.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFieldset.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutHTMLCanvas.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutPartTest.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGRoot.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFullScreen.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFlexibleBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutIFrame.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceMarker.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGBlock.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/shapes/RectangleShape.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutVTTCue.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGPath.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGEllipse.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutImageResourceStyleImage.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMedia.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutText.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutThemeLinux.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutSlider.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMultiColumnSet.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutGrid.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextControl.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceClipper.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFullScreen.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextControlSingleLine.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGText.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutThemeAndroid.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourcePattern.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutProgress.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutRubyRun.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutPart.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutSearchField.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceMasker.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTestHelper.cpp?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutButton.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTextTrackContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceFilter.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTableSection.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGHiddenContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/TableLayoutAlgorithmFixed.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutTableRow.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutReplaced.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGShape.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGTextPath.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutWordBreak.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGTransformableContainer.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutRuby.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutSliderThumb.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBlockFlow.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutThemeMac.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/svg/LayoutSVGResourceGradient.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/line/RootInlineBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/line/InlineTextBox.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutApplet.h?r1=198748&r2=198747&pathrev=198748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/MultiColumnFragmentainerGroupTest.cpp?r1=198748&r2=198747&pathrev=198748

Fix virtual/override/final usage in Source/core/layout/.

- We should specify just one of them to a function.
  This was done by the following command.
  % sed -i "" -E "s/virtual (.*) final/\1 final/g;
    s/virtual (.*) override/\1 override/g;
    s/override final/final/g" <files>
- Non-base virtual destructors should have |override| keywords.

This CL has no behavior changes.

BUG=417463

Review URL: https://codereview.chromium.org/1231363003
-----------------------------------------------------------------
Project Member

Comment 501 by bugdroid1@chromium.org, Jul 13 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=198760

------------------------------------------------------------------
r198760 | tkent@chromium.org | 2015-07-13T08:54:34.968783Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py?r1=198760&r2=198759&pathrev=198760
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py?r1=198760&r2=198759&pathrev=198760

check-webkit-style: Detect redundant usage of virtual/override/final.

Import CheckRedundantVirtual() and CheckRedundantOverrideOrFinal from cpplint.py.
https://github.com/google/styleguide/blob/gh-pages/cpplint/cpplint.py#L5747

BUG=417463

Review URL: https://codereview.chromium.org/1232373002
-----------------------------------------------------------------
Completed for Blink.

Status: Fixed
Showing comments 404 - 503 of 503 Older

Sign in to add a comment