New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 303152

Blocking:
issue 455093



Sign in to add a comment

Support URLSearchParams in Response ctor

Project Member Reported by dmu...@chromium.org, Sep 8 2014

Issue description

We need to support (ArrayBuffer or ArrayBufferView or Blob or FormData or ScalarValueString or URLSearchParams)
 
Status: Started
Request support already implemented here:
https://codereview.chromium.org/516603004

Comment 5 by jsb...@chromium.org, Sep 10 2014

Blockedon: chromium:303152
Nice!

So we're missing:

Response / FormData - See https://github.com/slightlyoff/ServiceWorker/issues/449

Response / URLSearchParams - Blink doesn't implement URL fully yet -  issue 303152  (adding that as a blocker)
Also, the Response() ctor's BodyInit param is supposed to be optional.
... and we currently support new Response(null) for some reason, which shouldn't be allowed (or should turn into "null")

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 11 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185051

------------------------------------------------------------------
r185051 | jsbell@chromium.org | 2014-11-10T17:57:35.054890Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Response.cpp?r1=185051&r2=185050&pathrev=185051
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Response.h?r1=185051&r2=185050&pathrev=185051
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/Response.idl?r1=185051&r2=185050&pathrev=185051
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js?r1=185051&r2=185050&pathrev=185051
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/serviceworker/resources/response-content-worker.js?r1=185051&r2=185050&pathrev=185051

Service Workers/Fetch: Fix Response constructor for empty/null

The fetch spec[1] has the body parameter of the Response constructor
marked optional, and none of the accepted types are nullable. In contrast,
the Blink implementation supported passing null but required an argument.
Make the impl match the spec.

[1] https://fetch.spec.whatwg.org

BUG= 412027 

Review URL: https://codereview.chromium.org/701683005
-----------------------------------------------------------------
Labels: Release-notes
Cc: dmu...@chromium.org hirosh...@chromium.org
Labels: -Cr-Blink-ServiceWorker -Release-notes Cr-Blink-Fetch
Owner: ----
Status: Available
Summary: Support URLSearchParams in Response ctor (was: Full type construction support for Response & Request)
Response / FormData was added in https://chromium.googlesource.com/chromium/blink/+/61f2a596932ab58f8690b723cea3e634a13b3595%5E%21/Source/modules/fetch/Response.idl

So I think the remaining work is just URLSearchParams. Retitling and relabeling.
Blocking: chromium:455093
Labels: -Cr-Blink-Fetch Cr-Blink-FetchAPI

Comment 14 by tkent@chromium.org, Nov 27 2015

Labels: -Cr-Blink-FetchAPI Cr-Blink-Network-FetchAPI
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 10 2016

Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-OpenBugWithCL
Since it is blocking and has blocked on issues , removing Hotlist-OpenBugWithCL label.
Owner: eero.hak...@intel.com
Status: Started (was: Available)
Status: Fixed (was: Started)
URLSearchParams was the last one of (ArrayBuffer or ArrayBufferView or Blob or FormData or ScalarValueString or URLSearchParams) which were to be supported. Closing accordingly.
Labels: M-54
The last one, URLSearchParams support is planned to be included from M54

Sign in to add a comment