New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 40996 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Options > Basics > Home page > Open this page: URL can be mangled

Reported by mberkowitz@chromium.org, Apr 9 2010

Issue description

Chrome Chrome 5.0.371.0 (Official Build 43900)
OS: Win XP

What steps will reproduce the problem?
--------------------------------------
1. Go to options > Basics > Home page.
2. Clear the "Open this page:" text field.
3. Enter "http://" in the field.
4. Close, reopen the Options dialog.

What is the expected output?
----------------------------
Invalid URL string was entered, so URL field should probably be blank.

What do you see instead?
------------------------
URL string is "http://http/".
Similarly, if you clear the field and enter "https://" or "ftp://", you get 
"http:/ftp/" or "http://https/".

 

Comment 1 by ben@chromium.org, Apr 22 2010

Labels: Mstone-X HelpWanted Fixit
Status: Available

Comment 2 by weinja...@gmail.com, May 23 2010

This bug appears to happen because each keystroke is committed to the preferences. When 
the user enters in the colon and slashes, they URL is now an invalid URL and it is not committed.

http://ftp/ and http://https/ show up because URLFixerUpper::FixupURL has interpreted 
the raw 'ftp' and 'https' as hostnames and assigned them a generic scheme of http.

This bug will _not_ be reproduced by pasting "http://" in the textbox over a valid URL 
like "http://www.google.com". There must be an event where the URL *might* be valid 
(such as entering in the scheme as separate keystrokes).

I have a patch ready to submit.
Labels: OS-Linux
The same thing happens on 6.0.413.0 (47980) Ubuntu. So marking this OS-Linux too.

Comment 4 by weinja...@gmail.com, May 24 2010

There is a codereview available at: http://codereview.chromium.org/2102019/show

Comment 5 by mhm@chromium.org, May 26 2010

Status: Fixed
Fixed by Jared! Thanks!

Comment 6 by mhm@chromium.org, May 26 2010

Labels: -OS-Linux OS-All

Comment 7 by bugdro...@gmail.com, May 26 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=48270 

------------------------------------------------------------------------
r48270 | mhm@chromium.org | 2010-05-26 05:55:19 -0700 (Wed, 26 May 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS?r1=48270&r2=48269
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/preferences_window_controller.mm?r1=48270&r2=48269
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/general_page_gtk.cc?r1=48270&r2=48269
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/general_page_gtk.h?r1=48270&r2=48269
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/general_page_view.cc?r1=48270&r2=48269
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/general_page_view.h?r1=48270&r2=48269

Invalid URLs are no longer mangled when reopening the Options window.

If the homepage URL is changed to an invalid URL, the homepage preference is swapped to a blank URL and NTP is shown.

BUG= 40996 
TEST=Set homepage to http://www.google.com, close Chromium, restart Chromium and see homepage set to http://www.google.com. Set homepage to http://, close Chromium, restart Chromium and see homepage set to New Tab Page.

Patch by Jared Wein <weinjared@gmail.com>

Review URL: http://codereview.chromium.org/2102019
------------------------------------------------------------------------

Labels: -Fixit bulkmove TaskForce-Fixit
Chrome Chrome 5.0.371.0 (Official Build 43900)
OS: Win XP

What steps will reproduce the problem?
--------------------------------------
1. Go to options &gt; Basics &gt; Home page.
2. Clear the &quot;Open this page:&quot; text field.
3. Enter &quot;http://&quot; in the field.
4. Close, reopen the Options dialog.

What is the expected output?
----------------------------
Invalid URL string was entered, so URL field should probably be blank.

What do you see instead?
------------------------
URL string is &quot;http://http/&quot;.
Similarly, if you clear the field and enter &quot;https://&quot; or &quot;ftp://&quot;, you get 
&quot;http:/ftp/&quot; or &quot;http://https/&quot;.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Area-UI Cr-UI

Sign in to add a comment