Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 407399 [META] Remove LKGR
Starred by 7 users Project Member Reported by eseidel@chromium.org, Aug 25 2014 Back to list
Status: Assigned
Owner:
Cc:
Components:
NextAction: ----
OS: All
Pri: 2
Type: Bug


Sign in to add a comment
As discussed in:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/lkgr/chromium-dev/e4lQRKYbRJY/zNebDVTEuwcJ

We're interested in removing LKGR for Chromium.  This is the bug to track that work.  Please relate any issues blocking this removal.
 
Blockedon: chromium:407401
Blockedon: chromium:407402
Blocking: chromium:407381
Comment 4 by ojan@chromium.org, Aug 25 2014
Cc: cmp@chromium.org
I had a recent discussion with someone who actually uses LKGR locally that made me wonder if we should take a different approach. Keep LKGR, but have it mean something similar to what it means for the canaries. Instead of the last green revision, it grabs the best revision of the last 40. And it updates every 30 minutes.

This bot would be relatively easy to maintain I think and would not require anyone to change their workflows.
I totally agree with Ojan in #4 and also gives us consistency on when we can expect build. 
That's fine.  But what is "best" defined as?  Across which bots does it check?  Presumably we could build a generic infrastructure for this and allow people to consume it with different sets of bots.  However it's not clear how you compare a build with 100 layouttest failures vs. one with 1 ASAN failure, etc.  I suspect those comparisons differ between use-cases.

My interest in this bug is about freeing our infrastructure team to forget some of our past mistakes and free their time to focus on better future projects.  With so few consumers of LKGR and so much code/infrastructure to maintain it, it seems like a very poor trade of our capacity and infrastructure-engineer resources.
Blockedon: chromium:414906
Comment 8 by ojan@chromium.org, Oct 17 2014
Once issue 407402 is resolved, we can change the lkgr waterfall to actually pull lkcr and then we can kill lkgr. We can't kill the lkgr waterfall, because those bots actually do things. But, we won't need to maintain lkgr and deal with it getting behind.
Labels: TE-NeedsFurtherTriage
Cc: -cmp@chromium.org infe...@chromium.org dtu@chromium.org iannucci@chromium.org mar...@chromium.org nednguyen@chromium.org aneeshm@chromium.org phajdan.jr@chromium.org aga...@chromium.org
Labels: -TE-NeedsFurtherTriage Te-NeedsFurtherTriage
Owner: dpranke@chromium.org
Status: Assigned
I think we need to finally get around to doing this as part of the recipe migration and the GN migration.

It looks like there's three classes of bots:

- bots whose sole purpose is to build at lkgr. We should just remove these.
- the telemetry upload harness bot. We should just move this to trunk (bug 407402)
- the clusterfuzz bots. We should move this to trunk and write a recipe
  that only uploads the builds to the bucket after we run and pass some list of
  tests (bug 407401)
Cc: och...@chromium.org mbarbe...@chromium.org
Sounds good, thanks Dirk. Yes each bot can individually run the tests and hence wont be blocked on a revision.
This sounds good to me.

I started converting this waterfall to recipes some days ago, but left it on the backburner after a preliminary inspection because I couldn't replicate some builders' steps locally.

Which bots are going to be deleted? If I know this, I can skip them when converting the rest to recipes. (The recipe can be used even after the bots switch masters, so I'm planning to go ahead with the conversion.)
@aneeshm - I'm deleting the bots in https://codereview.chromium.org/1813123002/ .

I don't know that we'll want to land your conversion, but it would probably be at least helpful to me in converting things to proper recipes (whether we use the chromium recipe as a basis or, more likely, write new ones), so make sure you keep me involved in whatever you end up doing.
Project Member Comment 14 by bugdroid1@chromium.org, Mar 18 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ffe53a8970e65115b9d1721b46930f157302f0ee

commit ffe53a8970e65115b9d1721b46930f157302f0ee
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Fri Mar 18 21:12:52 2016

Remove non-clusterfuzz, non-telemetry LKGR bots.

We don't need and don't want to support them any more.

R=maruel@chromium.org
BUG=407399

Review URL: https://codereview.chromium.org/1813123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299390 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/ffe53a8970e65115b9d1721b46930f157302f0ee/masters/master.chromium.lkgr/master_lkgr_cfg.py
[modify] https://crrev.com/ffe53a8970e65115b9d1721b46930f157302f0ee/masters/master.chromium.lkgr/slaves.cfg

Labels: -Pri-2 Pri-3
Components: -Infra Infra>Client>Chrome
Labels: -TE-NeedsFurtherTriage TE-NeedsFurthertriage OS-All
Comment 18 by dpranke@chromium.org, Jan 15 (4 days ago)
Labels: -Pri-3 Pri-2
Sign in to add a comment