New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 362794



Sign in to add a comment

Change topsites warning to a less generic string

Project Member Reported by meacer@chromium.org, Aug 16 2014 Back to list

Issue description

Context: https://code.google.com/p/chromium/issues/detail?id=362794#c17

We should change topSites warning from "Read your browsing history" to something like "Read a list of 20 sites you visit most frequently" (grammar?)

 

Comment 1 by meacer@chromium.org, Aug 16 2014

Cc: meacer@chromium.org
Status: Available

Comment 2 by meacer@chromium.org, Aug 16 2014

Blocking: chromium:362794

Comment 3 by t...@yort.com, Aug 16 2014

+1 for this change and that wording +- grammar. Maybe "Read a list of the 20 sites you most frequently visit". It's wordy but clear.

Comment 4 by kalman@chromium.org, Aug 18 2014

Cc: jyasskin@chromium.org
SGTM.

(but we should continue to suppress this warning if the history and/or tabs permissions are requested.)

<grammar bikeshed>

I'm not sure if "20" is overly specific, and whether you could just stop at "most frequent". "Read a list of your most frequently visited websites". The word "list" puts me off a bit. Perhaps "Locate your most frequently visited websites"? "Find your most frequently visited websites"? "Track your most frequently visited websites"?

(I'm staying away from "access" and similar words because that sounds too much like content scripts).

</grammar bikeshed>

Jeffrey, any advice on wording?

Comment 5 by t...@yort.com, Aug 18 2014

I'd be SGTM too if it wasn't for the end users who ask the question this aims to resolve :)

I'll raise a problem with those that I think trumps any grammar justification: they're not clear. None of the examples you gave are actually going to make the user realize what access this has. They're all going to make a user think it has way more access than it does.

A description like "Locate your most frequently visited websites" or "Track your most frequently visited websites" isn't much better than what's there now, because a user is going to incorrectly assume that an extension has some access to at least visit count, if not history. (I'd actually argue they sort of say that, and the user's not assuming much, but that's a question of interpretation.)

Imagine that you know nothing about an extension and you've never seen or heard of a manifest. "Track your most frequently visited websites" makes it seem like the extension is tracking your site visits. I think omitting the 20 leaves so much to the imagination that there's no other short factual description.

Without the 20, the only other clear, short description I can come up with is explaining it in terms people already know: the new tab page. "Obtain the addresses of most frequently visited sites (as shown on new Chrome tabs)."

Comment 6 by meacer@chromium.org, Aug 18 2014

Feel free to bikeshed on the CL :) https://codereview.chromium.org/482953003/ (I used "Read a list of your most frequently visited websites" tentatively)

Comment 7 by meacer@chromium.org, Aug 18 2014

Cc: -meacer@chromium.org
Owner: meacer@chromium.org
Status: Started

Comment 8 by kalman@chromium.org, Aug 18 2014

#5 I see your points. I think that including "a list" in the wording does mitigate the problem of sounding like it tracks site visits. I can't think of a solid reason why it shouldn't be "20" besides brevity. Like I said... just seems oddly specific.

Comment 9 by t...@yort.com, Aug 18 2014

#8 I agree. I think the oddness is worthwhile here though, because this permission is sort of odd.

To combine what I like about everything so far, how about: "Obtain a list of your 20 most frequently visited websites"

It doesn't feel as awkward as the others which had a number, but is also really direct. I used "Obtain" instead of "Read" because I think it's clearer about what's happening - and that no HTML or cookie data can be read - but I could see either word working.

#6 I continued this here since it felt weird to just up and move it. Feel free to tell me otherwise :)
I actually thought about "obtain", but was wondering whether it matters that it sounds like that's a once-off type thing. I like it other than that.
Status: Fixed
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4429e8a296c8898d5c48702bf0361b03233919a

commit a4429e8a296c8898d5c48702bf0361b03233919a
Author: meacer <meacer@chromium.org>
Date: Sat Aug 30 02:03:15 2014

Remove implicit conversion from scoped_refptr to T*

BUG= 404334 

Review URL: https://codereview.chromium.org/522053002

Cr-Commit-Position: refs/heads/master@{#292757}

[modify] https://chromium.googlesource.com/chromium/src.git/+/a4429e8a296c8898d5c48702bf0361b03233919a/chrome/common/extensions/permissions/permission_set_unittest.cc

Sign in to add a comment