Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 68 users
Status: Fixed
Owner: ----
Closed: Sep 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature
KDE

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
Add possibility to use KDE's file dialog when saving/opening files
Reported by piotrek....@gmail.com, Mar 31 2010 Back to list
Chrome Version (from the about:version page):
Is this the most recent version:
OS + version:
CPU architecture (32-bit / 64-bit):
Window manager:
URLs (if relevant):
Behavior in Linux Firefox:It is possible to set the browser to use "native" 
file dialog
Behavior in Windows Chrome (if you have access to it):

What steps will reproduce the problem?
1.
2.
3.

What is the expected result?
If we set the browser to ask where it wants to save the file add 
possibility to use native (KDE) file dialog instead of gtk file dialog

What happens instead?
It is using gtk's file dialog.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

 
I think when you set it to use the "native" dialog in firefox, it uses gnome, 
otherwise it uses XUL; AFAIK there is no way to get KDE. I think to get the kde file 
picker, we'd have to depend on KDE packages, which is a no-go
Comment 2 by evan@chromium.org, Apr 2 2010
Labels: -Area-Undefined -Type-Bug Area-UI Type-Feature Pri-3 KDE Mstone-X
Status: Available
We could shell out to
  kdialog --attach --getopenfilename
hmm, that is interesting
Comment 4 by evan@chromium.org, Apr 2 2010
Really shoulda done a summer of code project for better KDE integration.  :\
Well i was mistaken about the "native" file dialog, i should be more specific about 
that. When using Firefox it is possible to use KDE's file dialog and not XUL or GNOME 
file dialog. It shouldn't be hard as firefox doesn't depend on KDE at all while it is 
still possible to use KDE's file dialog. It is near perfect now, using qtcurve makes 
gtk apps (chromium) look like KDE but the file dialog shows the true nature of 
chromium ;) 
Comment 6 by evan@chromium.org, Apr 4 2010
 Issue 40356  has been merged into this issue.
Comment 7 by pablo...@gmail.com, May 5 2010
You don't have to depend on KDE packages. You could make another optional package
which uses KDE and Qt (named like "khromium" :D), just like Ubuntu's kmozillahelper
package.
Comment 8 by mity...@gmail.com, Jun 22 2010
To use native Open, Save, Print dialogs, you don't need KDE dependenties. You can just use Qt dialogs (they look just as KDE dialogs).
Gtk dialogs really confuse KDE users (ie there's a double-click instead of single).
Comment 9 by evan@chromium.org, Jun 22 2010
Labels: HelpWanted
please implement this...
Comment 11 by obey...@gmail.com, Jul 5 2010
It could be whery nice feature.
Comment 12 by mity...@gmail.com, Jul 8 2010
Opera 10.60 can do so. It uses Gtk dialogs by default, Qt dialogs can be turned on in preferences.
I use KDE and Opera 10.60 automatically use KDE file dialog. Even Firefox (at least on openSUSE) already have further integration with KDE.
Comment 14 by mity...@gmail.com, Jul 8 2010
misbachul.munir, Most linux distros have an extension for XULRunner to use Qt dialogs. Chromium is not so customizable, so we need Qt support in "vanilla" code.
Comment 15 by tre...@gmail.com, Jul 25 2010
Lacking kde integration is keeping me from using chromium, especially since firefox integrates very well with kde since about Q4 2009.

I would asume that if Firefox can be integrated into kde, so can Chrome/Chromium...
Please, I'd love to see this fixed, the gtk-like look and feel is really annoying, specially the save/open file dialog.

Is there anything being done regarding this? I'd like to follow the changes if any. 
Comment 17 by 4pla...@gmail.com, Aug 13 2010
I was fed up with GTK dialogs, so I hacked the kdialog shell utility into chromium. It is not very clean (dialogs are modal, i.e. synchronously called), but it looks good and works well for me.

Only changed for open and save file (not select dir or multiple filesĂș, because I did not find where it is used in practice.

Do feel free to make it better!

Attached diff for src/chrome/browser/gtk/dialogs_gtk.cc, which is the only file needed to be changed.
dialogs_gtk.cc.diff
11.0 KB View Download
Comment 18 Deleted
Comment 19 by Deleted ...@, Oct 13 2010
yes, agree, it has to be implemented, like in Opera.

PS:  issue 36628  seems to be similar
Comment 20 by evan@chromium.org, Oct 13 2010
 Issue 36628  has been merged into this issue.
Please do this
Please do this
Looking forward to seeing this getting implemented :)
KDE people really need it
This would also create a temporary workaround for  issue 30288  (failure to upload images on Linux).
Really must-have for KDE users!!!
I want this too!
I want this too!
What about usign Qt's own QFileDialog function that is capable of displaying either native KDE file dialog or Qt's own file dialog? Wouldn't it be possible to somehow use dbus for that file dialog without adding any Qt libraries to dependencies? 
Most people using KDE already have Qt installed anyway so having KDE is like having Qt installed.
Comment 31 by evan@chromium.org, Jan 27 2011
Labels: -HelpWanted GoodFirstBug
Deprecating HelpWanted label.
Comment 32 by Deleted ...@, Jan 28 2011
I want this too!
it's a perfect feature to implement!
Comment 34 by krog...@gmail.com, Feb 21 2011
please do it!
Comment 35 by 4pla...@gmail.com, Feb 21 2011
Could anybody of you "please i want" guys try mu patch? I know it's much better if incorporated, but this is working and I use it and if you could maybe make it better, it would be just super for me too.

Current patch for Chrome 6/7 and a different for 9: http://plague.cz/patches.php

Comment 36 by krog...@gmail.com, Feb 21 2011
and for 10?
Comment 37 by krtul...@gmail.com, Feb 21 2011
4plague, would you consider submitting the patch into the Chromium code per
http://dev.chromium.org/developers/contributing-code

Comment 38 Deleted
Comment 39 by 4pla...@gmail.com, Feb 21 2011
I just updated the source and the binary still reports 9.0 version, so no 10 there?
I looked at the submit page but I do not meet those requirements (like unit tests etc.) so if anybody wants to take over my code to finish it for submission, I'll be happy...
Comment 40 by egg...@gmail.com, Mar 5 2011
>Could anybody of you "please i want" guys try mu patch?
4plague, I'd like to try it but have no idea how to do this? Maybe you can give some instructions (I'm on Gentoo)
Labels: -GoodFirstBug bulkmove Hotlist-GoodFirstBug
Chrome Version (from the about:version page):
Is this the most recent version:
OS + version:
CPU architecture (32-bit / 64-bit):
Window manager:
URLs (if relevant):
Behavior in Linux Firefox:It is possible to set the browser to use "native" 
file dialog
Behavior in Windows Chrome (if you have access to it):

What steps will reproduce the problem?
1.
2.
3.

What is the expected result?
If we set the browser to ask where it wants to save the file add 
possibility to use native (KDE) file dialog instead of gtk file dialog

What happens instead?
It is using gtk's file dialog.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.
Comment 42 by Deleted ...@, May 29 2011
Yes, please do it
KDE file dialogs are now supported! :)
http://codereview.chromium.org/7885002/
Cc: dfilimon@google.com
Status: Fixed
Adobe Flash seems that is still using the GTK open file dialog. I'm wondering if showing these kind of dialogs is managed by the browser or by Flash Player itself... If the answer is the first option, would be possible to use KDE dialogs too when they are triggered by Flash Plugin?
Comment 46 by skr...@gmail.com, Jan 11 2012
Unfortunately, the new dialog box does not have the "save as full webpage" functionality it used to.  From my post on the Chrome help forums at http://www.google.com/support/forum/p/Chrome/thread?tid=316641145fe80076&hl=en: 

Google Chrome	16.0.912.63 (Official Build 113337)
OS	Linux

To reproduce in KDE: open a webpage, right click on the page and select "Save as". The "Save As" KDialog will pop up, but this dialog only allows you to save the HTML source of the currently open page, instead of the complete webpage, including all images, style sheets, etc.
Comment 47 by skr...@gmail.com, Jan 11 2012
Another person with this problem - Georg Kovalcik's comment (#4) on http://www.tavisonline.com/2011/09/chrome-kdialog/
Comment 48 by evan@chromium.org, Jan 11 2012
Tears.  Should we revert for now?  Is there a flag to make kdialog show such an option?
No, please do not revert.
If you use KDE and you don't like the KDE file dialog for whatever reason, on ToT, you can run NO_CHROME_KDE_FILE_DIALOG=1 /path/to/chrome and go back to the GTK dialog. If your version is older, you can mess with your environment variables to pretend you're not running KDE.

I filed bug 109913 for the issue in comment 46. Please discuss that bug there.
Cc: -dfilimon@google.com
Comment 52 Deleted
Comment 53 by abar...@gmail.com, Apr 26 2012
Same issue as #46. Should be at least be reopened? or is there a new bug report for this?
abarrei: bug 109913
Project Member Comment 55 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 56 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Area-UI Cr-UI
Sign in to add a comment