New issue
Advanced search Search tips

Issue 393317 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Switch to BoringSSL

Project Member Reported by agl@chromium.org, Jul 11 2014

Issue description

This is a tracking bug for the switch of Chromium over to BoringSSL.
 

Comment 1 by agl@chromium.org, Jul 14 2014

Cc: rsleevi@chromium.org agl@chromium.org
 Issue 391121  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2014

------------------------------------------------------------------
r283025 | agl@chromium.org | 2014-07-14T21:22:52.438976Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/openssl_nacl.gyp?r1=283025&r2=283024&pathrev=283025
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/openssl.gyp?r1=283025&r2=283024&pathrev=283025

OpenSSL: forward to BoringSSL.

This change will sit in the OpenSSL deps repo. When we switch to BoringSSL,
that patch will update DEPS to point to this revision. This avoids having to
update webrtc and libjingle repos at the same time.

The NaCl build is removed because I believe that all the pointers to it are in
the main Chromium repo and can be switched over. I'd rather get a clear build
error than linking in both OpenSSL and BoringSSL. (Also, forwarding doesn't
appear to work for NaCl targets.)

BUG= 393317 

https://codereview.chromium.org/383273002/

-----------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2014

------------------------------------------------------------------
r284247 | davidben@chromium.org | 2014-07-18T23:13:07.117004Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/openssl.gyp?r1=284247&r2=284246&pathrev=284247

Switch openssl forwarding target to 'none'.

Building it as a static library causes problems on Mac at least since it's
empty.

BUG= 393317 

Review URL: https://codereview.chromium.org/401903004
-----------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edfd0f43f597524764f6cb6988f6d52cc3d5a815

commit edfd0f43f597524764f6cb6988f6d52cc3d5a815
Author: davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 22 18:20:37 2014

Switch to BoringSSL.

This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG= 393317 
R=agl@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/401153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284729 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2014

------------------------------------------------------------------
r284729 | davidben@chromium.org | 2014-07-22T18:20:37.383432Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/linux/system.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/boringssl_unittest.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/flip_server/acceptor_thread.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/modes/ghash-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/webcrypto/openssl/rsa_key_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/webcrypto/openssl/aes_gcm_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/sha/sha1-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/BUILD.gn?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/aes/aesni-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/aes/aesni-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/md5/md5-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/buildbot/deps_whitelist.py?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_session_cache_openssl_unittest.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/BUILD.gn?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/rc4/rc4-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_ui.gypi?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/remoting_nacl.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/native/webview_native.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/quic/crypto/aead_base_encrypter_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/cert/cert_verify_proc_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/zygote/zygote_main_linux.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/sha/sha1-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/cpu-x86-asm.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/flip_server/spdy_ssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/boringssl.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/encryptor_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/sha/sha512-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/usrsctp/usrsctp.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_child.gypi?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/bn/x86-mont.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/aes/aes-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/sha/sha256-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/openssl_ssl_util.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/token_validator_base.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/des.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/bn/bn-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/linux/unbundle/replace_gyp_files.py?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/bn/bn-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjingle_nacl.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/BUILD.gn?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/modes/ghash-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/openssl_util.cc?r1=284729&r2=284728&pathrev=284729
   A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/boringssl_nacl.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/md5/md5-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/crypto_nacl.gyp?r1=284729&r2=284728&pathrev=284729
   A http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/BUILD.gn?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/sha/sha512-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/android/keystore_unittest.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/crypto.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/rc4/rc4-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/sha/sha256-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/signature_verifier_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_server_socket_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/aes/vpaes-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net_nacl.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/aes/vpaes-x86.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/scoped_openssl_types.h?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/google_apis/google_apis.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/update_gypi_and_asm.py?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/bn/co-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/mac-x86/crypto/bn/co-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/cert/x509_certificate_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjingle.gyp?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/cpu-x86-asm.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/boringssl_tests.gypi?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/bn/x86-mont.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/boringssl/linux-x86/crypto/aes/aes-586.S?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/rsa_private_key_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/android/keystore_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/quic/crypto/aead_base_decrypter_openssl.cc?r1=284729&r2=284728&pathrev=284729
   M http://src.chromium.org/viewvc/chrome/trunk/src/crypto/openssl_bio_string_unittest.cc?r1=284729&r2=284728&pathrev=284729

Switch to BoringSSL.

This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG= 393317 
R=agl@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/401153002
-----------------------------------------------------------------
Cc: davidben@chromium.org
Status: Fixed
Okay, I think this finally stuck!

Sign in to add a comment