New issue
Advanced search Search tips

Issue 392075 link

Starred by 3 users

Issue metadata

Status: Fixed
Closed: Oct 2015
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 432683

Sign in to add a comment

[CSS Font Loading] Make FontFaceSet Set-like

Project Member Reported by, Jul 8 2014

Issue description

Currently FontFaceSet implements the following set methods:
  readonly attribute unsigned long size;
  void add(FontFace font);
  boolean has(FontFace font);
  boolean delete(FontFace font);
  void clear();
  void forEach(ForEachCallback cb, optional any thisArg);

The following methods are still missing:
  Iterator entries();
  Iterator keys();
  Iterator values();
  FontFace iterator;

Blockedon: chromium:432683
Summary: [CSS Font Loading] Make FontFaceSet Set-like (was: [CSS Font Loading] Add missing set methods to FontFaceSet)
Now the spec says simply:

interface FontFaceSet : EventTarget {
  // FontFaceSet is Set-like!

Setlike/maplike support in Blink IDL is in progress ( Issue 432683 ). We should be able to use it.
Owner: ----
Status: Available
Status: Assigned
Let me see this bug to understand font related code.

For now, maplike/setlike are supported by IDL parser, but there are no use case of setlike now.
It will need some code to use setlike. But it still looks like a kind of good-first-bug.
Thanks Toyoshima-san!

FYI, this is an old patch I wrote before Blink IDL supports setlike.

Status: Started
Project Member

Comment 7 by, Oct 20 2015

The following revision refers to this bug:

commit 570fb77ac846fb6f52c67e14245e254d1ae9db43
Author: toyoshim <>
Date: Tue Oct 20 01:13:56 2015

CSS Font Loading: drop readonly to use Setlike functionalities

FontFaceSet.idl used readonly setlike<FontFace> to use
existing add(), delete(), and clear() implementations.

This patch drops readonly to use binding scheme to implement
writable Setlike methods.

Note that add() method returns FontFaceSet after this change.

BUG= 392075 

Review URL:

Cr-Commit-Position: refs/heads/master@{#354947}


Status: Fixed
See for related behavior changes.

Sign in to add a comment