New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 389343 link

Starred by 60 users

Issue metadata

Status: Fixed
Owner:
Last visit 20 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: Yes
Launch-M-Approved: ----
Launch-M-Target: 56-Dev , 56-Beta , 56-Stable , 57-Dev , 57-Beta , 57-Stable
Launch-Privacy: Yes
Launch-Security: Started
Launch-Test: NotReviewed
Launch-UI: NotReviewed
Rollout-Type: ----
Proj-XR

Blocked on:
issue 472898
issue 540848
issue 623989
issue 628417
issue 644492
issue 644780
issue 644783
issue 644784
issue 644785
issue 646751

Blocking:
issue 515192
issue 643784
issue 643785



Sign in to add a comment

Implement WebVR for Android

Project Member Reported by bajones@chromium.org, Jun 26 2014

Issue description

Change description:
Adds input and output support for Virtual Reality head mounted displays, such as the Oculus Rift

Changes to API surface:
 * Adds Navigator.getVRDevices() function
 * Adds HMDVRDevice interface
 * Adds PositionSensorVRDevice interface
 * Adds the ability to pass an options dictionary to Element.requestFullscreen

Links:
VR discussion mailing list. Archive includes spec discussion: https://mail.mozilla.org/listinfo/web-vr-discuss
Mozilla's blog post: http://blog.bitops.com/blog/2014/06/26/first-steps-for-vr-on-the-web/

Support in other browsers:
Firefox: Experimental
Internet Explorer: No
Safari: No

 
Showing comments 36 - 135 of 135 Older
Blockedon: 628417
Project Member

Comment 37 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e3d9baf2f84b162048a59487360e057cce3223

commit 99e3d9baf2f84b162048a59487360e057cce3223
Author: bajones <bajones@chromium.org>
Date: Thu Jul 28 21:20:03 2016

Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG= 389343 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2167643003
Cr-Commit-Position: refs/heads/master@{#408473}

[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/BUILD.gn
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/BUILD.gn
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/test/fake_vr_device.h
[add] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_client_dispatcher.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_device_manager.cc
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_device_manager.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_service.mojom
[add] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_service_impl.cc
[add] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_service_impl.h
[add] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/device/vr/vr_service_impl_unittest.cc
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/DEPS
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/VRDisplay.h
[delete] https://crrev.com/4fd767727f8a4bd4e86d626fce4921972f8180f8/third_party/WebKit/Source/modules/vr/VRDisplayCollection.cpp
[delete] https://crrev.com/4fd767727f8a4bd4e86d626fce4921972f8180f8/third_party/WebKit/Source/modules/vr/VRDisplayCollection.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h
[modify] https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c699e89f096292539b287b7917441ed19d13a2e9

commit c699e89f096292539b287b7917441ed19d13a2e9
Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com>
Date: Mon Aug 01 22:51:40 2016

GN: Set |enable_webvr| in the declare_args() block.

This effectively makes it a configurable argument that can be changed by
downstreams and users alike; so far, trying to change it via `gn args'
failed with:

  The variable "enable_webvr" was set as a build argument
  but never appeared in a declare_args() block in any buildfile.

BUG= 389343 
R=bajones@chromium.org,brettw@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2198003002
Cr-Commit-Position: refs/heads/master@{#409083}

[modify] https://crrev.com/c699e89f096292539b287b7917441ed19d13a2e9/build/config/features.gni

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e25d54f49c265b7e445a344fc396b33645a5b22

commit 1e25d54f49c265b7e445a344fc396b33645a5b22
Author: bajones <bajones@chromium.org>
Date: Wed Aug 10 19:07:37 2016

Added some missing java files to android_protobuf/BUILD.gn

Including these files is necessary in order to satisfy dependencies in
gvr-android-sdk.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2235733003
Cr-Commit-Position: refs/heads/master@{#411112}

[modify] https://crrev.com/1e25d54f49c265b7e445a344fc396b33645a5b22/third_party/android_protobuf/BUILD.gn

Cc: yunchao...@intel.com
Project Member

Comment 42 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267d5f909f25543d2351cc506626b5d5c08461c3

commit 267d5f909f25543d2351cc506626b5d5c08461c3
Author: bajones <bajones@chromium.org>
Date: Thu Aug 18 00:52:36 2016

Migrate WebVR Cardboard implementation to GVR

BUG= 389343 

Review-Url: https://codereview.chromium.org/2219203002
Cr-Commit-Position: refs/heads/master@{#412710}

[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/chrome/android/BUILD.gn
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/content/content.gyp
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/content/public/android/BUILD.gn
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/BUILD.gn
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/BUILD.gn
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/DEPS
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/BUILD.gn
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/cardboard/cardboard_vr_device.cc
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/cardboard/cardboard_vr_device.h
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/cardboard/cardboard_vr_device_provider.cc
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/cardboard/cardboard_vr_device_provider.h
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_api_manager.cc
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_api_manager.h
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_device.cc
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_device.h
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_device_provider.cc
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/gvr/gvr_device_provider.h
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/vr_jni_registrar.cc
[delete] https://crrev.com/02dbcbfc282ca7c2e94eb5181ceb60f0820f5003/device/vr/android/vr_jni_registrar.h
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/device/vr/vr_device_manager.cc
[modify] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/third_party/gvr-android-sdk/BUILD.gn
[add] https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60fb40258dc3548735720b48a5a8cfad8c11ecbd

commit 60fb40258dc3548735720b48a5a8cfad8c11ecbd
Author: boliu <boliu@chromium.org>
Date: Thu Aug 18 02:23:09 2016

Revert of Migrate WebVR Cardboard implementation to GVR (patchset #20 id:380001 of https://codereview.chromium.org/2219203002/ )

Reason for revert:
Android build failure on cronet:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/4131

/b/build/slave/Android_Cronet_MIPS_Builder/build/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //third_party/gvr-android-sdk/BUILD.gn:27:1: Empty sources for copy command.
copy("libgvr_shared_library") {
^------------------------------
You have to specify at least one file to copy in the "sources".
See //device/vr/BUILD.gn:47:7: which caused the file to be included.
      "//third_party/gvr-android-sdk:libgvr",
      ^-------------------------------------
GN gen failed: 1
step returned non-zero exit code: 1

Also suspect but have not confirmed causing these two build failures:
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/7419
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7722

Original issue's description:
> Migrate WebVR Cardboard implementation to GVR
>
> BUG= 389343 
>
> Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3
> Cr-Commit-Position: refs/heads/master@{#412710}

TBR=dtrainor@chromium.org,girard@chromium.org,bshe@chromium.org,mthiesse@chromium.org,klausw@google.com,sievers@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 389343 

Review-Url: https://codereview.chromium.org/2258513003
Cr-Commit-Position: refs/heads/master@{#412724}

[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/chrome/android/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/content/content.gyp
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/content/public/android/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/DEPS
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/BUILD.gn
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device.h
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device_provider.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device_provider.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_api_manager.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_api_manager.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device_provider.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device_provider.h
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/vr_jni_registrar.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/vr_jni_registrar.h
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/vr_device_manager.cc
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/third_party/gvr-android-sdk/BUILD.gn
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 44 by bugdroid1@chromium.org, Aug 18 2016

Labels: merge-merged-2832
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60fb40258dc3548735720b48a5a8cfad8c11ecbd

commit 60fb40258dc3548735720b48a5a8cfad8c11ecbd
Author: boliu <boliu@chromium.org>
Date: Thu Aug 18 02:23:09 2016

Revert of Migrate WebVR Cardboard implementation to GVR (patchset #20 id:380001 of https://codereview.chromium.org/2219203002/ )

Reason for revert:
Android build failure on cronet:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/4131

/b/build/slave/Android_Cronet_MIPS_Builder/build/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //third_party/gvr-android-sdk/BUILD.gn:27:1: Empty sources for copy command.
copy("libgvr_shared_library") {
^------------------------------
You have to specify at least one file to copy in the "sources".
See //device/vr/BUILD.gn:47:7: which caused the file to be included.
      "//third_party/gvr-android-sdk:libgvr",
      ^-------------------------------------
GN gen failed: 1
step returned non-zero exit code: 1

Also suspect but have not confirmed causing these two build failures:
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/7419
https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7722

Original issue's description:
> Migrate WebVR Cardboard implementation to GVR
>
> BUG= 389343 
>
> Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3
> Cr-Commit-Position: refs/heads/master@{#412710}

TBR=dtrainor@chromium.org,girard@chromium.org,bshe@chromium.org,mthiesse@chromium.org,klausw@google.com,sievers@chromium.org,bajones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 389343 

Review-Url: https://codereview.chromium.org/2258513003
Cr-Commit-Position: refs/heads/master@{#412724}

[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/chrome/android/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/content/content.gyp
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/content/public/android/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/BUILD.gn
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/DEPS
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/BUILD.gn
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device.h
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device_provider.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/cardboard/cardboard_vr_device_provider.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_api_manager.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_api_manager.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device.h
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device_provider.cc
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/gvr/gvr_device_provider.h
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/vr_jni_registrar.cc
[add] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/android/vr_jni_registrar.h
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/device/vr/vr_device_manager.cc
[modify] https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd/third_party/gvr-android-sdk/BUILD.gn
[delete] https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 45 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330

commit 7ab52ec35d497d6bb96c6a1fa36c9b123bc72330
Author: bajones <bajones@chromium.org>
Date: Fri Aug 19 19:54:25 2016

Migrate WebVR Cardboard implementation to GVR

BUG= 389343 

Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3
Review-Url: https://codereview.chromium.org/2219203002
Cr-Original-Commit-Position: refs/heads/master@{#412710}
Cr-Commit-Position: refs/heads/master@{#413217}

[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/build/config/features.gni
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/chrome/android/BUILD.gn
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/content/content.gyp
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/content/public/android/BUILD.gn
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/BUILD.gn
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/BUILD.gn
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/DEPS
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/BUILD.gn
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/cardboard/cardboard_vr_device.cc
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/cardboard/cardboard_vr_device.h
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/cardboard/cardboard_vr_device_provider.cc
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/cardboard/cardboard_vr_device_provider.h
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_api_manager.cc
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_api_manager.h
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_device.cc
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_device.h
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_device_provider.cc
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/gvr/gvr_device_provider.h
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/vr_jni_registrar.cc
[delete] https://crrev.com/c024602a0ac658ce22783371be61ad5459591e6c/device/vr/android/vr_jni_registrar.h
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/device/vr/vr_device_manager.cc
[modify] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/third_party/gvr-android-sdk/BUILD.gn
[add] https://crrev.com/7ab52ec35d497d6bb96c6a1fa36c9b123bc72330/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd

commit 8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd
Author: bajones <bajones@chromium.org>
Date: Tue Aug 23 23:23:11 2016

Updated VRPose.timestamp to use same casing as WebVR spec. Also changing type to DOMHighResTimeStamp (typedef for double), again to match the spec.

See relevant spec text here: https://w3c.github.io/webvr/#interface-vrpose

BUG= 389343 

Review-Url: https://codereview.chromium.org/2268893003
Cr-Commit-Position: refs/heads/master@{#413894}

[modify] https://crrev.com/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd/third_party/WebKit/Source/modules/vr/VRPose.cpp
[modify] https://crrev.com/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd/third_party/WebKit/Source/modules/vr/VRPose.h
[modify] https://crrev.com/8b9eb3e957c3ab75cbd97b0ff35060b4677ce8bd/third_party/WebKit/Source/modules/vr/VRPose.idl

Project Member

Comment 48 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52355939d8d703281cf450d853dda33e6c3a089f

commit 52355939d8d703281cf450d853dda33e6c3a089f
Author: bajones <bajones@chromium.org>
Date: Wed Aug 24 22:05:06 2016

Adding WebVR temporary presentation handling on mobile

Temporary code path that invokes fullscreen in lieu of proper VR presentation.
Also includes VRDisplayEvent and related code + casing change to VRPose "timestamp" attribute to match spec.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2265053004
Cr-Commit-Position: refs/heads/master@{#414165}

[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplay.h
[add] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplayEvent.cpp
[add] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplayEvent.h
[add] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplayEvent.idl
[add] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
[modify] https://crrev.com/52355939d8d703281cf450d853dda33e6c3a089f/tools/metrics/histograms/histograms.xml

Project Member

Comment 49 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95d513d3be6520a86f74105ccb95cedf3f849e92

commit 95d513d3be6520a86f74105ccb95cedf3f849e92
Author: shaobo.yan <shaobo.yan@intel.com>
Date: Mon Aug 29 03:53:46 2016

Add SchedulePollEvents and PollEvents

Since WebVR spec already has VRDisplayEvent and definess several types of
events. Devices needs to be queried to get status and generate events.

These two methods enable the mechanism to query vr device. VRDeviceManager queries devices by
invoke PollEvents and vr device will implement PollEvent to do this.

BUG= 389343 
R=bajones@chromium.org

Review-Url: https://codereview.chromium.org/2266793002
Cr-Commit-Position: refs/heads/master@{#414970}

[modify] https://crrev.com/95d513d3be6520a86f74105ccb95cedf3f849e92/AUTHORS
[modify] https://crrev.com/95d513d3be6520a86f74105ccb95cedf3f849e92/device/vr/vr_device_manager.cc
[modify] https://crrev.com/95d513d3be6520a86f74105ccb95cedf3f849e92/device/vr/vr_device_manager.h
[modify] https://crrev.com/95d513d3be6520a86f74105ccb95cedf3f849e92/device/vr/vr_device_provider.h

Labels: -Pri-2 Launch-Accessibility-NA Launch-Legal-NotReviewed Launch-M-Target-55-Beta Launch-Privacy-NotReviewed Launch-Security-NotReviewed Launch-Test-NotReviewed Launch-UI-NotReviewed Pri-1
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43812e7f2b8f612a503a11e30036ddbc662a33e2

commit 43812e7f2b8f612a503a11e30036ddbc662a33e2
Author: foolip <foolip@chromium.org>
Date: Thu Sep 01 23:37:47 2016

Drop DocumentCreateEventVRDisplayEvent use counter

These entries are no longer needed. Context:
https://codereview.chromium.org/2265053004
https://codereview.chromium.org/2210253002

Also sneek in the M54 cutoff comment.

BUG= 389343 ,569690
R=bajones@chromium.org

Review-Url: https://codereview.chromium.org/2301533002
Cr-Commit-Position: refs/heads/master@{#416122}

[modify] https://crrev.com/43812e7f2b8f612a503a11e30036ddbc662a33e2/third_party/WebKit/Source/core/frame/UseCounter.h

Components: Blink>WebVR
Labels: Proj-VR
Labels: M-55
Blocking: 643784
Blockedon: 643785
Blocking: 643785
Blockedon: -643785
Project Member

Comment 58 by bugdroid1@chromium.org, Sep 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92370143e6206f3bffe3e9bac1618c840f22648b

commit 92370143e6206f3bffe3e9bac1618c840f22648b
Author: bajones <bajones@chromium.org>
Date: Sun Sep 04 15:41:20 2016

Only allow VR presentation in response to a user gesture

BUG= 389343 

Review-Url: https://codereview.chromium.org/2305213002
Cr-Commit-Position: refs/heads/master@{#416473}

[modify] https://crrev.com/92370143e6206f3bffe3e9bac1618c840f22648b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Labels: -OS-All OS-Android
Splitting out bug to track Android and desktop implementations separately. 
Using this bug for Android, filed the following launch bug for desktop: https://bugs.chromium.org/p/chromium/issues/detail?id=644502
Summary: Implement WebVR for Android (was: Implement WebVR)
Labels: -Launch-Privacy-NotReviewed Launch-Privacy-Started
Project Member

Comment 62 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/487d1fc5424211ef6fc1b3f5cfc1e5355169339f

commit 487d1fc5424211ef6fc1b3f5cfc1e5355169339f
Author: bajones <bajones@chromium.org>
Date: Wed Sep 07 00:30:17 2016

Plumbing through more WebVR presentation code

Also improved the client/delegate model for managing the GvrApi context in
anticipation of making VrShell the GvrDelegate.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2309523003
Cr-Commit-Position: refs/heads/master@{#416796}

[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/BUILD.gn
[delete] https://crrev.com/5aff38d7c5b1387eed23687dfac5bd43ecdaadf4/device/vr/android/gvr/gvr_api_manager.cc
[delete] https://crrev.com/5aff38d7c5b1387eed23687dfac5bd43ecdaadf4/device/vr/android/gvr/gvr_api_manager.h
[add] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_delegate.cc
[add] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/vr_device.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/vr_service.mojom
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/vr_service_impl.cc
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/device/vr/vr_service_impl.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Blockedon: 644780
Blockedon: 644783
Blockedon: 644784
Blockedon: 644785
Blockedon: 644786
Labels: Launch-Status-Review-Requested
Labels: -Launch-Legal-NotReviewed Launch-Legal-Started
Labels: -Launch-Privacy-Started Launch-Privacy-NotReviewed
Labels: -Launch-Privacy-NotReviewed Launch-Privacy-Started
Project Member

Comment 73 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2

commit aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2
Author: bajones <bajones@chromium.org>
Date: Tue Sep 13 03:05:41 2016

Update WebVR interface to match the 1.1 spec

This update doesn't change the VR API backends at all, just transforms
the data that they're currently providing to match the WebVR 1.1 spec.
A future CL will plumb the changes all the way back to /device/vr.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2331553002
Cr-Commit-Position: refs/heads/master@{#418153}

[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/BUILD.gn
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRDisplay.idl
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRFieldOfView.h
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRFieldOfView.idl
[delete] https://crrev.com/d558b56986277beba11471c70e17693df83a080f/third_party/WebKit/Source/modules/vr/VRFieldOfViewInit.idl
[add] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRFrameData.cpp
[add] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRFrameData.h
[add] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRFrameData.idl
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRPose.cpp
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRPose.h
[modify] https://crrev.com/aa686778a64f59ffab3fcda0531d7d2d1ab0ecc2/third_party/WebKit/Source/modules/vr/VRPose.idl

Labels: PrivacyReview-646751
Blockedon: 646751
Project Member

Comment 76 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ed46b81d0a4da803a9ad25bb217f2aac28709a

commit 73ed46b81d0a4da803a9ad25bb217f2aac28709a
Author: bajones <bajones@chromium.org>
Date: Thu Sep 15 03:53:13 2016

Isolate a presenting VR device from pages other than the one presenting.

Prevents a page from reading or resetting the pose of a
device which is currently being presented to by a
different page, as that potentially creates an
information leak between pages.

Also prevented pages from beginning presentation if another page is already presenting to a device. This is a
little overly aggressive right now, as disallows
presentation to more than one device at a time from any
page, but that's a reasonable limitation at this point
given the rarity of VR hardware.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2329893002
Cr-Commit-Position: refs/heads/master@{#418771}

[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_device.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_device.h
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_device_manager.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_device_manager.h
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_device_manager_unittest.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_service.mojom
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_service_impl.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_service_impl.h
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/device/vr/vr_service_impl_unittest.cc
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/73ed46b81d0a4da803a9ad25bb217f2aac28709a/third_party/WebKit/Source/modules/vr/VRDisplay.h

Project Member

Comment 78 by bugdroid1@chromium.org, Sep 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66ce5b08f2af95f149303ad716119db190a52823

commit 66ce5b08f2af95f149303ad716119db190a52823
Author: shaobo.yan <shaobo.yan@intel.com>
Date: Sun Sep 18 03:11:33 2016

Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG= 389343 
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org

Review-Url: https://codereview.chromium.org/2317483002
Cr-Commit-Position: refs/heads/master@{#419392}

[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_client_dispatcher.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_device_manager.cc
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_device_manager.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_device_provider.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_service.mojom
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/device/vr/vr_service_impl_unittest.cc
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823/third_party/WebKit/Source/modules/vr/VRDisplay.h

Comment 79 by noellek@google.com, Sep 20 2016

Labels: -Launch-Legal-Started Launch-Legal-Yes
Project Member

Comment 81 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7f480d5099bcb664eba873a5c24f374d12e517d

commit d7f480d5099bcb664eba873a5c24f374d12e517d
Author: bajones <bajones@chromium.org>
Date: Wed Sep 21 22:26:26 2016

Switch WebVR to handle GvrApi management through VrShellDelegate

BUG= 389343 

Review-Url: https://codereview.chromium.org/2343023002
Cr-Commit-Position: refs/heads/master@{#420181}

[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/vr_shell/vr_shell.h
[add] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[add] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_delegate.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/vr_client_dispatcher.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/vr_device_manager.cc
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/vr_device_manager.h
[modify] https://crrev.com/d7f480d5099bcb664eba873a5c24f374d12e517d/device/vr/vr_service.mojom

Project Member

Comment 84 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80ccce30a1ca124086bae9d46d4b9edbbd7059ba

commit 80ccce30a1ca124086bae9d46d4b9edbbd7059ba
Author: bajones <bajones@chromium.org>
Date: Fri Sep 23 19:08:16 2016

Updated to GVR 1.0 SDK

BUG= 389343 

Review-Url: https://codereview.chromium.org/2367673002
Cr-Commit-Position: refs/heads/master@{#420686}

[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/DEPS
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_gl_util.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_math.cc
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_math.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/device/vr/android/gvr/gvr_gamepad_data_fetcher.h
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/third_party/gvr-android-sdk/BUILD.gn
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/third_party/gvr-android-sdk/LICENSE
[modify] https://crrev.com/80ccce30a1ca124086bae9d46d4b9edbbd7059ba/third_party/gvr-android-sdk/README.chromium
[delete] https://crrev.com/1299d0c91e5943e7ebc689d3770793180fa0b1af/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 85 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579759c320d284129d41eda17dfa37702e7bdc95

commit 579759c320d284129d41eda17dfa37702e7bdc95
Author: dtrainor <dtrainor@chromium.org>
Date: Tue Sep 27 21:58:41 2016

Revert "Updated to GVR 1.0 SDK"

This reverts commit 80ccce30a1ca124086bae9d46d4b9edbbd7059ba.

BUG= 389343 
TBR=bshe@

Review-Url: https://codereview.chromium.org/2377763003
Cr-Commit-Position: refs/heads/master@{#421352}

[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/DEPS
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_gl_util.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_math.cc
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_math.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/device/vr/android/gvr/gvr_gamepad_data_fetcher.h
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/third_party/gvr-android-sdk/BUILD.gn
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/third_party/gvr-android-sdk/LICENSE
[modify] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/third_party/gvr-android-sdk/README.chromium
[add] https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 86 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bdd119442049affe8ad5e1c3f96070e0531a543

commit 7bdd119442049affe8ad5e1c3f96070e0531a543
Author: klausw <klausw@chromium.org>
Date: Thu Sep 29 18:44:24 2016

Expose secure origin state to WebVR renderer

Will enable display of warnings in WebVR for insecure origins

BUG= 389343 

patch from issue 2361533003 at patchset 20001 (http://crrev.com/2361533003#ps20001)

Review-Url: https://codereview.chromium.org/2374153002
Cr-Commit-Position: refs/heads/master@{#421883}

[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_device.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_device.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_device_manager.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_device_manager.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_service.mojom
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_service_impl.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_service_impl.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/device/vr/vr_service_impl_unittest.cc
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/7bdd119442049affe8ad5e1c3f96070e0531a543/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Comment 87 by bshe@chromium.org, Sep 30 2016

Blockedon: 623989

Comment 88 by bshe@chromium.org, Sep 30 2016

Blockedon: -522683
Labels: -Launch-Privacy-Started Launch-Privacy-Yes
Labels: -Launch-Security-NotReviewed Launch-Security-Started
Blockedon: 644492
Blockedon: -644786
Project Member

Comment 93 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf

commit 069c76c2ffc77d5fcebb84937e07df8e61c3ebaf
Author: klausw <klausw@chromium.org>
Date: Tue Oct 04 01:06:04 2016

WebVR: implement insecure content warning display

On WebVR pages loaded over insecure transport, show a small "Not secure"
warning overlay permanently, and a transient more verbose warning for
a short time on first entering the page.

It uses the information from bajones's "Expose secure origin state to
WebVR renderer" implementation.

The message strings were previously added to chrome/app/generated_resources.grd in https://codereview.chromium.org/2368443002/

BUG= 389343 ,644492
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2363553003
Cr-Commit-Position: refs/heads/master@{#422647}

[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/browser_resources.grd
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc
[add] https://crrev.com/069c76c2ffc77d5fcebb84937e07df8e61c3ebaf/ui/webui/resources/images/i_circle.svg

Project Member

Comment 94 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/511e7f727be80e20d41fc5fd07cf8b5244cafbf0

commit 511e7f727be80e20d41fc5fd07cf8b5244cafbf0
Author: bshe <bshe@chromium.org>
Date: Tue Oct 04 23:46:23 2016

Reland gvr upgrade

The original CL is here: https://codereview.chromium.org/2367673002/
It was reverted because of compile failure with gn flags:
is_debug=false
is_component_build=true
target_os="android"
The reason is gvr uses API that only available in Android N SDK. For
release build, proguard detected the dependancy and results a compile
error. N SDK is in the process of rolling to chromium
https://codereview.chromium.org/2350013004/
In this CL, I restricted WebVr to debug build only. This could unblock
us. And I will remove the is_debug restriction once N is in Chromium

BUG= 389343 
TBR=dtrainor@

Review-Url: https://codereview.chromium.org/2396663002
Cr-Commit-Position: refs/heads/master@{#423005}

[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/DEPS
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/build/config/features.gni
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_gesture.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_gl_util.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_math.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_math.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/device/vr/android/gvr/gvr_gamepad_data_fetcher.h
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/third_party/gvr-android-sdk/BUILD.gn
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/third_party/gvr-android-sdk/LICENSE
[modify] https://crrev.com/511e7f727be80e20d41fc5fd07cf8b5244cafbf0/third_party/gvr-android-sdk/README.chromium
[delete] https://crrev.com/b2fd3d47699032e7d52a4ac2317135e444bbea6f/third_party/gvr-android-sdk/proguard/base.flags

Project Member

Comment 95 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e

commit dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e
Author: klausw <klausw@chromium.org>
Date: Thu Oct 06 01:04:02 2016

Encode frame number in pixel data for pose sync

This encodes the pose number of the drawn WebVR frame in a corner pixel
block, this is read by vr_shell.cc to use the corresponding pose when
submitting the frame to GVR for presentation.

Log data shows that the pose is 2-3 frames old by the time it is ready for
submission to GVR. This includes compositor buffering and SurfaceTexture
buffering. The patch helps in getting reprojection working as intended, but
can't do anything about the excessive latency.

BUG= 389343 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2384593002
Cr-Commit-Position: refs/heads/master@{#423367}

[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/vr_service.mojom
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/DEPS
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Project Member

Comment 96 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6ea17321313ae71b507c89bfec5ba8dda372c6

commit ed6ea17321313ae71b507c89bfec5ba8dda372c6
Author: billorr <billorr@chromium.org>
Date: Fri Oct 07 16:50:07 2016

Add deprecation messages to deprecated parts of the WebVR API.

VRDisplay.getPose() and VREyeParameters.fieldOfView are marked as
deprecated, so we'll report appropriate deprecation warnings in the
console.

This change also adds metrics for secure vs. insecure origin access to WebVR
APIs.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2394703003
Cr-Commit-Position: refs/heads/master@{#423885}

[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/modules/vr/VRDisplay.idl
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/third_party/WebKit/Source/modules/vr/VREyeParameters.idl
[modify] https://crrev.com/ed6ea17321313ae71b507c89bfec5ba8dda372c6/tools/metrics/histograms/histograms.xml

Labels: -M-55 M-56
Project Member

Comment 98 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6805d8ab4296d9033602bad708da31e67e9fff6d

commit 6805d8ab4296d9033602bad708da31e67e9fff6d
Author: billorr <billorr@chromium.org>
Date: Tue Oct 11 20:08:55 2016

Add WebVR histograms for requestPresent failures/success and headset types.

Add usage counters for gamepad extensions.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2388163005
Cr-Commit-Position: refs/heads/master@{#424522}

[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/gamepad/Gamepad.idl
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/gamepad/GamepadButton.idl
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/gamepad/GamepadPose.idl
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/tools/metrics/histograms/histograms.xml

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3cd4e9863d31653dfdf1f9dfba1b7b7f1f1ae5

commit cf3cd4e9863d31653dfdf1f9dfba1b7b7f1f1ae5
Author: bajones <bajones@chromium.org>
Date: Tue Oct 11 21:39:38 2016

Fixed depth range of WebVR projection matrices

Accidentally used a matrix that assumed a [0, 1] depth range (which is what D3D
uses) instead of OpenGL's [-1, 1] range. This effectively cut the depth
precision in half.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2407413002
Cr-Commit-Position: refs/heads/master@{#424555}

[modify] https://crrev.com/cf3cd4e9863d31653dfdf1f9dfba1b7b7f1f1ae5/third_party/WebKit/Source/modules/vr/VRFrameData.cpp

Project Member

Comment 100 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4fa4460242c7a38d416fe7f83caa88c18f8ae03

commit f4fa4460242c7a38d416fe7f83caa88c18f8ae03
Author: bshe <bshe@chromium.org>
Date: Wed Oct 12 00:41:55 2016

Pull in vr_shell code for webvr

BUG= 389343 

Review-Url: https://codereview.chromium.org/2399533002
Cr-Commit-Position: refs/heads/master@{#424616}

[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/android/BUILD.gn
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/BUILD.gn
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/browser_resources.grd
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/common/features.gni
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/common/url_constants.cc
[modify] https://crrev.com/f4fa4460242c7a38d416fe7f83caa88c18f8ae03/chrome/common/url_constants.h

"Accidentally used a matrix that assumed a [0, 1] depth range (which is
what D3D
uses) instead of OpenGL's [-1, 1] range. This effectively cut the depth
precision in half."

This is just a general technical question: Would the [0, 1] range actually
make a difference? I always thought [0, 1] was the output range required
from fragment shaders, in which case precision would be lost from [-1, 1]
anyway.

Thanks :)
Sorry, I meant "vertex" shaders not "fragment" shaders.
Project Member

Comment 103 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75ec67ea320306345e2d2b2f7750de9b8998dc72

commit 75ec67ea320306345e2d2b2f7750de9b8998dc72
Author: bshe <bshe@chromium.org>
Date: Thu Oct 13 15:14:41 2016

Enable magic window mode with new Gvr

Magic window mode was disabled(not reporting phone sensor
data) here: https://codereview.chromium.org/2367673002/
The reason was new API requires an Activity instead of a
context like before. This CL moves the initialization of
GVR to chrome so CTA is available.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2398103002
Cr-Commit-Position: refs/heads/master@{#425035}

[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[add] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContext.java
[add] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextInterface.java
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/android/java_sources.gni
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/content/public/android/BUILD.gn
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/device/vr/BUILD.gn
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72/device/vr/android/gvr/gvr_device_provider.h
[delete] https://crrev.com/f506bdfec37f2e79353169d874b1eb8fbf155873/device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java

Project Member

Comment 104 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58290e535d3de7a235e13b6f023b1c8bf06a223a

commit 58290e535d3de7a235e13b6f023b1c8bf06a223a
Author: bajones <bajones@chromium.org>
Date: Fri Oct 21 22:15:32 2016

Draw WebVR security overlay with a non-reprojected viewport

This prevents the overlay from jittering regardless of the performance of the
WebVR content.

BUG= 389343 

Review-Url: https://chromiumcodereview.appspot.com/2430543002
Cr-Commit-Position: refs/heads/master@{#426912}

[modify] https://crrev.com/58290e535d3de7a235e13b6f023b1c8bf06a223a/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/58290e535d3de7a235e13b6f023b1c8bf06a223a/chrome/browser/android/vr_shell/vr_shell.h

Project Member

Comment 105 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c157a5ad42329f513f124d7d609d086d33310e84

commit c157a5ad42329f513f124d7d609d086d33310e84
Author: bajones <bajones@chromium.org>
Date: Tue Oct 25 04:51:31 2016

Fixed bad WebVR content judder when the HTTP warning was displayed

BUG= 389343 

Review-Url: https://codereview.chromium.org/2445083002
Cr-Commit-Position: refs/heads/master@{#427276}

[modify] https://crrev.com/c157a5ad42329f513f124d7d609d086d33310e84/chrome/browser/android/vr_shell/vr_shell.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dcae4a8c016b4b284cc550b23bc404a2c439d25

commit 8dcae4a8c016b4b284cc550b23bc404a2c439d25
Author: bajones <bajones@chromium.org>
Date: Tue Oct 25 21:54:31 2016

Allow VRDisplay to manage it's own rAF callbacks.

This will be necessary when we begin firing VR rAFs at a different rate than window.rAF, but here is used to prevent misuse of submitFrame, which needs to happen in a VR-specific rAF in order to ensure a good experience across the board.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2413903002
Cr-Commit-Position: refs/heads/master@{#427496}

[modify] https://crrev.com/8dcae4a8c016b4b284cc550b23bc404a2c439d25/third_party/WebKit/Source/core/dom/ScriptedAnimationController.h
[modify] https://crrev.com/8dcae4a8c016b4b284cc550b23bc404a2c439d25/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/8dcae4a8c016b4b284cc550b23bc404a2c439d25/third_party/WebKit/Source/modules/vr/VRDisplay.h

Project Member

Comment 107 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e

commit dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e
Author: klausw <klausw@chromium.org>
Date: Thu Oct 06 01:04:02 2016

Encode frame number in pixel data for pose sync

This encodes the pose number of the drawn WebVR frame in a corner pixel
block, this is read by vr_shell.cc to use the corresponding pose when
submitting the frame to GVR for presentation.

Log data shows that the pose is 2-3 frames old by the time it is ready for
submission to GVR. This includes compositor buffering and SurfaceTexture
buffering. The patch helps in getting reprojection working as intended, but
can't do anything about the excessive latency.

BUG= 389343 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2384593002
Cr-Commit-Position: refs/heads/master@{#423367}

[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/device/vr/vr_service.mojom
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/DEPS
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/dfa8ed4b3b10200b70d9f79cf247b8a1ec23e20e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Project Member

Comment 108 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece9c5729f55509bbe9d50d2c850f328eea48fda

commit ece9c5729f55509bbe9d50d2c850f328eea48fda
Author: bajones <bajones@chromium.org>
Date: Thu Nov 03 00:38:23 2016

Updated ResetPose logic for GVR devices

Old call was deprecated and new one should only be used with Cardboard devices

BUG= 389343 

Review-Url: https://codereview.chromium.org/2473903002
Cr-Commit-Position: refs/heads/master@{#429480}

[modify] https://crrev.com/ece9c5729f55509bbe9d50d2c850f328eea48fda/device/vr/android/gvr/gvr_device.cc

Comment 109 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 110 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb586400bdf276af3a94bf95b5790a0afdc8f31

commit ffb586400bdf276af3a94bf95b5790a0afdc8f31
Author: bshe <bshe@chromium.org>
Date: Wed Nov 09 03:25:21 2016

Remove is_debug from enable_webvr flag (N SDK is now available!)

Also add comment about why is_component_build check is necessary

BUG= 389343 

Review-Url: https://codereview.chromium.org/2416143003
Cr-Commit-Position: refs/heads/master@{#430844}

[modify] https://crrev.com/ffb586400bdf276af3a94bf95b5790a0afdc8f31/build/config/features.gni

Labels: -Launch-M-Target-55-Beta Launch-M-Target-56-Dev Launch-M-Target-56-Beta
Project Member

Comment 113 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93c3a787b003a8720a585e58c842505fe54f6ce

commit b93c3a787b003a8720a585e58c842505fe54f6ce
Author: bajones <bajones@chromium.org>
Date: Tue Nov 15 16:59:30 2016

Refactoring how WebVR eye bounds are handled

BUG= 389343 

Review-Url: https://codereview.chromium.org/2499793002
Cr-Commit-Position: refs/heads/master@{#432198}

[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/vr_device.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/vr_display_impl.cc
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/device/vr/vr_display_impl.h
[modify] https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Project Member

Comment 117 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c

commit 1fe0f40829f0e14e7af0721d5047bd62ba1dd07c
Author: bajones <bajones@chromium.org>
Date: Wed Nov 16 01:29:01 2016

Wired up vrdisplayactivate/deactivate

These events allows pages to automatically enter or exit WebVR presentation when
the HMD indicates that it's appropriate (such as when the user puts it on or
when a mobile device is placed in the headset.)

BUG= 389343 

Review-Url: https://codereview.chromium.org/2505493004
Cr-Commit-Position: refs/heads/master@{#432339}

[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_device.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_device.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_service.mojom
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplayEvent.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplayEvent.h

Project Member

Comment 118 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c

commit 1fe0f40829f0e14e7af0721d5047bd62ba1dd07c
Author: bajones <bajones@chromium.org>
Date: Wed Nov 16 01:29:01 2016

Wired up vrdisplayactivate/deactivate

These events allows pages to automatically enter or exit WebVR presentation when
the HMD indicates that it's appropriate (such as when the user puts it on or
when a mobile device is placed in the headset.)

BUG= 389343 

Review-Url: https://codereview.chromium.org/2505493004
Cr-Commit-Position: refs/heads/master@{#432339}

[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_device.cc
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_device.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/device/vr/vr_service.mojom
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplayEvent.cpp
[modify] https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c/third_party/WebKit/Source/modules/vr/VRDisplayEvent.h

Project Member

Comment 121 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4026d565687ddbc1f67c4cc04887c339b7a03685

commit 4026d565687ddbc1f67c4cc04887c339b7a03685
Author: klausw <klausw@chromium.org>
Date: Thu Nov 17 08:27:52 2016

WebVR: Use content CVC size for compositor rendering

We can't currently resize the content window used by the
compositor rendering path, so we must use its dimensions
for the WebVR API reported render sizes.

It includes a rather nasty hack to override canvas size to 100% if
it was manually set to something different. This works around
three.js examples not rendering right, apparently a fullscreened
canvas just gets centered if it explicitly sets a size smaller
than the fullscreen dimensions.

BUG= 389343 , 655722 

Review-Url: https://codereview.chromium.org/2508703002
Cr-Commit-Position: refs/heads/master@{#432811}

[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/4026d565687ddbc1f67c4cc04887c339b7a03685/third_party/WebKit/Source/modules/vr/VRDisplay.h

Project Member

Comment 123 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/650300dcb6a24933d499d74b57a20705efacab74

commit 650300dcb6a24933d499d74b57a20705efacab74
Author: klausw <klausw@chromium.org>
Date: Thu Nov 17 22:57:20 2016

WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG= 389343 , 666467 

Review-Url: https://codereview.chromium.org/2510083004
Cr-Commit-Position: refs/heads/master@{#433002}

[modify] https://crrev.com/650300dcb6a24933d499d74b57a20705efacab74/chrome/browser/android/vr_shell/vr_shell.cc

Project Member

Comment 124 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2846f5e75fb555fc8b943485ade6415c405ca3

commit 8a2846f5e75fb555fc8b943485ade6415c405ca3
Author: bajones <bajones@chromium.org>
Date: Fri Nov 18 02:55:13 2016

Added some tracing to VrShell

Should help identify how long we're spending in the frame rendering portion
of VrShell

BUG= 389343 

Review-Url: https://codereview.chromium.org/2513773002
Cr-Commit-Position: refs/heads/master@{#433032}

[modify] https://crrev.com/8a2846f5e75fb555fc8b943485ade6415c405ca3/chrome/browser/android/vr_shell/vr_shell.cc

Project Member

Comment 125 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c9f7733bd011ec909e3a5a60422b6c50066cb5

commit 96c9f7733bd011ec909e3a5a60422b6c50066cb5
Author: bajones <bajones@chromium.org>
Date: Fri Nov 18 07:54:43 2016

Notify VRDeviceProviders when there are pages listening for vrdisplayactivate

BUG= 389343 

Review-Url: https://codereview.chromium.org/2510993002
Cr-Commit-Position: refs/heads/master@{#433144}

[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_device_manager.cc
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_device_manager.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_device_provider.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_service.mojom
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_service_impl.cc
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/device/vr/vr_service_impl.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5/third_party/WebKit/Source/modules/vr/VRController.h

Labels: Merge-Request-56
Of the commits associated with this ticket, only https://chromium.googlesource.com/chromium/src.git/+/96c9f7733bd011ec909e3a5a60422b6c50066cb5 missed the M56 branch point. Requesting a merge so that we can ensure the feature works in it's entirety.

Comment 127 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
Project Member

Comment 128 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522153b5468b72cba5fde13ac25779da23c06f9c

commit 522153b5468b72cba5fde13ac25779da23c06f9c
Author: shaobo.yan <shaobo.yan@intel.com>
Date: Fri Nov 25 08:34:30 2016

Unittests updated in device/vr

Modify unit tests in device/vr.

BUG= 389343 

Review-Url: https://codereview.chromium.org/2514343006
Cr-Commit-Position: refs/heads/master@{#434455}

[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/BUILD.gn
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/BUILD.gn
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_device.h
[add] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_display_impl_client.cc
[add] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_display_impl_client.h
[add] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_service_client.cc
[add] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/test/fake_vr_service_client.h
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_device.h
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_device_manager.h
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_device_manager_unittest.cc
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_display_impl.h
[add] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_service_impl.h
[modify] https://crrev.com/522153b5468b72cba5fde13ac25779da23c06f9c/device/vr/vr_service_impl_unittest.cc

Project Member

Comment 129 by bugdroid1@chromium.org, Nov 30 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407c23ebf91c4645edc9441223a386152e3c0765

commit 407c23ebf91c4645edc9441223a386152e3c0765
Author: Brandon Jones <bajones@chromium.org>
Date: Wed Nov 30 17:24:19 2016

Notify VRDeviceProviders when there are pages listening for vrdisplayactivate

BUG= 389343 

Review-Url: https://codereview.chromium.org/2510993002
Cr-Commit-Position: refs/heads/master@{#433144}
(cherry picked from commit 96c9f7733bd011ec909e3a5a60422b6c50066cb5)

Review URL: https://codereview.chromium.org/2537403004 .

Cr-Commit-Position: refs/branch-heads/2924@{#192}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_device_manager.cc
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_device_manager.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_device_provider.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_service.mojom
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_service_impl.cc
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/device/vr/vr_service_impl.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/407c23ebf91c4645edc9441223a386152e3c0765/third_party/WebKit/Source/modules/vr/VRController.h

Labels: M-57 Launch-M-Target-56-Stable Launch-M-Target-57-Dev Launch-M-Target-57-Beta Launch-M-Target-57-Stable
Status: Fixed (was: Assigned)
This bug has gotten very noisy, so I'm closing it down. Future code commits should be against more granular bugs. OWP Launch status is now being tracked on https://bugs.chromium.org/p/chromium/issues/detail?id=670502
Clarification: The merge that's referred to in comment #129 was actually approved in  crbug.com/669271 , which was set up to make it clearer which CL we were actually merging from this beast of a bug.
Labels: -Merge-Review-56
The merge requested in c#126 was re-issued and approved in  issue 669271 .
Project Member

Comment 134 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c602e5dd72a6acd31dd4f76eb606b54db549b11

commit 1c602e5dd72a6acd31dd4f76eb606b54db549b11
Author: shaobo.yan <shaobo.yan@intel.com>
Date: Tue Dec 06 05:06:14 2016

Refine VRDevice Class

Since VRDisplayImpl knows its own VRService, VRDevice could only
contains VRDisplayImpl. This CL is a follow up for TODOs in VRDevice.

BUG= 389343 
R=bajones@chromium.org

Review-Url: https://codereview.chromium.org/2537723002
Cr-Commit-Position: refs/heads/master@{#436531}

[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_device.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_device.h
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_device_manager.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_device_manager.h
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_display_impl.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_display_impl.h
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_service_impl.cc
[modify] https://crrev.com/1c602e5dd72a6acd31dd4f76eb606b54db549b11/device/vr/vr_service_impl_unittest.cc

Components: Blink>WebXR
Showing comments 36 - 135 of 135 Older

Sign in to add a comment