Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users
Status: Fixed
Owner:
Email to this user bounced
Closed: Jan 2015
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment
hr element not exposed with a separator role
Project Member Reported by faulkner...@gmail.com, Jun 14 2014 Back to list
Version: <35>
OS: <windows 8.1>

HTML5 requires that the hr element is exposed in browsers with an ARIA role=separator. This maps to ROLE_SYSTEM_SEPARATOR in MSAA + IAccessible2 role . Currently the hr element is not exposed MSAA + IAccessible2 role 

HTML5 WAI-ARIA section http://www.w3.org/html/wg/drafts/html/master/dom.html#sec-strong-native-semantics
WAI-ARIA implementation guide role mapping table: http://www.w3.org/WAI/PF/aria-implementation/#mapping_role_table
hr element definition HTML5 http://www.w3.org/html/wg/drafts/html/master/grouping-content.html#the-hr-element


What is the expected behavior?  

hr element is exposed in MSAA + IAccessible2 role as ROLE_SYSTEM_SEPARATOR

Steps to reproduce

open https://dl.dropboxusercontent.com/u/377471/browser-tests/hr.html check the MSAA+IA2 role of the hr element role using an object inspection tool (aViewer for example: http://www.paciellogroup.com/resources/aviewer)  
 
Owner: shreera...@samsung.com
Status: Started
Can we mark this as fixed?

Project Member Comment 5 by bugdroid1@chromium.org, Nov 8 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc

commit fc47ce190a01e2a5cb5a38a38303c53047839afc
Author: shreeram.k <shreeram.k@samsung.com>
Date: Sat Nov 08 02:52:23 2014

AX_ROLE_HORIZONTAL_RULE is not required.

There is already SeparatorRole defined in blink, so better to remove HorizontalRuleRole from blink and return SeparatorRole for hr tag.
This patch makes the changes in chromium side.

This CL would be followed by one blink CL which will remove the defined redundant role in blink side and one chromium CL after that to enable AX test and exposing correctly on MAC platform.

BUG= 384723 

Review URL: https://codereview.chromium.org/709523002

Cr-Commit-Position: refs/heads/master@{#303364}

[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/chrome/common/extensions/api/automation.idl
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/shell/renderer/test_runner/web_ax_object_proxy.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/test/data/accessibility/hr-expected-win.txt
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/content/test/data/accessibility/hr.html
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/ui/accessibility/ax_enums.idl
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc47ce190a01e2a5cb5a38a38303c53047839afc/ui/accessibility/platform/ax_platform_node_mac.mm

Project Member Comment 6 by bugdroid1@chromium.org, Nov 11 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/708102a97f1d000bf29f6bd968940989fcb1ad11

commit 708102a97f1d000bf29f6bd968940989fcb1ad11
Author: shreeram.k <shreeram.k@samsung.com>
Date: Tue Nov 11 09:34:55 2014

Exposing hr tag with SplitterRole.

This is the third patch in series to remove the redundant role HorizontalRule Role.

This CL depends on https://codereview.chromium.org/703033006/

BUG= 384723 

Review URL: https://codereview.chromium.org/685783005

Cr-Commit-Position: refs/heads/master@{#303616}

[modify] https://chromium.googlesource.com/chromium/src.git/+/708102a97f1d000bf29f6bd968940989fcb1ad11/content/test/data/accessibility/hr-expected-mac.txt

Project Member Comment 7 by bugdroid1@chromium.org, Nov 11 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185002

------------------------------------------------------------------
r185002 | dcheng@chromium.org | 2014-11-08T05:11:29.781701Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185002&r2=185001&pathrev=185002

Mark accessibility/chromium-only-roles.html as failing.

It looks like this test needs to be rebaselined after the changes in
https://crrev.com/303364 are fully implemented.

BUG= 384723 
TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/708103003
-----------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Nov 11 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185053

------------------------------------------------------------------
r185053 | shreeram.k@samsung.com | 2014-11-10T18:05:31.221597Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AXRenderObject.cpp?r1=185053&r2=185052&pathrev=185053
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebAXEnums.h?r1=185053&r2=185052&pathrev=185053
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AXObject.h?r1=185053&r2=185052&pathrev=185053

hr tag should return SplitterRole.

Remove redundant role HorizontalRuleRole. HR tag should return SplitterRole.

This CL depends on https://codereview.chromium.org/709523002/

BUG= 384723 

Review URL: https://codereview.chromium.org/703033006
-----------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Nov 13 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185273

------------------------------------------------------------------
r185273 | shreeram.k@samsung.com | 2014-11-13T07:18:55.648967Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/chromium-only-roles.html?r1=185273&r2=185272&pathrev=185273
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185273&r2=185272&pathrev=185273
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/chromium-only-roles-expected.txt?r1=185273&r2=185272&pathrev=185273

Rebaseline accessibility/chromium-only-roles.html

This test was disabled because of changes related to html hr tag were in progress. But now those changes are complete, hence we can enable this layout test.

BUG= 384723 

Review URL: https://codereview.chromium.org/721753004
-----------------------------------------------------------------
Status: Fixed
this states its fixed, but when checking using this test file http://thepaciellogroup.github.io/AT-browser-tests/test-files/hr.html
and tthis chrome version Version 48.0.2564.103 m (64-bit) the <hr> is not exposed in acc tree.
Sign in to add a comment