New issue
Advanced search Search tips

Issue 383340 link

Starred by 1 user

Issue metadata

Status: Fixed
Closed: Dec 4
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 917355
issue 897969
issue 897970

issue 314403

Sign in to add a comment

Make Android ninja build deterministic

Project Member Reported by, Jun 11 2014

Issue description

1. Learn about android build system.
2. ninja -C out/Release clank_unittests
3. ren out out2
4. gclient runhooks
5. ninja -C out/Release clank_unittests

Content of out/ and out2/ is byte-for-byte identical.

They aren't.

This is specific about Android/ninja/<whatever default compiler>

Comment 1 by, Jun 11 2014

Blocking: chromium:314403
Project Member

Comment 2 by, Nov 5 2014

r292848 | | 2014-11-05T15:39:28.367468Z

Changed paths:

Add .apk to
BUG= 383340 

Review URL:

Comment 3 by, Nov 28 2014

Status: Fixed
It was fixed in r292869.
Project Member

Comment 4 by, Apr 21 2015

r294932 | | 2015-04-21T22:53:57.463104Z

Changed paths:

Disable the test isolation on the Android deterministic builder.

test_isolation_mode!=noop is not supported on android so the compile fails.

BUG= 383340 

Review URL:
Status: Started (was: Fixed)
The main bot is currently red and has been for a while, suggesting android sheriffs don't watch it:

Need to

1. Add the new files to the whitelist

2. File bugs for them to investigate

3. Talk to android sheriffs and make sure they feel responsible for the release bot, and mark bot as not experimental

The debug bot times out during comparison (

(+agrieve who is an android/infra person and may or may not have any insight on this :-))
Oh, the actual error:

Unexpected files with diffs:


The debug bot doesn't finish loading its output, so less clear what's happening over there.
Blockedon: 897969
Blockedon: 897970
Project Member

Comment 9 by, Oct 25

The following revision refers to this bug:

commit d80798db579edc48b03fe101122965e4572cafe5
Author: Nico Weber <>
Date: Thu Oct 25 01:46:42 2018

Update Android deterministic build whitelist.

apks/ChromePublicTest.apk was different in both of the two builds below,
the test apks were different once each.

Bug:  897969 , 383340 
Change-Id: I6b55470c5c1507856cbc416bc484b5cc1b5427f8
Reviewed-by: Takuto Ikuta <>
Commit-Queue: Nico Weber <>
Cr-Commit-Position: refs/heads/master@{#602567}

Project Member

Comment 10 by, Nov 29

The following revision refers to this bug:

commit 6caaa90989fac7b99060db4fa70da1dcb83fd0df
Author: Andrew Grieve <>
Date: Thu Nov 29 05:16:22 2018

Cronet: Make zero-out timestamps

Zero'ed timestamps means the build output is the same for each run,
which is generally desireable.

I checked that these two files were the same before/after:
 * cronet_api-src.jar
 * cronet_impl_common_java-src.jar

Where "the same" means they no longer contain directory entries
and also no "META-INF/MANIFEST.MF" file.

Bug:  383340 
Change-Id: I4f644378dc3c33e429010509202011dd7b7f9f95
Commit-Queue: agrieve <>
Reviewed-by: Paul Jensen <>
Cr-Commit-Position: refs/heads/master@{#612049}

Status: Fixed (was: Started)
I think this is fixed now?
Blockedon: 917355

Sign in to add a comment