New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2014
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 314403



Sign in to add a comment

Make Android ninja build deterministic

Project Member Reported by mar...@chromium.org, Jun 11 2014

Issue description

1. Learn about android build system.
2. ninja -C out/Release clank_unittests
3. ren out out2
4. gclient runhooks
5. ninja -C out/Release clank_unittests

Expected:
Content of out/ and out2/ is byte-for-byte identical.

Actual:
They aren't.

This is specific about Android/ninja/<whatever default compiler>
 

Comment 1 by mar...@chromium.org, Jun 11 2014

Blocking: chromium:314403
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 2014

------------------------------------------------------------------
r292848 | maruel@chromium.org | 2014-11-05T15:39:28.367468Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py?r1=292848&r2=292847&pathrev=292848

Add .apk to compare_build_artifacts.py.

R=sebmarchand@chromium.org
BUG= 383340 

Review URL: https://codereview.chromium.org/703763004
-----------------------------------------------------------------

Comment 3 by mar...@chromium.org, Nov 28 2014

Cc: -sebmarchand@chromium.org mar...@chromium.org
Owner: sebmarchand@chromium.org
Status: Fixed
It was fixed in r292869.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2015

------------------------------------------------------------------
r294932 | sebmarchand@chromium.org | 2015-04-21T22:53:57.463104Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/swarming/deterministic_build.py?r1=294932&r2=294931&pathrev=294932
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_build.json?r1=294932&r2=294931&pathrev=294932

Disable the test isolation on the Android deterministic builder.

test_isolation_mode!=noop is not supported on android so the compile fails.

BUG= 383340 

Review URL: https://codereview.chromium.org/1097423003
-----------------------------------------------------------------

Sign in to add a comment