Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 37865 M5 toolbar updates, Mac
Starred by 15 users Project Member Reported by estade@chromium.org, Mar 10 2010 Back to list
Status: Verified
Owner:
ex-Googler
Closed: Apr 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 40419
issue 40463

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
like  bug 37864 , but for mac
 
Labels: MrBotRecommends
This an automated note...
Recommendations based on labels Feature-Omnibox and os-mac from activity in the last 60 days
	pkasting@chromium.org(Recommended)
Labels: ReleaseBlock-Beta
Status: Assigned
Thanks for talking with Peter about this.
Now that r42502 has landed, the first task to do here is to split the security icon and 
label apart and move the icon to the left of the address, to match what has happened on 
Windows.
Summary: M5 toolbar updates, Mac (was: NULL)
Here are all the other tasks still to do, so you don't have to cross-reference the 
Windows bug:

* Move the Star button to the right side of the location bar (right of all page 
actions) and reverse its bubble arrow side (dunno if this applies on Mac).  Move the 
reload button to where the Star was and eliminate Reload.  This task is probably 
going to be almost completely platform-specific and could be started now.

* Eliminate the Home button by default in new installs.  Hopefully a cross-platform 
change you don't need to worry about.

* Don't show "http://" on URLs by default.  Hopefully mostly cross-platform (by 
modifying the string that "formats a URL for display") but may have platform-specific 
code related to what happens when we copy the URL (behavior not firmly decided yet to 
my knowledge).

* Pull in the sides of the omnibox dropdown to be aligned with the editable area, 
make the top corners square, and move up to look "attached" to the editable area.  
Completely platform-specific.  Could be started now.

* Where the security icon is moving to, show the globe icon on non-secure URLs, and 
show the icon matching the user's omnibox selection while the user is editing.  This 
depends on both the security icon move and some other cross-platform work I'm going 
to do here to try and plumb the right icon type through the toolbar model, but after 
that there will also be platform-specific changes.

* Clicking the icon should show page info (it already does), and dragging from it 
should make it a drag source for the URL.  Platform-specific, could be started now or 
wait until the icon changes above happen.

* Change the tab-to-search UI to show a magnifying glass on the left end of the 
"Search foo.com:" blue bubble.  See mock atop  bug 27570 .  Platform-specific, could be 
started now.
Comment 5 by sh...@chromium.org, Mar 24 2010
WRT the new security icon, would like to verify: In the future there will ALWAYS be an icon over there except in 
tab-to-search mode.  Even for NTP.
Yes.  (When the bar is blank the icon is going to be the magnifying glass.)
Comment 7 by sh...@chromium.org, Mar 27 2010
Status: Started
Informal status update: I've wired up the location icon, should fit with Peter's 
changes, also the ssl label.  Refactored action icons in the autocomplete field a bit 
to clean up some cruft.  In process of wiring up support for moving the star, and the 
popup frame mod.
I have landed the changes to show the globe or edit-specific icons where the security 
icon is (the third-to-last bullet).
Comment 9 by sh...@chromium.org, Mar 31 2010
alcor, do you have a reload_endcap_Template.pdf?  [The reload version of star_Template.pdf.]

Also, I'm currently using star_noborder_center.png and starred_noborder_center.png for the star icon in the 
page-actions area.  This works reasonably (PDF may not be an option here for the near term), but the icon sizes 
are funky WRT regular page actions (22x22 vs 19x19).  I can hard-code the page-action size to make things 
look good, are there going to be real icon drops or are estade's icons what we're using?
I believe pkasting is holding onto the real icons
Comment 11 by sh...@chromium.org, Mar 31 2010
I completely lied, hard-coding the size will be moderately annoying.  But doable if we have to go there.  Evan, 
would it break you badly if I trimmed the star icons to 19x19, which is Extension::kPageActionIconMaxSize?
my guess it that it would make 0 difference for gtk because the image is centered.
(vertically speaking --- I guess it would affect the horizontal padding, but I haven't 
made that pixel perfect yet anyway; waiting on mocks from alcor for that)
Comment 14 by sh...@chromium.org, Mar 31 2010
On Mac I'm laying it out just like a page action, so wider is wider and narrower is 
narrower.  Variable space for icons may be an historical artifact, though, in which 
case I could just lay it out in 19x19 cells.
Comment 15 by zero...@gmail.com, Mar 31 2010
@9: We have a reload template PDF in the tree already, and neither it nor the star 
template have a button underneath them, they're both just the glyph.  w.r.t. star 
icons, the "noborder" and "noborder center" ones in the tree are the ones that will be 
staying AFAIK.
(Sigh, comment 15 is me)
Comment 17 by sh...@chromium.org, Mar 31 2010
#15, yeah, I figured that out later on, I was just being stupid when I rearranged buttons.

Note to self: page-action overflow handling needs to be handled, or a bug entered.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43249 

------------------------------------------------------------------------
r43249 | shess@chromium.org | 2010-03-31 13:07:13 -0700 (Wed, 31 Mar 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.h?r1=43249&r2=43248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm?r1=43249&r2=43248

[Mac] Rearrange SSL status icon/label in omnibox.

Refactor action icons with an eye towards adding additional icons in
the future.  Renames the SSL status icon to be compatible with
pkasting's upcoming changes, and splits it between the icon on the
left and the label floating on the right.

BUG= 37865 
TEST=SSL icon should be to the left, and clickable.
TEST=SSL label should float to the left of page actions and not be clickable.

Review URL: http://codereview.chromium.org/1566004
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43286 

------------------------------------------------------------------------
r43286 | shess@chromium.org | 2010-03-31 16:37:17 -0700 (Wed, 31 Mar 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43286&r2=43285

[Mac] Fix DCHECK() on page actions in preview.

Page actions can be image-less for a bit until their image loads.  The
image is visible and a default size is used.  The DCHECK() just wanted
to make sure that we weren't accidentally drawing an image of one size
into a rect of a different size.

BUG= 37865 
TEST=No DCHECK installing an extension.

Review URL: http://codereview.chromium.org/1605002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43357 

------------------------------------------------------------------------
r43357 | shess@chromium.org | 2010-04-01 10:22:25 -0700 (Thu, 01 Apr 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=43357&r2=43356
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43357&r2=43356
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=43357&r2=43356
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=43357&r2=43356

[Mac] Line up omnibox popup under field.

Also line up the icons.  Spacing can be adjusted later.

BUG= 37865 
TEST=Popup edges line up under field edges.
TEST=Popup icons and text should line up under field icon and text.

Review URL: http://codereview.chromium.org/1608001
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43376 

------------------------------------------------------------------------
r43376 | shess@chromium.org | 2010-04-01 12:47:18 -0700 (Thu, 01 Apr 2010) | 22 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBubble.xib?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=43376&r2=43375
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=43376&r2=43375

[Mac] Move star button into page-actions area of omnibox.

Removes the star button from the toolbar entirely.  Adds a
LocationBarImageView subclass for the star icon and wires it to the
RHS of the field.  Adjust the bookmark bubble to move the arrow to the
RHS and position appropriately.

BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right.

Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing.  All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there.

BUG= 37865 
TEST=No star icon on toolbar.
TEST=Optional home button adjustments should work right.
TEST=Star action in omnibox when showing an URL.
TEST=Star action can be clicked to bookmark current page.
TEST=Bookmark bubble arrow points at star like before.
TEST=Command-d brings up bookmark bubble.
TEST=Star action changes from blank to yellow depending on state.
TEST=Star action tooltip changes depending on state.

Review URL: http://codereview.chromium.org/1540009
------------------------------------------------------------------------

Status update:

DONE: star to right, reversed bubble arrow, moved reload.
UNKNOWN: Eliminate Home by default.
UNKNOWN: Eliminate "http://" on URLs by default.
DONE: Omnibox drop-down alignment and attachment.
DONE: Moved location icon.
TODO: Drag from location icon.
INPROGRESS: Tab-to-search magnifying glass.
TODO: Separator to right of SSL label.  Right now is just label then icons.
TODO: Consistent icon sizing (pkasting has a thread on this somewhere).
TODO: "Verified by <...>" as SSL label tooltip.
TODO: Pester UI team about spacing around location icon WRT omnibox popup.
Eliminate Home by default: beng
Eliminate "http://" on URLs by default: Punted to M6
Separator to right of SSL label: The position/conditions for this are trickier than 
stated, this is probably punt to M6
"Verified by <...>" as SSL label tooltip: We're not going to have a tooltip for this 
icon
Pester UI team about spacing around location icon WRT omnibox popup: Probably becomes 
more sane once the icon sizes are all consistent
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43540 

------------------------------------------------------------------------
r43540 | shess@chromium.org | 2010-04-02 15:39:50 -0700 (Fri, 02 Apr 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43540&r2=43539
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm?r1=43540&r2=43539
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac_unittest.mm?r1=43540&r2=43539

[Mac] Magnifying glass in keyword-search bubble.

Abstract the image-in-attributed-string code into a helper function so
everyone makes the same mistakes.  The keyword-search string's
baseline became wrong at some point, adjust it to match the rest of
the field.

BUG= 37865 
TEST=Type "google.com" until "press tab to search" appears, hit TAB.  "Search Google:" bubble should have a magnifying glass on the LHS.
TEST=Add a bunch of text to search.  Resizing smaller should first remove the image, then change to shorter text ("Search Go..." or somesuch).

Review URL: http://codereview.chromium.org/1581011
------------------------------------------------------------------------

Labels: Mstone-6-b3
Labels: Mstone-5-b3
 Issue 40031  has been merged into this issue.
Blockedon: 40419
Marking  Issue 40419  as blocking, it was logged by someone to track the vertical icon spacing under location 
item.
 Issue 40383  has been merged into this issue.
Blockedon: 40463
Labels: -ReleaseBlock-Beta
Removing release block from all these assuming that things that were marked 
5-b3 were meant for targeting and not blocking.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=43971 

------------------------------------------------------------------------
r43971 | shess@chromium.org | 2010-04-08 11:10:35 -0700 (Thu, 08 Apr 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=43971&r2=43970
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_unittest.mm?r1=43971&r2=43970
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.h?r1=43971&r2=43970
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm?r1=43971&r2=43970

[Mac] Location icon in omnibox as drag source.

Wire up location icon to allow dragging if the user click-drags or
click-holds.  Otherwise falls through to the page-info display.

BUG= 37865 
TEST=When omnibox shows an URL, click-drag the globe initiates an URL drag.
TEST=Drop it in web content.
TEST=Drop it in safari.
TEST=Drop it on bookmark bar.

Review URL: http://codereview.chromium.org/1567023
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=44152 

------------------------------------------------------------------------
r44152 | shess@chromium.org | 2010-04-09 16:04:08 -0700 (Fri, 09 Apr 2010) | 10 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_history.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_green.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_invalid.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_valid.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_more.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_star.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.h?r1=44152&r2=44151
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=44152&r2=44151
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=44152&r2=44151
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=44152&r2=44151
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar_view_mac.mm?r1=44152&r2=44151
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=44152&r2=44151

[Mac] PDF icons for omnibox.

Replaces the various resources used for omnibox icons with PDF images.
The use of copies is because the field is flipped while the popup is
unflipped (and the icons get flipped to match).

BUG= 37865 
TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug.

Review URL: http://codereview.chromium.org/1629010
------------------------------------------------------------------------

Status: Fixed
OK, I'm marking this one closed.

 Issue 40999  is about popup positioning WRT resolution independence.  I don't think it's worth blocking mstone-
5.

 Issue 40463  is about the star and page-action icons being present when search hints and the like are active.  I 
believe it's marked blocking.
The Star bookmarks icon being on the right sucks.. please put it back to its' original 
location.
The reload button is good where it is.. I agree with that.. but it should look like the 
home button, and the Star should be where it used to be.
Comment 37 by sh...@chromium.org, Apr 11 2010
 Issue 41038  has been merged into this issue.
Status: Verified
Chrome version: 5.0.381.0 r44886. 
This is fixed , and Logged few other minor issues , and are tracking them as separate
bugs instead of morphing this.
Closing.
Comment 39 by Deleted ...@, Oct 2 2010
please, please move the bookmark star BACK to the left - or at least make it configurable!  
Project Member Comment 40 by bugdroid1@chromium.org, Oct 12 2012
Blockedon: -chromium:40419 -chromium:40463 chromium:40419 chromium:40463
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 41 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Omnibox Cr-UI-Browser-Omnibox Cr-UI
Sign in to add a comment