New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 377359 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to edit the bookmark name.

Reported by mni...@etouch.net, May 26 2014

Issue description

chrome Version       :  37.0.2013.2 (Official Build 272766)
OS :  Windows

What steps will reproduce the problem?
1) Launch chrome, click on 'Bookmark icon' (start icon). 
2) Click on folder drop-dwon box, then click on 'Name' text field and delete 'New tab' text and try to enter any character.

What is the expected result?
Should able to edit the bookmark name.

What happens instead?
Unable to edit the bookmark name.

This is a Regression issue broken in 'M-37' and will provide the bisect info soon.

 

Comment 1 by mni...@etouch.net, May 26 2014

Cc: fsam...@chromium.org sadrul@chromium.org sky@chromium.org
Labels: OS-Linux Cr-IO-Keyboard Cr-UI
Owner: kevers@chromium.org
Status: Assigned
Summary: Regression: Unable to edit the bookmark name. (was: Regression: Unable to the edit bookmark name.)
Narrow bisect info:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=270802%3A270822

Suspecting r270818 or r270816 or r270809
Could you please reassign to correct dev if its not related to your change?

Note : Issue is not reproducible on Mac OS.
Actual_bookmark_edit.mp4
811 KB Download
Expected_bookmark_edit.mp4
581 KB Download
Labels: ReleaseBlock-Beta
Able to reproduce the issue. Adding Blocker label as this is has broken functionality. 
Labels: OS-Chrome
Reproducible in Chrome 37.0.2017.3/ CrOS 5899.2.0 - Butterfly.  
the exact bug described by OP is reproducible in version:
Google Chrome	37.0.2023.0 (Official Build 274036) canary
OS	Windows
-----------------------------------------
However I have some seemingly related glitch to report here:
What steps will reproduce the problem?
1) open any page, click the Pentagram/Star button in URL bar for bookmarking.
2) In the drop-down box, click the [edit...] button.
3) In the bookmark tree structure, try to edit any folder name by right-clicking on the folder and select edit in the menu.
4) try input characters by keyboard in the textfield.

What is the expected result?
   The textfield should be editable using keyboard.

What happens instead?
   Can not input any character in the field other than using tab/Esc to quit editing or using backspace to delete existing text.

Additional information:
   1.This bug does not take effect when you try to edit the textfield immediately after create a New Folder using the [New Folder] button in step 3.(i.e. you can edit the textfield freely at this moment, but not after you finish the editing.)       
   2.Text can still be copied from system clipboard into the field.


Labels: Iteration-107
Status: Started
Cc: pneubeck@chromium.org krisr@chromium.org josa...@chromium.org bmahadev@chromium.org tienchang@chromium.org
 Issue 378914  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/466ebdf6c681f9713d5657aa948a3bbdb4a815cc

commit 466ebdf6c681f9713d5657aa948a3bbdb4a815cc
Author: kevers@chromium.org <kevers@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 02 23:52:03 2014

Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text fields."

The fix to use OnTextInputTypeChanged in place of OnFocus and OnBlur to resolve focus loss on text field navigation has introduced a number of regressions. As it turns out, the fix is no longer even necessary to address the original bug that it was intended to address (365741).  This patch is a revert of r270818.

BUG= 375125 , 377359 , 378914 

Review URL: https://codereview.chromium.org/302363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274374 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2014

------------------------------------------------------------------
r274374 | kevers@chromium.org | 2014-06-02T23:52:03.045505Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/textfield/textfield_unittest.cc?r1=274374&r2=274373&pathrev=274374
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/textfield/textfield.cc?r1=274374&r2=274373&pathrev=274374

Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text fields."

The fix to use OnTextInputTypeChanged in place of OnFocus and OnBlur to resolve focus loss on text field navigation has introduced a number of regressions. As it turns out, the fix is no longer even necessary to address the original bug that it was intended to address (365741).  This patch is a revert of r270818.

BUG= 375125 , 377359 , 378914 

Review URL: https://codereview.chromium.org/302363002
-----------------------------------------------------------------
Also cannot type in the box to change a folder name in the bookmarks list in Version 37.0.2017.2 dev-m.  Copy/paste works as a temporary workaround.
Status: Fixed

Comment 11 Deleted

Well its awkward that you guys eliminated this bug in Canary but I am now experiencing it in dev-channel and below versions (I tried beta and stable also).is this normal because you haven't merge it into these versions?

Currently using : Version 37.0.2024.2 dev-m

Comment 13 Deleted

Comment 14 by Deleted ...@, Jun 10 2014

2031.2 dev-m has a problem with the text as well.  This is most noticeable in Gmail.  Prominent vertical lines have also appeared as column separators in the main scrolling window of Gmail, though that may not be related.

Note: the appearance of blurred text and shifting blurred text on mouseover persists in this version.  Please move this post if I've responded in the incorrect thread.  Also, this occurs with and without DPI compatibility settings checked in Windows 8.1 on 1920x1080 display.  Disabling display scaling used to address a similar issue.
Re #14: The issues you are reporting appear to be unrelated to the originally reported bug of being unable to enter text.  Please file as a separate bug.  The bug fix here is unrelated to text quality on high-DPI displays.

Comment 16 Deleted

Status: Verified

Google Chrome	37.0.2052.1 (Official Build 277355) dev
Platform	5963.0.0 (Official Build) dev-channel 

Sign in to add a comment