New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Jan 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 327832



Sign in to add a comment

Drop quirk: ignore style on table elements

Project Member Reported by zcorpan@gmail.com, May 5 2014 Back to list

Issue description

Version: 36.0.1974.2 canary
OS: all

What steps will reproduce the problem?
1. Use display:inline on table, tbody, tr, td in quirks mode
2.
3.

What is the expected output? What do you see instead?
The table is rendered as an inline-table with the rows and columns intact.
Expected to render as display:inline as in standards mode.

Please use labels and text to provide additional information.
http://quirks.spec.whatwg.org/ does not specify this quirk because Gecko does not have it.
We need to fix  bug 53693  before dropping this quirk in order to not break Web sites that specify display:inline on only table and expect inline-table behavior.
 

Comment 1 by loyso@chromium.org, May 20 2015

Owner: loyso@chromium.org

Comment 2 by loyso@chromium.org, May 20 2015

Blockedon: -chromium:53693 chromium:327832

Comment 3 by loyso@chromium.org, May 20 2015

Labels: Needs-Feedback Cr-Blink-Layout-Table
Owner: ----
Is it a duplicate for 327832?
Labels: -Needs-Feedback Hotlist-Interop
Status: Available
Simple test case:

data:text/html,
<table id="table"></table>
<script>
table.style.display = 'inline';
document.body.textContent = `Table display property computes to "${getComputedStyle(table).display}", expecting "inline".`;
</script>

Comment 5 by zcorpan@gmail.com, Jan 11 2016

This bug appears to cause some trouble: https://news.ycombinator.com/item?id=10880935

Comment 6 by robho...@gmail.com, Jan 18 2016

Status: Fixed

Comment 7 by robho...@gmail.com, Jan 18 2016

Status: Available

Comment 8 by nainar@chromium.org, Jan 19 2016

Owner: nainar@chromium.org
Status: Started
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aea8a9a12d5a3b60bb022953825f900f90e7b4b

commit 0aea8a9a12d5a3b60bb022953825f900f90e7b4b
Author: nainar <nainar@chromium.org>
Date: Wed Jan 20 14:16:29 2016

Don't force display:inline-table/table on table elements when in quirks mode

Currently in quirks mode we force table elements to display:inline-table
or table. This current action is not supported in quirks spec and is
inconsistent with Gecko. This leads to elements with display set to
lose that information. This patch fixes that and allows those elements
with display to retain this state even in quirks mode.

BUG= 369979 

Review URL: https://codereview.chromium.org/1607703003

Cr-Commit-Position: refs/heads/master@{#370382}

[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/TestExpectations
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/editing/execCommand/insertHTML-expected.txt
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/editing/execCommand/insertHTML.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/editing/pasteboard/innerText-inline-table.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/editing/selection/inline-table.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/editing/selection/table-caret-3.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/fast/borders/table-borders.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/fast/dom/inner-text-001.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/fast/encoding/utf-16-big-endian.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/fast/encoding/utf-16-little-endian.html
[add] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html
[modify] http://crrev.com/0aea8a9a12d5a3b60bb022953825f900f90e7b4b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Status: Fixed

Comment 11 by zcorpan@gmail.com, Jan 21 2016

Thanks for fixing!

It appears the code still forces display on <td> elements though. (And float.) Filed followup bug https://code.google.com/p/chromium/issues/detail?id=580053
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78195a4ace7d557d0a6604e2a6adcaccc2f3641d

commit 78195a4ace7d557d0a6604e2a6adcaccc2f3641d
Author: Walter Korman <wkorman@google.com>
Date: Tue Jan 26 01:51:03 2016

Auto-rebaseline for r370382

https://chromium.googlesource.com/chromium/src/+/0aea8a9a1

BUG= 369979 
TBR=nainar@chromium.org

Review URL: https://codereview.chromium.org/1634913003 .

Cr-Commit-Position: refs/heads/master@{#371415}

[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/TestExpectations
[add] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/android/fast/table/table-display-types-expected.png
[add] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/android/fast/table/table-display-types-expected.txt
[add] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/android/fast/table/table-display-types-vertical-expected.png
[add] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/android/fast/table/table-display-types-vertical-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/linux/fast/table/table-display-types-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/linux/fast/table/table-display-types-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/linux/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/linux/fast/table/table-display-types-vertical-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac-lion/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac-mavericks/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac-snowleopard/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-display-types-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-display-types-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-display-types-vertical-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/win/fast/table/table-display-types-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/win/fast/table/table-display-types-expected.txt
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/win/fast/table/table-display-types-vertical-expected.png
[modify] http://crrev.com/78195a4ace7d557d0a6604e2a6adcaccc2f3641d/third_party/WebKit/LayoutTests/platform/win/fast/table/table-display-types-vertical-expected.txt

Sign in to add a comment