New issue
Advanced search Search tips

Issue 368830 link

Starred by 226 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2014
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Implement the picture element and related HTMLImageElement source selection

Project Member Reported by y...@yoav.ws, Apr 30 2014

Issue description

(See http://www.chromium.org/blink#launch-process for an overview)

Change description:
Enable a responsive images solution for the "art direction" use case, allowing authors to provide multiple image sources, varying according to media-query based breakpoints. 

Changes to API surface:
* HTMLPictureElement
* HTMLSourceElement - media, srcset and sizes attributes
* HTMLImageElement - a modified resource selection algorithm when a parent HTMLPictureElement is present.

Links:
Public standards discussion: http://picture.responsiveimages.org/

Support in other browsers:
Internet Explorer: Under consideration
Firefox: Actively worked on
Safari: Not yet



 
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173440

------------------------------------------------------------------
r173440 | yoav@yoav.ws | 2014-05-06T22:02:13.513724Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=173440&r2=173439&pathrev=173440

Add a picture runtime flag

BUG= 368830 

Review URL: https://codereview.chromium.org/265833002
-----------------------------------------------------------------

Comment 2 by tkent@chromium.org, May 7 2014

Labels: Blink-Image

Comment 3 by tkent@chromium.org, May 7 2014

Labels: -Blink-Image Cr-Blink-Image
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173727

------------------------------------------------------------------
r173727 | yoav@yoav.ws | 2014-05-09T06:31:16.715920Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSourceElement.idl?r1=173727&r2=173726&pathrev=173727

Add picture related attributes to Source

As part of the picture specification, the source element gets added with several new attributes, that are used in HTMLImageElement's source selection algorithm.
This CL adds these attributes.

BUG= 368830 

Review URL: https://codereview.chromium.org/267693002
-----------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, May 20 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174354

------------------------------------------------------------------
r174354 | yoav@yoav.ws | 2014-05-20T09:07:53.906450Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-invalid-expected.txt?r1=174354&r2=174353&pathrev=174354
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-1x-expected.txt?r1=174354&r2=174353&pathrev=174354
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-nested.html?r1=174354&r2=174353&pathrev=174354
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/resources/image-set-1x.png?r1=174354&r2=174353&pathrev=174354
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/resources/image-set-2x.png?r1=174354&r2=174353&pathrev=174354
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=174354&r2=174353&pathrev=174354
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-invalid.html?r1=174354&r2=174353&pathrev=174354
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-1x.html?r1=174354&r2=174353&pathrev=174354
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html?r1=174354&r2=174353&pathrev=174354
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=174354&r2=174353&pathrev=174354
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParser.h?r1=174354&r2=174353&pathrev=174354
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html?r1=174354&r2=174353&pathrev=174354
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-picture-nested-expected.txt?r1=174354&r2=174353&pathrev=174354

Add HTMLPictureElement-based source selection to HTMLImageElement

This CL adds HTMLPictureElement-based source selection algorithm to 
HTMLImageElement and makes sure that the right resource is picked when
HTMLImageElement has an HTMLPictureElement parent.

BUG= 368830 

Review URL: https://codereview.chromium.org/288033018
-----------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174711

------------------------------------------------------------------
r174711 | yoav@yoav.ws | 2014-05-23T21:11:40.186680Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-sizes-expected.txt?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-nested-expected.txt?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-sizes.html?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-sizes-2x-expected.txt?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-invalid-expected.txt?r1=174711&r2=174710&pathrev=174711
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/resources/picture-preload-helper.js?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-nested.html?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-sizes-2x.html?r1=174711&r2=174710&pathrev=174711
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.h?r1=174711&r2=174710&pathrev=174711
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-picture-invalid.html?r1=174711&r2=174710&pathrev=174711

Add preloader support for picture based source selection

This CL adds preloader support to the source selection algorithm used by HTMLImageElement when it has a picture parent.

BUG= 368830 

Review URL: https://codereview.chromium.org/265763010
-----------------------------------------------------------------
According to the site, the spec has now been superseded. http://picture.responsiveimages.org/ now displays the message:

This specification has been superseded. See the HTML Standard[1] (or the Web developer version[2]).

With links to:
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/edits.html#embedded-content
[2] http://developers.whatwg.org/edits.html#embedded-content

Comment 9 by y...@yoav.ws, Jun 27 2014

That's true. Last week the picture specification was integrated into the WHATWG HTML spec, and no longer lives as a separate specification.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 23 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=178754

------------------------------------------------------------------
r178754 | yoav@yoav.ws | 2014-07-23T12:41:28.026846Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt?r1=178754&r2=178753&pathrev=178754
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=178754&r2=178753&pathrev=178754

Turn on the picture runtime flag by default

Following the discussion on the "intent to ship" thread (https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t3KRycUCGA8/VTJMRx20XiwJ ), this CL turns the flag on by default.

BUG= 368830 

Review URL: https://codereview.chromium.org/401403003
-----------------------------------------------------------------

Comment 11 by y...@yoav.ws, Jul 23 2014

Status: Fixed

Comment 12 by y...@yoav.ws, Jul 23 2014

 Issue 233751  has been merged into this issue.

Sign in to add a comment