New issue
Advanced search Search tips
Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
M-5

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 36798: Update mac tabstrip to support mini-tabs

Reported by sky@chromium.org, Feb 25 2010 Project Member

Issue description

The mac tabstrip needs to be updated to support mini-tabs. See the patches 
in 32845 for specifics.
 

Comment 1 by mikesmith@chromium.org, Feb 26 2010

Labels: Mstone-5 ReleaseBlock-Stable

Comment 2 by mikesmith@chromium.org, Feb 26 2010

Status: Assigned

Comment 3 by marceloc...@gmail.com, Mar 9 2010

Any update for this one ? As I can see it is already working on linux and windows.

Cheers

Comment 4 Deleted

Comment 5 by pinkerton@chromium.org, Mar 19 2010

Status: Untriaged
re-requesting triage.

Comment 6 by mikesmith@chromium.org, Mar 19 2010

Labels: UI-Needed
Status: Assigned
No Mac team anymore - can you take care of this. Thanks!

Comment 7 by sky@chromium.org, Mar 19 2010

Status: Available
I will not have time to do this before M5.

Comment 8 by rsesek@chromium.org, Mar 20 2010

Status: Started

Comment 9 by brian@chromium.org, Mar 22 2010

Labels: -UI-Needed
wrong use of ui-needed (that's for mocks). Ben's looking for an owner.

Comment 10 by sky@chromium.org, Mar 23 2010

rsesek has a patch out for review that fixes this:)

Comment 11 by mikesmith@chromium.org, Mar 23 2010

Labels: -Pri-2 -ReleaseBlock-Stable Pri-1 ReleaseBlock-Beta

Comment 12 by bugdro...@gmail.com, Mar 24 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42548 

------------------------------------------------------------------------
r42548 | rsesek@chromium.org | 2010-03-24 15:33:08 -0700 (Wed, 24 Mar 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/defaults.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/defaults.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service_unittest.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_menu_model.cc?r1=42548&r2=42547

[Mac] Re-enable pinned tabs; add support for mini-tabs and phantom tabs.

This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.

BUG= 36798 ,  32845 
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.

Review URL: http://codereview.chromium.org/1119005
------------------------------------------------------------------------

Comment 13 by rsesek@chromium.org, Mar 24 2010

Status: Fixed

Comment 14 by deepakg@chromium.org, Mar 30 2010

Status: Verified
Verified in 5.0.365.0 (Official Build 43016)

Comment 15 by bugdroid1@chromium.org, Oct 12 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 16 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Mstone-5 M-5 Cr-UI

Comment 17 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment