New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 28 users
Status: Fixed
Owner:
Closed: Sep 2014
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----
Product-Review: ----


Sign in to add a comment
Implement Web Application Manifest
Project Member Reported by mlamouri@chromium.org, Apr 23 2014 Back to list
Description:
This specification defines a JSON-based manifest, which provides developers with a centralized place to put metadata associated with a web application. This includes, but is not limited to, the web application's name, links to icons, as well as the preferred URL to open when the user launches the web application. The manifest also allows developers to declare a default orientation for their web application, as well as how the application is to be displayed by the user agent (e.g., in fullscreen).

Using this meta data, user agents can provide developers with means to create user experiences that are more comparable to that of a native application.

Specification: https://w3c.github.io/manifest/

Support in other browsers:
Internet Explorer: public support
Firefox: proprietary implementation, working on standard one
Safari: no public signal
 
Project Member Comment 1 by bugdroid1@chromium.org, May 8 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173664

------------------------------------------------------------------
r173664 | mlamouri@chromium.org | 2014-05-08T18:47:49.297910Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/data/link-manifest-change.html?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/FrameLoaderClientImpl.cpp?r1=173664&r2=173663&pathrev=173664
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkManifest.cpp?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkRelAttribute.cpp?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameLoaderClient.h?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/FrameLoaderClientImpl.h?r1=173664&r2=173663&pathrev=173664
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkManifest.h?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkRelAttribute.h?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkResource.h?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebFrameTest.cpp?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebFrameClient.h?r1=173664&r2=173663&pathrev=173664
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=173664&r2=173663&pathrev=173664

Detect <link rel='manifest'> and notify embedder.

WebFrameClient gets a dispatchManifestChange method that will
be called by the FrameLoaderClient when the manifest
information might have changed. The embedder is not aware of
the manifest URL.

BUG= 366145 

Review URL: https://codereview.chromium.org/249633002
-----------------------------------------------------------------
Project Member Comment 2 by bugdroid1@chromium.org, May 10 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173823

------------------------------------------------------------------
r173823 | mlamouri@chromium.org | 2014-05-10T12:48:18.315671Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.h?r1=173823&r2=173822&pathrev=173823
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.cpp?r1=173823&r2=173822&pathrev=173823
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=173823&r2=173822&pathrev=173823
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentTest.cpp?r1=173823&r2=173822&pathrev=173823

Implement the logic to find the correct <link> for Manifest in Document.

This is will then be use by WebFrame to get the data from the
HTMLLinkElement and fetch the ressource.

BUG= 366145 

Review URL: https://codereview.chromium.org/270283007
-----------------------------------------------------------------
Comment 3 by mathi...@opera.com, Jun 2 2014
Cc: w...@marcosc.com
 Issue 377671  has been merged into this issue.
Blockedon: chromium:409696
Blockedon: chromium:409996
Blockedon: chromium:410414
Blockedon: chromium:410419
Project Member Comment 8 by bugdroid1@chromium.org, Sep 10 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=181725

------------------------------------------------------------------
r181725 | mlamouri@chromium.org | 2014-09-10T10:39:33.511034Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=181725&r2=181724&pathrev=181725
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=181725&r2=181724&pathrev=181725

Do not use a Blink feature flag for Manifest.

BUG= 366145 

Review URL: https://codereview.chromium.org/557283002
-----------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Sep 16 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b

commit efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Sep 16 16:55:40 2014

Implement ManifestManager to handle manifest in content/.

This can be used from the renderer process or the browser
process. Requesting the manifest can be done via one call, a
callback has to be passed and will run with the manifest
passed as parameter. A failure will return the empty
manifest.

Some more logic could be added like caching the manifest in
the browser process or keeping track of the manifest dirty
state in the browser process but those things can be added
transparently later.

BUG= 366145 

Review URL: https://codereview.chromium.org/537053002

Cr-Commit-Position: refs/heads/master@{#295085}

[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/manifest/OWNERS
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/manifest/manifest_browsertest.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/manifest/manifest_manager_host.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/manifest/manifest_manager_host.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/web_contents/web_contents_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/browser/web_contents/web_contents_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/common/content_message_generator.h
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/common/manifest_manager_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/content_browser.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/content_common.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/content_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/content_tests.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/public/browser/web_contents.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/public/common/manifest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/public/common/manifest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/public/renderer/render_frame_observer.h
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/renderer/manifest/manifest_manager.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/renderer/manifest/manifest_manager.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/renderer/render_frame_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/renderer/render_frame_impl.h
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/404-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/dummy-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/dummy-manifest.json
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/dynamic-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/empty-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/empty-manifest.json
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/no-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/parse-error-manifest.html
[add] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/content/test/data/manifest/parse-error-manifest.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/efdca9d8f31e7aa0ce7cb7a2eff5f08dead2498b/ipc/ipc_message_start.h

Project Member Comment 10 by bugdroid1@chromium.org, Sep 16 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac

commit 89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Sep 16 19:29:58 2014

Merge Android RetrieveWebappInformation and Extensions GetApplicationInfo.

This is refactoring some code and also allows add to homescreen to use
<meta name='application-name'>.

BUG= 366145 

Review URL: https://codereview.chromium.org/568823003

Cr-Commit-Position: refs/heads/master@{#295125}

[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/browser/android/shortcut_helper.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/browser/extensions/tab_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/browser/extensions/tab_helper.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/browser/web_applications/web_app_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/chrome_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/chrome_tests_unit.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/chrome_constants.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/chrome_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/extensions/chrome_extension_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/render_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/web_application_info.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/common/web_application_info.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/renderer/chrome_render_view_observer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/renderer/chrome_render_view_observer.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac//dev/null
[delete] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac//dev/null
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/renderer/web_apps.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/89ccc63d3e5ad5893006d0e445750ecdfcb2c5ac/chrome/renderer/web_apps.h

Blocking: chromium:414873
Project Member Comment 12 by bugdroid1@chromium.org, Sep 16 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45

commit c267d1ed82d7911e06f63775ea26a07b0d718c45
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Sep 16 21:34:41 2014

Add support for 'start_url' in Manifest.

BUG= 366145 

Review URL: https://codereview.chromium.org/577673004

Cr-Commit-Position: refs/heads/master@{#295147}

[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/browser/manifest/manifest_manager_host.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/common/manifest_manager_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/public/common/manifest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/renderer/manifest/manifest_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/renderer/manifest/manifest_manager.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/renderer/manifest/manifest_parser.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/renderer/manifest/manifest_parser.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c267d1ed82d7911e06f63775ea26a07b0d718c45/content/renderer/manifest/manifest_parser_unittest.cc

Project Member Comment 13 by bugdroid1@chromium.org, Sep 17 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b225ae560fea0648b61fad36b5972221a7f5c47d

commit b225ae560fea0648b61fad36b5972221a7f5c47d
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Sep 17 11:51:37 2014

Use Web Manifest when creating a shortcut on Chrome Android.

This is using the short_name and the name set in the Manifest.

BUG= 366145 

Review URL: https://codereview.chromium.org/573073002

Cr-Commit-Position: refs/heads/master@{#295256}

[modify] https://chromium.googlesource.com/chromium/src.git/+/b225ae560fea0648b61fad36b5972221a7f5c47d/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/b225ae560fea0648b61fad36b5972221a7f5c47d/chrome/browser/android/shortcut_helper.h

Project Member Comment 16 by bugdroid1@chromium.org, Sep 18 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9317a291b84457b9a8feb8ecd94d0593bb0fff9b

commit 9317a291b84457b9a8feb8ecd94d0593bb0fff9b
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Sep 18 11:49:07 2014

Use Manifest.display when creating a shortcut on Android.

The display property will be used only if properly set and
parsed. If used, it will override the signal sent by the
'apple-web-app-capable' and 'mobile-web-app-capable' meta
tags.

This CL is implemented on top of
https://codereview.chromium.org/563083004/

BUG= 366145 

Review URL: https://codereview.chromium.org/576153002

Cr-Commit-Position: refs/heads/master@{#295457}

[modify] https://chromium.googlesource.com/chromium/src.git/+/9317a291b84457b9a8feb8ecd94d0593bb0fff9b/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9317a291b84457b9a8feb8ecd94d0593bb0fff9b/chrome/browser/android/shortcut_helper.h

Project Member Comment 17 by bugdroid1@chromium.org, Sep 18 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1

commit c806854f11967371b4f2fd87b91a3706077776b1
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Sep 18 15:58:34 2014

Create org.chromium.content_public.common and move two classes there.

ScreenOrientationValues and Referrer are being moved there. Another
class regarding shortcuts and default orientaiton will also be added.

BUG= 366145 
TBR=avi@chromium.org (for content/content.gyp)

Review URL: https://codereview.chromium.org/584523003

Cr-Commit-Position: refs/heads/master@{#295473}

[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/android_webview/java_library_common.mk
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItemDelegate.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/EmptyChromeContextMenuItemDelegate.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/content.gyp
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/BUILD.gn
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java
[rename] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/java/src/org/chromium/content_public/common/Referrer.java
[rename] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationValues.template
[modify] https://chromium.googlesource.com/chromium/src.git/+/c806854f11967371b4f2fd87b91a3706077776b1/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

Project Member Comment 18 by bugdroid1@chromium.org, Sep 18 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918

commit 350ce8afc8e4a34c1bb2f51659a7ae9c329a7918
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Sep 18 18:17:21 2014

Use Manifest's orientation when creating a shortcut and as default orientation.

The orientation's value will be passed to the shortcut intent and will
then be used when trying to find out the default orientation.

BUG= 366145 
TBR=eseidel@chromium.org (for chrome/browser/DEPS change)

Review URL: https://codereview.chromium.org/579883002

Cr-Commit-Position: refs/heads/master@{#295498}

[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/chrome/browser/DEPS
[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/chrome/browser/android/shortcut_helper.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[add] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java

Project Member Comment 19 by bugdroid1@chromium.org, Sep 24 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808

commit c00b78f53f2bc38d19c0dd671a6558160d98f808
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Sep 24 10:37:06 2014

Add support for icons.{src,type,density} in Manifest.

This is not yet supporting icons.sizes. It will be
implemented in a separate CL because the algorithm might be
more complex and could require some code sharing with Blink.

BUG= 366145 

Review URL: https://codereview.chromium.org/590563002

Cr-Commit-Position: refs/heads/master@{#296382}

[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/browser/manifest/manifest_manager_host.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/common/manifest_manager_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/public/common/manifest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/public/common/manifest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/renderer/manifest/manifest_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/renderer/manifest/manifest_parser.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c00b78f53f2bc38d19c0dd671a6558160d98f808/content/renderer/manifest/manifest_parser_unittest.cc

Project Member Comment 21 by bugdroid1@chromium.org, Sep 24 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1

commit c679bbfd5b692c6fd9e415933eb400c91bd3dbf1
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Sep 24 21:24:49 2014

Use Manifest.icons instead of favicon in ShortcutHelper when possible.

The algorithm is first trying to find an image to fit exactly the
required size in the device scale factor and default scale factor.
If it can't it will try to find the closest but preferrable largest
image. Note that the algorithm completely ignore an entry with no 'sizes'.

Fetching the image happens as soon as the Manifest is loaded and can be
done before or after the call to ShortcutHelper::AddShortcut().

BUG= 366145 
TEST=ShortcutHelperTest

Review URL: https://codereview.chromium.org/601433002

Cr-Commit-Position: refs/heads/master@{#296522}

[modify] https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1/chrome/browser/android/shortcut_helper.h
[add] https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1/chrome/browser/android/shortcut_helper_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/c679bbfd5b692c6fd9e415933eb400c91bd3dbf1/chrome/chrome_tests_unit.gypi

Labels: M-39
Status: Fixed
The initial work for Manifest in Chromium M39 is done.

The manifest parser handles name, short_name, start_url, icons, orientation and display. There is only one consumer of the Manifest as of now, it is ShortcutHelper (Android only) which supports all of the attributes to some extent.
Project Member Comment 23 by bugdroid1@chromium.org, Oct 7 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=183317

------------------------------------------------------------------
r183317 | kenneth.r.christiansen@intel.com | 2014-10-07T08:42:52.050235Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-manifest.html?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed-expected.txt?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/csp/CSPDirectiveList.cpp?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked.html?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/csp/ContentSecurityPolicy.cpp?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/directive-parsing-manifest-expected.txt?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/URLTestHelpers.cpp?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest.test/manifest.json?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/csp/CSPDirectiveList.h?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/csp/ContentSecurityPolicy.h?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/URLTestHelpers.h?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/AssociatedURLLoader.cpp?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/data/link-manifest-fetch.json?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/WebFrameTest.cpp?r1=183317&r2=183316&pathrev=183317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fetch/ResourceFetcher.cpp?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest-src-allowed.html?r1=183317&r2=183316&pathrev=183317
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/manifest.test?r1=183317&r2=183316&pathrev=183317

Implement CSP check for manifest fetching

The CSP bits include the 'manifest-src' directive, but _not_ the
forthcoming "manifest that sets a CSP for its documents" feature.

BUG= 366145 

Review URL: https://codereview.chromium.org/570563003
-----------------------------------------------------------------
Project Member Comment 24 by bugdroid1@chromium.org, Oct 7 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e

commit 269f776a43e8d4534d8040f953a427c91ec4f44e
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Oct 07 21:24:31 2014

[Manifest] Add metrics recording.

This is recording whether the manifest fetching was successful or failed.
It is also recording which properties are present in the parsed Manifest
and whether the output of the parsing is empty.
Finally, it is recording whether a Manifest was used when creating a
shortcut.

BUG= 366145 

Review URL: https://codereview.chromium.org/622813002

Cr-Commit-Position: refs/heads/master@{#298575}

[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/chrome/browser/android/shortcut_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/content/content_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/content/renderer/manifest/manifest_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/content/renderer/manifest/manifest_parser.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/content/renderer/manifest/manifest_uma_util.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/content/renderer/manifest/manifest_uma_util.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/tools/metrics/actions/actions.xml
[modify] https://chromium.googlesource.com/chromium/src.git/+/269f776a43e8d4534d8040f953a427c91ec4f44e/tools/metrics/histograms/histograms.xml

Blocking: chromium:323307
Blockedon: chromium:437210
Project Member Comment 27 by bugdroid1@chromium.org, Dec 15 2014
Sign in to add a comment