New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2014
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove pipelining code from Chrome

Project Member Reported by mmenke@chromium.org, Apr 17 2014 Back to list

Issue description

No one's working on getting the pipelining code enabled by default, and the code hasn't been touched for 2.5 years or so.  Long periods of disuse can lead to bit rot, and it also imposes a non-negligible maintenance burden when adding new features and when refactoring code.

That having been said, its impact on binary size is negligible (< 2k).

So let's get rid of it.  If we want to investigate it in the future, we can bring it back.

I don't expect this to be a huge amount of work.
 
SGTM. Does that get rid of the persisted settings related to pipelining as well?

Comment 2 by mmenke@chromium.org, Apr 17 2014

I'll need to make sure we don't keep those around.

Comment 3 by mmenke@chromium.org, May 27 2014

Status: Fixed
Landed in revision 272903 (https://codereview.chromium.org/275953002/).  Not sure why bots aren't updating this bug.
Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2014

------------------------------------------------------------------
r272903 | mmenke@chromium.org | 2014-05-27T00:39:10.594649Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/network_stats_uploader.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/test_server_locations.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_chunked_decoder.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_connection_impl.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_capability.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/test_server_locations.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/net_log_event_type_list.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_network_transaction_unittest.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_impl.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/http_pipeline_view.html?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_impl.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/buffered_write_stream_socket.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/google_chrome_distribution.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gypi?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/chrome_app_host_distribution.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_session.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/google_chrome_distribution.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_job.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_pool.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_pool.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_test_util.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/net_internals/http_pipeline_view.js?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/browser_distribution.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_request.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/chrome_frame_distribution.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_request.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_body_drainer.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_body_drainer.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_context_builder.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_stream.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/main.js?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_impl_unittest.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_forced_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/buffered_write_stream_socket_unittest.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_connection.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_pool_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/load_timing_info.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/net_log_source_type_list.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/index.html?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_test_util.h?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_pipelining_compatibility_client_unittest.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_pipelining_compatibility_client.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/index.js?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_connection_impl.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_body_drainer_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_context_builder.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_stream.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/net_internals/log_util.js?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/net_error_list.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/buffered_write_stream_socket.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_forced.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_job.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/http_pipeline_view.js?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/google_apis/gcm/tools/mcs_probe.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties_impl.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties_impl.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/browser_distribution.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/network_stats_uploader.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/google_chrome_distribution_dummy.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_connection_impl_unittest.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_pipelining_compatibility_client.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/chrome_frame_distribution.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/http_pipelining?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/net_internals/net_internals_test.js?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/jingle/glue/proxy_resolving_client_socket.cc?r1=272903&r2=272902&pathrev=272903
   D http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_forced.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/net_internals/main.js?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/chrome_app_host_distribution.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_session.h?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc?r1=272903&r2=272902&pathrev=272903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/net_internals/browser_bridge.js?r1=272903&r2=272902&pathrev=272903

Remove HTTP pipelining support.

It's been a couple years since anyone worked on it, and there
are no plans to enable it by default.

Cached pipelining-related server information will automatically
be cleared when server information is next saved, so there are
no issues on that front.

BUG= 364557 
R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/275953002
-----------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 26 2014

Sign in to add a comment