New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 3641 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Aug 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

When Google Chrome is default browser on two accounts on Vista, unable to use on second

Reported by google-c...@gtempaccount.com, Oct 22 2008

Issue description

What steps will reproduce the problem?
1. Install Google Chrome on first account.
2. Install on second account
3. Open options of Google Chrome in first Windows system account, and set
Google Chrome as default system browser.
4. Open options of Google Chrome in second Windows system account, and set
Google Chrome as default system browser.

What is the expected output? 
Able to use Google Chrome on both accounts.

What do you see instead?
On second account: can't open ftp, http and https-links.


Vista SP 1. Able to see two instances of Google Chrome application.

 

Comment 1 by cpu@chromium.org, Oct 22 2008

So in Vista SP1 the bug does not appear? only on Vista release?


Labels: -Area-Misc Area-Installer
Status: Available
Yes this is a known problem. see b/1275250. I am going to close that one so that we 
can track this issue here.
 Issue 2543  has been merged into this issue.
 Issue 7571  has been merged into this issue.
 Issue 7602  has been merged into this issue.

Comment 6 by bugdro...@gmail.com, Jul 23 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21428 

------------------------------------------------------------------------
r21428 | kuchhal@chromium.org | 2009-07-23 12:51:18 -0700 (Thu, 23 Jul 2009) | 19 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/setup_main.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.h?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.h?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/util_constants.cc?r1=21428&r2=21427
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/util_constants.h?r1=21428&r2=21427

Allow two user level installs of Chrome to have default browser settings.

This change will allow two Windows users to install thier own copy of Chrome
and set it as default browser. There is a bunch of refactoring in this change.
- Divided the registry entries into three categories:
  * Entries that are only read from HKLM
  * Entries that actually tie file/protocol associations to Chrome. This will
    almost always be in HKCU (except when it is a OEM install).
  * Entries that we can create in HKCU if we fail to create them in HKLM.
- For single user machine nothing should change.
- For two users on the same machine (each with a different user level Chrome
installed), the second user's default browser will get renamed to
Chromium.<user> and the required registry entries will also be renamed so that
they do not overwrite first users's registry entries.

BUG= 3641 
TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install.

Review URL: http://codereview.chromium.org/159172
------------------------------------------------------------------------

Status: Fixed
This should be fixed now. It involved lot of code refactoring. Even though I tested all 
the common cases, I might have missed some combinations since we have so many of them.

Sunand, can you test this more thoroughly whenever you test installer next?
Status: Assigned
Issue 1:
On Vista Admin, UAC ON, 
- If Chrome is not made default ChromeExt and ChromeHTML are written @ 
HKEY_CURRENT_USER\Software\Classes\ChromeHTML
- If  Chrome is made default then they are written @ 
HKEY_CURRENT_USER\Software\Classes and HKEY_LOCAL_MACHINE\SOFTWARE\Classes\

 Issue 2 :
On Vista Admin, UAC ON,
- Install Chrome in Admin(user1) and make it as default browser. This will write 
ChromeExt and ChromeHTML @ HKEY_LOCAL_MACHINE\SOFTWARE\Classes\
-Install Chrome in NonAdmin(user2) and make it as default browser. This will prompt 
for Admin credentials. Enter the credentials of user1
***This is supposed to write ChromeExt.user2 and ChromeHTML.user2 @ 
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\ but it doesn't***

I have to verify a lot of other cases too. I will continue sometime tomorrow.

Comment 9 by bugdro...@gmail.com, Jul 31 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22204 

------------------------------------------------------------------------
r22204 | kuchhal@chromium.org | 2009-07-31 14:59:10 -0700 (Fri, 31 Jul 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.cc?r1=22204&r2=22203

Add missing space to command line that registers Chrome on Windows.

So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>".

BUG= 3641 
TBR=huanr

Review URL: http://codereview.chromium.org/160481
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22282 

------------------------------------------------------------------------
r22282 | kuchhal@chromium.org | 2009-08-03 10:30:44 -0700 (Mon, 03 Aug 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.cc?r1=22282&r2=22281

Add missing space to command line that registers Chrome on Windows.

So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>".

BUG= 3641 
TBR=huanr

Committed: http://src.chromium.org/viewvc/22194

Review URL: http://codereview.chromium.org/160481
------------------------------------------------------------------------

Status: Fixed
Status: Verified
Verified on XP, Vista UAC ON and UAC OFF with Chromium 3.0.197.0 (Developer Build 
22383)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=23192 

------------------------------------------------------------------------
r23192 | mal@chromium.org | 2009-08-12 11:26:27 -0700 (Wed, 12 Aug 2009) | 23 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/shell_integration.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/install.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/setup_main.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/uninstall.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/setup/uninstall.h?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/shell_util.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/shell_util.h?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/util_constants.cc?r1=23192&r2=23191
   M http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/installer/util/util_constants.h?r1=23192&r2=23191

Merge 21428 - Allow two user level installs of Chrome to have default browser settings.

This change will allow two Windows users to install thier own copy of Chrome
and set it as default browser. There is a bunch of refactoring in this change.
 Divided the registry entries into three categories:
  * Entries that are only read from HKLM
  * Entries that actually tie file/protocol associations to Chrome. This will
    almost always be in HKCU (except when it is a OEM install).
  * Entries that we can create in HKCU if we fail to create them in HKLM.
 For single user machine nothing should change.
 For two users on the same machine (each with a different user level Chrome
installed), the second user's default browser will get renamed to
Chromium.<user> and the required registry entries will also be renamed so that
they do not overwrite first users's registry entries.

BUG= 3641 
TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, userlevel install/systemlevel install.

Review URL: http://codereview.chromium.org/159172

TBR=kuchhal@chromium.org

Review URL: http://codereview.chromium.org/164408
------------------------------------------------------------------------

Labels: -Area-Installer Area-Internals Internals-Install
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Internals-Install Cr-Internals-Install Cr-Internals
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Internals-Install Cr-Internals-Installer

Sign in to add a comment