New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
Closed: Nov 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Sign in to add a comment
[Canvas2D] [Metabug] Clean-up non-standard APIs in CanvasRenderingContext2D
Project Member Reported by junov@chromium.org, Apr 14 2014 Back to list
There are a number of non-standard APIs in CanvasRenderingContext2D that are completely redundant with existing standard APIs. We need to track their usage and move for deprecation and/or removal on a case by case basis.

Individual features are tracked in the child bugs.

The APIs slated for deprecation and/or removal are:

    void setAlpha(float alpha);
    void setCompositeOperation(DOMString compositeOperation);

    void setLineWidth(float width);
    void setLineCap(DOMString cap);
    void setLineJoin(DOMString join);
    void setMiterLimit(float limit);
    void clearShadow();

    void setStrokeColor([StrictTypeChecking] DOMString color, optional float alpha);
    void setStrokeColor(float grayLevel, optional float alpha);
    void setStrokeColor(float r, float g, float b, float a);
    void setStrokeColor(float c, float m, float y, float k, float a);

    void setFillColor([StrictTypeChecking] DOMString color, optional float alpha);
    void setFillColor(float grayLevel, optional float alpha);
    void setFillColor(float r, float g, float b, float a);
    void setFillColor(float c, float m, float y, float k, float a);

    void drawImageFromRect(HTMLImageElement image,
                           optional float sx, optional float sy, optional float sw, optional float sh,
                           optional float dx, optional float dy, optional float dw, optional float dh,
                           optional DOMString compositeOperation);

   void setShadow(float width, float height, float blur, [StrictTypeChecking] optional DOMString color, optional float alpha);
    void setShadow(float width, float height, float blur, float grayLevel, optional float alpha);
    void setShadow(float width, float height, float blur, float r, float g, float b, float a);
    void setShadow(float width, float height, float blur, float c, float m, float y, float k, float a);


First step is to track usage to see where these stand.
 
Project Member Comment 1 by bugdroid1@chromium.org, Apr 16 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171798

------------------------------------------------------------------
r171798 | junov@chromium.org | 2014-04-16T19:49:50.587409Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=171798&r2=171797&pathrev=171798
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.idl?r1=171798&r2=171797&pathrev=171798

Adding use counters for non-standard 2D canvas APIs

BUG= 363198 

Review URL: https://codereview.chromium.org/240353003
-----------------------------------------------------------------
Comment 2 by pava...@samsung.com, Sep 23 2014
Blockedon: chromium:363192
Cc: pavan.e@chromium.org
@junov, i suppose we have the usage data by now for these non standard apis.

If you approve, i can send an intent mail for these apis.
Comment 3 by junov@chromium.org, Sep 23 2014
There already was an intent thread. And by now there has been enough simmer time for the stats. I intend to revive the code review I have on standby as soon as we branch for M39
Comment 4 by pava...@samsung.com, Sep 24 2014
Oh, i see. Sorry for barging in. :)

I searched for intent thread related to this but i couldn't find. 
So, i thought i could take this up. Never mind. :)


Comment 6 by phil...@opera.com, Nov 18 2014
Cc: phil...@opera.com
The Intent to Remove now has the necessary LGTMs.
Project Member Comment 7 by bugdroid1@chromium.org, Nov 22 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185835

------------------------------------------------------------------
r185835 | junov@chromium.org | 2014-11-22T02:56:05.930408Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-color-serialization.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setShadow-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-2-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-6-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/set-colors-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setShadow.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect.html?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.idl?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-2.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/set-colors-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-color-serialization-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-6.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.cpp?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-3-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-7-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-currentColor.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-3.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-7.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-overloads-setFillColor.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-4-expected.txt?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.h?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/resources/shadow-offset.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setStrokeColor-expected.txt?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/image-object-in-canvas.html?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-currentColor-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-4.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setFillColor-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-overloads-setShadow.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-6-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-5-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setStrokeColor.html?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-3-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/shadow-offset-5-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-7-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/canvas-overloads-setStrokeColor.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/canvas-overloads-setFillColor.html?r1=185835&r2=185834&pathrev=185835
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/script-tests/set-colors.js?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-currentColor-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/shadow-offset-5.html?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/shadow-offset-2-expected.png?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/canvas/stroke-with-system-color-and-alpha-crash-expected.txt?r1=185835&r2=185834&pathrev=185835
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/shadow-offset-4-expected.png?r1=185835&r2=185834&pathrev=185835

Remove non-standard API entry points in CanvasRenderingContext2D

Rmoving the API entry points for the following 2d canvas methods:
setAlpha
setCompositingOperation
setLineWidth
setLineCap
setLineJoin
setMiterLimit
clearShadow
setStrokeColor
setFillColor
drawImageFromRect
setShadow

According to usage statistics, these entry points are not used anywhere
on the web. They are undocumented and redundant with existing standard
APIs.

BUG= 363198 , 363165 , 363166 , 363180 , 363181 , 363184 , 363185 , 363186 , 363188 , 363189 , 363191 

Review URL: https://codereview.chromium.org/408813007
-----------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Nov 22 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185837

------------------------------------------------------------------
r185837 | wangxianzhu@chromium.org | 2014-11-22T05:05:20.667680Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/virtual/gpu/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/gpu/fast/canvas/image-object-in-canvas-expected.txt?r1=185837&r2=185836&pathrev=185837
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png?r1=185837&r2=185836&pathrev=185837

Auto-rebaseline for r185835

http://src.chromium.org/viewvc/blink?view=revision&revision=185835

BUG= 363198 
TBR=junov@chromium.org

Review URL: https://codereview.chromium.org/753743002
-----------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Nov 22 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185844

------------------------------------------------------------------
r185844 | pdr@chromium.org | 2014-11-22T21:43:25.182354Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185844&r2=185843&pathrev=185844

Manually rebaseline fast/canvas/image-object-in-canvas.html after r185835

This test is failing [1] at head due to r185835 [2]. Lets try another
rebaseline and see if it cleans these up.

[1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fimage-object-in-canvas.html%2C%20fast%2Fcanvas%2Fimage-object-in-canvas.html
[2] https://src.chromium.org/viewvc/blink?view=rev&revision=185835

NOTRY=true
TBR=junov,timvolodine
BUG= 363198 

Review URL: https://codereview.chromium.org/751893002
-----------------------------------------------------------------
Comment 10 by junov@chromium.org, Nov 24 2014
Status: Fixed
Sign in to add a comment