New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 362303 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Treat Shill Service.ClearProperties failures in the success callback as warnings

Project Member Reported by steve...@chromium.org, Apr 10 2014

Issue description

Repro: Attempt to connect to an OpenVPN network that does not require a certificate.

Error:
"Failed to connect to network 'MyVPN': Failed to configure network"

From the event log:
network_configuration_handler.cc:416 ClearProperties Failed: OpenVPN.Pkcs11.ID: /service/84

The problem is that Chrome clears the property to ensure that it is not set, and Shill indicates that it failed to clear the property if it has never been set.

Generally this should be fine, but currently Chrome treats this as an error and a failure when it should really just treat it as a warning.

 
Status: Started
Labels: CrosUiCurrentIteration
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2014

------------------------------------------------------------------
r265370 | stevenjb@chromium.org | 2014-04-22T21:37:08.343993Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/network/network_configuration_handler.h?r1=265370&r2=265369&pathrev=265370
   M http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/network/network_configuration_handler.cc?r1=265370&r2=265369&pathrev=265370

Don't treat Shill ClearProperty errors as failures.

BUG= 362303 
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/243103004
-----------------------------------------------------------------
Status: Verified
Able to connect to openvpn with only the CA (no user certificate) with no error.

Verified with 5808.0.0, R36

Comment 6 Deleted

Is there a workaround for users still using the previous version?
No workaround that I am aware of or can think of.

/me switches to dev channel =/

Sign in to add a comment