New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 359377 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 323873
issue 381588

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Eliminate the archived history database

Project Member Reported by pkasting@chromium.org, Apr 3 2014

Issue description

Peering through the history archiving code, it seems that while we archive URLs periodically, we never do anything with the archived DB.  AFAICT we do not display it on the history page, or search through it for history or omnibox searches.

It seems like we should either hook up the archived DB to do useful things, or get rid of it entirely and delete all related code and all archive files on disk.
 
I have no objections to deleting it.  I believe that pages only visited more than three months ago are not likely to be useful for omnibox purposes at least.

Labels: Cr-Privacy
Owner: dubroy@chromium.org
Status: Assigned
Patrick, PTAL.

Comment 3 by vabr@chromium.org, Apr 11 2014

Cc: engedy@chromium.org
Cc-ing engedy@, as just today he told me he is working on the bug of archived history popping up in suggestions without a way to delete it

Comment 4 by engedy@chromium.org, Apr 11 2014

We do surface archived history items in two places:
 (1) Searches on the chrome://history page.
 (2) Searches through the History API.

In fact, I have just started writing a fix for  Issue 323873 , to also make it possible to remove archived history items that show up as results. A similar defect is present with the History API.

If we decide to get rid of the whole thing, I am just the happier.

Comment 5 by engedy@chromium.org, Apr 16 2014

Cc: sky@chromium.org dubroy@chromium.org
Labels: M-36
Owner: engedy@chromium.org
Status: Started
Following an off-line discussion, we have consensus to remove this.

Comment 6 by dubroy@chromium.org, Apr 17 2014

sgtm

Comment 7 by engedy@chromium.org, May 21 2014

Labels: -M-36 M-37
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2014

------------------------------------------------------------------
r275159 | engedy@chromium.org | 2014-06-05T16:44:38.529323Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/favicon_cache.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend_unittest.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_querying_unittest.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/url_database.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.h?r1=275159&r2=275158&pathrev=275159
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/archived_history.4.sql?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.h?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/url_database.h?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_notifications.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_notifications.h?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_unittest.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/typed_url_syncable_service.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=275159&r2=275158&pathrev=275159
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/archived_database.cc?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/typed_url_syncable_service.h?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=275159&r2=275158&pathrev=275159
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/archived_database.h?r1=275159&r2=275158&pathrev=275159
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc?r1=275159&r2=275158&pathrev=275159

Eliminate the archived history database and clean up related code.

More specifically, this change list:
 * Removes all code related to the archived history database, and removes all mentions of it from comments.
 * Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
 * Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
 * Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.

BUG= 359377 
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/235863023
-----------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd05b97364507693c99110f642c611c929252cd4

commit cd05b97364507693c99110f642c611c929252cd4
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 05 16:44:38 2014

Eliminate the archived history database and clean up related code.

More specifically, this change list:
 * Removes all code related to the archived history database, and removes all mentions of it from comments.
 * Adds some code to purge the legacy database file on disk on first start-up, plus a unit test to check that this works.
 * Removes a migration path from M17 which was responsible for migrating some components, all of which have been unimplemented since then, except for the archived database, which, however, is now being removed.
 * Removes a tiny amount of code and some mentions of a "supplementary URL index" on the URLs table (this was unimplemented a long time ago). This is needed because otherwise some updated comments would be confusing.

BUG= 359377 
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/235863023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275159 0039d316-1c4b-4281-b951-d872f2087c98


Status: Fixed
Summary: Eliminate the archived history database (was: Hook up archived history to somewhere useful, or eliminate it)
The deed is done.
Blocking: chromium:381588
Blocking: chromium:323873
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d753c94adbbe38d1163a3fda57e620626fd9c295

commit d753c94adbbe38d1163a3fda57e620626fd9c295
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 12:49:25 2014

Remove recovery diagnostics for the archived history database.

The reason is that the archived history database feature has been removed as of r275159.

BUG= 359377 

Review URL: https://codereview.chromium.org/316063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276998 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 15 by bugdroid1@chromium.org, Jun 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908431e63848edfd99d78ec0cec0277bbea6e48a

commit 908431e63848edfd99d78ec0cec0277bbea6e48a
Author: kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 16:09:24 2014

Revert 276998 "Remove recovery diagnostics for the archived hist..."

Broke Linux ChromiumOS Tests.

> Remove recovery diagnostics for the archived history database.
> 
> The reason is that the archived history database feature has been removed as of r275159.
> 
> BUG= 359377 
> 
> Review URL: https://codereview.chromium.org/316063003

TBR=engedy@chromium.org

Review URL: https://codereview.chromium.org/333803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277030 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 17 by bugdroid1@chromium.org, Jul 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a7e95c78c04d996ab325c81f73507964419e6b

commit 28a7e95c78c04d996ab325c81f73507964419e6b
Author: engedy@chromium.org <engedy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 02 12:41:26 2014

Remove recovery diagnostics for the archived history database.

The reason is that the archived history database feature has been removed as of r275159.

BUG= 359377 

Review URL: https://codereview.chromium.org/334633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281003 0039d316-1c4b-4281-b951-d872f2087c98


Disappointed about this. I just spent two hours looking for an old link (one that just today became important) I'd visited in May before I discovered (by manually paging through my Chrome history) that Chrome only saves 90 days of history; further research turned up the ability to access the "archived history" database, which I was unable to find, which led me to this.

Count me as a bit peeved that you guys implemented this "fix."

Rather ironic that the king of amassing data (Google) has decided that anything I did more than 90 days ago isn't worth knowing.
Since the archived history database was never accessible from any Chrome UI anywhere, the changes here haven't changed the behavior of Chrome, which has been consistent since our 2008 launch.

So if you want to complain, don't complain about this bug.
pkasting, allow me to disagree. In fact, the entries older than 90 days were accessible from the Chrome UI, which has led to the discovery of at least  Issue 323873 ,  Issue 332743 ,  Issue 339130 ,  Issue 341839 ,  Issue 355088 , and  Issue 367447 . So not only have people had the possibility of accessing older history entries, they also did so often enough to find behavior inconsistent with the access to more recent history entries.
Argh.  When we discussed removing the archived history DB, the claim was that we don't use it anywhere anyway.  It's pretty annoying to find out that that wasn't true.

Given how atrociously awful the History page is at finding anything anyway, it's not as if this was a terribly reliable feature, but still.  Frustrating.  Thanks for the bug links.
Peter, back then, we did, in fact, debate the value provided by surfacing archived entries (see Comment #4 and also the off-line discussion per e-mail).  We arrived at pretty much the same conclusion as you have above: more code and more space on the user's disk for a feature that provides little value, is inconsistent and broken in several aspects, and would require a non-trivial amount of engineering effort to get into a reliably working state.

We can reconsider if this turns out to be a lot more useful than we had initially thought.
Well, today is just the day when I
(1) Can't read, and
(2) Am wrong

I apologize to everyone for repeatedly saying false things.  I'm going to go slink away from this bug now.

Comment 25 Deleted

Comment 26 by gnh...@euronet.nl, Nov 16 2014

Why exactly this function is removed? Because of the large disc space it is going to use overtime? Is it possible to put it back again as an option in chrome? So it isn't enable by default? I was happy with this function. Even though I don't use the function much, it's a very usefull function. Now i need it and it's gone... :( useually i use it in fall or winter times to view what i viewd in the spring or summer of the year. So 3 months is to less! Please put the function back!
Labels: Restrict-AddIssueComment-EditIssue
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3199711171ab3760a9b8f940f1befa2bc9f591c

commit a3199711171ab3760a9b8f940f1befa2bc9f591c
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Thu Sep 10 09:26:50 2015

Removed archived history file deletion on browser start

Remove delete of archived history file on browser start.
Archived history file usage was removed since M37.

BUG= 359377 

R=engedy@chromium.org

Review URL: https://codereview.chromium.org/1311403011

Cr-Commit-Position: refs/heads/master@{#348126}

[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend.h
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_backend_db_unittest.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_constants.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/browser/history_constants.h
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/test/history_backend_db_base_test.cc
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/components/history/core/test/history_backend_db_base_test.h
[delete] http://crrev.com/69a18f2bd871839d6ef9994f17b3e0ffd37d244b/components/test/data/history/archived_history.4.sql
[modify] http://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c/tools/metrics/histograms/histograms.xml

Sign in to add a comment