New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug

Blocking:
issue 42770

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Devtools stop working when chrome gets updated

Project Member Reported by thakis@chromium.org, Feb 15 2010

Issue description

Chrome Version (from the about:version page): Update from 307.5 to 
5.0.222.2 dev (but I saw that before during another update too.
Is this the most recent version: Yes

What steps will reproduce the problem?
1. Develop a webapp, use chrome's devtools, minding your own business
2. In the meantime, let chrome silently autoupdate in the background

What is the expected result?

Devtools continue working

What happens instead?

Devtools break after refreshing the page after the autoupdate happened.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

Maybe the devtools js file is not zygotized?
 

Comment 1 by evan@chromium.org, Feb 16 2010

Labels: Pri-2 Mstone-5
Status: Available
Labels: -Area-Undefined Area-Internals autoclass
Using an automated filter to classify this issue into an area...gulp

Comment 3 by evan@chromium.org, Feb 19 2010

Labels: -autoclass
Labels: -Mstone-5 Mstone-6
If anyone feels strongly about fixing this for 5.0, please feel free.  At this point it seems like a narrow issue so I'm 
punting to 6.0.
If it's the case that we need to zygotize the devtool js files, then let's just pack 
up the entire resources/ directory into a .pak file, open it in the browser so we have 
a handle to it, and fix the way we access these files. We already tunnel through the 
browser process to get to these files since the devtool / bookmark manager renderers 
don't have direct file system access, right?

I see there's bookmark manager and net internal resources there too, cc: arv.

Comment 6 by evan@chromium.org, Apr 7 2010

I thought we already did pack up the devtools js.  I think it would start faster too 
without needing to load all the subfiles separately.

Comment 7 by arv@chromium.org, Apr 7 2010

Mike is working on exposing shared DOM UI resources. Maybe there is some overlap here?

Comment 8 by tony@chromium.org, Apr 8 2010

We don't pack up the devtools js (see /opt/google/chrome/resources/inspector/).  This should be possible, we 
just need to manually create a mapping between inspector resource URLs and resource IDs.  It will probably be a 
pain to maintain.

Comment 9 by est...@chromium.org, Apr 26 2010

Labels: Feature-DevTools

Comment 10 by evan@chromium.org, May 17 2010

Summary: Devtools stop working when chrome gets updated

Comment 11 by e...@chromium.org, Jun 1 2010

Status: Assigned
Totally needs to be done before M6.
I assume this is an installation / deployment issue, not related to the DevTools functionality. Is that correct?

Comment 13 by e...@chromium.org, Jun 1 2010

Labels: OS-Mac
No changes will need to be made to the javascript code, if that's what you're asking.

What will have to happen is that the loose files need to persist when they are deleted 
from the filesystem in some way. Either I need to figure out some filesystem junk or I 
need to just add them to the chrome.pak files. Either way, the dom ui stuff will need 
some reworking.

Comment 14 by evan@chromium.org, Jun 7 2010

I think Mac does the "multiple parallel directories" trick so this only applies to Linux.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50257 

------------------------------------------------------------------------
r50257 | erg@chromium.org | 2010-06-18 10:36:39 -0700 (Fri, 18 Jun 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.cc?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.h?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.cc?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.h?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=50257&r2=50256
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.h?r1=50257&r2=50256

Reland r50057. This is exactly the same except with two lines cherrypicked from
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

Original Review: http://codereview.chromium.org/2855003

BUG= 35793 , 42770 
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/2800014
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50260 

------------------------------------------------------------------------
r50260 | erg@chromium.org | 2010-06-18 10:52:50 -0700 (Fri, 18 Jun 2010) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.cc?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.h?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.cc?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.h?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=50260&r2=50259
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.h?r1=50260&r2=50259

Revert 50257 - Reland r50057. This is exactly the same except with two lines cherrypicked from
tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h}
files.

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

Original Review: http://codereview.chromium.org/2855003

BUG= 35793 , 42770 
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/2800014

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2811016
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50374 

------------------------------------------------------------------------
r50374 | erg@chromium.org | 2010-06-21 13:07:17 -0700 (Mon, 21 Jun 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.cc?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.h?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.cc?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.h?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=50374&r2=50373
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.h?r1=50374&r2=50373

Load net-internals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG= 35793 , 42770 
TEST=none

Review URL: http://codereview.chromium.org/2865010
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50392 

------------------------------------------------------------------------
r50392 | willchan@chromium.org | 2010-06-21 15:12:39 -0700 (Mon, 21 Jun 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.cc?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.h?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.cc?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.h?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=50392&r2=50391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.h?r1=50392&r2=50391

Speculatively revert 50374 (miniinstaller breakage) - Load netinternals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG= 35793 , 42770 
TEST=none

Review URL: http://codereview.chromium.org/2865010

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2799022
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50433 

------------------------------------------------------------------------
r50433 | tony@chromium.org | 2010-06-21 23:45:22 -0700 (Mon, 21 Jun 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.cc?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resource_bundle.h?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.cc?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/data_pack.h?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.h?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer/chrome.release?r1=50433&r2=50432
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=50433&r2=50432

Load net-internals resources from resources.pak.

This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.

BUG= 35793 , 42770 
TEST=none

Review URL: http://codereview.chromium.org/2865010
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50777 

------------------------------------------------------------------------
r50777 | erg@chromium.org | 2010-06-24 15:34:09 -0700 (Thu, 24 Jun 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/chrome_url_data_manager.cc?r1=50777&r2=50776
   D /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.cc
   D /trunk/src/chrome/browser/dom_ui/shared_resources_data_source.h
   D /trunk/src/chrome/browser/resources/shared_resources.grd
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=50777&r2=50776
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=50777&r2=50776
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=50777&r2=50776
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer/chrome.release?r1=50777&r2=50776

Revert 50761 - Move the files in resources/shared/ into resources.pak

BUG= 35793 , 42770 
TEST=none

Review URL: http://codereview.chromium.org/2817026

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2855021
------------------------------------------------------------------------

Comment 25 by e...@chromium.org, Jul 7 2010

Labels: -Mstone-6 Mstone-7
The bookmark manager now works across updates. The devtools would be nice to have, but we're now not in danger of breaking majorly. Punting rest to M7.

Comment 26 by kerz@chromium.org, Aug 4 2010

Wondering if there's a chase of a fix for this for M6?

Comment 27 by tony@chromium.org, Aug 4 2010

It's a lot of work, so there's little chance of fixing this for M6.

Comment 28 by k...@google.com, Sep 14 2010

Labels: -Mstone-7 Mstone-9
Going to push out to M9 for now since it sounds large, and will give time to fix.  Please move to Mx if it's not going to get any traction.

Comment 29 by kerz@chromium.org, Oct 21 2010

Labels: Mstone-10
Bulk move of all P2 M9 bugs out to M10.  Bring back any you are actively working on for m9.

Comment 30 by kerz@chromium.org, Dec 9 2010

Labels: -Mstone-10 MovedFrom-10 Mstone-11
P2 bugs with an owner that are not marked as started are being automatically moved to mstone:11.

Comment 31 by e...@chromium.org, Feb 17 2011

Labels: -Mstone-11 Mstone-12
I probably don't know enough about gyp to do this. Randomly reassigning this to tony and punting to M12 :(
 Issue 74936  has been merged into this issue.

Comment 33 by tony@chromium.org, Mar 11 2011

Status: Started
Project Member

Comment 34 by bugdroid1@chromium.org, Mar 17 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=78468

------------------------------------------------------------------------
r78468 | tony@chromium.org | Wed Mar 16 17:02:49 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/node/misc_unittest.py?r1=78468&r2=78467&pathrev=78468
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/grd_reader_unittest.py?r1=78468&r2=78467&pathrev=78468
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/grd_reader.py?r1=78468&r2=78467&pathrev=78468
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/resource_ids?r1=78468&r2=78467&pathrev=78468
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/node/misc.py?r1=78468&r2=78467&pathrev=78468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=78468&r2=78467&pathrev=78468

Compile the devtools grd file into a .pak file so we
can include the data in resources.pak.

To avoid resource ids colliding between files, we have a global
file, resource_ids, that tracks the starting id values. Since
the devtools grd file is generated, it's hard to add an entry
to |resource_ids|.  To work around this, add support for expanding
variables in the |resource_ids|.

BUG= 35793 

Review URL: http://codereview.chromium.org/6685061
------------------------------------------------------------------------
Project Member

Comment 35 by bugdroid1@chromium.org, Mar 22 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=78949

------------------------------------------------------------------------
r78949 | tony@chromium.org | Mon Mar 21 17:31:38 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/devtools_ui.cc?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/chrome_test_suite.cc?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=78949&r2=78948&pathrev=78949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES?r1=78949&r2=78948&pathrev=78949

Load devtools files from resources.pak rather than from disk.

This change merges devtools_resources.pak into resources.pak and
puts the code to load files from disk behind a command line switch.
If --debug-devtools is passed on the command line, we enable the code
to load from disk (so the developer can make changes to the .js
files without having to recompile or restart the browser).

I also tried to make sure we no longer include the resources directory
in release packages, but I probably missed something.

BUG= 35793 

Review URL: http://codereview.chromium.org/6670072
------------------------------------------------------------------------
Project Member

Comment 36 by bugdroid1@chromium.org, Mar 22 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79038

------------------------------------------------------------------------
r79038 | tony@chromium.org | Tue Mar 22 14:32:29 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/devtools_ui.cc?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/chrome_test_suite.cc?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/component_extension_resources.grd?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=79038&r2=79037&pathrev=79038
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES?r1=79038&r2=79037&pathrev=79038

Load devtools files from resources.pak rather than from disk take 2.

This change merges devtools_resources.pak into resources.pak and
puts the code to load files from disk behind a command line switch.
If --debug-devtools is passed on the command line, we enable the code
to load from disk (so the developer can make changes to the .js
files without having to recompile or restart the browser).

I also tried to make sure we no longer include the resources directory
in release packages, but I probably missed something.

This time, make sure to include the devtools_resources.pak in
Chromium.app on OSX.

BUG= 35793 
TBR=pfeldman

Review URL: http://codereview.chromium.org/6708093
------------------------------------------------------------------------

Comment 37 by tony@chromium.org, Mar 22 2011

Status: Fixed
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:42770 chromium:42770
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 39 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-DevTools -Mstone-12 Cr-Platform-DevTools Cr-Internals M-12
Project Member

Comment 40 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment