New issue
Advanced search Search tips
Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2014
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Implement picture's sizes and (extended) srcset attribute

Project Member Reported by y...@yoav.ws, Mar 28 2014

Issue description

(See http://www.chromium.org/blink#launch-process for an overview)

Change description:
Enable a responsive images solution for the "resolution switching"/"variable width images" use case, by letting authors hint the browser regarding eventual layout dimensions, and provide multiple resources in multiple dimensions. 

Changes to API surface:
* Add support for sizes attribute on the img element
* Add support for resource dimensions in the srcset attribute

Links:
Public standards discussion: http://picture.responsiveimages.org/

Support in other browsers:
Internet Explorer: Not yet
Firefox: Being worked on
Safari: Not yet


 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 9 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171164

------------------------------------------------------------------
r171164 | yoav@yoav.ws | 2014-04-09T19:00:16.302059Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=171164&r2=171163&pathrev=171164

Add a sizes attribute runtime flag

BUG= 357586 

Review URL: https://codereview.chromium.org/230973002
-----------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171237

------------------------------------------------------------------
r171237 | yoav@yoav.ws | 2014-04-10T06:54:53.264863Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.h?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryToken.h?r1=171237&r2=171236&pathrev=171237
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryBlockWatcher.cpp?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizer.cpp?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizerTest.cpp?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.cpp?r1=171237&r2=171236&pathrev=171237
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryBlockWatcher.h?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizer.h?r1=171237&r2=171236&pathrev=171237
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryToken.cpp?r1=171237&r2=171236&pathrev=171237

Moved MQ parsing block tracking to tokenizer

For better spec compliance of the tokenizer itself, and to enable the sizes
parser to be aware of blocks, I've moved the block tracking logic from the 
MQ parser to the tokenizer.

BUG= 357586 

Review URL: https://codereview.chromium.org/225293006
-----------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171489

------------------------------------------------------------------
r171489 | yoav@yoav.ws | 2014-04-14T17:19:13.454122Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParser.h?r1=171489&r2=171488&pathrev=171489
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParser.cpp?r1=171489&r2=171488&pathrev=171489
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParserTest.cpp?r1=171489&r2=171488&pathrev=171489

Align srcset parsing with spec changed

This CL align the srcset parsing algorithm with recent picture spec changes.
Specifically:
* Src URL are now not part of the source selection algoritm, as per https://github.com/ResponsiveImagesCG/picture-element/pull/147
* 0w resources are ignored, to avoid 0/0 operations, and because they make no sense, as per https://github.com/ResponsiveImagesCG/picture-element/pull/151

BUG= 357586 

Review URL: https://codereview.chromium.org/236593003
-----------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171701

------------------------------------------------------------------
r171701 | yoav@yoav.ws | 2014-04-15T20:46:58.993336Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.h?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple.html?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.h?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple-expected.txt?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length.html?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQuerySetTest.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryExp.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaConditionTest.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.h?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.h?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.idl?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluatorTest.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=171701&r2=171700&pathrev=171701
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=171701&r2=171700&pathrev=171701
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=171701&r2=171700&pathrev=171701

A sizes attribute parser

This CL implements a parser for HTMLImageElement's sizes attribute.
It also hooks that parser to HTMLImageElement, but doesn't yet do anything with the output.

BUG= 357586 

Review URL: https://codereview.chromium.org/224733011
-----------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 16 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171751

------------------------------------------------------------------
r171751 | hayato@chromium.org | 2014-04-16T06:49:47.851425Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.cpp?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.h?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple.html?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.h?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple-expected.txt?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length.html?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQuerySetTest.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaConditionTest.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryExp.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.idl?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.h?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.h?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=171751&r2=171750&pathrev=171751
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluatorTest.cpp?r1=171751&r2=171750&pathrev=171751
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt?r1=171751&r2=171750&pathrev=171751

Revert "A sizes attribute parser" (https://codereview.chromium.org/224733011)

Reason for revert:
[blink gardening]
SystemMemoryApiTest.Memory started to fail.

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35970

I manually bisected in range 171674: 171705.
After r171701, SystemMemoryApiTest.Memory started to fail.

I suspect this patch might be also the cause of the failures of other tests,
such as Storage, StorageAttachment and so on.

Let me revert this.


TBR=yoav@yoav.ws,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 357586 

Review URL: https://codereview.chromium.org/240063003
-----------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171843

------------------------------------------------------------------
r171843 | yoav@yoav.ws | 2014-04-17T06:18:48.632340Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple.html?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.h?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple-expected.txt?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length.html?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQuerySetTest.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaConditionTest.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryExp.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.idl?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.h?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.h?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluatorTest.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=171843&r2=171842&pathrev=171843
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.cpp?r1=171843&r2=171842&pathrev=171843
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.h?r1=171843&r2=171842&pathrev=171843

A sizes attribute parser

This CL implements a parser for HTMLImageElement's sizes attribute.
It also hooks that parser to HTMLImageElement, but doesn't yet do anything with the output.

BUG= 357586 

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171701

Review URL: https://codereview.chromium.org/224733011
-----------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171845

------------------------------------------------------------------
r171845 | sigbjornf@opera.com | 2014-04-17T07:00:21.765377Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=171845&r2=171844&pathrev=171845
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.h?r1=171845&r2=171844&pathrev=171845

Oilpan: fix build after r171843.

R=
BUG= 357586 
NOTRY=true

Review URL: https://codereview.chromium.org/240503006
-----------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171985

------------------------------------------------------------------
r171985 | yoav@yoav.ws | 2014-04-18T23:25:33.910191Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/add-remove-stylesheets-minimal-recalc-style.html?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.h?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleMedia.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.h?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/add-remove-stylesheets-minimal-recalc-style-expected.txt?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryMatcher.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/add-remove-stylesheets-at-once-minimal-recalc-style.html?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.h?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style-expected.txt?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluatorTest.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/add-remove-stylesheets-at-once-minimal-recalc-style-expected.txt?r1=171985&r2=171984&pathrev=171985
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=171985&r2=171984&pathrev=171985

Remove MediaValues' dependency on style

MediaValues needed a RenderStyle for default font calculations. However, since a renderer is not always available,
and the default font size can also be concluded from the LocalFrame, this dependency can be removed.

BUG= 357586 

Review URL: https://codereview.chromium.org/242883002
-----------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171995

------------------------------------------------------------------
r171995 | yoav@yoav.ws | 2014-04-19T08:07:43.842618Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/resources/image-set-1x.png?r1=171995&r2=171994&pathrev=171995
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/resources/image-set-2x.png?r1=171995&r2=171994&pathrev=171995
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/resources/image-set-4x.png?r1=171995&r2=171994&pathrev=171995

Add test binaries for Sizes parser tests

Because of http://crbug.com/365066 , the layout tests on https://codereview.chromium.org/236713005/ fail.
This CL uploads the binaries for that CL, in hope that they'd be taken into account on the trybots for that CL.

BUG= 357586 

Review URL: https://codereview.chromium.org/242103008
-----------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 21 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172004

------------------------------------------------------------------
r172004 | yoav@yoav.ws | 2014-04-21T01:13:05.908830Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizer.cpp?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-innerhtml-expected.txt?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-image-sizes.html?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-image-sizes-2x-expected.txt?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.h?r1=172004&r2=172003&pathrev=172004
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple.html?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-image-sizes-expected.txt?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x-expected.txt?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParser.cpp?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x-expected.txt?r1=172004&r2=172003&pathrev=172004
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple-expected.txt?r1=172004&r2=172003&pathrev=172004
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length.html?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSrcsetParser.h?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.idl?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change-expected.txt?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-innerhtml.html?r1=172004&r2=172003&pathrev=172004
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/loading/preload-image-sizes-2x.html?r1=172004&r2=172003&pathrev=172004
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=172004&r2=172003&pathrev=172004
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=172004&r2=172003&pathrev=172004

Use SizesAttributeParser to get the right srcset resource

This CL connects the sizes parser to the extended srcset parser and makes sure the images are properly fetched and displayed.

BUG= 357586 
Depends on http://crrev.com/242103008

Review URL: https://codereview.chromium.org/236713005
-----------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 30 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172992

------------------------------------------------------------------
r172992 | yoav@yoav.ws | 2014-04-30T15:27:58.141174Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.cpp?r1=172992&r2=172991&pathrev=172992
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesCalcParserTest.cpp?r1=172992&r2=172991&pathrev=172992
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesCalcParser.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesCached.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizer.cpp?r1=172992&r2=172991&pathrev=172992
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesCalcParser.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/build/scripts/make_mediaquery_tokenizer_codepoints.py?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryTokenizer.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryToken.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValues.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryToken.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaValuesDynamic.h?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaConditionTest.cpp?r1=172992&r2=172991&pathrev=172992
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/MediaQueryParser.h?r1=172992&r2=172991&pathrev=172992

A thread safe CSS calc parser for sizes

The sizes attribute parsing requires calc() parsing and evaluation.
This CL adds a thread safe calc parser (for unsigned length values).

BUG= 357586 

Review URL: https://codereview.chromium.org/252743004
-----------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 30 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173000

------------------------------------------------------------------
r173000 | yoav@yoav.ws | 2014-04-30T16:38:34.942548Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=173000&r2=172999&pathrev=173000
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=173000&r2=172999&pathrev=173000

Enable calc() parsing in the sizes attribute

This CL enabled calc parsing in the sizes attribute, and adds tests for that.

BUG= 357586 
Depends on http://crrev.com/252743004

Review URL: https://codereview.chromium.org/259193004
-----------------------------------------------------------------

Comment 14 by y...@yoav.ws, Apr 30 2014

Status: Fixed
These feature are now fully implemented. Closing.
Project Member

Comment 15 by bugdroid1@chromium.org, May 16 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=174206

------------------------------------------------------------------
r174206 | cbiesinger@chromium.org | 2014-05-16T20:23:55.405277Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParser.cpp?r1=174206&r2=174205&pathrev=174206

Replace a stale fixme with a comment

Eliminate a stale FIXME comment in the SizesAttributeParser, and replaces it with a comment stating why sizes' media conditions should not be evaluated as non-screen media types.

BUG= 357586 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/284263005
-----------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 3 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175328

------------------------------------------------------------------
r175328 | yoav@yoav.ws | 2014-06-03T01:49:45.284745Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/SizesAttributeParserTest.cpp?r1=175328&r2=175327&pathrev=175328

Clean up SizesAttributeParserTest and add some tests

BUG= 357586 

Review URL: https://codereview.chromium.org/300843008
-----------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 26 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=176988

------------------------------------------------------------------
r176988 | yoav@yoav.ws | 2014-06-26T15:40:03.240853Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=176988&r2=176987&pathrev=176988

Enable the sizes attribute and srcset 'w' descriptor by default

Following the intent to ship thread[1], this CL enables the sizes attribute and srcset's 'w' descriptor by default.

BUG= 357586 

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/GRfwz951FHo/RUue8U49iuwJ

Review URL: https://codereview.chromium.org/356833007
-----------------------------------------------------------------
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f38919e18ed8fa5b4fa96834a024cfdd9a0667

commit 10f38919e18ed8fa5b4fa96834a024cfdd9a0667
Author: hayato <hayato@chromium.org>
Date: Tue Jul 26 08:56:23 2016

Remove unused code from HTMLLinkElement

This should be removed in https://codereview.chromium.org/242883002

BUG= 357586 , 630141 

Review-Url: https://codereview.chromium.org/2181263002
Cr-Commit-Position: refs/heads/master@{#407739}

[modify] https://crrev.com/10f38919e18ed8fa5b4fa96834a024cfdd9a0667/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Sign in to add a comment