Project: chromium ▼ Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.
Issue 357112 Deprecate and remove XMLHttpRequestProgressEvent
Starred by 7 users Project Member Reported by sigbjo...@opera.com, Mar 27 2014 Back to list
Status: Fixed
Owner:
█ phil...@opera.com
Email to this user bounced
Closed: Feb 2016
Cc:
tyoshino@chromium.org
█ arv@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----

Blocking:
issue 568218



Sign in to add a comment
 
XHR progress event instances have an extra entry on their prototype chain (XMLHttpRequestProgressEvent) to provide some Gecko-compatibility properties ("totalSize" and "position", from LSProgressEvent originally).

Support for these progress event properties (and LSProgressEvent) has been dropped by Mozilla,

  https://bugzilla.mozilla.org/show_bug.cgi?id=845631

Follow suit and deprecate&remove XMLHttpRequestProgressEvent. Perhaps outright removal, but a sensible first step would be to gauge usage.
Comment 1 by tyoshino@chromium.org, Mar 27 2014 
OK. Let's consider adding UseCounter and also printing deprecation message.
Project Member Comment 3 by bugdroid1@chromium.org, Mar 27 2014 
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170198

------------------------------------------------------------------
r170198 | sigbjornf@opera.com | 2014-03-27T19:47:48.738471Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequestProgressEvent.idl?r1=170198&r2=170197&pathrev=170198
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=170198&r2=170197&pathrev=170198

Add use counters for XMLHttpRequestProgressEvent properties.

Gauge if removing these compatibility properties is feasible.

R=jochen@chromium.org
BUG= 357112 

Review URL: https://codereview.chromium.org/214563002
-----------------------------------------------------------------
Comment 4 by tyoshino@chromium.org, Mar 28 2014 
Thanks. I'll share the result with you in a few days.
Comment 5 by sigbjo...@opera.com, Mar 28 2014 
It'll be available via http://www.chromestatus.com/metrics/feature/timeline/popularity soon enough (once we've pushed updates to the UI)
Comment 7 by sigbjo...@opera.com, Apr 9 2014 
Those counters made the "cut" for M35, so a picture should start developing.

(I've created a pull request to have the dashboard include their labels, btw.)
Comment 8 by tyoshino@chromium.org, Apr 9 2014 
Oops, right.

FYI, count for M36 canary is indicating that the usage is a factor of 0.001%. Anyway, let's wait and see, sorry.
Comment 9 by tyoshino@chromium.org, Apr 9 2014 
I've updated histograms.xml

https://codereview.chromium.org/229823002/
Comment 11 by phil...@opera.com, Dec 16 2014 
Intent on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/nsLnqT__I78/zXQtEX-vUK0J

(Found a deprecation with no blink-dev thread, just checking to see if there were any others recently.)
Comment 12 by philip.j...@gmail.com, Nov 3 2015 
This has been deprecated for over a year and usage is really low. sigbjornf@, are you interested in following up with the removal as well?
Comment 13 by tkent@chromium.org, Nov 27 2015
Labels: -Cr-Blink-XHR Cr-Blink-Network-XHR
Comment 14 by phil...@opera.com, Dec 9 2015
Labels: -Type-Bug Type-Launch-OWP OWP-Type-Deprecation OWP-Standards-No OWP-Design-No
Owner: phil...@opera.com
Status: Assigned
I'll take care of removing this. Converting to an OWP launch tracking bug.
Comment 15 by rbyers@chromium.org, Dec 9 2015
Blocking: chromium:568218
Comment 17 by tyoshino@chromium.org, Jan 21 2016
Labels: M-50
It's time to remove :)
Comment 18 by phil...@opera.com, Jan 25 2016 
Indeed! I'll get to it before the next branch point, but if anyone is excited to do it, please go ahead!
Project Member Comment 19 by bugdroid1@chromium.org, Feb 9 2016 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e137ed7bb6df2db8d527ff70a71af15f628cdb1b

commit e137ed7bb6df2db8d527ff70a71af15f628cdb1b
Author: philipj <philipj@opera.com>
Date: Tue Feb 09 20:11:43 2016

Remove XMLHttpRequestProgressEvent (position and totalSize)

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bpbq0Rcpauk/cnpJtHddAgAJ

BUG= 357112 

Review URL: https://codereview.chromium.org/1681923002

Cr-Commit-Position: refs/heads/master@{#374434}

[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/fast/events/event-creation-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/fast/events/event-creation.html
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/local/formdata/upload-events-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/readystatechange.html
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-onprogress-event-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-progress-events.html
[delete] http://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match-expected.txt
[delete] http://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/core.gypi
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[delete] http://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h
[delete] http://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.idl
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
[modify] http://crrev.com/e137ed7bb6df2db8d527ff70a71af15f628cdb1b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp
Comment 21 by phil...@opera.com, Feb 11 2016
Status: Fixed
Project Member Comment 22 by bugdroid1@chromium.org, Feb 11 2016 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d43953428579c3d482bb433168732408d50737e

commit 7d43953428579c3d482bb433168732408d50737e
Author: chrishtr <chrishtr@chromium.org>
Date: Thu Feb 11 16:09:58 2016

Revert of Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle (patchset #1 id:1 of https://codereview.chromium.org/1690503002/ )

Reason for revert:
More discussion is needed about these class names.

Original issue's description:
> Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle
>
> XMLHttpRequestProgressEvent is no more.
>
> BUG= 357112 
> R=chrishtr@chromium.org
>
> Committed: https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974
> Cr-Commit-Position: refs/heads/master@{#374683}

TBR=tyoshino@chromium.org,philipj@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 357112 

Review URL: https://codereview.chromium.org/1686953006

Cr-Commit-Position: refs/heads/master@{#374906}

[modify] http://crrev.com/7d43953428579c3d482bb433168732408d50737e/third_party/WebKit/Source/core/core.gypi
[modify] http://crrev.com/7d43953428579c3d482bb433168732408d50737e/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] http://crrev.com/7d43953428579c3d482bb433168732408d50737e/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[rename] http://crrev.com/7d43953428579c3d482bb433168732408d50737e/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
[rename] http://crrev.com/7d43953428579c3d482bb433168732408d50737e/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
► Sign in to add a comment