Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 356878 Upgrade to CodeMirror 4.0
Starred by 4 users Reported by addyosm...@gmail.com, Mar 26 2014 Back to list
Status: Fixed
Owner:
Closed: Apr 2014
Components:
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Sign in to add a comment
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.76 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools
2. Navigate to the Sources panel
3. Expect to find features available in CodeMirror V4. These features are not available (e.g multiple cursors)

What is the expected behavior?
Features in CodeMirror V4 should be available. These include:

- Multiple selections (ctrl-click, alt-drag, API).
- Sublime Text bindings.
- Module loader shims wrapped around all modules.
- Selection undo/redo.
- Improved character measuring (faster, handles wrapped lines more robustly).

What went wrong?
The features expected in CodeMirror V4 are not available in the DevTools. It would be great if we could consider upgrading to this version as JSBin and Codepen have already done so.

Did this work before? No 

Chrome version: 34.0.1847.76  Channel: n/a
OS Version: OS X 10.9.1
Flash Version: Shockwave Flash 13.0 r0

Release notes: http://codemirror.net/doc/releases.html
 
Worth noting: there are a few changes in V4 which are not backwards compatible. It would be of value to consult the upgrading guide here if we're looking at this: http://codemirror.net/doc/upgrade_v4.html
Labels: -Via-Wizard Cr-Platform-DevTools-HTML
Owner: lushnikov@chromium.org
Status: Assigned
Project Member Comment 3 by bugdroid1@chromium.org, Mar 31 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170462

------------------------------------------------------------------
r170462 | lushnikov@chromium.org | 2014-03-31T16:55:16.774724Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/closebrackets.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/codemirror.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/CodeMirrorUtils.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/externs.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/matchbrackets.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/headlesscodemirror.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/markselection.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/codemirror.css?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/CodeMirrorTextEditor.js?r1=170462&r2=170461&pathrev=170462
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/cm/comment.js?r1=170462&r2=170461&pathrev=170462

DevTools: roll CodeMirror to v4.0.3

This patch rolls codemirror to version 4.0.3.
It also rolls all supporting plugins we use, though leaving highlighting
modes intact.

BUG= 356878 

Review URL: https://codereview.chromium.org/216973004
-----------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Apr 1 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170557

------------------------------------------------------------------
r170557 | lushnikov@chromium.org | 2014-04-01T13:05:02.285143Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/editor/text-editor-ctrl-d-expected.txt?r1=170557&r2=170556&pathrev=170557
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/CodeMirrorTextEditor.js?r1=170557&r2=170556&pathrev=170557
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/editor/text-editor-ctrl-d.html?r1=170557&r2=170556&pathrev=170557
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/externs.js?r1=170557&r2=170556&pathrev=170557

DevTools: [CodeMirror] Implement "select next occurrence" functionality

This patch adds a Ctrl-D shortcut to the devtools editor which selects
the next occurrence of word or selection. Implementation is based
on CodeMirror v4 multiple cursor capabilities.

BUG= 356878 

Review URL: https://codereview.chromium.org/219583002
-----------------------------------------------------------------
Status: Fixed
Sign in to add a comment