New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

'CC' label on Subtitled Video should be 'S' for en-gb

Reported by gidsgold...@gmail.com, Mar 17 2014

Issue description

Chrome Version       : 32.0.1700.107 (Developer Build 32.0.1700.107-0ubuntu0.13.10.1~20140204.972.1) Ubuntu 13.10
URLs (if applicable) : www.theguardian.com/science/antarctica-live/2014/feb/28/-sp-rescue-from-antarctica


What steps will reproduce the problem?
1. Open Chromium en-GB localised version
2. Go to a page with an HTML5 subtitled video
3. Look at video player

What is the expected result?
Subtitle label is 'S' instead of 'CC'
as per BBC iPlayer (http://bbc.co.uk/iplayer) (most popular streaming service in GB and Sky TV (most popular paid TV platform in GB (https://accessibility.sky.com/sky-tv-help/subtitles)

What happens instead?
Label is 'CC' which is confusing for en-gb audience



 
Labels: -Type-Bug Type-Feature Cr-Internals-Media-Track
Status: Untriaged
Several sources, including wikipedia confirm this. Setting as feature request
Cc: lpalmaro@chromium.org silviapf@chromium.org jluther@chromium.org
Labels: -Pri-2 Pri-3 Hotlist-Fixit
Status: Available
cc'ing some PMs and accessibility folks
This *may* be applicable to other locales however you would need to do your own investigation as I only have knowledge of en-gb.
Labels: StaleAvailable
Cc: phil...@opera.com
philipj@, these bugs have been stale for >6 month. can you take a look and take below actions:
1) assign the bug to an appropriate owner if you want to keep the bug. OR
2) remove Cr-Internals-Media-subarea label if the bug is not in your area. OR
3) close the bug if it's not valuable to keep.
​​
Labels: StaleClosed
Status: WontFix
these bugs are stale for > 6 month. After 3 rounds of call, the bug owners still haven't marked them as StaleKeep. I assume the bug owner has no intention to keep them. Close these bug, and add label StaleClosed, so it's possible to bring them back in the future.

Comment 7 by phil...@opera.com, Nov 3 2015

Labels: -StaleClosed
Owner: liber...@chromium.org
Status: Assigned
Frank, I'm boldly assigning this to you since you've worked on the controls recently. If you don't want it, just leave it as available :)
Labels: -StaleAvailable StaleKeep

Comment 9 by foolip@chromium.org, Nov 11 2016

Cc: foolip@chromium.org
Cc: -phil...@opera.com
Cc: mlamouri@chromium.org liber...@chromium.org
Owner: ----
Status: Available (was: Assigned)
unassigning since i don't do any UI work these days.
Cc: beccahughes@chromium.org rachelis@chromium.org
Components: -Internals>Media>Track Blink>Media>Controls
Labels: -StaleKeep -Hotlist-Fixit Hotlist-Media-UX OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dah...@chromium.org
This is a generic issue as the [CC] button is an image used for all locales. I see that Material Design has an icon for "subtitles". I wonder if it would make sense to replace the [CC] icon with this in the new media controls UI.

dahlke@, do you know who to ping to check if we should move away from [CC] icon?
Cc: amyroberts@chromium.org helenepark@chromium.org
Thanks for flagging this to me Mounir, and thanks everyone!

I agree that this is an important translation / localization piece and we should address it. I would however like to make sure we can address it more broadly/scalably, and avoid creating a one-off.

Jon, Mounir, or +Helene, do you happen to have a contact on the YouTube team who may be able to provide us with a more scalable data source for correctly localizing this icon?

+Amyroberts FYI as well
YouTube Android application uses the "subtitles" icon from MD for their "captions" entry. On the website, they do not seem to use an icon.
I get the CC icon in the YT application, mweb and desktop web, so it does appear that they are using Subtitles as a locale-specific icon. I have reached out to the eng team to see if they can confirm the behavior. 
Cc: -rachelis@chromium.org dah...@chromium.org
Labels: -Pri-3 Pri-2
Owner: beccahughes@chromium.org
Per the internal discussion, I propose we use the CC icon in the following countries:
- United States
- Mexico
- Canada
- Australia

For all other countries we use the existing subtitles MD icon.

Assigning to beccahughes to implement as part of the media controls redesign. Let me know if there are objections.
What (or whose) geographic location is used to determine the "country" for UX purposes?  Could this be used to reveal additional geographic information to the page author?


I am assuming that we would use the device locale (yes, this is an imperfect proxy, but one that we use for all our location-based customizations) and that no new information would be provided to the site developer since we are using native controls. Someone please correct me if those are bad assumptions.
As mentioned in the internal email thread, we need to clarify a couple of things, among them is whether we want to use the CC icon for es_MX? The discussion we had was per-country and not per locale and things might be a bit different. Though, to clarify, I think we should definitely use the build locale and not the country.

Something else: we use a OFF icon for CC today which, AFAIK, doesn't exist in MD. We will need someone to generate a similar icon for Subtitles if we want to keep this in the new design (I assume we do).
Update, from the internal thread. Here are the following countries we should use CC: 
- United States (EN, ES)
- Mexico (ES)
- Canada (EN, FR)
- Australia (EN)
- Brazil (PT)


RE: Off state, the designers and I talked this morning and we don't think we need to use an off state for either of the icons in the new design. 

Status: Assigned (was: Available)
Cc: -foolip@chromium.org
Owner: lethalantidote@chromium.org
Labels: -Pri-2 Pri-3
Cc: -lpalmaro@chromium.org -silviapf@chromium.org hbengali@chromium.org denizz@chromium.org
Owner: beccahughes@chromium.org
Status: Started (was: Assigned)
Looking at the supported Chrome locales:

https://developer.chrome.com/webstore/i18n#localeTable

 - There is no Canada (it would be "en" or "en-US")
 - Mexico & United States ES is ES-419 (Spanish (Latin America and Caribbean))
 - Australia is not supported (it would likely be "en")

Therefore I think using the locales "en", "en-US", "es-419" and "pt-BR" for closed captions will get us closest to that list.
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0109bbaa2074acaefbe6fcc72d66499f19137813

commit 0109bbaa2074acaefbe6fcc72d66499f19137813
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jul 12 18:21:33 2018

[Media Controls] Localize CC to S by locale

Use a "S" icon for the captions button by default
except for "en", "en-US", "es-419" and "pt-BR" which
should continue to use the CC icon.

I added some clarification about which locales in the
bug since there was some regions that were not locales
supported by Chrome.

BUG= 353120 

Change-Id: I41e05058a6b1589eddce0605d39272b4dd965248
Reviewed-on: https://chromium-review.googlesource.com/1134480
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574639}
[add] https://crrev.com/0109bbaa2074acaefbe6fcc72d66499f19137813/third_party/WebKit/LayoutTests/media/controls/closed-captions-locale.html
[modify] https://crrev.com/0109bbaa2074acaefbe6fcc72d66499f19137813/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[add] https://crrev.com/0109bbaa2074acaefbe6fcc72d66499f19137813/third_party/blink/renderer/modules/media_controls/resources/ic_subtitles.svg
[modify] https://crrev.com/0109bbaa2074acaefbe6fcc72d66499f19137813/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
I have filed a translation bug to update the text:

https://bugs.chromium.org/p/chromium/issues/detail?id=863621

Sign in to add a comment