Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
User never visited
Closed: Mar 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 351146



Sign in to add a comment
Histogram in ShadowRoot constructor is too expensive
Project Member Reported by esprehn@chromium.org, Mar 10 2014 Back to list
Google Chrome	35.0.1870.2 (Official Build 254650) dev
OS	Mac OS X 
Blink	537.36 (@168356)

The histogram in the constructor is hugely expensive in a profile of the attached benchmark (courtesy of sorvell):

Running Time	Self		Symbol Name
757.0ms  100.0%	7.0	 	v8::Function::Call(v8::Handle<v8::Value>, int, v8::Handle<v8::Value>*)
749.0ms   98.9%	8.0	 	 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, bool*, bool)
741.0ms   97.8%	44.0	 	  v8::internal::Invoke(bool, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, bool*)
264.0ms   34.8%	3.0	 	   WebCore::ElementV8Internal::createShadowRootMethodCallback(v8::FunctionCallbackInfo<v8::Value> const&)
206.0ms   27.2%	1.0	 	    WebCore::Element::createShadowRoot(WebCore::ExceptionState&)
181.0ms   23.9%	1.0	 	     WebCore::ElementShadow::addShadowRoot(WebCore::Element&, WebCore::ShadowRoot::ShadowRootType)
151.0ms   19.9%	3.0	 	      WebCore::ShadowRoot::ShadowRoot(WebCore::Document&, WebCore::ShadowRoot::ShadowRootType)


 
input-wstyle.html
1.5 KB View Download
Sorry I messed up my paste, that's missing the last line:

118.0ms   15.5%	30.0	 	       webkit_glue::WebKitPlatformSupportImpl::histogramEnumeration(char const*, int, int)

Labels: hotlist-toolkit
Comment 3 by abarth@chromium.org, Mar 11 2014
Owner: abarth@chromium.org
Comment 4 by abarth@chromium.org, Mar 11 2014
Status: Started
https://codereview.chromium.org/193683002
Blocking: chromium:351146
Project Member Comment 6 by bugdroid1@chromium.org, Mar 11 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168882

------------------------------------------------------------------------
r168882 | abarth@chromium.org | 2014-03-11T04:31:12.336050Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ShadowRoot.cpp?r1=168882&r2=168881&pathrev=168882

Remove histogram in ShadowRoot constructor

This histogram takes too much time. If we want to track these stats, we can use
a UseCounter instead.

R=esprehn@chromium.org
BUG= 351135 

Review URL: https://codereview.chromium.org/193683002
------------------------------------------------------------------------
Comment 7 by abarth@chromium.org, Mar 11 2014
Status: Fixed
Project Member Comment 8 by bugdroid1@chromium.org, Mar 12 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168966

------------------------------------------------------------------------
r168966 | adamk@chromium.org | 2014-03-12T00:38:20.970232Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ShadowRoot.cpp?r1=168966&r2=168965&pathrev=168966

Remove unused ShadowRootUsageOriginType enum

Its usage was removed in https://src.chromium.org/viewvc/blink?view=rev&revision=168882

R=eseidel@chromium.org, abarth@chromium.org
BUG= 351135 

Review URL: https://codereview.chromium.org/196023003
------------------------------------------------------------------------
Sign in to add a comment