New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 349016 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 241964



Sign in to add a comment

Add support for touch-action: manipulation

Project Member Reported by rbyers@chromium.org, Mar 4 2014

Issue description

The W3C pointer events specification of touch-action (https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#the-touch-action-css-property) is about to be updated to include the 'manipulation' value (shipped originally by IE: http://msdn.microsoft.com/en-us/library/ie/hh772044(v=vs.85).aspx).

This can be used instead of 'auto' to disable double-tap-zoom (and as a result the 300ms click delay) without disabling pinch-zoom.

This is simple and non-controversial enough that I think we should aim to get it implemented ASAP as part of our M-35 release of touch-action.



 
Note Gnana has a CL for the blink side that's almost what we need: https://codereview.chromium.org/134153016/ (just need to replace double-tap-zoom with manipulation).

Hopefully we can land that quickly and then I can do the chrome side.
Blocking: chromium:241964
Cc: rbyers@chromium.org
Owner: gnanasek...@samsung.com
Gnana has offered to do the blink side change here (thanks!).  Once that has landed I can do the chromium-side change (assuming no-one else wants to grab it). 

Comment 5 Deleted

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168752

------------------------------------------------------------------------
r168752 | gnanasekar.s@samsung.com | 2014-03-07T22:00:52.848298Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/data/touch-action-pan.html?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/touch-action-parsing.html?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/CSSPropertyParser.cpp?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyleConstants.h?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/data/touch-action-tests.css?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebTouchAction.h?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/css/touch-action-parsing-expected.txt?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/tests/TouchActionTest.cpp?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueKeywords.in?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/AssertMatchingEnums.cpp?r1=168752&r2=168751&pathrev=168752
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValueMappings.h?r1=168752&r2=168751&pathrev=168752

add 'manipulation' support to CSS touch-action parsing.
'manipulation' is added in latest editors draft
https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#the-touch-action-css-property

BUG= 349016 

Review URL: https://codereview.chromium.org/134153016
------------------------------------------------------------------------
Owner: rbyers@chromium.org
Over to me for the chromium side

Comment 9 by rbyers@chromium.org, Mar 12 2014

Chromium side up for review here: https://codereview.chromium.org/197273003
Summary: Add support for touch-action: manipulation (was: Add support for 'manipulation' property of touch-action)
Status: Fixed

Sign in to add a comment